Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 2 | class Home extends Template { |
||
| 3 | public function __construct( $_parameters ) { |
||
| 4 | parent::__construct( $_parameters ); |
||
| 5 | $this->tags["title"] = "JATE - Home"; |
||
| 6 | $this->tags["content"] = $this->makePage(); |
||
| 7 | } |
||
| 8 | public function makePage() { |
||
| 9 | jBlock(); |
||
| 10 | ?> |
||
| 11 | <div class="row" style="margin-top:70px;"> |
||
| 12 | <div class="col-lg-12"> |
||
| 13 | <div class="well well-sm"> |
||
| 14 | Hello World! |
||
| 15 | </div> |
||
| 16 | </div> |
||
| 17 | </div> |
||
| 18 | <?php |
||
| 19 | $temp = jBlockClose(); |
||
| 20 | return $temp; |
||
| 21 | } |
||
| 22 | } |
||
| 23 | ?> |
||
| 24 |