View GitHub Repository JATE

Schedule Inspection
Subscribe

PostgresqlAdapter::queryArray()   A
last analyzed

↳ Parent: PostgresqlAdapter

Complexity

Conditions 2
Paths 2

Size

Total Lines 8

Duplication

Lines 8
Ratio 100 %

Importance

Changes 0
Metric Value
cc 2
nc 2
nop 1
dl 8
loc 8
rs 10
c 0
b 0
f 0
1 
<?php
0 ignored issues
– show
Coding Style Compatibility introduced by
For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 3 and the first side effect is on line 2.

The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file.

The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place.

To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1.

Loading history...
2 
  jRequire("ConnectionInterface.php");
3 
  class PostgresqlAdapter implements ConnectionAdapterInterface {
0 ignored issues
– show
Coding Style Compatibility introduced by
PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

You can fix this by adding a namespace to your class:

namespace YourVendor;

class YourClass { }

When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.

Loading history...
4 
      public $connection;
5 
      public function __construct( $_srv, $_db, $_usr, $_pass ) {
6 
        try {
7 
          $this->connection = pg_connect("host=$_srv dbname=$_db user=$_usr password=$_pass")
8 
            or die('Could not connect: '.pg_last_error());
0 ignored issues
– show
Coding Style Compatibility introduced by
The method __construct() contains an exit expression.

An exit expression should only be used in rare cases. For example, if you write a short command line script.

In most cases however, using an exit expression makes the code untestable and often causes incompatibilities with other libraries. Thus, unless you are absolutely sure it is required here, we recommend to refactor your code to avoid its usage.

Loading history...
Comprehensibility Best Practice introduced by
Using logical operators such as or instead of || is generally not recommended.

PHP has two types of connecting operators (logical operators, and boolean operators):

  Logical Operators Boolean Operator
AND - meaning and &&
OR - meaning or ||

The difference between these is the order in which they are executed. In most cases, you would want to use a boolean operator like &&, or ||.

Let’s take a look at a few examples:

// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);

Logical Operators are used for Control-Flow

One case where you explicitly want to use logical operators is for control-flow such as this:

$x === 5
    or die('$x must be 5.');

// Instead of
if ($x !== 5) {
    die('$x must be 5.');
}

Since die introduces problems of its own, f.e. it makes our code hardly testable, and prevents any kind of more sophisticated error handling; you probably do not want to use this in real-world code. Unfortunately, logical operators cannot be combined with throw at this point:

// The following is currently a parse error.
$x === 5
    or throw new RuntimeException('$x must be 5.');

These limitations lead to logical operators rarely being of use in current PHP code.

Loading history...
9 
        } catch( Exception $e ) {
10 
          throw new JException($e->getMessage());
11 
        }
12 
      }
13 
      public function query( $_query ) {
14 
        $this->stdQuery($_query);
15 
        return true;
16 
      }
17 
      public function queryInsert( $_query ) {
18 
        $this->stdQuery($_query);
19 
        return $this->stdQuery("SELECT lastval()");
20 
      }
21 View Code Duplication 
      public function queryFetch( $_query ) {
0 ignored issues
– show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
22 
        $result = $this->stdQuery($_query);
23 
        $rows = [];
24 
        while($row = pg_fetch_assoc($result))
25 
          $rows[] = $row;
26 
        pg_free_result($result);
27 
        return $rows;
28 
      }
29 View Code Duplication 
      public function queryArray( $_query ) {
0 ignored issues
– show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
30 
        $result = $this->stdQuery($_query);
31 
        $rows = [];
32 
        while($row = pg_fetch_array($result))
33 
          $rows[] = $row;
34 
        pg_free_result($result);
35 
        return $rows;
36 
      }
37 
      protected function stdQuery( $_query ) {
38 
        $database = $this->connection;
39 
        $result = pg_query($database, $_query);
40 View Code Duplication 
        if(!$result)
0 ignored issues
– show
Duplication introduced by
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
41 
          throw new JException(json_encode([
42 
            "query" => $_query,
43 
            "error" => pg_last_error()
44 
          ]));
45 
        return $result;
46 
      }
47 
  }
48 
?>
0 ignored issues
– show
Best Practice introduced by
It is not recommended to use PHP's closing tag ?> in files other than templates.

Using a closing tag in PHP files that only contain PHP code is not recommended as you might accidentally add whitespace after the closing tag which would then be output by PHP. This can cause severe problems, for example headers cannot be sent anymore.

A simple precaution is to leave off the closing tag as it is not required, and it also has no negative effects whatsoever.

Loading history...
49