View GitHub Repository JATE

Schedule Inspection
Subscribe

JConfig::__construct()   B
last analyzed

↳ Parent: JConfig

Complexity

Conditions 7
Paths 7

Size

Total Lines 15

Duplication

Lines 0
Ratio 0 %

Importance

Changes 0
Metric Value
cc 7
nc 7
nop 1
dl 0
loc 15
rs 8.8333
c 0
b 0
f 0
1 
<?php
2 
  class JConfig {
0 ignored issues
– show
Coding Style Compatibility introduced by
PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

You can fix this by adding a namespace to your class:

namespace YourVendor;

class YourClass { }

When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.

Loading history...
3 
    public function __construct( $_path ) {
4 
      if(!is_string($_path))
5 
        throw new JException("Path must be a string.");
6 
      if(!file_exists($_path))
7 
        throw new JException("File [$_path] not found.");
8 
      $data = file_get_contents($_path);
9 
      $data = json_decode($data);
10 
      if($data === NULL)
11 
        throw new JException("Invalid file data. [$_path]");
12 
      if(is_object($data))
13 
        foreach (get_object_vars($data) as $key => $value)
14 
          $this->$key = $value;
15 
      if(is_array($data))
16 
        $this->data = $data;
0 ignored issues
– show
Bug introduced by
The property data does not exist. Did you maybe forget to declare it?

In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code:

class MyClass { }

$x = new MyClass();
$x->foo = true;

Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion:

class MyClass {
    public $foo;
}

$x = new MyClass();
$x->foo = true;
Loading history...
17 
    }
18 
  }
19 
?>
0 ignored issues
– show
Best Practice introduced by
It is not recommended to use PHP's closing tag ?> in files other than templates.

Using a closing tag in PHP files that only contain PHP code is not recommended as you might accidentally add whitespace after the closing tag which would then be output by PHP. This can cause severe problems, for example headers cannot be sent anymore.

A simple precaution is to leave off the closing tag as it is not required, and it also has no negative effects whatsoever.

Loading history...
20