correios::uninstall() - Code Metrics - Inspection of "Update .scrutinizer.yml" - XRSites/correios - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Push — master ( 0a5acd...43aa97 )

by Guilherme Luiz Argentino
created 2017-05-15 01:05 UTC
correios::uninstall() A

↳ Parent: correios
Complexity

Conditions	4
Paths	3
Size

Total Lines	12
Code Lines	7
Duplication

Lines	0
Ratio	0 %
Importance

Changes
Metric	Value
cc	4
eloc	7
nc	3
nop	0
dl	0
loc	12
rs	9.2
c	0
b	0
f	0
<?php


/** MODULO ADAPTADO POR ODLANIER
 * @author Odlanier de Souza Mendes
 * @copyright Dlani
 * @email [email protected]
 * @version 3.0
 * */
if (!defined('_PS_VERSION_'))
    exit;

class correios extends CarrierModule {
namespace YourVendor;

class YourClass { }

    public $id_carrier;
    private $_urlWebservice = "http://ws.correios.com.br/calculador/CalcPrecoPrazo.asmx?wsdl";
    private $_html = '';

    private $_postErrors = array();

    private $_factorys = array(

        "soapclient" => "SOAP Client",
        "nusoap" => "NuSoap"
    );
    private $_factory = "soapclient";
    public $servicos_todos = array(
        '04510' => 'PAC',# era '41106' => 'PAC',

        '04014' => 'SEDEX', # era '40010' => 'SEDEX',

        '40215' => 'SEDEX 10',
        '40290' => 'SEDEX HOJE',
            //'81019' => 'E-SEDEX', 

            //'44105' => 'MALOTE',

            //'41017' => 'NORMAL', 

            //'40045' => 'SEDEX A COBRAR', 

    );
    private $_moduleName = 'correios';

    function __construct() {

        $this->name = 'correios';
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->tab = 'shipping_logistics';
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->version = '3.0';
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->author = 'Dlani Mendes';
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->limited_countries = array('br');
class MyClass { }

$x = new MyClass();
$x->foo = true;

        parent::__construct();

        /* The parent construct is required for translations */
        $this->page = basename(__file__, '.php');
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->displayName = $this->l('Frete Correios');
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->description = 'Painel de Controle dos Frete Correios.';
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    function install() {

        if (parent::install() == false or
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                $this->registerHook('updateCarrier') == false or
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
                $this->registerHook('extraCarrier') == false or
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
                $this->registerHook('beforeCarrier') == false)

            return false;

        $this->installCarriers();

        return true;
    }

    /**
     * 
     */
    private function installCarriers() {
        $configBase = array(
            'id_tax_rules_group' => 0,
            'active' => true,
            'deleted' => 0,
            'shipping_handling' => false,
            'range_behavior' => 0,
            'delay' => array("br" => "Entrega pelos Correios."),
            'id_zone' => 1,
            'is_module' => true,
            'shipping_external' => true,
            'external_module_name' => $this->_moduleName,
            'need_range' => true,
            'url' => Tools::getHttpHost(true) . "/modules/correios/rastreio.php?objeto=@",
        );

        $arrayConfigs = array();
        foreach ($this->servicos_todos as $codServico => $servico)
            $arrayConfigs[] = array(
                "name" => "Correios - $servico",
                "cod_servico" => $codServico
            );

        foreach ($arrayConfigs as $config) {
            $config = array_merge($configBase, $config);
            $this->installExternalCarrier($config);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }
    }

    /**
     * 
     * @param type $config
     * @return boolean
     */
    public function installExternalCarrier($config) {
        $check = Db::getInstance()->executeS("SELECT id_carrier FROM " . _DB_PREFIX_ . "carrier WHERE name = '" . $config['name'] . "' ");
        if (is_array($check) && !empty($check))
            return Db::getInstance()->autoExecute(_DB_PREFIX_ . 'carrier', array('deleted' => 0), 'UPDATE', ' name = "' . $config['name'] . '" ');

        $carrier = new Carrier();
        $carrier->name = $config['name'];

        $carrier->url = $config['url'];

        $carrier->id_tax_rules_group = $config['id_tax_rules_group'];

        $carrier->id_zone = $config['id_zone'];

        $carrier->active = $config['active'];

        $carrier->deleted = $config['deleted'];

        $carrier->delay = $config['delay'];

        $carrier->shipping_handling = $config['shipping_handling'];

        $carrier->range_behavior = $config['range_behavior'];

        $carrier->is_module = $config['is_module'];

        $carrier->shipping_external = $config['shipping_external'];

        $carrier->external_module_name = $config['external_module_name'];

        $carrier->need_range = $config['need_range'];


        $languages = Language::getLanguages(true);
        foreach ($languages as $language) {
            $carrier->delay[(int) $language['id_lang']] = $config['delay']['br'];
        }

        if ($carrier->add()) {

            $groups = Group::getGroups(true);
            foreach ($groups as $group)
                Db::getInstance()->autoExecute(_DB_PREFIX_ . 'carrier_group', array('id_carrier' => (int) ($carrier->id), 'id_group' => (int) ($group['id_group'])), 'INSERT');


            $rangePrice = new RangePrice();
            $rangePrice->id_carrier = $carrier->id;
            $rangePrice->delimiter1 = '0';
            $rangePrice->delimiter2 = '0';
            $rangePrice->add();

            $rangeWeight = new RangeWeight();
            $rangeWeight->id_carrier = $carrier->id;
            $rangeWeight->delimiter1 = '0';
            $rangeWeight->delimiter2 = '30';
            $rangeWeight->add();

            $zones = Zone::getZones(true);
            foreach ($zones as $zone) {
                Db::getInstance()->autoExecute(_DB_PREFIX_ . 'carrier_zone', array('id_carrier' => (int) ($carrier->id), 'id_zone' => (int) ($zone['id_zone'])), 'INSERT');
                Db::getInstance()->autoExecuteWithNullValues(_DB_PREFIX_ . 'delivery', array('id_carrier' => (int) ($carrier->id), 'id_range_price' => (int) ($rangePrice->id), 'id_range_weight' => NULL, 'id_zone' => (int) ($zone['id_zone']), 'price' => '0'), 'INSERT');
                Db::getInstance()->autoExecuteWithNullValues(_DB_PREFIX_ . 'delivery', array('id_carrier' => (int) ($carrier->id), 'id_range_price' => NULL, 'id_range_weight' => (int) ($rangeWeight->id), 'id_zone' => (int) ($zone['id_zone']), 'price' => '0'), 'INSERT');
            }

            Configuration::updateValue("PS_CORREIOS_CARRIER_{$carrier->id}", $config['cod_servico']);


            // Copy Logo
            if (!copy(dirname(__FILE__) . '/logos/' . $config['cod_servico'] . '.png', _PS_SHIP_IMG_DIR_ . '/' . (int) $carrier->id . '.jpg'))
                return false;

            // Return ID Carrier
            return (int) ($carrier->id);
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
        }
        return false;
    }

    /**
     * 
     * @return boolean
     */
    public function uninstall() {
        // Uninstall Carriers
        $result = Db::getInstance()->autoExecute(_DB_PREFIX_ . 'carrier', array('deleted' => 1), 'UPDATE', ' name LIKE "Correios%" ');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        if (!Configuration::deleteByName('PS_CORREIOS_CEP_ORIG'))

            return false;

        if (!parent::uninstall() OR !$this->unregisterHook('updateCarrier'))
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            return false;

        return true;
    }

    /**
     * 
     * @return type
     */
    public function getContent() {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
        $output = '<h2>' . $this->displayName . '</h2>';
        if (Tools::isSubmit('submitcarrinho_correios')) {
            Configuration::updateValue('PS_CORREIOS_CEP_ORIG', intval($_POST['cep']));


            $output .= '<div class="conf confirm"><img src="../img/admin/ok.gif" alt="' . $this->
                            l('Confirmation') . '" />' . $this->l('Settings updated') . '</div>';

        }
        if (Tools::isSubmit('factory')) {
            Configuration::updateValue('PS_CORREIOS_FACTORY', $_POST['factory']);


            $output .= '<div class="conf confirm"><img src="../img/admin/ok.gif" alt="' . $this->
                            l('Confirmation') . '" />' . $this->l('Settings updated') . '</div>';

        }

        return $output . $this->displayForm();
    }

    /**
     * 
     * @return type
     */
    public function displayForm() {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
        $conf = Configuration::getMultiple(array('PS_CORREIOS_CEP_ORIG'));
        $cep_orig = array_key_exists('cep', $_POST) ? $_POST['cep'] : (array_key_exists('PS_CORREIOS_CEP_ORIG', $conf) ? $conf['PS_CORREIOS_CEP_ORIG'] : '');
        include (dirname(__file__) . "/form_config.php");
        return $form_config;

    }

    /**
     * 
     * @param type $params
     * @param type $shipping_cost
     * @return boolean
     */
    public function getOrderShippingCost($params, $shipping_cost) {
        $carrier = new Carrier();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $chave = Configuration::get("PS_CORREIOS_CARRIER_{$this->id_carrier}");
        $address = new Address($params->id_address_delivery);


        $sCepDestino = preg_replace("/([^0-9])/", "", $address->postcode);

        $paramsCorreios = array(
            "sCepDestino" => $sCepDestino,
            "nVlPeso" => (string) $params->getTotalWeight(),
            "nCdServico" => $chave,
        );

        $this->getPriceWebService($paramsCorreios);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $custoFrete = $this->getPriceWebService($paramsCorreios);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        if ($custoFrete === false || $custoFrete === 0.0)
            return false;

        return $custoFrete + $shipping_cost;
    }

    /**
     * 
     * @param type $params
     * @return type
     */
    public function getOrderShippingCostExternal($params) {
        return $this->getOrderShippingCost($params, 0);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * 
     * @param type $params
     */
    public function hookupdateCarrier($params) {

        
    }

    /**
     * 
     * @global type $smarty
     * @param type $params
     * @return type
     */
    public function hookbeforeCarrier($params) {
        global $smarty;
function myFunction($a, $b) {
    // Do something
}
        $address = new Address($params['cart']->id_address_delivery);

        $smarty->assign(array(
            "sCepDestino" => $address->postcode
        ));
        return $this->display(__file__, 'extra_carrier.tpl');

    }

    /**
     * 
     * @param type $params
     */
    public function hookextraCarrier($params) {

        
    }

    /**
     * 
     * @param type $params
     * @return type
     */
    private function getPriceWebService($params) {
        $paramsBase = array(
            "nCdEmpresa" => "",
            "sDsSenha" => "",
            "sCepOrigem" => str_pad(Configuration::get('PS_CORREIOS_CEP_ORIG'), 8, "0", STR_PAD_LEFT),
            "nCdFormato" => "1",
            "nVlComprimento" => "30",
            "nVlAltura" => "8",
            "nVlLargura" => "30",
            "nVlDiametro" => "0",
            "sCdMaoPropria" => "N",
            "nVlValorDeclarado" => "0",
            "sCdAvisoRecebimento" => "N"
        );
        $params = array_merge($paramsBase, $params);
        $hash = ( implode("|", $params) );
        $getInCache = $this->getCache($hash);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        if ($getInCache) {
            $return = $getInCache;
        } else {
            $this->_factory = Configuration::get("PS_CORREIOS_FACTORY");
            $method = "getPreco" . ucfirst(strtolower($this->_factory));
            
            $return = $this->$method($params, $hash);
            $this->setCache($hash, $return);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }
        return $return;
    }

    /**
     * 
     * @global type $smarty
     * @param type $idCarrier
     * @param type $sCepDestino
     * @return type
     */
    public function getPrazoDeEntrega($idCarrier, $sCepDestino) {
        global $smarty;
function myFunction($a, $b) {
    // Do something
}
        $Carrier = new Carrier($idCarrier);


        $params = array(
            "sCepOrigem" => str_pad(Configuration::get('PS_CORREIOS_CEP_ORIG'), 8, "0", STR_PAD_LEFT),
            "nCdServico" => Configuration::get("PS_CORREIOS_CARRIER_{$idCarrier}"),
            "sCepDestino" => $sCepDestino,
        );

        $this->_factory = Configuration::get("PS_CORREIOS_FACTORY");
        $method = "getPrazo" . ucfirst(strtolower($this->_factory));
        $dias = $this->$method($params);

        $smarty->assign(array(
            "nomeServico" => $Carrier->name,

            "dias" => $dias
        ));

        return $this->display(__file__, 'prazo_de_entrega.tpl');

    }

    private function getPrazoSoapclient($params) {
        try {
            $client = new SoapClient($this->_urlWebservice);
            $result = $client->CalcPrazo($params);
            if (intval($result->CalcPrazoResult->Servicos->cServico->Erro) !== 0)
                return false;
            else
                return (integer) $result->CalcPrazoResult->Servicos->cServico->PrazoEntrega;
        } catch (Exception $e) {
            return false;
        }
    }

    private function getPrazoNusoap($params) {
        require_once('vendor/lib/nusoap.php');
        $nusoap = new nusoap_client($this->_urlWebservice, 'wsdl');
        $nusoap->setUseCURL(true);
        $result = $nusoap->call("CalcPrazo", $params);
        if (intval($result['CalcPrazoResult']['Servicos']['cServico']['Erro']) !== 0) {
            return false;
        } else {
            return (integer) str_replace(",", ".", $result['CalcPrazoResult']['Servicos']['cServico']['PrazoEntrega']);
        }
    }

    /**
     * 
     * @param type $name
     * @param type $value
     */
    private function setCache($name, $value) {
        if (_PS_CACHE_ENABLED_)
            Cache::getInstance()->setQuery($name, $value);
    }

    /**
     * 
     * @param type $name
     * @return boolean
     */
    private function getCache($name) {
        if (_PS_CACHE_ENABLED_)
            return Cache::getInstance()->get(md5($name));
        return false;
    }

    /**
     * 
     * @param type $params
     * @param type $hash
     * @return boolean
     */
    private function getPrecoSoapclient($params, $hash) {
        try {
            $client = new SoapClient($this->_urlWebservice);
        } catch (Exception $e) {
            return false;
        }
        $result = $client->CalcPreco($params);
        var_dump ($result);

        if (intval($result->CalcPrecoResult->Servicos->cServico->Erro) !== 0) {
            $this->setCache($hash, false);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            return false;
        } else {
            return (float) str_replace(",", ".", $result->CalcPrecoResult->Servicos->cServico->Valor);
        }
    }

    /**
     * 
     * @param type $params
     * @param type $hash
     * @return boolean
     */
    private function getPrecoNusoap($params, $hash) {
        require_once('vendor/lib/nusoap.php');
        $nusoap = new nusoap_client($this->_urlWebservice, 'wsdl');
        $nusoap->setUseCURL(true);
        $result = $nusoap->call("CalcPreco", $params);
        if (intval($result['CalcPrecoResult']['Servicos']['cServico']['Erro']) !== 0) {
            $this->setCache($hash, false);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            return false;
        } else {
            return (float) str_replace(",", ".", $result['CalcPrecoResult']['Servicos']['cServico']['Valor']);
        }
    }

}

?>


Push — master ( 0a5acd...43aa97 )

correios::uninstall() A

Complexity

Size

Duplication

Importance

Available Fixes

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Available Fixes

Logical Operators are used for Control-Flow

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

XRSites / correios

Push — master ( 0a5acd...43aa97 )

correios::uninstall() A

Complexity

Size

Duplication

Importance

Available Fixes

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Available Fixes

Logical Operators are used for Control-Flow

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like
