HTMLPurifier_AttrDef_CSS::validate() - Code Metrics - Inspection of "HTML Purifier is 4.9.3" - XOOPS/XoopsCore25 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#516)

by Michael

created 2017-07-07 09:00 UTC

HTMLPurifier_AttrDef_CSS::validate() F

↳ Parent: HTMLPurifier_AttrDef_CSS

Complexity

Conditions	20
Paths	496

Size

Total Lines	110
Code Lines	69

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	20
eloc	69
nc	496
nop	3
dl	0
loc	110
rs	3.0567
c	0
b	0
f	0

How to fix Long Method Complexity

<?php

/**
 * Validates the HTML attribute style, otherwise known as CSS.
 * @note We don't implement the whole CSS specification, so it might be
 *       difficult to reuse this component in the context of validating
 *       actual stylesheet declarations.
 * @note If we were really serious about validating the CSS, we would
 *       tokenize the styles and then parse the tokens. Obviously, we
 *       are not doing that. Doing that could seriously harm performance,
 *       but would make these components a lot more viable for a CSS
 *       filtering solution.
 */
class HTMLPurifier_AttrDef_CSS extends HTMLPurifier_AttrDef
{

    /**
     * @param string $css
     * @param HTMLPurifier_Config $config
     * @param HTMLPurifier_Context $context
     * @return bool|string
     */
    public function validate($css, $config, $context)
    {
        $css = $this->parseCDATA($css);

        $definition = $config->getCSSDefinition();
        $allow_duplicates = $config->get("CSS.AllowDuplicates");


        // According to the CSS2.1 spec, the places where a
        // non-delimiting semicolon can appear are in strings
        // escape sequences.   So here is some dumb hack to
        // handle quotes.
        $len = strlen($css);
        $accum = "";
        $declarations = array();
        $quoted = false;
        for ($i = 0; $i < $len; $i++) {
            $c = strcspn($css, ";'\"", $i);
            $accum .= substr($css, $i, $c);
            $i += $c;
            if ($i == $len) break;
            $d = $css[$i];
            if ($quoted) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
                $accum .= $d;
                if ($d == $quoted) {
                    $quoted = false;
                }
            } else {
                if ($d == ";") {
                    $declarations[] = $accum;
                    $accum = "";
                } else {
                    $accum .= $d;
                    $quoted = $d;
                }
            }
        }
        if ($accum != "") $declarations[] = $accum;

        $propvalues = array();
        $new_declarations = '';

        /**
         * Name of the current CSS property being validated.
         */
        $property = false;
        $context->register('CurrentCSSProperty', $property);

        foreach ($declarations as $declaration) {
            if (!$declaration) {
                continue;
            }
            if (!strpos($declaration, ':')) {
                continue;
            }
            list($property, $value) = explode(':', $declaration, 2);
            $property = trim($property);
            $value = trim($value);
            $ok = false;
            do {
                if (isset($definition->info[$property])) {
                    $ok = true;
                    break;
                }
                if (ctype_lower($property)) {
                    break;
                }
                $property = strtolower($property);
                if (isset($definition->info[$property])) {
                    $ok = true;
                    break;
                }
            } while (0);
            if (!$ok) {
                continue;
            }
            // inefficient call, since the validator will do this again
            if (strtolower(trim($value)) !== 'inherit') {
                // inherit works for everything (but only on the base property)
                $result = $definition->info[$property]->validate(
                    $value,
                    $config,
                    $context
                );
            } else {
                $result = 'inherit';
            }
            if ($result === false) {
                continue;
            }
            if ($allow_duplicates) {
                $new_declarations .= "$property:$result;";
            } else {
                $propvalues[$property] = $result;
            }
        }

        $context->destroy('CurrentCSSProperty');

        // procedure does not write the new CSS simultaneously, so it's
        // slightly inefficient, but it's the only way of getting rid of
        // duplicates. Perhaps config to optimize it, but not now.

        foreach ($propvalues as $prop => $value) {
            $new_declarations .= "$prop:$value;";
        }

        return $new_declarations ? $new_declarations : false;

    }

}

// vim: et sw=4 sts=4


1			<?php
2
3			/**
4			* Validates the HTML attribute style, otherwise known as CSS.
5			* @note We don't implement the whole CSS specification, so it might be
6			* difficult to reuse this component in the context of validating
7			* actual stylesheet declarations.
8			* @note If we were really serious about validating the CSS, we would
9			* tokenize the styles and then parse the tokens. Obviously, we
10			* are not doing that. Doing that could seriously harm performance,
11			* but would make these components a lot more viable for a CSS
12			* filtering solution.
13			*/
14			class HTMLPurifier_AttrDef_CSS extends HTMLPurifier_AttrDef
15			{
16
17			/**
18			* @param string $css
19			* @param HTMLPurifier_Config $config
20			* @param HTMLPurifier_Context $context
21			* @return bool\|string
22			*/
23			public function validate($css, $config, $context)
24			{
25			$css = $this->parseCDATA($css);
26
27			$definition = $config->getCSSDefinition();
28			$allow_duplicates = $config->get("CSS.AllowDuplicates");
29
30
31			// According to the CSS2.1 spec, the places where a
32			// non-delimiting semicolon can appear are in strings
33			// escape sequences. So here is some dumb hack to
34			// handle quotes.
35			$len = strlen($css);
36			$accum = "";
37			$declarations = array();
38			$quoted = false;
39			for ($i = 0; $i < $len; $i++) {
40			$c = strcspn($css, ";'\"", $i);
41			$accum .= substr($css, $i, $c);
42			$i += $c;
43			if ($i == $len) break;
44			$d = $css[$i];
45			if ($quoted) {
			0 ignored issues – show Bug Best Practice introduced 2017-07-07 09:10 UTC by Report Bug Copy Issue Report The expression `$quoted` of type `false\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== false` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
46			$accum .= $d;
47			if ($d == $quoted) {
48			$quoted = false;
49			}
50			} else {
51			if ($d == ";") {
52			$declarations[] = $accum;
53			$accum = "";
54			} else {
55			$accum .= $d;
56			$quoted = $d;
57			}
58			}
59			}
60			if ($accum != "") $declarations[] = $accum;
61
62			$propvalues = array();
63			$new_declarations = '';
64
65			/**
66			* Name of the current CSS property being validated.
67			*/
68			$property = false;
69			$context->register('CurrentCSSProperty', $property);
70
71			foreach ($declarations as $declaration) {
72			if (!$declaration) {
73			continue;
74			}
75			if (!strpos($declaration, ':')) {
76			continue;
77			}
78			list($property, $value) = explode(':', $declaration, 2);
79			$property = trim($property);
80			$value = trim($value);
81			$ok = false;
82			do {
83			if (isset($definition->info[$property])) {
84			$ok = true;
85			break;
86			}
87			if (ctype_lower($property)) {
88			break;
89			}
90			$property = strtolower($property);
91			if (isset($definition->info[$property])) {
92			$ok = true;
93			break;
94			}
95			} while (0);
96			if (!$ok) {
97			continue;
98			}
99			// inefficient call, since the validator will do this again
100			if (strtolower(trim($value)) !== 'inherit') {
101			// inherit works for everything (but only on the base property)
102			$result = $definition->info[$property]->validate(
103			$value,
104			$config,
105			$context
106			);
107			} else {
108			$result = 'inherit';
109			}
110			if ($result === false) {
111			continue;
112			}
113			if ($allow_duplicates) {
114			$new_declarations .= "$property:$result;";
115			} else {
116			$propvalues[$property] = $result;
117			}
118			}
119
120			$context->destroy('CurrentCSSProperty');
121
122			// procedure does not write the new CSS simultaneously, so it's
123			// slightly inefficient, but it's the only way of getting rid of
124			// duplicates. Perhaps config to optimize it, but not now.
125
126			foreach ($propvalues as $prop => $value) {
127			$new_declarations .= "$prop:$value;";
128			}
129
130			return $new_declarations ? $new_declarations : false;
131
132			}
133
134			}
135
136			// vim: et sw=4 sts=4
137

XOOPS / XoopsCore25

Pull Request — master (#516)

HTMLPurifier_AttrDef_CSS::validate() F

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like