| Conditions | 18 |
| Paths | 34 |
| Total Lines | 109 |
| Code Lines | 66 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 195 | function xtube_showvideo($vidid, $source, $screenshot, $picurl) |
||
| 196 | { |
||
| 197 | global $xoopsModule, $xoopsModuleConfig; |
||
| 198 | $showvideo = ''; |
||
| 199 | $autoplay = $xoopsModuleConfig['autoplay']; |
||
| 200 | if ($xoopsModuleConfig['autoplay']) { |
||
| 201 | $autoplay2 = 'yes'; |
||
| 202 | $autoplay3 = 'true'; |
||
| 203 | $photobucket = '&ap=1'; |
||
| 204 | $google = 'FlashVars="autoPlay=true"'; |
||
| 205 | $viddler = 'flashvars="autoplay=t"'; |
||
| 206 | } else { |
||
| 207 | $autoplay2 = 'no'; |
||
| 208 | $autoplay3 = 'false'; |
||
| 209 | $photobucket = ''; |
||
| 210 | $google = ''; |
||
| 211 | $viddler = ''; |
||
| 212 | } |
||
| 213 | |||
| 214 | // $hquality = ''; |
||
| 215 | // if ($hq == 1) { |
||
| 216 | // $hquality = '&ap=%2526fmt%3D18&'; |
||
| 217 | // } |
||
| 218 | |||
| 219 | switch ($source) { |
||
| 220 | // YouTube |
||
| 221 | case 0: |
||
| 222 | // $showvideo = '<object width="480" height="295"><param name="movie" value="https://www.youtube.com/v/' . $vidid . '&ap=%2526fmt%3D18&&autoplay=' . $autoplay . '&rel=1&fs=1&color1=0x999999&color2=0x999999&border=0&loop=0"></param><param name="wmode" value="transparent"></param><embed src="https://www.youtube.com/v/' . $vidid . '&ap=%2526fmt%3D18&&autoplay=' . $autoplay . '&rel=1&fs=1&color1=0x999999&color2=0x999999&border=0&loop=0" type="application/x-shockwave-flash" allowscriptaccess="always" allowfullscreen="true" wmode="transparent" width="480" height="295"></embed></object>'; |
||
| 223 | $showvideo = '<embed src="https://www.youtube.com/v/' . $vidid . '&autoplay=' . $autoplay . '&fs=1" type="application/x-shockwave-flash" allowscriptaccess="always" allowfullscreen="true" width="853" height="480"></embed>'; |
||
| 224 | break; |
||
| 225 | |||
| 226 | // MetaCafe |
||
| 227 | case 1: |
||
| 228 | $showvideo = '<embed flashVars="playerVars=showStats=no|autoPlay=' . $autoplay2 . '" src="https://www.metacafe.com/fplayer/' . $vidid . '.swf" width="853" height="480" wmode="transparent" pluginspage="https://www.macromedia.com/go/getflashplayer" type="application/x-shockwave-flash"></embed>'; |
||
| 229 | break; |
||
| 230 | |||
| 231 | // iFilm/Spike |
||
| 232 | case 2: |
||
| 233 | $showvideo = '<embed width="853" height="480" src="https://www.spike.com/efp" quality="high" bgcolor="000000" name="efp" align="middle" type="application/x-shockwave-flash" pluginspage="https://www.macromedia.com/go/getflashplayer" flashvars="flvbaseclip=' . $vidid . '" allowfullscreen="true"> </embed>'; |
||
| 234 | break; |
||
| 235 | |||
| 236 | // Photobucket |
||
| 237 | case 3: |
||
| 238 | $vidid = str_replace('th_', '', (string) $vidid); |
||
| 239 | $showvideo = '<embed width="853" height="480" type="application/x-shockwave-flash" wmode="transparent" src="https://i51.photobucket.com/player.swf?file=https://vid51.photobucket.com/albums/' . $vidid . '.flv' . $photobucket . '"></embed>'; |
||
| 240 | break; |
||
| 241 | |||
| 242 | // Viddler |
||
| 243 | case 4: |
||
| 244 | $showvideo = '<embed src="https://www.viddler.com/player/' . $vidid . '/" width="853" height="480" type="application/x-shockwave-flash" ' . $viddler . ' allowScriptAccess="always" allowFullScreen="true" name="viddler_' . $vidid . '" ></embed>'; |
||
| 245 | break; |
||
| 246 | |||
| 247 | // Google Video |
||
| 248 | case 100: |
||
| 249 | $showvideo = '<embed style="width:480px; height:295px;" id="VideoPlayback" type="application/x-shockwave-flash" src="https://video.google.com/googleplayer.swf?docId=' . $vidid . '&hl=en" ' . $google . '> </embed>'; |
||
| 250 | break; |
||
| 251 | |||
| 252 | // MySpace TV |
||
| 253 | case 101: |
||
| 254 | $showvideo = '<embed src="https://mediaservices.myspace.com/services/media/embed.aspx/m=' . $vidid . ',t=1,mt=video,ap=' . $autoplay . '" width="480" height="295" allowFullScreen="true" type="application/x-shockwave-flash"></embed>'; |
||
| 255 | break; |
||
| 256 | |||
| 257 | // DailyMotion |
||
| 258 | case 102: |
||
| 259 | $showvideo = '<embed src="https://www.dailymotion.com/swf/' . $vidid . '&autoPlay=' . $autoplay . '" type="application/x-shockwave-flash" width="480" height="295" allowFullScreen="true" allowScriptAccess="always"></embed>'; |
||
| 260 | break; |
||
| 261 | |||
| 262 | // Blip.tv |
||
| 263 | case 103: |
||
| 264 | $showvideo = '<embed src="https://blip.tv/play/' . $vidid . '" type="application/x-shockwave-flash" width="480" height="295" allowscriptaccess="always" allowfullscreen="true" flashvars="autostart=' . $autoplay3 . '"></embed>'; |
||
| 265 | break; |
||
| 266 | |||
| 267 | // ClipFish |
||
| 268 | case 104: |
||
| 269 | $showvideo = '<embed src="https://www.clipfish.de/videoplayer.swf?as=' . $autoplay . '&videoid=' . $vidid . '==&r=1&c=0067B3" quality="high" bgcolor="#0067B3" width="464" height="380" name="player" align="middle" allowFullScreen="true" allowScriptAccess="always" type="application/x-shockwave-flash" pluginspage="https://www.macromedia.com/go/getflashplayer"></embed>'; // Change c=0067B3 for different player color |
||
| 270 | break; |
||
| 271 | |||
| 272 | // LiveLeak |
||
| 273 | case 105: |
||
| 274 | $showvideo = '<embed src="https://www.liveleak.com/e/' . $vidid . '" type="application/x-shockwave-flash" flashvars="autostart=' . $autoplay3 . '" wmode="transparent" width="450" height="370"></embed>'; |
||
| 275 | break; |
||
| 276 | |||
| 277 | // Maktoob |
||
| 278 | case 106: |
||
| 279 | $showvideo = '<embed width="448" height="320" align="middle" pluginspage="https://www.macromedia.com/go/getflashplayer" type="application/x-shockwave-flash" name="flvplayer" bgcolor="#ffffff" devicefont="true" wmode="transparent" quality="high" src="https://clipat.maktoob.com/flvplayerOurJS.swf?file=https://' . $vidid . '.flv&enablejs=true&image=' . $picurl . '&lightcolor=0x557722&backcolor=0x000000&frontcolor=0xCCCCCC&showfsbutton=true&autostart=' . $autoplay3 . '&logo=https://clipat.maktoob.com/language/ar_sa/images/clipat-icon.png&displaywidth=448" />'; |
||
| 280 | break; |
||
| 281 | |||
| 282 | // Veoh |
||
| 283 | case 107: |
||
| 284 | $showvideo = '<embed src="https://www.veoh.com/veohplayer.swf?permalinkId=' . $vidid . '&id=anonymous&player=videodetailsembedded&affiliateId=&videoAutoPlay=' . $autoplay . '" allowFullScreen="true" width="480" height="295" bgcolor="#FFFFFF" type="application/x-shockwave-flash" pluginspage="https://www.macromedia.com/go/getflashplayer"></embed>'; |
||
| 285 | break; |
||
| 286 | |||
| 287 | // Vimeo |
||
| 288 | case 108: |
||
| 289 | $showvideo = '<embed src="https://vimeo.com/moogaloop.swf?clip_id=' . $vidid . '&server=vimeo.com&show_title=1&show_byline=1&show_portrait=0&color=&fullscreen=1&autoplay=' . $autoplay . '" type="application/x-shockwave-flash" allowfullscreen="true" allowscriptaccess="always" quality="best" width="400" height="321"></embed>'; |
||
| 290 | break; |
||
| 291 | |||
| 292 | // Megavideo |
||
| 293 | case 109: |
||
| 294 | $showvideo = '<object width="640" height="363"><param name="movie" value="https://www.megavideo.com/v/' . $vidid . '"></param><param name="allowFullScreen" value="true"></param><embed src="https://www.megavideo.com/v/' . $vidid . '" type="application/x-shockwave-flash" allowfullscreen="true" width="640" height="363"></embed></object>'; |
||
| 295 | break; |
||
| 296 | |||
| 297 | // XoopsTube |
||
| 298 | case 200: |
||
| 299 | $showvideo = '<embed src="' . XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . '/include/mediaplayer.swf" width="425" height="350" allowScriptAccess="always" allowFullScreen="true" flashvars="width=425&height=350&file=' . XOOPS_URL . '/' . $xoopsModuleConfig['videodir'] . '/' . $vidid . '&image=' . XOOPS_URL . '/' . $xoopsModuleConfig['videoimgdir'] . '/' . $screenshot . '&autostart=' . $autoplay3 . '"></embed>'; |
||
| 300 | break; |
||
| 301 | } |
||
| 302 | |||
| 303 | return $showvideo; |
||
| 304 | } |
||
| 305 |