Test Failed
Pull Request — master (#592)
by Lucio
10:17
created
htdocs/modules/pm/class/message.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -134,7 +134,7 @@  discard block
 block discarded – undo
134 134
     public function getSavecount(XoopsUser $user = null)
135 135
     {
136 136
         if (!is_object($user)) {
137
-            $user =& $GLOBALS['xoopsUser'];
137
+            $user = & $GLOBALS['xoopsUser'];
138 138
         }
139 139
         $crit_to = new CriteriaCompo(new Criteria('to_delete', 0));
140 140
         $crit_to->add(new Criteria('to_save', 1));
@@ -159,7 +159,7 @@  discard block
 block discarded – undo
159 159
         global $xoopsConfig;
160 160
 
161 161
         if (!is_object($user)) {
162
-            $user =& $GLOBALS['xoopsUser'];
162
+            $user = & $GLOBALS['xoopsUser'];
163 163
         }
164 164
         $msg = sprintf(_PM_EMAIL_DESC, $user->getVar('uname'));
165 165
         $msg .= "\n\n";
@@ -167,17 +167,17 @@  discard block
 block discarded – undo
167 167
         $msg .= "\n";
168 168
         $from = new XoopsUser($pm->getVar('from_userid'));
169 169
         $to   = new XoopsUser($pm->getVar('to_userid'));
170
-        $msg .= sprintf(_PM_EMAIL_FROM, $from->getVar('uname') . ' (' . XOOPS_URL . '/userinfo.php?uid=' . $pm->getVar('from_userid') . ')');
170
+        $msg .= sprintf(_PM_EMAIL_FROM, $from->getVar('uname').' ('.XOOPS_URL.'/userinfo.php?uid='.$pm->getVar('from_userid').')');
171 171
         $msg .= "\n";
172
-        $msg .= sprintf(_PM_EMAIL_TO, $to->getVar('uname') . ' (' . XOOPS_URL . '/userinfo.php?uid=' . $pm->getVar('to_userid') . ')');
172
+        $msg .= sprintf(_PM_EMAIL_TO, $to->getVar('uname').' ('.XOOPS_URL.'/userinfo.php?uid='.$pm->getVar('to_userid').')');
173 173
         $msg .= "\n";
174
-        $msg .= _PM_EMAIL_MESSAGE . ":\n";
175
-        $msg .= "\n" . $pm->getVar('subject') . "\n";
176
-        $msg .= "\n" . strip_tags(str_replace(array('<p>', '</p>', '<br>', '<br>'), "\n", $pm->getVar('msg_text'))) . "\n\n";
174
+        $msg .= _PM_EMAIL_MESSAGE.":\n";
175
+        $msg .= "\n".$pm->getVar('subject')."\n";
176
+        $msg .= "\n".strip_tags(str_replace(array('<p>', '</p>', '<br>', '<br>'), "\n", $pm->getVar('msg_text')))."\n\n";
177 177
         $msg .= "--------------\n";
178
-        $msg .= $xoopsConfig['sitename'] . ': ' . XOOPS_URL . "\n";
178
+        $msg .= $xoopsConfig['sitename'].': '.XOOPS_URL."\n";
179 179
 
180
-        $xoopsMailer =& xoops_getMailer();
180
+        $xoopsMailer = & xoops_getMailer();
181 181
         $xoopsMailer->useMail();
182 182
         $xoopsMailer->setToEmails($user->getVar('email'));
183 183
         $xoopsMailer->setFromEmail($xoopsConfig['adminmail']);
@@ -195,7 +195,7 @@  discard block
 block discarded – undo
195 195
      **/
196 196
     public function getPruneForm()
197 197
     {
198
-        include_once XOOPS_ROOT_PATH . '/class/xoopsformloader.php';
198
+        include_once XOOPS_ROOT_PATH.'/class/xoopsformloader.php';
199 199
         $form = new XoopsThemeForm(_PM_AM_PRUNE, 'form', 'prune.php', 'post', true);
200 200
 
201 201
         $form->addElement(new XoopsFormDateTime(_PM_AM_PRUNEAFTER, 'after'));
Please login to merge, or discard this patch.
htdocs/modules/pm/admin/admin_header.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -17,9 +17,9 @@  discard block
 block discarded – undo
17 17
  */
18 18
 
19 19
 $path = dirname(dirname(dirname(__DIR__)));
20
-include_once $path . '/mainfile.php';
21
-include_once $path . '/include/cp_functions.php';
22
-require_once $path . '/include/cp_header.php';
20
+include_once $path.'/mainfile.php';
21
+include_once $path.'/include/cp_functions.php';
22
+require_once $path.'/include/cp_header.php';
23 23
 
24 24
 global $xoopsModule;
25 25
 
@@ -33,11 +33,11 @@  discard block
 block discarded – undo
33 33
 xoops_loadLanguage('modinfo', $thisModuleDir);
34 34
 xoops_loadLanguage('main', $thisModuleDir);
35 35
 
36
-$pathIcon16      = '../' . $xoopsModule->getInfo('icons16');
37
-$pathIcon32      = '../' . $xoopsModule->getInfo('icons32');
36
+$pathIcon16      = '../'.$xoopsModule->getInfo('icons16');
37
+$pathIcon32      = '../'.$xoopsModule->getInfo('icons32');
38 38
 $pathModuleAdmin = $xoopsModule->getInfo('dirmoduleadmin');
39 39
 
40
-include_once $GLOBALS['xoops']->path($pathModuleAdmin . '/moduleadmin.php');
40
+include_once $GLOBALS['xoops']->path($pathModuleAdmin.'/moduleadmin.php');
41 41
 
42 42
 if ($xoopsUser) {
43 43
     /* @var $moduleperm_handler XoopsGroupPermHandler  */
@@ -46,17 +46,17 @@  discard block
 block discarded – undo
46 46
         redirect_header(XOOPS_URL, 1, _NOPERM);
47 47
     }
48 48
 } else {
49
-    redirect_header(XOOPS_URL . '/user.php', 1, _NOPERM);
49
+    redirect_header(XOOPS_URL.'/user.php', 1, _NOPERM);
50 50
 }
51 51
 
52 52
 if (!isset($xoopsTpl) || !is_object($xoopsTpl)) {
53
-    include_once XOOPS_ROOT_PATH . '/class/template.php';
53
+    include_once XOOPS_ROOT_PATH.'/class/template.php';
54 54
     $xoopsTpl = new XoopsTpl();
55 55
 }
56 56
 
57 57
 //$xoopsTpl->assign('pathIcon16', $pathIcon16);
58 58
 
59 59
 if (!isset($GLOBALS['xoopsTpl']) || !is_object($GLOBALS['xoopsTpl'])) {
60
-    include_once XOOPS_ROOT_PATH . '/class/template.php';
60
+    include_once XOOPS_ROOT_PATH.'/class/template.php';
61 61
     $GLOBALS['xoopsTpl'] = new XoopsTpl();
62 62
 }
Please login to merge, or discard this patch.
htdocs/modules/pm/admin/about.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -16,9 +16,9 @@  discard block
 block discarded – undo
16 16
  * @author              Mage, Mamba
17 17
  **/
18 18
 
19
-include_once dirname(dirname(dirname(__DIR__))) . '/include/cp_header.php';
20
-include_once dirname(dirname(dirname(__DIR__))) . '/class/xoopsformloader.php';
21
-include_once __DIR__ . '/admin_header.php';
19
+include_once dirname(dirname(dirname(__DIR__))).'/include/cp_header.php';
20
+include_once dirname(dirname(dirname(__DIR__))).'/class/xoopsformloader.php';
21
+include_once __DIR__.'/admin_header.php';
22 22
 xoops_cp_header();
23 23
 
24 24
 $aboutAdmin = new ModuleAdmin();
@@ -26,5 +26,5 @@  discard block
 block discarded – undo
26 26
 echo $aboutAdmin->addNavigation(basename(__FILE__));
27 27
 echo $aboutAdmin->renderAbout('[email protected]', false);
28 28
 
29
-include_once __DIR__ . '/admin_footer.php';
29
+include_once __DIR__.'/admin_footer.php';
30 30
 //xoops_cp_footer();
Please login to merge, or discard this patch.
htdocs/modules/pm/admin/admin_footer.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -16,6 +16,6 @@
 block discarded – undo
16 16
  * @author              XOOPS Development Team
17 17
  **/
18 18
 
19
-echo "<div class='adminfooter'>\n" . "  <div style='text-align: center;'>\n" . "    <a href='http://www.xoops.org' rel='external'><img src='{$pathIcon32}/xoopsmicrobutton.gif' alt='XOOPS' title='XOOPS'></a>\n" . "  </div>\n" . '  ' . _AM_MODULEADMIN_ADMIN_FOOTER . "\n" . '</div>';
19
+echo "<div class='adminfooter'>\n"."  <div style='text-align: center;'>\n"."    <a href='http://www.xoops.org' rel='external'><img src='{$pathIcon32}/xoopsmicrobutton.gif' alt='XOOPS' title='XOOPS'></a>\n"."  </div>\n".'  '._AM_MODULEADMIN_ADMIN_FOOTER."\n".'</div>';
20 20
 
21 21
 xoops_cp_footer();
Please login to merge, or discard this patch.
htdocs/modules/pm/admin/header.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -16,9 +16,9 @@
 block discarded – undo
16 16
  * @author              Taiwen Jiang <[email protected]>
17 17
  */
18 18
 
19
-require_once dirname(dirname(dirname(__DIR__))) . '/include/cp_header.php';
19
+require_once dirname(dirname(dirname(__DIR__))).'/include/cp_header.php';
20 20
 
21 21
 if (!isset($GLOBALS['xoopsTpl']) || !is_object($GLOBALS['xoopsTpl'])) {
22
-    include_once XOOPS_ROOT_PATH . '/class/template.php';
22
+    include_once XOOPS_ROOT_PATH.'/class/template.php';
23 23
     $GLOBALS['xoopsTpl'] = new XoopsTpl();
24 24
 }
Please login to merge, or discard this patch.
htdocs/modules/pm/admin/menu.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@  discard block
 block discarded – undo
19 19
 // defined('XOOPS_ROOT_PATH') || exit('XOOPS root path not defined');
20 20
 
21 21
 $path = dirname(dirname(dirname(__DIR__)));
22
-include_once $path . '/mainfile.php';
22
+include_once $path.'/mainfile.php';
23 23
 
24 24
 $dirname         = basename(dirname(__DIR__));
25 25
 /* @var $module_handler XoopsModuleHandler */
@@ -27,10 +27,10 @@  discard block
 block discarded – undo
27 27
 $module          = $module_handler->getByDirname($dirname);
28 28
 $pathIcon32      = $module->getInfo('icons32');
29 29
 $pathModuleAdmin = $module->getInfo('dirmoduleadmin');
30
-$pathLanguage    = $path . $pathModuleAdmin;
30
+$pathLanguage    = $path.$pathModuleAdmin;
31 31
 
32
-if (!file_exists($fileinc = $pathLanguage . '/language/' . $GLOBALS['xoopsConfig']['language'] . '/' . 'main.php')) {
33
-    $fileinc = $pathLanguage . '/language/english/main.php';
32
+if (!file_exists($fileinc = $pathLanguage.'/language/'.$GLOBALS['xoopsConfig']['language'].'/'.'main.php')) {
33
+    $fileinc = $pathLanguage.'/language/english/main.php';
34 34
 }
35 35
 
36 36
 include_once $fileinc;
@@ -40,12 +40,12 @@  discard block
 block discarded – undo
40 40
 $i                      = 1;
41 41
 $adminmenu[$i]['title'] = _PM_MI_INDEX;
42 42
 $adminmenu[$i]['link']  = 'admin/admin.php';
43
-$adminmenu[$i]['icon']  = $pathIcon32 . '/home.png';
43
+$adminmenu[$i]['icon']  = $pathIcon32.'/home.png';
44 44
 ++$i;
45 45
 $adminmenu[$i]['title'] = _PM_MI_PRUNE;
46 46
 $adminmenu[$i]['link']  = 'admin/prune.php';
47
-$adminmenu[$i]['icon']  = $pathIcon32 . '/prune.png';
47
+$adminmenu[$i]['icon']  = $pathIcon32.'/prune.png';
48 48
 ++$i;
49 49
 $adminmenu[$i]['title'] = _PM_MI_ABOUT;
50 50
 $adminmenu[$i]['link']  = 'admin/about.php';
51
-$adminmenu[$i]['icon']  = $pathIcon32 . '/about.png';
51
+$adminmenu[$i]['icon']  = $pathIcon32.'/about.png';
Please login to merge, or discard this patch.
htdocs/modules/pm/admin/prune.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -16,7 +16,7 @@  discard block
 block discarded – undo
16 16
  * @author              Jan Pedersen
17 17
  * @author              Taiwen Jiang <[email protected]>
18 18
  */
19
-include_once __DIR__ . '/admin_header.php';
19
+include_once __DIR__.'/admin_header.php';
20 20
 xoops_cp_header();
21 21
 
22 22
 $indexAdmin = new ModuleAdmin();
@@ -83,5 +83,5 @@  discard block
 block discarded – undo
83 83
         redirect_header('admin.php', 2, sprintf(_PM_AM_MESSAGESPRUNED, $deletedrows));
84 84
         break;
85 85
 }
86
-include_once __DIR__ . '/admin_footer.php';
86
+include_once __DIR__.'/admin_footer.php';
87 87
 //xoops_cp_footer();
Please login to merge, or discard this patch.
htdocs/modules/pm/admin/admin.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -16,7 +16,7 @@  discard block
 block discarded – undo
16 16
  * @author              Taiwen Jiang <[email protected]>
17 17
  */
18 18
 
19
-include_once __DIR__ . '/admin_header.php';
19
+include_once __DIR__.'/admin_header.php';
20 20
 xoops_cp_header();
21 21
 
22 22
 $indexAdmin = new ModuleAdmin();
@@ -24,5 +24,5 @@  discard block
 block discarded – undo
24 24
 echo $indexAdmin->addNavigation(basename(__FILE__));
25 25
 echo $indexAdmin->renderIndex();
26 26
 
27
-include_once __DIR__ . '/admin_footer.php';
27
+include_once __DIR__.'/admin_footer.php';
28 28
 //xoops_cp_footer();
Please login to merge, or discard this patch.
htdocs/modules/pm/pmlite.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -18,9 +18,9 @@  discard block
 block discarded – undo
18 18
  */
19 19
 
20 20
 if (!defined('XOOPS_MAINFILE_INCLUDED')) {
21
-    include_once dirname(dirname(__DIR__)) . '/mainfile.php';
21
+    include_once dirname(dirname(__DIR__)).'/mainfile.php';
22 22
 } else {
23
-    chdir(XOOPS_ROOT_PATH . '/modules/pm/');
23
+    chdir(XOOPS_ROOT_PATH.'/modules/pm/');
24 24
     xoops_loadLanguage('main', 'pm');
25 25
 }
26 26
 
@@ -38,7 +38,7 @@  discard block
 block discarded – undo
38 38
 $msg_id    = XoopsRequest::getInt('msg_id', 0, 'GET');
39 39
 
40 40
 if (empty($_GET['refresh']) && $op !== 'submit') {
41
-    $jump = 'pmlite.php?refresh=' . time();
41
+    $jump = 'pmlite.php?refresh='.time();
42 42
     if ($send == 1) {
43 43
         $jump .= "&send={$send}";
44 44
     } elseif ($send2 == 1) {
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
         $jump .= "&reply={$reply}&msg_id={$msg_id}";
48 48
     } else {
49 49
     }
50
-    header('location: ' . $jump);
50
+    header('location: '.$jump);
51 51
     exit();
52 52
 }
53 53
 
@@ -62,9 +62,9 @@  discard block
 block discarded – undo
62 62
     $member_handler = xoops_getHandler('member');
63 63
     $count          = $member_handler->getUserCount(new Criteria('uid', XoopsRequest::getInt('to_userid', 0, 'POST')));
64 64
     if ($count != 1) {
65
-        echo '<br><br><div><h4>' . _PM_USERNOEXIST . '<br>';
66
-        echo _PM_PLZTRYAGAIN . '</h4><br>';
67
-        echo "[ <a href='javascript:history.go(-1)'>" . _PM_GOBACK . '</a> ]</div>';
65
+        echo '<br><br><div><h4>'._PM_USERNOEXIST.'<br>';
66
+        echo _PM_PLZTRYAGAIN.'</h4><br>';
67
+        echo "[ <a href='javascript:history.go(-1)'>"._PM_GOBACK.'</a> ]</div>';
68 68
     } elseif ($GLOBALS['xoopsSecurity']->check()) {
69 69
         $pm_handler = xoops_getModuleHandler('message', 'pm');
70 70
         $pm         = $pm_handler->create();
@@ -83,15 +83,15 @@  discard block
 block discarded – undo
83 83
         }
84 84
         if (!$pm_handler->insert($pm)) {
85 85
             echo $pm->getHtmlErrors();
86
-            echo "<br><a href='javascript:history.go(-1)'>" . _PM_GOBACK . '</a>';
86
+            echo "<br><a href='javascript:history.go(-1)'>"._PM_GOBACK.'</a>';
87 87
         } else {
88 88
             // @todo: Send notification email if user has selected this in the profile
89 89
 
90
-            echo "<br><br><div style='text-align:center;'><h4>" . _PM_MESSAGEPOSTED . "</h4><br><a href=\"javascript:window.opener.location='" . XOOPS_URL . "/viewpmsg.php';window.close();\">" . _PM_CLICKHERE . "</a><br><br><a href=\"javascript:window.close();\">" . _PM_ORCLOSEWINDOW . '</a></div>';
90
+            echo "<br><br><div style='text-align:center;'><h4>"._PM_MESSAGEPOSTED."</h4><br><a href=\"javascript:window.opener.location='".XOOPS_URL."/viewpmsg.php';window.close();\">"._PM_CLICKHERE."</a><br><br><a href=\"javascript:window.close();\">"._PM_ORCLOSEWINDOW.'</a></div>';
91 91
         }
92 92
     } else {
93 93
         echo implode('<br>', $GLOBALS['xoopsSecurity']->getErrors());
94
-        echo "<br><a href=\"javascript:window.close();\">" . _PM_ORCLOSEWINDOW . '</a>';
94
+        echo "<br><a href=\"javascript:window.close();\">"._PM_ORCLOSEWINDOW.'</a>';
95 95
     }
96 96
 } elseif ($reply == 1 || $send == 1 || $send2 == 1 || $sendmod == 1) {
97 97
     if ($reply == 1) {
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
101 101
             $pm_uname = XoopsUser::getUnameFromId($pm->getVar('from_userid'));
102 102
             $message  = "[quote]\n";
103 103
             $message .= sprintf(_PM_USERWROTE, $pm_uname);
104
-            $message .= "\n" . $pm->getVar('msg_text', 'E') . "\n[/quote]";
104
+            $message .= "\n".$pm->getVar('msg_text', 'E')."\n[/quote]";
105 105
         } else {
106 106
             unset($pm);
107 107
             $reply = $send2 = 0;
@@ -115,8 +115,8 @@  discard block
 block discarded – undo
115 115
     $message = '';
116 116
     if ($reply == 1) {
117 117
         $subject = $pm->getVar('subject', 'E');
118
-        if (!preg_match('/^' . _RE . '/i', $subject)) {
119
-            $subject = _RE . ' ' . $subject;
118
+        if (!preg_match('/^'._RE.'/i', $subject)) {
119
+            $subject = _RE.' '.$subject;
120 120
         }
121 121
         $pmform->addElement(new XoopsFormLabel(_PM_TO, $pm_uname));
122 122
         $pmform->addElement(new XoopsFormHidden('to_userid', $pm->getVar('from_userid')));
@@ -142,7 +142,7 @@  discard block
 block discarded – undo
142 142
     $icons_radio = new XoopsFormRadio(_MESSAGEICON, 'msg_image', $msg_image);
143 143
     $subjectImages = array();
144 144
     foreach ($subject_icons as $name => $value) {
145
-        $subjectImages[$name] = '<img src="' . XOOPS_URL . '/images/subject/' . $value .'">';
145
+        $subjectImages[$name] = '<img src="'.XOOPS_URL.'/images/subject/'.$value.'">';
146 146
     }
147 147
     $icons_radio->addOptionArray($subjectImages);
148 148
     $pmform->addElement($icons_radio);
Please login to merge, or discard this patch.