XOOPS /
XoopsCore25
| Conditions | 18 |
| Paths | 64 |
| Total Lines | 96 |
| Code Lines | 62 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 4 | ||
| Bugs | 1 | Features | 1 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 23 | function protector_onupdate_base($module, $mydirname) |
||
| 24 | { |
||
| 25 | // translations on module update |
||
| 26 | |||
| 27 | global $msgs; // TODO :-D |
||
| 28 | |||
| 29 | if (!is_array($msgs)) { |
||
| 30 | $msgs = array(); |
||
| 31 | } |
||
| 32 | |||
| 33 | $db = XoopsDatabaseFactory::getDatabaseConnection(); |
||
| 34 | $mid = $module->getVar('mid'); |
||
| 35 | |||
| 36 | // TABLES (write here ALTER TABLE etc. if necessary) |
||
| 37 | |||
| 38 | // configs (Though I know it is not a recommended way...) |
||
| 39 | $sql = 'SHOW COLUMNS FROM ' . $db->prefix('config') . " LIKE 'conf_title'"; |
||
| 40 | $result = $db->query($sql); |
||
| 41 | if ($db->isResultSet($result) && ($myrow = $db->fetchArray($result)) && isset($myrow['Type']) && $myrow['Type'] === 'varchar(30)') { |
||
| 42 | $db->queryF('ALTER TABLE ' . $db->prefix('config') . " MODIFY `conf_title` varchar(255) NOT NULL default '', MODIFY `conf_desc` varchar(255) NOT NULL default ''"); |
||
| 43 | } |
||
| 44 | |||
| 45 | $sql = 'SHOW CREATE TABLE ' . $db->prefix('config'); |
||
| 46 | $result = $db->query($sql); |
||
| 47 | if (!$db->isResultSet($result)) { |
||
| 48 | throw new \RuntimeException( |
||
| 49 | \sprintf(_DB_QUERY_ERROR, $sql) . $db->error(), E_USER_ERROR |
||
| 50 | ); |
||
| 51 | } |
||
| 52 | list(, $create_string) = $db->fetchRow($result); |
||
| 53 | |||
| 54 | foreach (explode('KEY', $create_string) as $line) { |
||
| 55 | if (preg_match('/(\`conf\_title_\d+\`) \(\`conf\_title\`\)/', $line, $regs)) { |
||
| 56 | $db->query('ALTER TABLE ' . $db->prefix('config') . ' DROP KEY ' . $regs[1]); |
||
| 57 | } |
||
| 58 | } |
||
| 59 | $db->query('ALTER TABLE ' . $db->prefix('config') . ' ADD KEY `conf_title` (`conf_title`)'); |
||
| 60 | |||
| 61 | // 2.x -> 3.0 |
||
| 62 | $sql = 'SHOW CREATE TABLE ' . $db->prefix($mydirname . '_log'); |
||
| 63 | $result = $db->query($sql); |
||
| 64 | if (!$db->isResultSet($result)) { |
||
| 65 | throw new \RuntimeException( |
||
| 66 | \sprintf(_DB_QUERY_ERROR, $sql) . $db->error(), E_USER_ERROR |
||
| 67 | ); |
||
| 68 | } |
||
| 69 | list(, $create_string) = $db->fetchRow($result); |
||
| 70 | if (preg_match('/timestamp\(/i', $create_string)) { |
||
| 71 | $db->query('ALTER TABLE ' . $db->prefix($mydirname . '_log') . ' MODIFY `timestamp` DATETIME'); |
||
| 72 | } |
||
| 73 | |||
| 74 | // TEMPLATES (all templates have been already removed by modulesadmin) |
||
| 75 | /** @var XoopsTplfileHandler $tplfile_handler */ |
||
| 76 | $tplfile_handler = xoops_getHandler('tplfile'); |
||
| 77 | $tpl_path = __DIR__ . '/templates'; |
||
| 78 | if ($handler = @opendir($tpl_path . '/')) { |
||
| 79 | while (($file = readdir($handler)) !== false) { |
||
| 80 | if (substr($file, 0, 1) === '.') { |
||
| 81 | continue; |
||
| 82 | } |
||
| 83 | $file_path = $tpl_path . '/' . $file; |
||
| 84 | if (is_file($file_path) && in_array(strrchr($file, '.'), array('.html', '.css', '.js'))) { |
||
| 85 | $mtime = (int)(@filemtime($file_path)); |
||
| 86 | $tplfile = $tplfile_handler->create(); |
||
| 87 | $tplfile->setVar('tpl_source', file_get_contents($file_path), true); |
||
| 88 | $tplfile->setVar('tpl_refid', $mid); |
||
| 89 | $tplfile->setVar('tpl_tplset', 'default'); |
||
| 90 | $tplfile->setVar('tpl_file', $mydirname . '_' . $file); |
||
| 91 | $tplfile->setVar('tpl_desc', '', true); |
||
| 92 | $tplfile->setVar('tpl_module', $mydirname); |
||
| 93 | $tplfile->setVar('tpl_lastmodified', $mtime); |
||
| 94 | $tplfile->setVar('tpl_lastimported', 0); |
||
| 95 | $tplfile->setVar('tpl_type', 'module'); |
||
| 96 | if (!$tplfile_handler->insert($tplfile)) { |
||
| 97 | $msgs[] = '<span style="color:#ff0000;">ERROR: Could not insert template <b>' . htmlspecialchars($mydirname . '_' . $file, ENT_QUOTES) . '</b> to the database.</span>'; |
||
| 98 | } else { |
||
| 99 | $tplid = $tplfile->getVar('tpl_id'); |
||
| 100 | $msgs[] = 'Template <b>' . htmlspecialchars($mydirname . '_' . $file, ENT_QUOTES) . '</b> added to the database. (ID: <b>' . $tplid . '</b>)'; |
||
| 101 | // generate compiled file |
||
| 102 | include_once XOOPS_ROOT_PATH . '/class/xoopsblock.php'; |
||
| 103 | include_once XOOPS_ROOT_PATH . '/class/template.php'; |
||
| 104 | if (!xoops_template_touch((string)$tplid)) { |
||
| 105 | $msgs[] = '<span style="color:#ff0000;">ERROR: Failed compiling template <b>' . htmlspecialchars($mydirname . '_' . $file, ENT_QUOTES) . '</b>.</span>'; |
||
| 106 | } else { |
||
| 107 | $msgs[] = 'Template <b>' . htmlspecialchars($mydirname . '_' . $file, ENT_QUOTES) . '</b> compiled.</span>'; |
||
| 108 | } |
||
| 109 | } |
||
| 110 | } |
||
| 111 | } |
||
| 112 | closedir($handler); |
||
| 113 | } |
||
| 114 | include_once XOOPS_ROOT_PATH . '/class/xoopsblock.php'; |
||
| 115 | include_once XOOPS_ROOT_PATH . '/class/template.php'; |
||
| 116 | xoops_template_clear_module_cache($mid); |
||
| 117 | |||
| 118 | return true; |
||
| 119 | } |
||
| 136 |
Loading history...
This check looks for function or method calls that always return null and whose return value is assigned to a variable.
The method
getObject()can return nothing but null, so it makes no sense to assign that value to a variable.The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes.