XOOPS /
XoopsCore25
| Conditions | 18 |
| Paths | 444 |
| Total Lines | 77 |
| Code Lines | 63 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 35 | * |
||
| 36 | * @param unknown_type $color_number |
||
| 37 | * @param unknown_type $subject_image |
||
| 38 | * @param unknown_type $subject |
||
| 39 | * @param unknown_type $text |
||
| 40 | * @param unknown_type $post_date |
||
| 41 | * @param unknown_type $ip_image |
||
| 42 | * @param unknown_type $reply_image |
||
| 43 | * @param unknown_type $edit_image |
||
| 44 | * @param unknown_type $delete_image |
||
| 45 | * @param string|\unknown_type $username |
||
| 46 | * @param string|\unknown_type $rank_title |
||
| 47 | * @param string|\unknown_type $rank_image |
||
| 48 | * @param string|\unknown_type $avatar_image |
||
| 49 | * @param string|\unknown_type $reg_date |
||
| 50 | * @param string|\unknown_type $posts |
||
| 51 | * @param string|\unknown_type $user_from |
||
| 52 | * @param string|\unknown_type $online_image |
||
| 53 | * @param string|\unknown_type $profile_image |
||
| 54 | * @param string|\unknown_type $pm_image |
||
| 55 | * @param string|\unknown_type $email_image |
||
| 56 | * @param string|\unknown_type $www_image |
||
| 57 | * @param string|\unknown_type $icq_image |
||
| 58 | * @param string|\unknown_type $aim_image |
||
| 59 | * @param string|\unknown_type $yim_image |
||
| 60 | * @param string|\unknown_type $msnm_image |
||
| 61 | */ |
||
| 62 | function showThread($color_number, $subject_image, $subject, $text, $post_date, $ip_image, $reply_image, $edit_image, $delete_image, $username = '', $rank_title = '', $rank_image = '', $avatar_image = '', $reg_date = '', $posts = '', $user_from = '', $online_image = '', $profile_image = '', $pm_image = '', $email_image = '', $www_image = '', $icq_image = '', $aim_image = '', $yim_image = '', $msnm_image = '') |
||
| 63 | { |
||
| 64 | $bg = 'bg3'; |
||
| 65 | if ($color_number == 1) { |
||
| 66 | $bg = 'bg1'; |
||
| 67 | } |
||
| 68 | echo "<tr align='left'><td valign='top' class='$bg' nowrap='nowrap'><strong>$username</strong><br>$rank_title<br>$rank_image<br>$avatar_image<br><br>$reg_date<br>$posts<br>$user_from<br><br>$online_image</td>"; |
||
| 69 | echo "<td valign='top' class='$bg'><table width='100%' border='0'><tr><td valign='top'>$subject_image <strong>$subject</strong></td><td align='right'>" . $ip_image . '' . $reply_image . '' . $edit_image . '' . $delete_image . '</td></tr>'; |
||
| 70 | echo "<tr><td colspan='2'><p>$text</p></td></tr></table></td></tr>"; |
||
| 71 | echo "<tr align='left'><td class='$bg' valign='middle'>$post_date</td><td class='$bg' valign='middle'>" . $profile_image . '' . $pm_image . '' . $email_image . '' . $www_image . '' . $icq_image . '' . $aim_image . '' . $yim_image . '' . $msnm_image . '</td></tr>'; |
||
| 72 | } |
||
| 73 | |||
| 74 | /** |
||
| 75 | * Enter description here... |
||
| 76 | * |
||
| 77 | */ |
||
| 78 | function closeThread() |
||
| 79 | { |
||
| 80 | echo '</table></td></tr></table>'; |
||
| 81 | } |
||
| 82 |
Loading history...
The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g.
excluded_paths: ["lib/*"], you can move it to the dependency path list as follows:For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths