| Conditions | 6 |
| Paths | 32 |
| Total Lines | 78 |
| Code Lines | 55 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 51 | function regen_xoStats() |
||
| 52 | { |
||
| 53 | global $xoopsUser, $xoopsModule; |
||
| 54 | |||
| 55 | $stats = array(); |
||
| 56 | |||
| 57 | /** @var \XoopsMemberHandler $memberHandler */ |
||
| 58 | $memberHandler = xoops_getHandler('member'); |
||
| 59 | |||
| 60 | // Getting Total Online Users |
||
| 61 | /** @var \XoopsOnlineHandler $online_handler */ |
||
| 62 | $online_handler = xoops_getHandler('online'); |
||
| 63 | // set gc probabillity to 10% for now.. |
||
| 64 | if (mt_rand(1, 100) < 11) { |
||
| 65 | $online_handler->gc(300); |
||
| 66 | } |
||
| 67 | if (is_object($xoopsUser)) { |
||
| 68 | $uid = $xoopsUser->getVar('uid'); |
||
| 69 | $uname = $xoopsUser->getVar('uname'); |
||
| 70 | } else { |
||
| 71 | $uid = 0; |
||
| 72 | $uname = ''; |
||
| 73 | } |
||
| 74 | |||
| 75 | $requestIp = IPAddress::fromRequest()->asReadable(); |
||
| 76 | $requestIp = (false === $requestIp) ? '0.0.0.0' : $requestIp; |
||
| 77 | if (is_object($xoopsModule)) { |
||
| 78 | $online_handler->write($uid, $uname, time(), $xoopsModule->getVar('mid'), $requestIp); |
||
| 79 | } else { |
||
| 80 | $online_handler->write($uid, $uname, time(), 0, $requestIp); |
||
| 81 | } |
||
| 82 | $onlines = $online_handler->getAll(); |
||
| 83 | if (empty($onlines)) { |
||
| 84 | $stats['totalonline'] = 0; |
||
| 85 | } else { |
||
| 86 | $totalonline = count($onlines); |
||
| 87 | $stats['totalonline'] = $totalonline; |
||
| 88 | } |
||
| 89 | |||
| 90 | //Getting Total Registered Users |
||
| 91 | $level_criteria = new \Criteria('level', 0, '>'); |
||
| 92 | $criteria = new \CriteriaCompo($level_criteria); |
||
| 93 | $criteria24 = new \CriteriaCompo($level_criteria); |
||
| 94 | $criteria48 = new \CriteriaCompo($level_criteria); |
||
| 95 | $totaluser = $memberHandler->getUserCount($level_criteria); |
||
| 96 | $stats['totaluser'] = $totaluser; |
||
| 97 | |||
| 98 | //Getting User Registration Statistics |
||
| 99 | $users_reg_24 = $memberHandler->getUserCount($criteria24->add(new \Criteria('user_regdate', (mktime(0, 0, 0) - (24 * 3600)), '>=')), 'AND'); |
||
| 100 | $users_reg_48 = $memberHandler->getUserCount($criteria48->add(new \Criteria('user_regdate', (mktime(0, 0, 0) - (48 * 3600)), '>=')), 'AND'); |
||
| 101 | $todayregister = $users_reg_24; |
||
| 102 | $yesterdayregister = $users_reg_48; |
||
| 103 | $stats['totalregisteredtoday'] = $todayregister; |
||
| 104 | $stats['totalregisteredyesterday'] = $yesterdayregister; |
||
| 105 | |||
| 106 | // Getting Last Registered Member |
||
| 107 | $limit = 1; |
||
| 108 | $criteria->setOrder('DESC'); |
||
| 109 | $criteria->setSort('user_regdate'); |
||
| 110 | $criteria->setLimit($limit); |
||
| 111 | $lastmembers = $memberHandler->getUsers($criteria); |
||
| 112 | $lastusername = $lastmembers[0]->getVar('uname'); |
||
| 113 | $lastrealname = $lastmembers[0]->getVar('name'); |
||
| 114 | $latestuid = $lastmembers[0]->getVar('uid'); |
||
| 115 | $latestmembername = $lastrealname; |
||
| 116 | $latestmemberuname = $lastusername; |
||
| 117 | $stats['latestmembername'] = $latestmembername; |
||
| 118 | $stats['latestmemberuname'] = $latestmemberuname; |
||
| 119 | $stats['latestuid'] = $latestuid; |
||
| 120 | |||
| 121 | //Total Post Count |
||
| 122 | $sql = 'SELECT SUM(posts) AS totalpost FROM ' . $GLOBALS['xoopsDB']->prefix('users') . ' WHERE level > 0'; |
||
| 123 | $result = $GLOBALS['xoopsDB']->query($sql); |
||
| 124 | $myrow = $GLOBALS['xoopsDB']->fetchArray($result); |
||
| 125 | $totalpost = $myrow['totalpost']; |
||
| 126 | $stats['totalpost'] = $totalpost; |
||
| 127 | |||
| 128 | return $stats; |
||
| 129 | } |
||
| 130 |
This check looks for parameters that have been defined for a function or method, but which are not used in the method body.