Conditions | 45 |
Paths | > 20000 |
Total Lines | 246 |
Code Lines | 191 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
30 | function profile_getFieldForm(ProfileField $field, $action = false) |
||
31 | { |
||
32 | if ($action === false) { |
||
33 | $action = $_SERVER['REQUEST_URI']; |
||
34 | } |
||
35 | $title = $field->isNew() ? sprintf(_PROFILE_AM_ADD, _PROFILE_AM_FIELD) : sprintf(_PROFILE_AM_EDIT, _PROFILE_AM_FIELD); |
||
36 | |||
37 | include_once $GLOBALS['xoops']->path('class/xoopsformloader.php'); |
||
38 | $form = new XoopsThemeForm($title, 'form', $action, 'post', true); |
||
39 | |||
40 | $form->addElement(new XoopsFormText(_PROFILE_AM_TITLE, 'field_title', 35, 255, $field->getVar('field_title', 'e'))); |
||
41 | $form->addElement(new XoopsFormTextArea(_PROFILE_AM_DESCRIPTION, 'field_description', $field->getVar('field_description', 'e'))); |
||
42 | |||
43 | $fieldcat_id = 0; |
||
44 | if (!$field->isNew()) { |
||
45 | $fieldcat_id = $field->getVar('cat_id'); |
||
46 | } |
||
47 | $category_handler = xoops_getModuleHandler('category'); |
||
48 | $cat_select = new XoopsFormSelect(_PROFILE_AM_CATEGORY, 'field_category', $fieldcat_id); |
||
49 | $cat_select->addOption(0, _PROFILE_AM_DEFAULT); |
||
50 | $cat_select->addOptionArray($category_handler->getList()); |
||
|
|||
51 | $form->addElement($cat_select); |
||
52 | $form->addElement(new XoopsFormText(_PROFILE_AM_WEIGHT, 'field_weight', 10, 10, $field->getVar('field_weight', 'e'))); |
||
53 | if ($field->getVar('field_config') || $field->isNew()) { |
||
54 | if (!$field->isNew()) { |
||
55 | $form->addElement(new XoopsFormLabel(_PROFILE_AM_NAME, $field->getVar('field_name'))); |
||
56 | $form->addElement(new XoopsFormHidden('id', $field->getVar('field_id'))); |
||
57 | } else { |
||
58 | $form->addElement(new XoopsFormText(_PROFILE_AM_NAME, 'field_name', 35, 255, $field->getVar('field_name', 'e'))); |
||
59 | } |
||
60 | |||
61 | //autotext and theme left out of this one as fields of that type should never be changed (valid assumption, I think) |
||
62 | $fieldtypes = array( |
||
63 | 'checkbox' => _PROFILE_AM_CHECKBOX, |
||
64 | 'date' => _PROFILE_AM_DATE, |
||
65 | 'datetime' => _PROFILE_AM_DATETIME, |
||
66 | 'longdate' => _PROFILE_AM_LONGDATE, |
||
67 | 'group' => _PROFILE_AM_GROUP, |
||
68 | 'group_multi' => _PROFILE_AM_GROUPMULTI, |
||
69 | 'language' => _PROFILE_AM_LANGUAGE, |
||
70 | 'radio' => _PROFILE_AM_RADIO, |
||
71 | 'select' => _PROFILE_AM_SELECT, |
||
72 | 'select_multi' => _PROFILE_AM_SELECTMULTI, |
||
73 | 'textarea' => _PROFILE_AM_TEXTAREA, |
||
74 | 'dhtml' => _PROFILE_AM_DHTMLTEXTAREA, |
||
75 | 'textbox' => _PROFILE_AM_TEXTBOX, |
||
76 | 'timezone' => _PROFILE_AM_TIMEZONE, |
||
77 | 'yesno' => _PROFILE_AM_YESNO); |
||
78 | |||
79 | $element_select = new XoopsFormSelect(_PROFILE_AM_TYPE, 'field_type', $field->getVar('field_type', 'e')); |
||
80 | $element_select->addOptionArray($fieldtypes); |
||
81 | |||
82 | $form->addElement($element_select); |
||
83 | |||
84 | switch ($field->getVar('field_type')) { |
||
85 | case 'textbox': |
||
86 | $valuetypes = array( |
||
87 | XOBJ_DTYPE_TXTBOX => _PROFILE_AM_TXTBOX, |
||
88 | XOBJ_DTYPE_EMAIL => _PROFILE_AM_EMAIL, |
||
89 | XOBJ_DTYPE_INT => _PROFILE_AM_INT, |
||
90 | XOBJ_DTYPE_FLOAT => _PROFILE_AM_FLOAT, |
||
91 | XOBJ_DTYPE_DECIMAL => _PROFILE_AM_DECIMAL, |
||
92 | XOBJ_DTYPE_TXTAREA => _PROFILE_AM_TXTAREA, |
||
93 | XOBJ_DTYPE_URL => _PROFILE_AM_URL, |
||
94 | XOBJ_DTYPE_OTHER => _PROFILE_AM_OTHER, |
||
95 | XOBJ_DTYPE_ARRAY => _PROFILE_AM_ARRAY, |
||
96 | XOBJ_DTYPE_UNICODE_ARRAY => _PROFILE_AM_UNICODE_ARRAY, |
||
97 | XOBJ_DTYPE_UNICODE_TXTBOX => _PROFILE_AM_UNICODE_TXTBOX, |
||
98 | XOBJ_DTYPE_UNICODE_TXTAREA => _PROFILE_AM_UNICODE_TXTAREA, |
||
99 | XOBJ_DTYPE_UNICODE_EMAIL => _PROFILE_AM_UNICODE_EMAIL, |
||
100 | XOBJ_DTYPE_UNICODE_URL => _PROFILE_AM_UNICODE_URL); |
||
101 | |||
102 | $type_select = new XoopsFormSelect(_PROFILE_AM_VALUETYPE, 'field_valuetype', $field->getVar('field_valuetype', 'e')); |
||
103 | $type_select->addOptionArray($valuetypes); |
||
104 | $form->addElement($type_select); |
||
105 | break; |
||
106 | |||
107 | case 'select': |
||
108 | case 'radio': |
||
109 | $valuetypes = array( |
||
110 | XOBJ_DTYPE_TXTBOX => _PROFILE_AM_TXTBOX, |
||
111 | XOBJ_DTYPE_EMAIL => _PROFILE_AM_EMAIL, |
||
112 | XOBJ_DTYPE_INT => _PROFILE_AM_INT, |
||
113 | XOBJ_DTYPE_FLOAT => _PROFILE_AM_FLOAT, |
||
114 | XOBJ_DTYPE_DECIMAL => _PROFILE_AM_DECIMAL, |
||
115 | XOBJ_DTYPE_TXTAREA => _PROFILE_AM_TXTAREA, |
||
116 | XOBJ_DTYPE_URL => _PROFILE_AM_URL, |
||
117 | XOBJ_DTYPE_OTHER => _PROFILE_AM_OTHER, |
||
118 | XOBJ_DTYPE_ARRAY => _PROFILE_AM_ARRAY, |
||
119 | XOBJ_DTYPE_UNICODE_ARRAY => _PROFILE_AM_UNICODE_ARRAY, |
||
120 | XOBJ_DTYPE_UNICODE_TXTBOX => _PROFILE_AM_UNICODE_TXTBOX, |
||
121 | XOBJ_DTYPE_UNICODE_TXTAREA => _PROFILE_AM_UNICODE_TXTAREA, |
||
122 | XOBJ_DTYPE_UNICODE_EMAIL => _PROFILE_AM_UNICODE_EMAIL, |
||
123 | XOBJ_DTYPE_UNICODE_URL => _PROFILE_AM_UNICODE_URL); |
||
124 | |||
125 | $type_select = new XoopsFormSelect(_PROFILE_AM_VALUETYPE, 'field_valuetype', $field->getVar('field_valuetype', 'e')); |
||
126 | $type_select->addOptionArray($valuetypes); |
||
127 | $form->addElement($type_select); |
||
128 | break; |
||
129 | } |
||
130 | |||
131 | //$form->addElement(new XoopsFormRadioYN(_PROFILE_AM_NOTNULL, 'field_notnull', $field->getVar('field_notnull', 'e') )); |
||
132 | |||
133 | if ($field->getVar('field_type') === 'select' || $field->getVar('field_type') === 'select_multi' || $field->getVar('field_type') === 'radio' || $field->getVar('field_type') === 'checkbox') { |
||
134 | $options = $field->getVar('field_options'); |
||
135 | if (count($options) > 0) { |
||
136 | $remove_options = new XoopsFormCheckBox(_PROFILE_AM_REMOVEOPTIONS, 'removeOptions'); |
||
137 | $remove_options->columns = 3; |
||
138 | asort($options); |
||
139 | foreach (array_keys($options) as $key) { |
||
140 | $options[$key] .= "[{$key}]"; |
||
141 | } |
||
142 | $remove_options->addOptionArray($options); |
||
143 | $form->addElement($remove_options); |
||
144 | } |
||
145 | |||
146 | $option_text = "<table cellspacing='1'><tr><td class='width20'>" . _PROFILE_AM_KEY . '</td><td>' . _PROFILE_AM_VALUE . '</td></tr>'; |
||
147 | for ($i = 0; $i < 3; ++$i) { |
||
148 | $option_text .= "<tr><td><input type='text' name='addOption[{$i}][key]' id='addOption[{$i}][key]' size='15' /></td><td><input type='text' name='addOption[{$i}][value]' id='addOption[{$i}][value]' size='35' /></td></tr>"; |
||
149 | $option_text .= "<tr height='3px'><td colspan='2'> </td></tr>"; |
||
150 | } |
||
151 | $option_text .= '</table>'; |
||
152 | $form->addElement(new XoopsFormLabel(_PROFILE_AM_ADDOPTION, $option_text)); |
||
153 | } |
||
154 | } |
||
155 | |||
156 | if ($field->getVar('field_edit')) { |
||
157 | switch ($field->getVar('field_type')) { |
||
158 | case 'textbox': |
||
159 | case 'textarea': |
||
160 | case 'dhtml': |
||
161 | $form->addElement(new XoopsFormText(_PROFILE_AM_MAXLENGTH, 'field_maxlength', 35, 35, $field->getVar('field_maxlength', 'e'))); |
||
162 | $form->addElement(new XoopsFormTextArea(_PROFILE_AM_DEFAULT, 'field_default', $field->getVar('field_default', 'e'))); |
||
163 | break; |
||
164 | |||
165 | case 'checkbox': |
||
166 | case 'select_multi': |
||
167 | $def_value = $field->getVar('field_default', 'e') != null ? unserialize($field->getVar('field_default', 'n')) : null; |
||
168 | $element = new XoopsFormSelect(_PROFILE_AM_DEFAULT, 'field_default', $def_value, 8, true); |
||
169 | $options = $field->getVar('field_options'); |
||
170 | asort($options); |
||
171 | // If options do not include an empty element, then add a blank option to prevent any default selection |
||
172 | // if (!in_array('', array_keys($options))) { |
||
173 | if (!array_key_exists('', $options)) { |
||
174 | $element->addOption('', _NONE); |
||
175 | } |
||
176 | $element->addOptionArray($options); |
||
177 | $form->addElement($element); |
||
178 | break; |
||
179 | |||
180 | case 'select': |
||
181 | case 'radio': |
||
182 | $def_value = $field->getVar('field_default', 'e') != null ? $field->getVar('field_default') : null; |
||
183 | $element = new XoopsFormSelect(_PROFILE_AM_DEFAULT, 'field_default', $def_value); |
||
184 | $options = $field->getVar('field_options'); |
||
185 | asort($options); |
||
186 | // If options do not include an empty element, then add a blank option to prevent any default selection |
||
187 | // if (!in_array('', array_keys($options))) { |
||
188 | if (!array_key_exists('', $options)) { |
||
189 | $element->addOption('', _NONE); |
||
190 | } |
||
191 | $element->addOptionArray($options); |
||
192 | $form->addElement($element); |
||
193 | break; |
||
194 | |||
195 | case 'date': |
||
196 | $form->addElement(new XoopsFormTextDateSelect(_PROFILE_AM_DEFAULT, 'field_default', 15, $field->getVar('field_default', 'e'))); |
||
197 | break; |
||
198 | |||
199 | case 'longdate': |
||
200 | $form->addElement(new XoopsFormTextDateSelect(_PROFILE_AM_DEFAULT, 'field_default', 15, strtotime($field->getVar('field_default', 'e')))); |
||
201 | break; |
||
202 | |||
203 | case 'datetime': |
||
204 | $form->addElement(new XoopsFormDateTime(_PROFILE_AM_DEFAULT, 'field_default', 15, $field->getVar('field_default', 'e'))); |
||
205 | break; |
||
206 | |||
207 | case 'yesno': |
||
208 | $form->addElement(new XoopsFormRadioYN(_PROFILE_AM_DEFAULT, 'field_default', $field->getVar('field_default', 'e'))); |
||
209 | break; |
||
210 | |||
211 | case 'timezone': |
||
212 | $form->addElement(new XoopsFormSelectTimezone(_PROFILE_AM_DEFAULT, 'field_default', $field->getVar('field_default', 'e'))); |
||
213 | break; |
||
214 | |||
215 | case 'language': |
||
216 | $form->addElement(new XoopsFormSelectLang(_PROFILE_AM_DEFAULT, 'field_default', $field->getVar('field_default', 'e'))); |
||
217 | break; |
||
218 | |||
219 | case 'group': |
||
220 | $form->addElement(new XoopsFormSelectGroup(_PROFILE_AM_DEFAULT, 'field_default', true, $field->getVar('field_default', 'e'))); |
||
221 | break; |
||
222 | |||
223 | case 'group_multi': |
||
224 | $form->addElement(new XoopsFormSelectGroup(_PROFILE_AM_DEFAULT, 'field_default', true, unserialize($field->getVar('field_default', 'n')), 5, true)); |
||
225 | break; |
||
226 | |||
227 | case 'theme': |
||
228 | $form->addElement(new XoopsFormSelectTheme(_PROFILE_AM_DEFAULT, 'field_default', $field->getVar('field_default', 'e'))); |
||
229 | break; |
||
230 | |||
231 | case 'autotext': |
||
232 | $form->addElement(new XoopsFormTextArea(_PROFILE_AM_DEFAULT, 'field_default', $field->getVar('field_default', 'e'))); |
||
233 | break; |
||
234 | } |
||
235 | } |
||
236 | /** @var XoopsGroupPermHandler $groupperm_handler */ |
||
237 | $groupperm_handler = xoops_getHandler('groupperm'); |
||
238 | $searchable_types = array( |
||
239 | 'textbox', |
||
240 | 'select', |
||
241 | 'radio', |
||
242 | 'yesno', |
||
243 | 'date', |
||
244 | 'datetime', |
||
245 | 'timezone', |
||
246 | 'language'); |
||
247 | if (in_array($field->getVar('field_type'), $searchable_types)) { |
||
248 | $search_groups = $groupperm_handler->getGroupIds('profile_search', $field->getVar('field_id'), $GLOBALS['xoopsModule']->getVar('mid')); |
||
249 | $form->addElement(new XoopsFormSelectGroup(_PROFILE_AM_PROF_SEARCH, 'profile_search', true, $search_groups, 5, true)); |
||
250 | } |
||
251 | if ($field->getVar('field_edit') || $field->isNew()) { |
||
252 | $editable_groups = array(); |
||
253 | if (!$field->isNew()) { |
||
254 | //Load groups |
||
255 | $editable_groups = $groupperm_handler->getGroupIds('profile_edit', $field->getVar('field_id'), $GLOBALS['xoopsModule']->getVar('mid')); |
||
256 | } |
||
257 | $form->addElement(new XoopsFormSelectGroup(_PROFILE_AM_PROF_EDITABLE, 'profile_edit', false, $editable_groups, 5, true)); |
||
258 | $form->addElement(new XoopsFormRadioYN(_PROFILE_AM_REQUIRED, 'field_required', $field->getVar('field_required', 'e'))); |
||
259 | $regstep_select = new XoopsFormSelect(_PROFILE_AM_PROF_REGISTER, 'step_id', $field->getVar('step_id', 'e')); |
||
260 | $regstep_select->addOption(0, _NO); |
||
261 | $regstep_handler = xoops_getModuleHandler('regstep'); |
||
262 | $regstep_select->addOptionArray($regstep_handler->getList()); |
||
263 | $form->addElement($regstep_select); |
||
264 | } |
||
265 | $form->addElement(new XoopsFormHidden('op', 'save')); |
||
266 | $form->addElement(new XoopsFormButton('', 'submit', _SUBMIT, 'submit')); |
||
267 | |||
268 | $options = $field->getVar('field_options'); |
||
269 | if (count($options) > 0) { |
||
270 | $linkText = defined('_PROFILE_AM_EDIT_OPTION_STRINGS') ? _PROFILE_AM_EDIT_OPTION_STRINGS : 'Edit Option Strings'; |
||
271 | $editOptionsButton = new XoopsFormLabel('','<a href="'.$action.'&op=edit-option-strings"><i class="fa fa-fw fa-2x fa-language" aria-hidden="true"></i> ' . $linkText . '</a>'); |
||
272 | $form->addElement($editOptionsButton); |
||
273 | } |
||
274 | |||
275 | return $form; |
||
276 | } |
||
600 |