Conditions | 10 |
Paths | 512 |
Total Lines | 59 |
Code Lines | 39 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
146 | function modify_chmod($value_chmod, $path_file, $id) |
||
147 | { |
||
148 | $chmod = '<div id="loading_' . $id . '" align="center" style="display:none;">' . '<img src="./images/mimetypes/spinner.gif" title="Loading" alt="Loading" width="12px"/></div>' . '<div id="chmod' . $id . '">' . '<select size="1" onChange="filemanager_modify_chmod(\'' . $path_file . '\', \'' . $id . '\')" name="chmod" id="chmod">'; |
||
149 | if ($value_chmod == 777) { |
||
150 | $chmod .= '<option value="777" selected><span style="color:green;">777</span></option>'; |
||
151 | } else { |
||
152 | $chmod .= '<option value="777"><span style="color:green;">777</span></option>'; |
||
153 | } |
||
154 | |||
155 | if ($value_chmod == 776) { |
||
156 | $chmod .= '<option value="776" selected>776</option>'; |
||
157 | } else { |
||
158 | $chmod .= '<option value="776">776</option>'; |
||
159 | } |
||
160 | |||
161 | if ($value_chmod == 766) { |
||
162 | $chmod .= '<option value="766" selected>766</option>'; |
||
163 | } else { |
||
164 | $chmod .= '<option value="766">766</option>'; |
||
165 | } |
||
166 | |||
167 | if ($value_chmod == 666) { |
||
168 | $chmod .= '<option value="666" selected>666</option>'; |
||
169 | } else { |
||
170 | $chmod .= '<option value="666">666</option>'; |
||
171 | } |
||
172 | |||
173 | if ($value_chmod == 664) { |
||
174 | $chmod .= '<option value="664" selected>664</option>'; |
||
175 | } else { |
||
176 | $chmod .= '<option value="664">664</option>'; |
||
177 | } |
||
178 | |||
179 | if ($value_chmod == 644) { |
||
180 | $chmod .= '<option value="644" selected>644</option>'; |
||
181 | } else { |
||
182 | $chmod .= '<option value="644">644</option>'; |
||
183 | } |
||
184 | |||
185 | if ($value_chmod == 444) { |
||
186 | $chmod .= '<option value="444" selected><span style="color:red;">444</span></option>'; |
||
187 | } else { |
||
188 | $chmod .= '<option value="444">444</option>'; |
||
189 | } |
||
190 | |||
191 | if ($value_chmod == 440) { |
||
192 | $chmod .= '<option value="440" selected>440</option>'; |
||
193 | } else { |
||
194 | $chmod .= '<option value="440">440</option>'; |
||
195 | } |
||
196 | |||
197 | if ($value_chmod == 400) { |
||
198 | $chmod .= '<option value="400" selected>400</option>'; |
||
199 | } else { |
||
200 | $chmod .= '<option value="400">400</option>'; |
||
201 | } |
||
202 | $chmod .= '</select>'; |
||
203 | |||
204 | return $chmod; |
||
205 | } |
||
206 |