Xoops\Core\Kernel\Model\Stats

Complexity

Total Complexity

19

Size/Duplication

Total Lines	89
Duplicated Lines	0 %

Test Coverage

Coverage

70.83%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
B	getCount()	0	41	11
B	getCounts()	0	29	8

<?php
/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
*/

namespace Xoops\Core\Kernel\Model;

use Xoops\Core\Kernel\CriteriaElement;
use Xoops\Core\Kernel\XoopsModelAbstract;
use Doctrine\DBAL\FetchMode;

/**
 * Object stats handler class.
 *
 * @category  Xoops\Core\Kernel\Model\Stats
 * @package   Xoops\Core\Kernel
 * @author    Taiwen Jiang <phppp@users.sourceforge.net>
 * @copyright 2000-2019 XOOPS Project (https://xoops.org)
 * @license   GNU GPL 2 or later (https://www.gnu.org/licenses/gpl-2.0.html)
 */
class Stats extends XoopsModelAbstract
{
    /**
     * count objects matching a condition
     *
     * @param CriteriaElement|null $criteria criteria to match
     *
     * @return int count of objects
     */
    public function getCount(CriteriaElement $criteria = null)
    {
        $qb = \Xoops::getInstance()->db()->createXoopsQueryBuilder();

        $groupBy = false;
        if (isset($criteria) && ($criteria instanceof CriteriaElement)) {
            $temp = $criteria->getGroupBy();
            if (!empty($temp)) {
                $qb->select($temp);
                $groupBy = true;
            }
        }
        if (!$groupBy) {
            $qb->select('COUNT(*)');
        } else {
            $qb->addSelect('COUNT(*)');
        }

        $qb->from($this->handler->table, null);
        if (isset($criteria) && ($criteria instanceof CriteriaElement)) {
            $qb = $criteria->renderQb($qb);
        }
        try {
            $result = $qb->execute();
            if (!$result) {
                return 0;
            }
        } catch (\Exception $e) {
            \Xoops::getInstance()->events()->triggerEvent('core.exception', $e);
            return 0;
        }

        if ($groupBy == false) {

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

            list ($count) = $result->fetch(FetchMode::NUMERIC);
            return $count;
        } else {
            $ret = array();
            while (list ($id, $count) = $result->fetch(FetchMode::NUMERIC)) {
                $ret[$id] = $count;
            }
            return $ret;

The expression return $ret returns the type array which is incompatible with the documented return type integer.

        }
    }

    /**
     * get counts matching a condition
     *
     * @param CriteriaElement|null $criteria criteria to match
     *
     * @return array of counts
     */
    public function getCounts(CriteriaElement $criteria = null)
    {
        $qb = \Xoops::getInstance()->db()->createXoopsQueryBuilder();

        $ret = array();
        $limit = null;

The assignment to $limit is dead and can be removed.

        $start = null;

The assignment to $start is dead and can be removed.

        $groupby_key = $this->handler->keyName;
        if (isset($criteria) && ($criteria instanceof CriteriaElement)) {
            if ($groupBy = $criteria->getGroupBy()) {
                $groupby_key = $groupBy;
            }
        }
        $qb->select($groupby_key)
            ->addSelect('COUNT(*)')
            ->from($this->handler->table, null)
            ->groupBy($groupby_key);

        if (isset($criteria) && ($criteria instanceof CriteriaElement)) {
            $qb = $criteria->renderQb($qb);
        }
        $result = $qb->execute();
        if (!$result) {
            return $ret;
        }
        while (list ($id, $count) = $result->fetch(FetchMode::NUMERIC)) {
            $ret[$id] = $count;
        }
        return $ret;
    }
}