XoopsCaptchaText - Code Metrics - Inspection of "Merge pull request #554 from geekwright/randbytes" - XOOPS/XoopsCore - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e0bf63...0051a3 )

by Michael

created 2017-07-24 17:39 UTC

XoopsCaptchaText A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	38
Duplicated Lines	7.89 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

94.12%

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	3
loc	38
ccs	16
cts	17
cp	0.9412
rs	10
wmc	4
lcom	1
cbo	1

2 Methods

Rating	Name	Duplication	Size	Complexity
A	loadText()	0	13	2
A	render()	3	11	2

How to fix Duplicated Code

<?php
/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
*/

/**
 * CAPTCHA for text mode
 *
 * PHP 5.3
 *
 * @category  Xoops\Class\Captcha\Captcha
 * @package   Captcha
 * @author    Taiwen Jiang <[email protected]>
 * @copyright 2013 XOOPS Project (http://xoops.org)
 * @license   GNU GPL 2 or later (http://www.gnu.org/licenses/gpl-2.0.html)
 * @version   $Id$
 * @link      http://xoops.org
 * @since     2.6.0
 */
class XoopsCaptchaText extends XoopsCaptchaMethod
{
    /**
     * XoopsCaptchaText::render()
     *
     * @return string
     */
    public function render()
    {
        $form = $this->loadText() . '&nbsp;&nbsp; <input type="text" name="' . $this->config['name']
			. '" id="' . $this->config['name'] . '" size="' . $this->config['num_chars']
			. '" maxlength="' . $this->config['num_chars'] . '" value="" />';
        $form .= '<br />' . XoopsLocale::INPUT_RESULT_FROM_EXPRESSION;
        if (!empty($this->config['maxattempts'])) {
            $form .= '<br />' . sprintf(XoopsLocale::F_MAXIMUM_ATTEMPTS, $this->config['maxattempts']);
        }
        return $form;
    }

    /**
     * XoopsCaptchaText::loadText()
     *
     * @return string
     */
    public function loadText()
    {
        $val_a = mt_rand(0, 9);
        $val_b = mt_rand(0, 9);
        if ($val_a > $val_b) {
            $expression = "{$val_a} - {$val_b} = ?";
            $this->code = $val_a - $val_b;
$answer = 42;

$correct = false;

$correct = (bool) $answer;
        } else {
            $expression = "{$val_a} + {$val_b} = ?";
            $this->code = $val_a + $val_b;
$answer = 42;

$correct = false;

$correct = (bool) $answer;
        }
        return '<span style="font-style: normal; font-weight: bold; font-size: 100%; font-color: #333; border: 1px solid #333; padding: 1px 5px;">' . $expression . '</span>';
    }
}


1			<?php
2			/*
3			You may not change or alter any portion of this comment or credits
4			of supporting developers from this source code or any supporting source code
5			which is considered copyrighted (c) material of the original comment or credit authors.
6
7			This program is distributed in the hope that it will be useful,
8			but WITHOUT ANY WARRANTY; without even the implied warranty of
9			MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
10			*/
11
12			/**
13			* CAPTCHA for text mode
14			*
15			* PHP 5.3
16			*
17			* @category Xoops\Class\Captcha\Captcha
18			* @package Captcha
19			* @author Taiwen Jiang <[email protected]>
20			* @copyright 2013 XOOPS Project (http://xoops.org)
21			* @license GNU GPL 2 or later (http://www.gnu.org/licenses/gpl-2.0.html)
22			* @version $Id$
23			* @link http://xoops.org
24			* @since 2.6.0
25			*/
26			class XoopsCaptchaText extends XoopsCaptchaMethod
27			{
28			/**
29			* XoopsCaptchaText::render()
30			*
31			* @return string
32			*/
33	1		public function render()
34			{
35	1		$form = $this->loadText() . '   <input type="text" name="' . $this->config['name']
36	1		. '" id="' . $this->config['name'] . '" size="' . $this->config['num_chars']
37	1		. '" maxlength="' . $this->config['num_chars'] . '" value="" />';
38	1		$form .= '<br />' . XoopsLocale::INPUT_RESULT_FROM_EXPRESSION;
39	1	View Code Duplication	if (!empty($this->config['maxattempts'])) {
40			$form .= '<br />' . sprintf(XoopsLocale::F_MAXIMUM_ATTEMPTS, $this->config['maxattempts']);
41			}
42	1		return $form;
43			}
44
45			/**
46			* XoopsCaptchaText::loadText()
47			*
48			* @return string
49			*/
50	2		public function loadText()
51			{
52	2		$val_a = mt_rand(0, 9);
53	2		$val_b = mt_rand(0, 9);
54	2		if ($val_a > $val_b) {
55	1		$expression = "{$val_a} - {$val_b} = ?";
56	1		$this->code = $val_a - $val_b;
			0 ignored issues – show Documentation Bug introduced 2015-12-12 03:50 UTC by Report Bug Copy Issue Report The property `$code` was declared of type `string`, but `$val_a - $val_b` is of type `integer`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
57			} else {
58	1		$expression = "{$val_a} + {$val_b} = ?";
59	1		$this->code = $val_a + $val_b;
			0 ignored issues – show Documentation Bug introduced 2015-12-12 03:50 UTC by Report Bug Copy Issue Report The property `$code` was declared of type `string`, but `$val_a + $val_b` is of type `integer`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
60			}
61	2		return '<span style="font-style: normal; font-weight: bold; font-size: 100%; font-color: #333; border: 1px solid #333; padding: 1px 5px;">' . $expression . '</span>';
62			}
63			}
64

XOOPS / XoopsCore

Push — master ( e0bf63...0051a3 )

XoopsCaptchaText A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

2 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like