Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like Logger often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Logger, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 45 | class Logger implements LoggerInterface |
||
| 46 | { |
||
| 47 | /** |
||
| 48 | * @var LoggerInterface[] chain of PSR-3 compatible loggers to call |
||
| 49 | */ |
||
| 50 | private $loggers = array(); |
||
| 51 | |||
| 52 | /** |
||
| 53 | * @var boolean do we have active loggers? |
||
| 54 | */ |
||
| 55 | private $logging_active = false; |
||
| 56 | |||
| 57 | /** |
||
| 58 | * @var boolean just to prevent fatal legacy errors. Does nothing. Stop it! |
||
| 59 | */ |
||
| 60 | //public $activated = false; |
||
| 61 | |||
| 62 | /** |
||
| 63 | * Get the Xoops\Core\Logger instance |
||
| 64 | * |
||
| 65 | * @return Logger object |
||
| 66 | */ |
||
| 67 | 18 | public static function getInstance() |
|
| 81 | |||
| 82 | /** |
||
| 83 | * Error handling callback. |
||
| 84 | * |
||
| 85 | * This will |
||
| 86 | * |
||
| 87 | * @param integer $errorNumber error number |
||
| 88 | * @param string $errorString error message |
||
| 89 | * @param string $errorFile file |
||
| 90 | * @param integer $errorLine line number |
||
| 91 | * |
||
| 92 | * @return void |
||
| 93 | */ |
||
| 94 | 55 | public function handleError($errorNumber, $errorString, $errorFile, $errorLine) |
|
| 165 | |||
| 166 | /** |
||
| 167 | * Exception handling callback. |
||
| 168 | * |
||
| 169 | * This will |
||
| 170 | * |
||
| 171 | * @param \Exception|\Throwable $e uncaught Exception or Error |
||
| 172 | * |
||
| 173 | * @return void |
||
| 174 | */ |
||
| 175 | public function handleException($e) |
||
| 180 | |||
| 181 | /** |
||
| 182 | * Announce fatal error, attempt to log |
||
| 183 | * |
||
| 184 | * @param string $msg error message to report |
||
| 185 | * |
||
| 186 | * @return void |
||
| 187 | */ |
||
| 188 | private function reportFatalError($msg) |
||
| 198 | |||
| 199 | /** |
||
| 200 | * clean a path to remove sensitive details |
||
| 201 | * |
||
| 202 | * @param string $message text to sanitize |
||
| 203 | * |
||
| 204 | * @return string sanitized message |
||
| 205 | */ |
||
| 206 | 21 | public function sanitizePath($message) |
|
| 229 | |||
| 230 | /** |
||
| 231 | * add a PSR-3 compatible logger to the chain |
||
| 232 | * |
||
| 233 | * @param object $logger a PSR-3 compatible logger object |
||
| 234 | * |
||
| 235 | * @return void |
||
| 236 | */ |
||
| 237 | 22 | public function addLogger($logger) |
|
| 244 | |||
| 245 | /** |
||
| 246 | * System is unusable. |
||
| 247 | * |
||
| 248 | * @param string $message message |
||
| 249 | * @param array $context array of context data for this log entry |
||
| 250 | * |
||
| 251 | * @return void |
||
| 252 | */ |
||
| 253 | 1 | public function emergency($message, array $context = array()) |
|
| 257 | |||
| 258 | /** |
||
| 259 | * Action must be taken immediately. |
||
| 260 | * |
||
| 261 | * Example: Entire website down, database unavailable, etc. This should |
||
| 262 | * trigger the SMS alerts and wake you up. |
||
| 263 | * |
||
| 264 | * @param string $message message |
||
| 265 | * @param array $context array of context data for this log entry |
||
| 266 | * |
||
| 267 | * @return void |
||
| 268 | */ |
||
| 269 | 1 | public function alert($message, array $context = array()) |
|
| 273 | |||
| 274 | /** |
||
| 275 | * Critical conditions. |
||
| 276 | * |
||
| 277 | * Example: Application component unavailable, unexpected exception. |
||
| 278 | * |
||
| 279 | * @param string $message message |
||
| 280 | * @param array $context array of context data for this log entry |
||
| 281 | * |
||
| 282 | * @return void |
||
| 283 | */ |
||
| 284 | 1 | public function critical($message, array $context = array()) |
|
| 288 | |||
| 289 | /** |
||
| 290 | * Runtime errors that do not require immediate action but should typically |
||
| 291 | * be logged and monitored. |
||
| 292 | * |
||
| 293 | * @param string $message message |
||
| 294 | * @param array $context array of context data for this log entry |
||
| 295 | * |
||
| 296 | * @return void |
||
| 297 | */ |
||
| 298 | 1 | public function error($message, array $context = array()) |
|
| 302 | |||
| 303 | /** |
||
| 304 | * Exceptional occurrences that are not errors. |
||
| 305 | * |
||
| 306 | * Example: Use of deprecated APIs, poor use of an API, undesirable things |
||
| 307 | * that are not necessarily wrong. |
||
| 308 | * |
||
| 309 | * @param string $message message |
||
| 310 | * @param array $context array of context data for this log entry |
||
| 311 | * |
||
| 312 | * @return void |
||
| 313 | */ |
||
| 314 | 1 | public function warning($message, array $context = array()) |
|
| 318 | |||
| 319 | /** |
||
| 320 | * Normal but significant events. |
||
| 321 | * |
||
| 322 | * @param string $message message |
||
| 323 | * @param array $context array of context data for this log entry |
||
| 324 | * |
||
| 325 | * @return void |
||
| 326 | */ |
||
| 327 | 1 | public function notice($message, array $context = array()) |
|
| 331 | |||
| 332 | /** |
||
| 333 | * Interesting events. |
||
| 334 | * |
||
| 335 | * Example: User logs in, SQL logs. |
||
| 336 | * |
||
| 337 | * @param string $message message |
||
| 338 | * @param array $context array of context data for this log entry |
||
| 339 | * |
||
| 340 | * @return void |
||
| 341 | */ |
||
| 342 | 1 | public function info($message, array $context = array()) |
|
| 346 | |||
| 347 | /** |
||
| 348 | * Detailed debug information. |
||
| 349 | * |
||
| 350 | * @param string $message message |
||
| 351 | * @param array $context array of context data for this log entry |
||
| 352 | * |
||
| 353 | * @return void |
||
| 354 | */ |
||
| 355 | 1 | public function debug($message, array $context = array()) |
|
| 359 | |||
| 360 | /** |
||
| 361 | * Logs with an arbitrary level. |
||
| 362 | * |
||
| 363 | * @param mixed $level PSR-3 LogLevel constant |
||
| 364 | * @param string $message message |
||
| 365 | * @param array $context array of context data for this log entry |
||
| 366 | * |
||
| 367 | * @return void |
||
| 368 | */ |
||
| 369 | 14 | public function log($level, $message, array $context = array()) |
|
| 383 | |||
| 384 | /** |
||
| 385 | * quiet - turn off output if output is rendered in XOOPS page output. |
||
| 386 | * This is intended to assist ajax code that may fail with any extra |
||
| 387 | * content the logger may introduce. |
||
| 388 | * |
||
| 389 | * It should have no effect on loggers using other methods, such a write |
||
| 390 | * to file. |
||
| 391 | * |
||
| 392 | * @return void |
||
| 393 | */ |
||
| 394 | 2 | public function quiet() |
|
| 408 | |||
| 409 | // Deprecated uses |
||
| 410 | |||
| 411 | /** |
||
| 412 | * Keep deprecated calls from failing |
||
| 413 | * |
||
| 414 | * @param string $var property |
||
| 415 | * @param string $val value |
||
| 416 | * |
||
| 417 | * @return void |
||
| 418 | * |
||
| 419 | * @deprecated |
||
| 420 | */ |
||
| 421 | 1 | public function __set($var, $val) |
|
| 430 | |||
| 431 | /** |
||
| 432 | * Keep deprecated calls from failing |
||
| 433 | * |
||
| 434 | * @param string $var property |
||
| 435 | * |
||
| 436 | * @return void |
||
| 437 | * |
||
| 438 | * @deprecated |
||
| 439 | */ |
||
| 440 | 1 | public function __get($var) |
|
| 444 | |||
| 445 | /** |
||
| 446 | * Keep deprecated calls from failing |
||
| 447 | * |
||
| 448 | * @param string $method method |
||
| 449 | * @param string $args arguments |
||
| 450 | * |
||
| 451 | * @return void |
||
| 452 | * |
||
| 453 | * @deprecated |
||
| 454 | */ |
||
| 455 | 1 | public function __call($method, $args) |
|
| 459 | |||
| 460 | /** |
||
| 461 | * issue a deprecated warning |
||
| 462 | * |
||
| 463 | * @return void |
||
| 464 | */ |
||
| 465 | 3 | private function deprecatedMessage() |
|
| 470 | } |
||
| 471 |
If you suppress an error, we recommend checking for the error condition explicitly: