UserconfigsPreload - Code Metrics - Inspection of "Fixes for some issues found after 462" - XOOPS/XoopsCore - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#464)

by Richard

created 2016-01-14 05:08 UTC

UserconfigsPreload A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	32
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	5

Metric	Value
wmc	3
lcom	0
cbo	5
dl	0
loc	32
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
A	eventCoreIncludeCommonClassmaps()	0	7	1
A	eventSystemModuleUninstall()	0	6	2

<?php
/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
*/

use Xoops\Core\PreloadItem;
use Xoops\Core\Kernel\Handlers\XoopsModule;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

/**
 * Userconfigs
 *
 * @package   UserConfigs
 * @author    trabis <[email protected]>
 * @copyright 2011-2013 XOOPS Project (http://xoops.org)
 * @license   GNU GPL 2 or later (http://www.gnu.org/licenses/gpl-2.0.html)
 * @link      http://xoops.org
 */
class UserconfigsPreload extends PreloadItem
{

    /**
     * add any module specific class map entries
     *
     * @param mixed $args not used
     *
     * @return void
     */
    public static function eventCoreIncludeCommonClassmaps($args)

    {
        $path = dirname(__DIR__);
        XoopsLoad::addMap(array(
            'userconfigs' => $path . '/class/helper.php',
        ));
    }

    /**
     * remove any userconfigs for module being uninstalled
     *
     * @param XoopsModule $module module object
     *
     * @return void
     */
    public static function eventSystemModuleUninstall(XoopsModule $module)
    {
        if ($plugin = \Xoops\Module\Plugin::getPlugin($module->getVar('dirname'), 'userconfigs')) {
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            Userconfigs::getInstance()->getHandlerConfig()->deleteConfigsByModule($module->getVar('mid'));
        }
    }
}


1			<?php
2			/*
3			You may not change or alter any portion of this comment or credits
4			of supporting developers from this source code or any supporting source code
5			which is considered copyrighted (c) material of the original comment or credit authors.
6
7			This program is distributed in the hope that it will be useful,
8			but WITHOUT ANY WARRANTY; without even the implied warranty of
9			MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
10			*/
11
12			use Xoops\Core\PreloadItem;
13			use Xoops\Core\Kernel\Handlers\XoopsModule;
			0 ignored issues – show Bug introduced 2016-01-14 05:18 UTC by Report Bug Copy Issue Report This use statement conflicts with another class in this namespace, `XoopsModule`. Let’s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let’s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
14
15			/**
16			* Userconfigs
17			*
18			* @package UserConfigs
19			* @author trabis <[email protected]>
20			* @copyright 2011-2013 XOOPS Project (http://xoops.org)
21			* @license GNU GPL 2 or later (http://www.gnu.org/licenses/gpl-2.0.html)
22			* @link http://xoops.org
23			*/
24			class UserconfigsPreload extends PreloadItem
25			{
26
27			/**
28			* add any module specific class map entries
29			*
30			* @param mixed $args not used
31			*
32			* @return void
33			*/
34			public static function eventCoreIncludeCommonClassmaps($args)
			0 ignored issues – show Unused Code introduced 2015-12-12 03:50 UTC by Report Bug Copy Issue Report The parameter `$args` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
35			{
36			$path = dirname(__DIR__);
37			XoopsLoad::addMap(array(
38			'userconfigs' => $path . '/class/helper.php',
39			));
40			}
41
42			/**
43			* remove any userconfigs for module being uninstalled
44			*
45			* @param XoopsModule $module module object
46			*
47			* @return void
48			*/
49			public static function eventSystemModuleUninstall(XoopsModule $module)
50			{
51			if ($plugin = \Xoops\Module\Plugin::getPlugin($module->getVar('dirname'), 'userconfigs')) {
			0 ignored issues – show Unused Code introduced 2015-12-12 03:50 UTC by Report Bug Copy Issue Report `$plugin` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
52			Userconfigs::getInstance()->getHandlerConfig()->deleteConfigsByModule($module->getVar('mid'));
53			}
54			}
55			}
56

XOOPS / XoopsCore

Pull Request — master (#464)

UserconfigsPreload A

Complexity

Size/Duplication

Coupling/Cohesion

2 Methods

Duplication Side-by-Side

Filter issues like