XOOPS /
XoopsCore
| Conditions | 1 |
| Paths | 1 |
| Total Lines | 20 |
| Code Lines | 12 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
| 1 | <?php |
||
| 22 | public function usermenu() |
||
| 23 | { |
||
| 24 | $helper = \Xoops::getModuleHelper(basename(dirname(dirname(__DIR__)))); |
||
| 25 | $helper->loadLanguage('modinfo'); |
||
| 26 | // View Account |
||
| 27 | $ret[] = [ |
||
|
|
|||
| 28 | 'name' => XoopsLocale::VIEW_ACCOUNT, |
||
| 29 | 'link' => $helper->url('userinfo.php?uid=' . $helper->xoops()->user->getVar('uid')), |
||
| 30 | 'icon' => 'glyphicon-user', |
||
| 31 | ]; |
||
| 32 | |||
| 33 | // Edit Account |
||
| 34 | $ret[] = [ |
||
| 35 | 'name' => _PROFILE_MI_EDITACCOUNT, |
||
| 36 | 'link' => $helper->url('edituser.php'), |
||
| 37 | 'icon' => 'glyphicon-pencil', |
||
| 38 | ]; |
||
| 39 | |||
| 40 | return $ret; |
||
| 41 | } |
||
| 42 | } |
||
| 43 |
Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code.
Let’s take a look at an example:
As you can see in this example, the array
$myArrayis initialized the first time when the foreach loop is entered. You can also see that the value of thebarkey is only written conditionally; thus, its value might result from a previous iteration.This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization $myArray = array() either outside or inside the foreach loop.