Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like Element often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Element, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
27 | abstract class Element extends Attributes |
||
28 | { |
||
29 | /** |
||
30 | * @var string[] list of attributes to NOT render |
||
31 | */ |
||
32 | protected $suppressList = ['caption', 'datalist', 'description', 'option']; |
||
33 | |||
34 | /** |
||
35 | * Javascript performing additional validation of this element data |
||
36 | * |
||
37 | * This property contains a list of Javascript snippets that will be sent to |
||
38 | * \Xoops\Form\Form::renderValidationJS(). |
||
39 | * NB: All elements are added to the output one after the other, so don't forget |
||
40 | * to add a ";" after each to ensure no Javascript syntax error is generated. |
||
41 | * |
||
42 | * @var array () |
||
43 | */ |
||
44 | public $customValidationCode = array(); |
||
45 | |||
46 | /** |
||
47 | * extra attributes to go in the tag |
||
48 | * |
||
49 | * @var array |
||
50 | */ |
||
51 | protected $extra = array(); |
||
52 | |||
53 | /** |
||
54 | * __construct |
||
55 | * |
||
56 | * @param array $attributes array of attribute name => value pairs |
||
57 | * Control attributes: |
||
58 | * ElementFactory::FORM_KEY optional form or tray to hold this element |
||
59 | */ |
||
60 | 9 | public function __construct($attributes = array()) |
|
68 | |||
69 | /** |
||
70 | * render - Generates output for the element. |
||
71 | * |
||
72 | * This method is abstract and must be overwritten by the child classes. |
||
73 | * |
||
74 | * @return string |
||
75 | */ |
||
76 | abstract public function render(); |
||
77 | |||
78 | /** |
||
79 | * render attributes as a string to include in HTML output |
||
80 | * |
||
81 | * @return string |
||
82 | */ |
||
83 | 7 | public function renderAttributeString() |
|
101 | |||
102 | /** |
||
103 | * getValue - Get an array of pre-selected values |
||
104 | * |
||
105 | * @param boolean $encode True to encode special characters |
||
106 | * |
||
107 | * @return mixed |
||
108 | */ |
||
109 | 8 | public function getValue($encode = false) |
|
121 | |||
122 | /** |
||
123 | * setValue - Set pre-selected values |
||
124 | * |
||
125 | * @param mixed $value value to assign to this element |
||
126 | * |
||
127 | * @return void |
||
128 | */ |
||
129 | 3 | public function setValue($value) |
|
133 | |||
134 | /** |
||
135 | * setName - set the "name" attribute for the element |
||
136 | * |
||
137 | * @param string $name "name" attribute for the element |
||
138 | * |
||
139 | * @return void |
||
140 | */ |
||
141 | 5 | public function setName($name) |
|
145 | |||
146 | /** |
||
147 | * getName - get the "name" attribute for the element |
||
148 | * |
||
149 | * @return string |
||
150 | */ |
||
151 | 5 | public function getName() |
|
155 | |||
156 | /** |
||
157 | * setAccessKey - set the access key attribute for the element |
||
158 | * |
||
159 | * @param string $key "accesskey" attribute for the element |
||
160 | * |
||
161 | * @return void |
||
162 | */ |
||
163 | 2 | public function setAccessKey($key) |
|
167 | |||
168 | /** |
||
169 | * getAccessKey - get the access key attribute for the element |
||
170 | * |
||
171 | * @return string "accesskey" attribute value |
||
172 | */ |
||
173 | 1 | public function getAccessKey() |
|
177 | |||
178 | /** |
||
179 | * getAccessString - If the access key is found in the specified string, underline it |
||
180 | * |
||
181 | * @param string $str string to add access key highlight to |
||
182 | * |
||
183 | * @return string Enhanced string with the 1st occurrence of "accesskey underlined |
||
184 | */ |
||
185 | 1 | public function getAccessString($str) |
|
196 | |||
197 | /** |
||
198 | * setClass - set the "class" attribute for the element |
||
199 | * |
||
200 | * @param string $class class attribute for the element |
||
201 | * |
||
202 | * @return void |
||
203 | */ |
||
204 | 3 | public function setClass($class) |
|
208 | |||
209 | /** |
||
210 | * getClass - get the "class" attribute for the element |
||
211 | * |
||
212 | * @return string "class" attribute value |
||
213 | */ |
||
214 | 1 | public function getClass() |
|
222 | |||
223 | /** |
||
224 | * setPattern - set the "pattern" attribute for the element |
||
225 | * |
||
226 | * @param string $pattern pattern attribute for the element |
||
227 | * @param string $patternDescription pattern description |
||
228 | * |
||
229 | * @return void |
||
230 | */ |
||
231 | 2 | public function setPattern($pattern, $patternDescription = '') |
|
236 | |||
237 | /** |
||
238 | * getPattern - get the "pattern" attribute for the element |
||
239 | * |
||
240 | * @return string "pattern" |
||
241 | */ |
||
242 | 1 | public function getPattern() |
|
246 | |||
247 | /** |
||
248 | * getPatternDescription - get the "pattern_description" |
||
249 | * |
||
250 | * @return string "pattern_description" |
||
251 | */ |
||
252 | 2 | public function getPatternDescription() |
|
256 | |||
257 | /** |
||
258 | * setDatalist - set the datalist attribute for the element |
||
259 | * |
||
260 | * @param string[]|string $datalist datalist attribute for the element |
||
261 | * |
||
262 | * @return void |
||
263 | */ |
||
264 | 3 | public function setDatalist($datalist) |
|
268 | |||
269 | /** |
||
270 | * renderDatalist - get the datalist attribute for the element |
||
271 | * |
||
272 | * @return string "datalist" attribute value |
||
273 | */ |
||
274 | 3 | public function renderDatalist() |
|
286 | |||
287 | /** |
||
288 | * isDatalist - is there a datalist for the element? |
||
289 | * |
||
290 | * @return boolean true if element has a non-empty datalist |
||
291 | */ |
||
292 | 4 | public function isDatalist() |
|
296 | |||
297 | /** |
||
298 | * setCaption - set the caption for the element |
||
299 | * |
||
300 | * @param string $caption caption for element |
||
301 | * |
||
302 | * @return void |
||
303 | */ |
||
304 | 4 | public function setCaption($caption) |
|
308 | |||
309 | /** |
||
310 | * getCaption - get the caption for the element |
||
311 | * |
||
312 | * @return string |
||
313 | */ |
||
314 | 3 | public function getCaption() |
|
319 | |||
320 | /** |
||
321 | * setTitle - set the title for the element |
||
322 | * |
||
323 | * @param string $title title for element |
||
324 | * |
||
325 | * @return void |
||
326 | */ |
||
327 | 2 | public function setTitle($title) |
|
331 | |||
332 | /** |
||
333 | * getTitle - get the title for the element |
||
334 | * |
||
335 | * @return string |
||
336 | */ |
||
337 | 6 | public function getTitle() |
|
352 | |||
353 | /** |
||
354 | * setDescription - set the element's description |
||
355 | * |
||
356 | * @param string $description description |
||
357 | * |
||
358 | * @return void |
||
359 | */ |
||
360 | 2 | public function setDescription($description) |
|
364 | |||
365 | /** |
||
366 | * getDescription - get the element's description |
||
367 | * |
||
368 | * @param boolean $encode True to encode special characters |
||
369 | * |
||
370 | * @return string |
||
371 | */ |
||
372 | 3 | public function getDescription($encode = false) |
|
377 | |||
378 | /** |
||
379 | * setHidden - flag the element as "hidden" |
||
380 | * |
||
381 | * @return void |
||
382 | */ |
||
383 | 5 | public function setHidden() |
|
387 | |||
388 | /** |
||
389 | * isHidden - is this a hidden element? |
||
390 | * |
||
391 | * @return boolean true if hidden |
||
392 | */ |
||
393 | 3 | public function isHidden() |
|
397 | |||
398 | /** |
||
399 | * setRequired - set entry required |
||
400 | * |
||
401 | * @param boolean $bool true to set required entry for this element |
||
402 | * |
||
403 | * @return void |
||
404 | */ |
||
405 | 3 | public function setRequired($bool = true) |
|
411 | |||
412 | /** |
||
413 | * isRequired - is entry required for this element? |
||
414 | * |
||
415 | * @return boolean true if entry is required |
||
416 | */ |
||
417 | 2 | public function isRequired() |
|
421 | |||
422 | /** |
||
423 | * setExtra - Add extra attributes to the element. |
||
424 | * |
||
425 | * This string will be inserted verbatim and unvalidated in the |
||
426 | * element's tag. Know what you are doing! |
||
427 | * |
||
428 | * @param string $extra extra raw text to insert into form |
||
429 | * @param boolean $replace If true, passed string will replace current |
||
430 | * content, otherwise it will be appended to it |
||
431 | * |
||
432 | * @return string[] New content of the extra string |
||
433 | * |
||
434 | * @deprecated please use attributes for event scripting |
||
435 | */ |
||
436 | public function setExtra($extra, $replace = false) |
||
437 | { |
||
438 | if ($replace) { |
||
439 | $this->extra = array(trim($extra)); |
||
440 | } else { |
||
441 | $this->extra[] = trim($extra); |
||
442 | } |
||
443 | return $this->extra; |
||
444 | } |
||
445 | |||
446 | /** |
||
447 | * getExtra - Get the extra attributes for the element |
||
448 | * |
||
449 | * @param boolean $encode True to encode special characters |
||
450 | * |
||
451 | * @return string |
||
452 | * |
||
453 | * @see setExtra() this is going to disappear |
||
454 | */ |
||
455 | 5 | public function getExtra($encode = false) |
|
466 | |||
467 | /** |
||
468 | * addCustomValidationCode - Add custom validation javascript |
||
469 | * |
||
470 | * This string will be inserted verbatim and unvalidated in the page. |
||
471 | * Know what you are doing! |
||
472 | * |
||
473 | * @param string $code javascript code to insert into form |
||
474 | * @param boolean $replace If true, passed string will replace current code, |
||
475 | * otherwise it will be appended to it |
||
476 | * |
||
477 | * @return void |
||
478 | */ |
||
479 | 1 | public function addCustomValidationCode($code, $replace = false) |
|
487 | |||
488 | /** |
||
489 | * renderValidationJS - Render custom javascript validation code |
||
490 | * |
||
491 | * @return string|false |
||
492 | */ |
||
493 | 2 | public function renderValidationJS() |
|
516 | |||
517 | /** |
||
518 | * Test if a class that starts with the pattern string is set |
||
519 | * |
||
520 | * @param string $pattern 'starts with' to match |
||
521 | * |
||
522 | * @return integer|false false if no match, or index of matching class |
||
523 | */ |
||
524 | 3 | public function hasClassLike($pattern) |
|
537 | |||
538 | /** |
||
539 | * themeDecorateElement - add theme decoration to element |
||
540 | * |
||
541 | * @return void |
||
542 | * |
||
543 | * @todo this should ask the theme |
||
544 | */ |
||
545 | 6 | public function themeDecorateElement() |
|
581 | |||
582 | /** |
||
583 | * Convenience method to assist with setting attributes when using BC Element syntax |
||
584 | * |
||
585 | * Set attribute $name to $value, replacing $value with $default if $value is empty, or if the |
||
586 | * value is not one of the values specified in the (optional) $enum array |
||
587 | * |
||
588 | * @param string $name attribute name |
||
589 | * @param mixed $value attribute value |
||
590 | * @param mixed $default default value |
||
591 | * @param array $enum optional list of valid values |
||
592 | * |
||
593 | * @return void |
||
594 | */ |
||
595 | 4 | public function setWithDefaults($name, $value, $default = null, $enum = null) |
|
604 | |||
605 | /** |
||
606 | * Convenience method to assist with setting attributes when using BC Element syntax |
||
607 | * |
||
608 | * Set attribute $name to $value, replacing $value with $default if $value is empty, or if the |
||
609 | * value is not one of the values specified in the (optional) $enum array |
||
610 | * |
||
611 | * @param string $name attribute name |
||
612 | * @param mixed $value attribute value |
||
613 | * |
||
614 | * @return void |
||
615 | */ |
||
616 | 3 | public function setIfNotEmpty($name, $value) |
|
623 | |||
624 | /** |
||
625 | * Convenience method to assist with setting attributes |
||
626 | * |
||
627 | * Set attribute $name to $value, replacing $value with $default if $value is empty, or if the |
||
628 | * value is not one of the values specified in the (optional) $enum array |
||
629 | * |
||
630 | * @param string $name attribute name |
||
631 | * @param mixed $value attribute value |
||
632 | * |
||
633 | * @return void |
||
634 | */ |
||
635 | 2 | public function setIfNotSet($name, $value) |
|
642 | } |
||
643 |