XOOPS / XoopsCore

htdocs/modules/banners/xoops_version.php

Spacing +1 added lines, -1 removed lines

@@ -44,7 +44,7 @@
 // paypal
 $modversion['paypal']                  = array();
 $modversion['paypal']['business']      = 'xoopsfoundation@gmail.com';
-$modversion['paypal']['item_name']     = 'Donation : ' . _MI_BANNERS_DESC;
+$modversion['paypal']['item_name']     = 'Donation : '._MI_BANNERS_DESC;
 $modversion['paypal']['amount']        = 0;
 $modversion['paypal']['currency_code'] = 'USD';
 

htdocs/modules/banners/preloads/preload.php

Spacing +2 added lines, -2 removed lines

@@ -34,13 +34,13 @@
     {
         $path = dirname(__DIR__);
         XoopsLoad::addMap(array(
-            'banners' => $path . '/class/helper.php',
+            'banners' => $path.'/class/helper.php',
         ));
     }
 
     public static function eventCoreBannerDisplay($args)
     {
-        require_once dirname(__DIR__) . '/class/bannerrender.php';
+        require_once dirname(__DIR__).'/class/bannerrender.php';
         $render = new BannerRender();
         $args[0] = $render->displayBanner();
     }

htdocs/modules/banners/include/install.php

Indentation +2 added lines, -2 removed lines

@@ -84,8 +84,8 @@
     $sql = "DELETE FROM " . $xoopsDB->prefix("config") . " WHERE `conf_name` = 'my_ip'";
     $xoopsDB->queryF($sql);
 */
-	$xoops_root_path = \XoopsBaseConfig::get('root-path');
-	$xoops_upload_url = \XoopsBaseConfig::get('uploads-url');
+    $xoops_root_path = \XoopsBaseConfig::get('root-path');
+    $xoops_upload_url = \XoopsBaseConfig::get('uploads-url');
 	
     // create folder "banners"
     $dir = $xoops_root_path . "/uploads/banners";

Spacing +11 added lines, -11 removed lines

@@ -32,7 +32,7 @@ 
     $xoops = Xoops::getInstance();
     //$xoops->db();
     //global $xoopsDB;
-    XoopsLoad::addMap(array('banners' => dirname(__DIR__) . '/class/helper.php'));
+    XoopsLoad::addMap(array('banners' => dirname(__DIR__).'/class/helper.php'));
     $helper = Banners::getInstance();
     // Get handler
     $banner_Handler = $helper->getHandlerBanner();
@@ -88,25 +88,25 @@ 
 	$xoops_upload_url = \XoopsBaseConfig::get('uploads-url');
 	
     // create folder "banners"
-    $dir = $xoops_root_path . "/uploads/banners";
+    $dir = $xoops_root_path."/uploads/banners";
     if (!is_dir($dir)) {
         mkdir($dir, 0777);
         chmod($dir, 0777);
     }
     //Copy index.html
-    $file = $xoops_root_path . "/uploads/banners/index.html";
+    $file = $xoops_root_path."/uploads/banners/index.html";
     if (!is_file($file)) {
-        copy($xoops_root_path . "/modules/banners/images/index.html", $file);
+        copy($xoops_root_path."/modules/banners/images/index.html", $file);
     }
     //Copy blank.gif
-    $file = $xoops_root_path . "/uploads/banners/blank.gif";
+    $file = $xoops_root_path."/uploads/banners/blank.gif";
     if (!is_file($file)) {
-        copy($xoops_root_path . "/uploads/blank.gif", $file);
+        copy($xoops_root_path."/uploads/blank.gif", $file);
     }
     //Copy .htaccess
-    $file = $xoops_root_path . "/uploads/banners/.htaccess";
+    $file = $xoops_root_path."/uploads/banners/.htaccess";
     if (!is_file($file)) {
-        copy($xoops_root_path . "/uploads/.htaccess", $file);
+        copy($xoops_root_path."/uploads/.htaccess", $file);
     }
 
 /* this should be in system upgrade, not module install
@@ -179,15 +179,15 @@ 
     );
     foreach ($banners as $k => $v) {
         //Copy banner
-        $file = $xoops_root_path . "/uploads/banners/" . $k;
-        $copy_file = $xoops_root_path . "/modules/banners/images/" . $k;
+        $file = $xoops_root_path."/uploads/banners/".$k;
+        $copy_file = $xoops_root_path."/modules/banners/images/".$k;
         if (!is_file($file) && is_file($copy_file)) {
             copy($copy_file, $file);
         }
         $obj = $banner_Handler->create();
         $obj->setVar("banner_cid", $newclient_id);
         $obj->setVar("banner_clickurl", $v);
-        $obj->setVar("banner_imageurl", $xoops_upload_url . '/banners/' . $k);
+        $obj->setVar("banner_imageurl", $xoops_upload_url.'/banners/'.$k);
         $obj->setVar("banner_datestart", time());
         $obj->setVar("banner_dateend", 0);
         $obj->setVar("banner_status", 1);

htdocs/modules/banners/language/english/blocks.php

Spacing +9 added lines, -9 removed lines

@@ -19,12 +19,12 @@
  * @author          Mage Grégory (AKA Mage)
  * @version         $Id$
  */
-define("_MB_BANNERS_DISP","Display");
-define("_MB_BANNERS","Banners");
-define("_MB_BANNERS_ALIGNEMENT","Alignement");
-define("_MB_BANNERS_ALIGNEMENT_H","horizontal");
-define("_MB_BANNERS_ALIGNEMENT_V","vertical");
-define("_MB_BANNERS_ALLCLIENTS","All clients");
-define("_MB_BANNERS_CLIENTSTODISPLAY","Select displayed clients");
-define("_MB_BANNERS_IDDISPLAY","Indicate the ID of the banner to be displayed");
-define("_MB_BANNERS_SEP","separated with ','.");
+define("_MB_BANNERS_DISP", "Display");
+define("_MB_BANNERS", "Banners");
+define("_MB_BANNERS_ALIGNEMENT", "Alignement");
+define("_MB_BANNERS_ALIGNEMENT_H", "horizontal");
+define("_MB_BANNERS_ALIGNEMENT_V", "vertical");
+define("_MB_BANNERS_ALLCLIENTS", "All clients");
+define("_MB_BANNERS_CLIENTSTODISPLAY", "Select displayed clients");
+define("_MB_BANNERS_IDDISPLAY", "Indicate the ID of the banner to be displayed");
+define("_MB_BANNERS_SEP", "separated with ','.");

htdocs/modules/banners/language/english/main.php

Spacing +1 added lines, -1 removed lines

@@ -23,7 +23,7 @@
 //define("_MD_BANNERS_INDEX_CLIENTNAME", "Displaying active banners for client: %s");
 define("_MD_BANNERS_INDEX_DBERROR", "Database was not updated due to some error!");
 define("_MD_BANNERS_INDEX_EMAIL", "Send E-mail stats");
-define("_MD_BANNERS_INDEX_NO_ID","No valid ID detected");
+define("_MD_BANNERS_INDEX_NO_ID", "No valid ID detected");
 define("_MD_BANNERS_INDEX_NO_REFERER", "No referer detected");
 define("_MD_BANNERS_INDEX_ID", "ID");
 define("_MD_BANNERS_INDEX_MAIL_MESSAGE", "Available Banner Statistics for the selected Banner at %s :\n\n\n

htdocs/modules/banners/language/english/admin.php

Spacing +45 added lines, -45 removed lines

@@ -20,64 +20,64 @@
  * @version         $Id$
  */
 //generic
-define("_AM_BANNERS_ACTION","Action");
-define("_AM_BANNERS_VIEW","View");
-define("_AM_BANNERS_DELETE","Delete");
-define("_AM_BANNERS_EDIT","Edit");
-define("_AM_BANNERS_DBUPDATED","Database updated successfully!");
+define("_AM_BANNERS_ACTION", "Action");
+define("_AM_BANNERS_VIEW", "View");
+define("_AM_BANNERS_DELETE", "Delete");
+define("_AM_BANNERS_EDIT", "Edit");
+define("_AM_BANNERS_DBUPDATED", "Database updated successfully!");
 
 //index.php
-define("_AM_BANNERS_INDEX_NBTOTAL","There are %s banners in our database");
-define("_AM_BANNERS_INDEX_NBCLIENT","There are %s client in our database");
-define("_AM_BANNERS_INDEX_NBFINISH","There are %s banners finished");
+define("_AM_BANNERS_INDEX_NBTOTAL", "There are %s banners in our database");
+define("_AM_BANNERS_INDEX_NBCLIENT", "There are %s client in our database");
+define("_AM_BANNERS_INDEX_NBFINISH", "There are %s banners finished");
 
 //clients.php
-define("_AM_BANNERS_CLIENTS_ACTIVEBANNERS","Active Banners");
-define("_AM_BANNERS_CLIENTS_ADD","Add a new client");
-define("_AM_BANNERS_CLIENTS_EDIT","Edit client");
-define("_AM_BANNERS_CLIENTS_EXTRAINFO","Extra Info");
-define("_AM_BANNERS_CLIENTS_LIST","List of clients");
-define("_AM_BANNERS_CLIENTS_MAIL","Client email");
-define("_AM_BANNERS_CLIENTS_NAME","Client name");
-define("_AM_BANNERS_CLIENTS_SUREDEL","Are you sure to delete this client '<strong>%s</strong>' and ALL its banners?");
-define("_AM_BANNERS_CLIENTS_UNAME","User name");
-define("_AM_BANNERS_CLIENTS_UNAME_NO","Do not use a member");
-define("_AM_BANNERS_CLIENTS_UNAME_YES","Use a member");
+define("_AM_BANNERS_CLIENTS_ACTIVEBANNERS", "Active Banners");
+define("_AM_BANNERS_CLIENTS_ADD", "Add a new client");
+define("_AM_BANNERS_CLIENTS_EDIT", "Edit client");
+define("_AM_BANNERS_CLIENTS_EXTRAINFO", "Extra Info");
+define("_AM_BANNERS_CLIENTS_LIST", "List of clients");
+define("_AM_BANNERS_CLIENTS_MAIL", "Client email");
+define("_AM_BANNERS_CLIENTS_NAME", "Client name");
+define("_AM_BANNERS_CLIENTS_SUREDEL", "Are you sure to delete this client '<strong>%s</strong>' and ALL its banners?");
+define("_AM_BANNERS_CLIENTS_UNAME", "User name");
+define("_AM_BANNERS_CLIENTS_UNAME_NO", "Do not use a member");
+define("_AM_BANNERS_CLIENTS_UNAME_YES", "Use a member");
 
 //banners.php
-define("_AM_BANNERS_BANNERS_ADD","Add a new banner");
-define("_AM_BANNERS_BANNERS_CLICKS","Clicks");
-define("_AM_BANNERS_BANNERS_CLICKURL","Click URL");
-define("_AM_BANNERS_BANNERS_CODEHTML","Code HTML");
-define("_AM_BANNERS_BANNERS_CURRENT","Current active banners");
-define("_AM_BANNERS_BANNERS_EDIT","Edit banner");
-define("_AM_BANNERS_BANNERS_ENDDATE","Date ended");
-define("_AM_BANNERS_BANNERS_FINISH","Finished banners");
-define("_AM_BANNERS_BANNERS_IMAGE","Image");
-define("_AM_BANNERS_BANNERS_IMAGE_PATH","Files exist in: %s");
-define("_AM_BANNERS_BANNERS_IMGURL","Image URL:");
-define("_AM_BANNERS_BANNERS_IMPRESIONLEFT","Impressions left");
-define("_AM_BANNERS_BANNERS_IMPRESSIONS","Impressions");
-define("_AM_BANNERS_BANNERS_IMPRESSIONSP","Impressions purchased");
-define("_AM_BANNERS_BANNERS_IMPRESSIONSP_PATTERN","You must enter an integer");
-define("_AM_BANNERS_BANNERS_LIST","List of banners");
-define("_AM_BANNERS_BANNERS_NCLICKS","% Clicks");
-define("_AM_BANNERS_BANNERS_RELOAD","Reload banner");
-define("_AM_BANNERS_BANNERS_STARTDATE","Date started");
-define("_AM_BANNERS_BANNERS_SUREDEL","Are you sure to delete this Banner?");
-define("_AM_BANNERS_BANNERS_UNLIMIT","Unlimited");
-define("_AM_BANNERS_BANNERS_UPLOADS","Upload");
-define("_AM_BANNERS_BANNERS_USEHTML","Use HTML?");
+define("_AM_BANNERS_BANNERS_ADD", "Add a new banner");
+define("_AM_BANNERS_BANNERS_CLICKS", "Clicks");
+define("_AM_BANNERS_BANNERS_CLICKURL", "Click URL");
+define("_AM_BANNERS_BANNERS_CODEHTML", "Code HTML");
+define("_AM_BANNERS_BANNERS_CURRENT", "Current active banners");
+define("_AM_BANNERS_BANNERS_EDIT", "Edit banner");
+define("_AM_BANNERS_BANNERS_ENDDATE", "Date ended");
+define("_AM_BANNERS_BANNERS_FINISH", "Finished banners");
+define("_AM_BANNERS_BANNERS_IMAGE", "Image");
+define("_AM_BANNERS_BANNERS_IMAGE_PATH", "Files exist in: %s");
+define("_AM_BANNERS_BANNERS_IMGURL", "Image URL:");
+define("_AM_BANNERS_BANNERS_IMPRESIONLEFT", "Impressions left");
+define("_AM_BANNERS_BANNERS_IMPRESSIONS", "Impressions");
+define("_AM_BANNERS_BANNERS_IMPRESSIONSP", "Impressions purchased");
+define("_AM_BANNERS_BANNERS_IMPRESSIONSP_PATTERN", "You must enter an integer");
+define("_AM_BANNERS_BANNERS_LIST", "List of banners");
+define("_AM_BANNERS_BANNERS_NCLICKS", "% Clicks");
+define("_AM_BANNERS_BANNERS_RELOAD", "Reload banner");
+define("_AM_BANNERS_BANNERS_STARTDATE", "Date started");
+define("_AM_BANNERS_BANNERS_SUREDEL", "Are you sure to delete this Banner?");
+define("_AM_BANNERS_BANNERS_UNLIMIT", "Unlimited");
+define("_AM_BANNERS_BANNERS_UPLOADS", "Upload");
+define("_AM_BANNERS_BANNERS_USEHTML", "Use HTML?");
 
-define("_AM_BANNERS_BANNERS_ERROR_NOCLIENT","Please create first a client");
+define("_AM_BANNERS_BANNERS_ERROR_NOCLIENT", "Please create first a client");
 
 
 // Tips
 define("_AM_BANNERS_TIPS_CLIENTS", "<ul><li>Add, modify and update clients.</li></ul>");
 define("_AM_BANNERS_TIPS_BANNERS", "<ul><li>Add, modify and update banners.</li></ul>");
 // Alert
-define("_AM_BANNERS_ALERT_INFO_TITLE_UPLOADS","Information for uploads");
-define("_AM_BANNERS_ALERT_INFO_TITLE","Information");
+define("_AM_BANNERS_ALERT_INFO_TITLE_UPLOADS", "Information for uploads");
+define("_AM_BANNERS_ALERT_INFO_TITLE", "Information");
 define("_AM_BANNERS_ALERT_INFO_CLIENT_ADDEDIT", "If you do not put a user of the site, the customer will not have access to these banners.");
 define("_AM_BANNERS_ALERT_INFO_MIMETYPES", "Authorized mime types: %s");
 define("_AM_BANNERS_ALERT_INFO_MAXFILE", "Max uploaded files size: %s [KB]");

htdocs/modules/banners/blocks/banners_blocks.php

Spacing +17 added lines, -17 removed lines

@@ -22,7 +22,7 @@ 
 function banners_blocks_show($options) {
     $block = array();
     $xoops = Xoops::getInstance();
-    require_once dirname(__DIR__) . '/class/bannerrender.php';
+    require_once dirname(__DIR__).'/class/bannerrender.php';
     $render = new BannerRender();
     switch ($options[0]) {
         case 'random':
@@ -49,10 +49,10 @@ 
     switch ($options[0]) {
 
         case 'random':
-            $form .= _MB_BANNERS_DISP . " \n";
-            $form .= "<input type=\"hidden\" name=\"options[0]\" value=\"" . $options[0] . "\" />\n";
-            $form .= "<input name=\"options[1]\" size=\"5\" maxlength=\"255\" value=\"" . $options[1] . "\" type=\"text\" />&nbsp;" . _MB_BANNERS . "<br />\n";
-            switch ($options[2]){
+            $form .= _MB_BANNERS_DISP."&nbsp;\n";
+            $form .= "<input type=\"hidden\" name=\"options[0]\" value=\"".$options[0]."\" />\n";
+            $form .= "<input name=\"options[1]\" size=\"5\" maxlength=\"255\" value=\"".$options[1]."\" type=\"text\" />&nbsp;"._MB_BANNERS."<br />\n";
+            switch ($options[2]) {
                 case 'H':
                     $checked_H = 'checked="checked"';
                     $checked_V = '';
@@ -63,30 +63,30 @@ 
                     $checked_V = 'checked="checked"';
                     break;
             }
-            $form .= _MB_BANNERS_ALIGNEMENT . " : <input name=\"options[2]\" value=\"H\" type=\"radio\" " . $checked_H . "/>" . _MB_BANNERS_ALIGNEMENT_H . "&nbsp;\n";
-            $form .= "<input name=\"options[2]\" value=\"V\" type=\"radio\" " . $checked_V . "/>" . _MB_BANNERS_ALIGNEMENT_V . "<br />\n";
+            $form .= _MB_BANNERS_ALIGNEMENT." : <input name=\"options[2]\" value=\"H\" type=\"radio\" ".$checked_H."/>"._MB_BANNERS_ALIGNEMENT_H."&nbsp;\n";
+            $form .= "<input name=\"options[2]\" value=\"V\" type=\"radio\" ".$checked_V."/>"._MB_BANNERS_ALIGNEMENT_V."<br />\n";
             array_shift($options);
             array_shift($options);
             array_shift($options);
-            $form .= _MB_BANNERS_CLIENTSTODISPLAY . "<br /><select name=\"options[]\" multiple=\"multiple\" size=\"5\">\n";
+            $form .= _MB_BANNERS_CLIENTSTODISPLAY."<br /><select name=\"options[]\" multiple=\"multiple\" size=\"5\">\n";
             $xoops = Xoops::getInstance();
-            $client_Handler = $xoops->getModuleHandler('bannerclient','banners');
+            $client_Handler = $xoops->getModuleHandler('bannerclient', 'banners');
             $criteria = new CriteriaCompo();
             $criteria->setSort('bannerclient_name');
             $criteria->setOrder('ASC');
             $client_arr = $client_Handler->getAll($criteria);
-            $form .= "<option value=\"0\" " . (array_search(0, $options) === false ? '' : 'selected="selected"') . ">" . _MB_BANNERS_ALLCLIENTS . "</option>\n";
+            $form .= "<option value=\"0\" ".(array_search(0, $options) === false ? '' : 'selected="selected"').">"._MB_BANNERS_ALLCLIENTS."</option>\n";
             foreach (array_keys($client_arr) as $i) {
-                $form .= "<option value=\"" . $client_arr[$i]->getVar('cid') . "\" " . (array_search($client_arr[$i]->getVar('cid'), $options) === false ? '' : 'selected="selected"') . ">" . $client_arr[$i]->getVar('name')."</option>\n";
+                $form .= "<option value=\"".$client_arr[$i]->getVar('cid')."\" ".(array_search($client_arr[$i]->getVar('cid'), $options) === false ? '' : 'selected="selected"').">".$client_arr[$i]->getVar('name')."</option>\n";
             }
             $form .= "</select>\n";
             break;
 
         case 'id':
-            $form .= _MB_BANNERS_IDDISPLAY . "&nbsp;\n";
-            $form .= "<input type=\"hidden\" name=\"options[0]\" value=\"" . $options[0] . "\" />\n";
-            $form .= "<input name=\"options[1]\" size=\"20\" maxlength=\"255\" value=\"" . $options[1] . "\" type=\"text\" />&nbsp;" . _MB_BANNERS_SEP . "<br />\n";
-            switch ($options[2]){
+            $form .= _MB_BANNERS_IDDISPLAY."&nbsp;\n";
+            $form .= "<input type=\"hidden\" name=\"options[0]\" value=\"".$options[0]."\" />\n";
+            $form .= "<input name=\"options[1]\" size=\"20\" maxlength=\"255\" value=\"".$options[1]."\" type=\"text\" />&nbsp;"._MB_BANNERS_SEP."<br />\n";
+            switch ($options[2]) {
                 case 'H':
                     $checked_H = 'checked="checked"';
                     $checked_V = '';
@@ -97,8 +97,8 @@ 
                     $checked_V = 'checked="checked"';
                     break;
             }
-            $form .= _MB_BANNERS_ALIGNEMENT . " : <input name=\"options[2]\" value=\"H\" type=\"radio\" " . $checked_H . "/>" . _MB_BANNERS_ALIGNEMENT_H . "&nbsp;\n";
-            $form .= "<input name=\"options[2]\" value=\"V\" type=\"radio\" " . $checked_V . "/>" . _MB_BANNERS_ALIGNEMENT_V . "<br />\n";
+            $form .= _MB_BANNERS_ALIGNEMENT." : <input name=\"options[2]\" value=\"H\" type=\"radio\" ".$checked_H."/>"._MB_BANNERS_ALIGNEMENT_H."&nbsp;\n";
+            $form .= "<input name=\"options[2]\" value=\"V\" type=\"radio\" ".$checked_V."/>"._MB_BANNERS_ALIGNEMENT_V."<br />\n";
             break;
     }
     return $form;

htdocs/modules/banners/class/bannerrender.php

Spacing +5 added lines, -5 removed lines

@@ -41,7 +41,7 @@ 
     public function displayBanner($nb_banner = 1, $align = 'H', $client = array(), $ids = '')
     {
         $xoops = Xoops::getInstance();
-        XoopsLoad::addMap(array('banners' => __DIR__ . '/helper.php'));
+        XoopsLoad::addMap(array('banners' => __DIR__.'/helper.php'));
         $helper = Banners::getInstance();
         if ($xoops->isActiveModule('banners')) {
             // Get banners handler
@@ -53,14 +53,14 @@ 
             $criteria->setSort($sort);
             if (!empty($client)) {
                 if (!in_array(0, $client)) {
-                    $criteria->add(new Criteria('banner_cid', '(' . implode(',', $client) . ')', 'IN'));
+                    $criteria->add(new Criteria('banner_cid', '('.implode(',', $client).')', 'IN'));
                 }
             }
             if ($ids == '') {
                 $criteria->setLimit($nb_banner);
                 $criteria->setStart(0);
             } else {
-                $criteria->add(new Criteria('banner_bid', '(' . $ids . ')', 'IN'));
+                $criteria->add(new Criteria('banner_bid', '('.$ids.')', 'IN'));
             }
             $banner_arr = $banner_Handler->getAll($criteria);
             $numrows = count($banner_arr);
@@ -81,9 +81,9 @@ 
                         $bannerobject .= $htmlcode;
                     } else {
                         if (stristr($imageurl, '.swf')) {
-                            $bannerobject .= '<a href="' . \XoopsBaseConfig::get('url') . '/modules/banners/index.php?op=click&amp;bid=' . $bid . '" rel="external" title="' . $clickurl . '"></a>' . '<object type="application/x-shockwave-flash" width="468" height="60" data="' . $imageurl . '" style="z-index:100;">' . '<param name="movie" value="' . $imageurl . '" />' . '<param name="wmode" value="opaque" />' . '</object>';
+                            $bannerobject .= '<a href="'.\XoopsBaseConfig::get('url').'/modules/banners/index.php?op=click&amp;bid='.$bid.'" rel="external" title="'.$clickurl.'"></a>'.'<object type="application/x-shockwave-flash" width="468" height="60" data="'.$imageurl.'" style="z-index:100;">'.'<param name="movie" value="'.$imageurl.'" />'.'<param name="wmode" value="opaque" />'.'</object>';
                         } else {
-                            $bannerobject .= '<a href="' . \XoopsBaseConfig::get('url') . '/modules/banners/index.php?op=click&amp;bid=' . $bid . '" rel="external" title="' . $clickurl . '"><img src="' . $imageurl . '" alt="' . $clickurl . '" /></a>';
+                            $bannerobject .= '<a href="'.\XoopsBaseConfig::get('url').'/modules/banners/index.php?op=click&amp;bid='.$bid.'" rel="external" title="'.$clickurl.'"><img src="'.$imageurl.'" alt="'.$clickurl.'" /></a>';
                         }
                     }
                     if ($align === 'V') {

htdocs/modules/banners/class/form/banner.php

Spacing +6 added lines, -6 removed lines

@@ -34,14 +34,14 @@ 
             $blank_img = 'blank.gif';
             $html_banner = 0;
         } else {
-            if (substr_count($obj->getVar('banner_imageurl'), $xoops_upload_url . '/banners/') == 0) {
+            if (substr_count($obj->getVar('banner_imageurl'), $xoops_upload_url.'/banners/') == 0) {
                 $blank_img = 'blank.gif';
             } else {
                 $namefile =
-                    substr_replace($obj->getVar('banner_imageurl'), '', 0, strlen($xoops_upload_url . '/banners/'));
-                $pathfile =  $xoops->path('uploads/banners/') . $namefile;
+                    substr_replace($obj->getVar('banner_imageurl'), '', 0, strlen($xoops_upload_url.'/banners/'));
+                $pathfile = $xoops->path('uploads/banners/').$namefile;
                 if (is_file($pathfile)) {
-                    $blank_img = str_replace($xoops_upload_url . '/banners/', '', $obj->getVar('banner_imageurl', 'e'));
+                    $blank_img = str_replace($xoops_upload_url.'/banners/', '', $obj->getVar('banner_imageurl', 'e'));
                 } else {
                     $blank_img = 'blank.gif';
                 }
@@ -73,13 +73,13 @@ 
         \Xoops\Core\Lists\ImageFile::setOptionsArray($imageselect_img, $xoops->path('uploads/banners'));
         $imageselect_img->setExtra(
             'onchange="showImgSelected(\'xo-banners-img\', \'banners_imageurl\', \'banners\', \'\', \''
-            . $xoops_upload_url . '\' )"'
+            . $xoops_upload_url.'\' )"'
         );
         $imgtray_img->addElement($imageselect_img, false);
         $imgtray_img->addElement(
             new Xoops\Form\Label(
                 '',
-                "<br /><img src='" . $xoops_upload_url . "/banners/" . $blank_img
+                "<br /><img src='".$xoops_upload_url."/banners/".$blank_img
                 . "' name='image_img' id='xo-banners-img' alt='' />"
             )
         );