XoopsUserUtility::validate()

Complexity

Conditions	42
Paths	> 20000

Size

Total Lines	127
Code Lines	83

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public static function validate()
    {
        $xoops = Xoops::getInstance();
        $args = func_get_args();
        $args_num = func_num_args();

        /* @var $user XoopsUser|null */
        $user = null;
        $uname = null;
        $email = null;
        $pass = null;
        $vpass = null;

        switch ($args_num) {
            case 1:
                $user = $args[0];
                break;
            case 2:
                list ($uname, $email) = $args;
                break;
            case 3:
                list ($user, $pass, $vpass) = $args;
                break;
            case 4:
                list ($uname, $email, $pass, $vpass) = $args;
                break;
            default:
                return false;
        }
        if (is_object($user)) {
            $uname = $user->getVar('uname', 'n');
            $email = $user->getVar('email', 'n');
        }

        //$user = empty($user) ? null : trim($user);
        $uname = empty($uname) ? null : trim($uname);
        $email = empty($email) ? null : trim($email);
        $pass = empty($pass) ? null : trim($pass);
        $vpass = empty($vpass) ? null : trim($vpass);

        $xoops->getConfigs();

        $stop = '';
        // Invalid email address
        if (!$xoops->checkEmail($email)) {
            $stop .= XoopsLocale::E_INVALID_EMAIL . '<br />';
        }
        if (strrpos($email, ' ') > 0) {

It seems like $email can also be of type null; however, parameter $haystack of strrpos() does only seem to accept string, maybe add an additional type check?

            $stop .= XoopsLocale::E_EMAIL_SHOULD_NOT_CONTAIN_SPACES . '<br />';
        }
        // Check forbidden email address if current operator is not an administrator
        if (!$xoops->userIsAdmin) {
            $bad_emails = $xoops->getConfig('bad_emails');
            if (!empty($bad_emails)) {
                foreach ($bad_emails as $be) {
                    if (!empty($be) && preg_match('/' . $be . '/i', $email)) {

It seems like $email can also be of type null; however, parameter $subject of preg_match() does only seem to accept string, maybe add an additional type check?

                        $stop .= XoopsLocale::E_INVALID_EMAIL . '<br />';
                        break;
                    }
                }
            }
        }
        // $uname = XoopsLocale::trim($uname);
        // no controls, puctuation, symbols, spaces or invisible separators
        if (!preg_match('/^[^\p{C}\p{P}\p{S}\p{Z}]+$/u', $uname)) {
            $stop .= XoopsLocale::E_INVALID_USERNAME . '<br />';
        }
        // Check uname settings if current operator is not an administrator
        if (!$xoops->userIsAdmin) {
            $maxuname = $xoops->getConfig('maxuname');
            if (!empty($maxuname) && mb_strlen($uname) > $maxuname) {

It seems like $uname can also be of type null; however, parameter $string of mb_strlen() does only seem to accept string, maybe add an additional type check?

                $stop .= sprintf(XoopsLocale::EF_USERNAME_MUST_BE_LESS_THAN, $maxuname) . '<br />';
            }
            $minuname = $xoops->getConfig('minuname');
            if (!empty($minuname) && mb_strlen($uname) < $minuname) {
                $stop .= sprintf(XoopsLocale::EF_USERNAME_MUST_BE_MORE_THAN, $minuname) . '<br />';
            }
            $bad_unames = $xoops->getConfig('bad_unames');
            if (!empty($bad_unames)) {
                foreach ($bad_unames as $bu) {
                    if (!empty($bu) && preg_match('/' . $bu . '/i', $uname)) {
                        $stop .= XoopsLocale::E_NAME_IS_RESERVED . '<br />';
                        break;
                    }
                }
            }
        }
        // Check if uname/email already exists if the user is a new one
        $uid = is_object($user) ? $user->getVar('uid') : 0;

        $user_handler = $xoops->getHandlerUser();

        $criteria = new CriteriaCompo(new Criteria('uname', $uname));
        if ($uid > 0) {
            $criteria->add(new Criteria('uid', $uid, '<>'));
        }
        $count = $user_handler->getCount($criteria);
        if ($count > 0) {
            $stop .= XoopsLocale::E_USERNAME_TAKEN . '<br />';
        }

        $criteria = new CriteriaCompo(new Criteria('email', $email));
        if ($uid > 0) {
            $criteria->add(new Criteria('uid', $uid, '<>'));
        }
        $count = $user_handler->getCount($criteria);
        if ($count > 0) {
            $stop .= XoopsLocale::E_EMAIL_TAKEN . '<br />';
        }

        // If password is not set, skip password validation
        if ($pass === null && $vpass === null) {
            return $stop;
        }

        if (empty($pass) || empty($vpass)) {
            $stop .= XoopsLocale::E_MUST_PROVIDE_PASSWORD . '<br />';
        }
        if (isset($pass) && isset($vpass) && ($pass != $vpass)) {
            $stop .= XoopsLocale::E_PASSWORDS_MUST_MATCH . '<br />';
        } else {
            $minpass = $xoops->getConfig('minpass');
            if (($pass != '') && (!empty($minpass)) && (mb_strlen($pass) < $minpass)) {
                $stop .= sprintf(XoopsLocale::EF_PASSWORD_MUST_BE_GREATER_THAN, $minpass) . '<br />';
            }
        }
        return $stop;
    }