Xoops\Module\Admin::renderIndex()

Complexity

Conditions	16
Paths	296

Size

Total Lines	130
Code Lines	79

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	272

Importance

Changes

0

<?php
    public function renderIndex()
    {
        $xoops = \Xoops::getInstance();
        $this->module->loadAdminMenu();
        foreach (array_keys($this->module->adminmenu) as $i) {
            if (\XoopsLoad::fileExists($xoops->path("media/xoops/images/icons/32/" . $this->module->adminmenu[$i]['icon']))) {
                $this->module->adminmenu[$i]['icon'] = $xoops->url("media/xoops/images/icons/32/" . $this->module->adminmenu[$i]['icon']);
            } elseif (\XoopsLoad::fileExists($xoops->path("modules/" . $xoops->module->dirname() . "/assets/icons/32/" . $this->module->adminmenu[$i]['icon']))) {

The method dirname() does not exist on null.

                $this->module->adminmenu[$i]['icon'] = $xoops->url("modules/" . $xoops->module->dirname() . "/assets/icons/32/" . $this->module->adminmenu[$i]['icon']);
            } else {
                $this->module->adminmenu[$i]['icon'] = $xoops->url("modules/" . $xoops->module->dirname() . "/icons/32/" . $this->module->adminmenu[$i]['icon']);
            }
            $xoops->tpl()->append('xo_admin_index_menu', $this->module->adminmenu[$i]);
        }
        if ($this->module->getInfo('help')) {
            $help = array();
            $help['link'] = '../system/help.php?mid=' . $this->module->getVar('mid', 's')
                . "&" . $this->module->getInfo('help');

Are you sure $this->module->getInfo('help') of type string|string[] can be used in concatenation?

            $help['icon'] = $xoops->url("/media/xoops/images/icons/32/help.png");
            $help['title'] = \XoopsLocale::HELP;
            $xoops->tpl()->append('xo_admin_index_menu', $help);
        }
        $xoops->tpl()->assign('xo_admin_box', $this->itemInfoBox);

        // If you use a config label
        if ($this->module->getInfo('min_php') || $this->module->getInfo('min_xoops')
            || $this->module->getInfo('min_db') || !empty($this->itemConfigBoxLine)
        ) {
            // PHP version
            if ($this->module->getInfo('min_php')) {
                if (0 >= version_compare(phpversion(), $this->module->getInfo('min_php'))) {

It seems like $this->module->getInfo('min_php') can also be of type string[]; however, parameter $version2 of version_compare() does only seem to accept string, maybe add an additional type check?

                    $this->addConfigBoxLine(
                        sprintf(
                            \XoopsLocale::F_MINIMUM_PHP_VERSION_REQUIRED,
                            $this->module->getInfo('min_php'),

It seems like $this->module->getInfo('min_php') can also be of type string[]; however, parameter $values of sprintf() does only seem to accept double|integer|string, maybe add an additional type check?

                            phpversion()
                        ),
                        'error'
                    );
                } else {
                    $this->addConfigBoxLine(
                        sprintf(
                            \XoopsLocale::F_MINIMUM_PHP_VERSION_REQUIRED,
                            $this->module->getInfo('min_php'),
                            phpversion()
                        ),
                        'accept'
                    );
                }
            }

            // Database version
            // Validate that the current system is acceptable for the module by checking a set of specific
            // databases and versions if specified in min_db key.
            //
            // An array of minimum versions keyed by platform can be optionally specified in xoops_version.php:
            //   $modversion['min_db'] = array('mysql' => '5.0.7', 'sqlite' => '3.0.8');
            //
            // If min_db is specified, and the current database is included in the array, the version will be
            // compared to the specified minimum. If the reported database version is equal or greater, an OK
            // message will be generated. If the version is lower, an error message will be issued.
            //
            // If min_db is specified, and the current platform is not included in the array, an error message
            // will indicate the module does not support the database current platform.
            //
            // If at all possible, modules should NOT specify this, as with Doctrine DBAL we should be able to
            // support many different databases, and thus portable modules are prefered. The supported databases
            // and versions are set by XoopsCore and Doctrine, and should not be restricted without reason.

            $dbarray = $this->module->getInfo('min_db');
            if ($dbarray !== false) {

The condition $dbarray !== false is always true.

                $dbCurrentPlatform = $xoops->db()->getDatabasePlatform()->getName();
                $dbCurrentVersion  = $xoops->db()->getWrappedConnection()->getServerVersion();
                if (isset($dbarray[$dbCurrentPlatform])) {
                    $dbRequiredVersion = $dbarray[$dbCurrentPlatform];
                    if (0 >= version_compare($dbCurrentVersion, $dbRequiredVersion)) {
                        $this->addConfigBoxLine(
                            sprintf(
                                strtoupper(\XoopsBaseConfig::get('db-type')) . ' '

It seems like XoopsBaseConfig::get('db-type') can also be of type null; however, parameter $string of strtoupper() does only seem to accept string, maybe add an additional type check?

                                . \XoopsLocale::F_MINIMUM_DATABASE_VERSION_REQUIRED,
                                $dbRequiredVersion,
                                $dbCurrentVersion
                            ),
                            'error'
                        );
                    } else {
                        $this->addConfigBoxLine(
                            sprintf(
                                strtoupper(\XoopsBaseConfig::get('db-type')) . ' ' . \XoopsLocale::F_MINIMUM_DATABASE_VERSION_REQUIRED,
                                $dbRequiredVersion,
                                $dbCurrentVersion
                            ),
                            'accept'
                        );
                    }
                } else {
                        $this->addConfigBoxLine(
                            sprintf(\XoopsLocale::EF_DATABASE_NOT_SUPPORTED, $dbCurrentPlatform),
                            'error'
                        );
                }
            }

            // xoops version
            if ($this->module->getInfo('min_xoops')) {
                $xoopsVersion = substr(\Xoops::VERSION, 6); // skip 'XOOPS ' prefix
                $xoopsCmpVersion = str_ireplace(['Alpha', 'Beta', 'RC'], ['0Alpha', '0Beta', '0RC'], $xoopsVersion);
                if (0 >= version_compare($xoopsCmpVersion, $this->module->getInfo('min_xoops'))) {

It seems like $xoopsCmpVersion can also be of type array; however, parameter $version1 of version_compare() does only seem to accept string, maybe add an additional type check?

                    $this->addConfigBoxLine(
                        sprintf(
                            \XoopsLocale::F_MINIMUM_XOOPS_VERSION_REQUIRED,
                            $this->module->getInfo('min_xoops'),
                            $xoopsVersion
                        ),
                        'error'
                    );
                } else {
                    $this->addConfigBoxLine(
                        sprintf(
                            \XoopsLocale::F_MINIMUM_XOOPS_VERSION_REQUIRED,
                            $this->module->getInfo('min_xoops'),
                            $xoopsVersion
                        ),
                        'accept'
                    );
                }
            }
            $xoops->tpl()->assign('xo_admin_index_config', $this->itemConfigBoxLine);
        }
        return $xoops->tpl()->fetch($this->getTplPath('index'));
    }