SystemModule::uninstall()

Complexity

Conditions	15
Paths	56

Size

Total Lines	112
Code Lines	80

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function uninstall($mod = '')
    {
        $xoops = Xoops::getInstance();
        $module_handler = $xoops->getHandlerModule();
        $module = $module_handler->getByDirname($mod);
        $xoops->templateClearModuleCache($module->getVar('mid'));

        if ($module->getVar('dirname') === 'system') {
            $this->error[] = sprintf(
                XoopsLocale::EF_NOT_UNINSTALLED,
                '<strong>' . $module->getVar('name') . '</strong>'
            ) . "&nbsp;" . XoopsLocale::C_ERRORS;
            $this->error[] = " - " . SystemLocale::E_SYSTEM_MODULE_CANNOT_BE_DEACTIVATED;
            return false;
        } elseif ($module->getVar('dirname') == $xoops->getConfig('startpage')) {
            $this->error[] = sprintf(
                XoopsLocale::EF_NOT_UNINSTALLED,
                '<strong>' . $module->getVar('name') . '</strong>'
            ) . "&nbsp;" . XoopsLocale::C_ERRORS;
            $this->error[] = " - " . SystemLocale::E_THIS_MODULE_IS_SET_AS_DEFAULT_START_PAGE;
            return false;
        } else {
            // Load module specific install script if any
            $uninstall_script = $module->getInfo('onUninstall');
            if ($uninstall_script && trim($uninstall_script) != '') {

It seems like $uninstall_script can also be of type string[]; however, parameter $string of trim() does only seem to accept string, maybe add an additional type check?

                XoopsLoad::loadFile($xoops->path('modules/' . $mod . '/' . trim($uninstall_script)));
            }
            $func = "xoops_module_pre_uninstall_{$mod}";
            // If pre uninstall function is defined, execute
            if (function_exists($func)) {
                $result = $func($module);
                if (!$result) {
                    $this->error[] = sprintf(XoopsLocale::EF_NOT_EXECUTED, $func);
                    $this->error[] = sprintf(
                        XoopsLocale::EF_NOT_UNINSTALLED,
                        '<strong>' . $module->getVar('name') . '</strong>'
                    ) . "&nbsp;" . XoopsLocale::C_ERRORS;
                    $this->error = array_merge($this->error, $module->getErrors());
                    return false;
                } else {
                    $this->trace[] = sprintf(XoopsLocale::SF_EXECUTED, "<strong>{$func}</strong>");
                    $this->trace = array_merge($this->trace, $module->getMessages());
                }
            }

            if (false === $module_handler->deleteModule($module)) {

It seems like $module can also be of type false; however, parameter $module of Xoops\Core\Kernel\Handlers\XoopsModuleHandler::deleteModule() does only seem to accept Xoops\Core\Kernel\Handlers\XoopsModule, maybe add an additional type check?

                $this->error[] = sprintf(XoopsLocale::EF_NOT_DELETED, $module->getVar('name'));

It seems like $module->getVar('name') can also be of type string[]; however, parameter $values of sprintf() does only seem to accept double|integer|string, maybe add an additional type check?

                return false;
            } else {
                // delete templates
                $this->deleteTemplates($module);

It seems like $module can also be of type false; however, parameter $module of SystemModule::deleteTemplates() does only seem to accept Xoops\Core\Kernel\Handlers\XoopsModule, maybe add an additional type check?

                // Delete blocks and block template files
                $this->deleteBlocks($module);

It seems like $module can also be of type false; however, parameter $module of SystemModule::deleteBlocks() does only seem to accept Xoops\Core\Kernel\Handlers\XoopsModule, maybe add an additional type check?

                // Delete tables used by this module
                $modtables = $module->getInfo('tables');
                if ($modtables != false && is_array($modtables)) {
                    // get a schema manager
                    $schemaManager = $xoops->db()->getSchemaManager();
                    // create schema from the current database
                    $toSchema = $schemaManager->createSchema();

                    $this->trace[] = SystemLocale::MANAGING_TABLES;
                    foreach ($modtables as $table) {
                        // prevent deletion of reserved core tables!
                        if (!in_array($table, $this->reservedTables)) {
                            $toSchema->dropTable($xoops->db()->prefix($table));
                            $this->trace[]['sub'] = sprintf(
                                XoopsLocale::SF_TABLE_DROPPED,
                                '<strong>' . $xoops->db()->prefix($table) . '</strong>'
                            );
                        } else {
                            $this->trace[]['sub'] = '<span class="red">' . sprintf(
                                XoopsLocale::EF_TABLE_DROP_NOT_ALLOWED,
                                '<strong>' . $xoops->db()->prefix($table) . '</strong>'
                            ) . '</span>';
                        }
                    }
                    $synchronizer = new SingleDatabaseSynchronizer($xoops->db());
                    $synchronizer->updateSchema($toSchema, false);
                }

                // delete permissions if any
                $gperm_handler = $xoops->getHandlerGroupPermission();
                if (false === $gperm_handler->deleteByModule($module->getVar('mid'))) {
                    $this->trace[] = '<span class="red">' . SystemLocale::E_GROUP_PERMISSIONS_NOT_DELETED . '</span>';
                } else {
                    $this->trace[] = SystemLocale::S_GROUP_PERMISSIONS_DELETED;
                }

                // delete module config options if any
                $this->deleteConfigs($module);

It seems like $module can also be of type false; however, parameter $module of SystemModule::deleteConfigs() does only seem to accept Xoops\Core\Kernel\Handlers\XoopsModule, maybe add an additional type check?

                // execute module specific install script if any
                $func = 'xoops_module_uninstall_' . $mod;
                if (function_exists($func)) {
                    $result = $func($module);
                    if (!$result) {
                        $this->trace[] = sprintf(XoopsLocale::EF_NOT_EXECUTED, $func);
                        $this->trace = array_merge($this->error, $module->getErrors());
                    } else {
                        $this->trace[] = sprintf(XoopsLocale::SF_EXECUTED, "<strong>{$func}</strong>");
                        $this->trace = array_merge($this->trace, $module->getMessages());
                    }
                }
                $this->trace[] = sprintf(
                    XoopsLocale::SF_UNINSTALLED,
                    '<strong>' . $module->getVar('name') . '</strong>'
                );
                $xoops->events()->triggerEvent('system.module.uninstall', $module);
                return $module;
            }