ObservableBunny::__construct() - Code Metrics - Inspection of "Close channel when disposing the subscription" - WyriHaximus/reactphp-observable-bunny - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( dbaa3f...fce5ae )

by Cees-Jan

created 2018-02-15 09:20 UTC

ObservableBunny::__construct() A

↳ Parent: ObservableBunny

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	5
ccs	3
cts	3
cp	1
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	3
nc	1
nop	2
crap	1

<?php declare(strict_types=1);

namespace WyriHaximus\React\ObservableBunny;

use Bunny\Async\Client;
use Bunny\Channel;
use Bunny\Message as BunnyMessage;
use Bunny\Protocol\MethodBasicConsumeOkFrame;
use React\EventLoop\LoopInterface;
use React\EventLoop\Timer\TimerInterface;
use Rx\Subject\Subject;

final class ObservableBunny
{
    /**
     * @var LoopInterface
     */
    private $loop;

    /**
     * @var Client
     */
    private $bunny;

    /**
     * @param LoopInterface $loop
     * @param Client        $bunny
     */
    public function __construct(LoopInterface $loop, Client $bunny)
    {
        $this->loop = $loop;
        $this->bunny = $bunny;
    }

    public function consume(
        string $queue = '',
        string $consumerTag = '',
        bool $noLocal = false,
        bool $noAck = false,
        bool $exclusive = false,
        bool $nowait = false,
        array $arguments = []
    ): Subject {
        $subject = new Subject();
        $consumeArgs = [$queue, $consumerTag, $noLocal, $noAck, $exclusive, $nowait, $arguments];

        $channel = $this->bunny->channel();
        $channel->then(function (Channel $channel) use ($subject, $consumeArgs) {
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            /** @var string $consumerTag */
            $consumerTag = null;
            $timer = $this->loop->addPeriodicTimer(1, function () use ($channel, $subject, &$timer, &$consumerTag) {
                if (!$subject->isDisposed()) {
                    return;
                }

                $this->cancelSubscription(
                    $timer,
                    $channel,
                    $consumerTag
                )->done([$subject, 'onComplete'], [$subject, 'onError']);
            });
            $channel->consume(
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
                function (BunnyMessage $message, Channel $channel) use ($subject, &$timer, &$consumerTag) {
                    if ($subject->isDisposed()) {
                        $channel->nack($message);
                        $this->cancelSubscription(
                            $timer,
                            $channel,
                            $consumerTag
                        )->done([$subject, 'onComplete'], [$subject, 'onError']);

                        return;
                    }

                    $subject->onNext(new Message($message, $channel));
                },
                ...$consumeArgs
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            )->then(function (MethodBasicConsumeOkFrame $response) use (&$consumerTag) {
                $consumerTag = $response->consumerTag;
            })->done(null, [$subject, 'onError']);
        })->done(null, [$subject, 'onError']);

        return $subject;
    }

    private function cancelSubscription(TimerInterface $timer, Channel $channel, string $consumerTag)
    {
        $this->loop->cancelTimer($timer);

        return $channel->cancel($consumerTag)->then(function () use ($channel) {
            return $channel->close();
        });
    }
}


1		<?php declare(strict_types=1);
2
3		namespace WyriHaximus\React\ObservableBunny;
4
5		use Bunny\Async\Client;
6		use Bunny\Channel;
7		use Bunny\Message as BunnyMessage;
8		use Bunny\Protocol\MethodBasicConsumeOkFrame;
9		use React\EventLoop\LoopInterface;
10		use React\EventLoop\Timer\TimerInterface;
11		use Rx\Subject\Subject;
12
13		final class ObservableBunny
14		{
15		/**
16		* @var LoopInterface
17		*/
18		private $loop;
19
20		/**
21		* @var Client
22		*/
23		private $bunny;
24
25		/**
26		* @param LoopInterface $loop
27		* @param Client $bunny
28	1	*/
29		public function __construct(LoopInterface $loop, Client $bunny)
30	1	{
31	1	$this->loop = $loop;
32	1	$this->bunny = $bunny;
33		}
34	1
35		public function consume(
36		string $queue = '',
37		string $consumerTag = '',
38		bool $noLocal = false,
39		bool $noAck = false,
40		bool $exclusive = false,
41		bool $nowait = false,
42		array $arguments = []
43	1	): Subject {
44	1	$subject = new Subject();
45		$consumeArgs = [$queue, $consumerTag, $noLocal, $noAck, $exclusive, $nowait, $arguments];
46	1
47	1	$channel = $this->bunny->channel();
48	1	$channel->then(function (Channel $channel) use ($subject, $consumeArgs) {
		0 ignored issues – show Bug introduced 2018-02-14 22:29 UTC by Report Bug Copy Issue Report The method `then` does only exist in `React\Promise\PromiseInterface`, but not in `Bunny\Channel`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
49	1	/** @var string $consumerTag */
50	1	$consumerTag = null;
51		$timer = $this->loop->addPeriodicTimer(1, function () use ($channel, $subject, &$timer, &$consumerTag) {
52		if (!$subject->isDisposed()) {
53		return;
54	1	}
55	1
56	1	$this->cancelSubscription(
57	1	$timer,
58	1	$channel,
59	1	$consumerTag
60		)->done([$subject, 'onComplete'], [$subject, 'onError']);
61		});
62		$channel->consume(
		0 ignored issues – show Bug introduced 2018-02-14 22:29 UTC by Report Bug Copy Issue Report The method `then` does only exist in `React\Promise\PromiseInterface`, but not in `Bunny\Protocol\MethodBasicConsumeOkFrame`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
63		function (BunnyMessage $message, Channel $channel) use ($subject, &$timer, &$consumerTag) {
64		if ($subject->isDisposed()) {
65		$channel->nack($message);
66		$this->cancelSubscription(
67	1	$timer,
68	1	$channel,
69	1	$consumerTag
70	1	)->done([$subject, 'onComplete'], [$subject, 'onError']);
71	1
72	1	return;
73	1	}
74
75	1	$subject->onNext(new Message($message, $channel));
76		},
77		...$consumeArgs
		0 ignored issues – show Documentation introduced 2018-02-14 22:29 UTC by Report Bug Copy Issue Report `$consumeArgs` is of type `array<integer,string\|boo..."boolean","6":"array"}>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
78		)->then(function (MethodBasicConsumeOkFrame $response) use (&$consumerTag) {
79		$consumerTag = $response->consumerTag;
80		})->done(null, [$subject, 'onError']);
81		})->done(null, [$subject, 'onError']);
82
83		return $subject;
84		}
85
86		private function cancelSubscription(TimerInterface $timer, Channel $channel, string $consumerTag)
87		{
88		$this->loop->cancelTimer($timer);
89
90		return $channel->cancel($consumerTag)->then(function () use ($channel) {
91		return $channel->close();
92		});
93		}
94		}
95

WyriHaximus / reactphp-observable-bunny

GitHub Access Token became invalid

Push — master ( dbaa3f...fce5ae )

ObservableBunny::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like