Session::__construct() - Code Metrics - Inspection of "Session controll (begin, end, regenerate)" - WyriHaximus/reactphp-http-middleware-session - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#2)

by Cees-Jan

created 2018-01-27 23:39 UTC

Session::__construct() A

↳ Parent: Session

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	10
ccs	7
cts	7
cp	1
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	6
nc	2
nop	3
crap	2

<?php declare(strict_types=1);

namespace WyriHaximus\React\Http\Middleware;

final class Session
{
    /**
     * @var string
     */
    private $id = '';

    /**
     * @var array
     */
    private $contents = [];

    /**
     * @var SessionIdInterface
     */
    private $sessionId = [];

    /**
     * @var int
     */
    private $status = \PHP_SESSION_NONE;

    /**
     * @param string             $id
     * @param array              $contents
     * @param SessionIdInterface $sessionId
     */
    public function __construct(string $id, array $contents, SessionIdInterface $sessionId)
    {
        $this->id = $id;
        $this->contents = $contents;
        $this->sessionId = $sessionId;

        if ($this->id !== '') {
            $this->status = \PHP_SESSION_ACTIVE;
        }
    }

    /**
     * @return string
     */
    public function getId(): string
    {
        return $this->id;
    }

    /**
     * @param array $contents
     */
    public function setContents(array $contents)
    {
        $this->contents = $contents;
    }

    /**
     * @return array
     */
    public function getContents(): array
    {
        return $this->contents;
    }

    public function begin()
    {
        if ($this->status === \PHP_SESSION_ACTIVE) {
            return true;
        }

        $this->status = \PHP_SESSION_ACTIVE;

        if ($this->id === '') {
            $this->id = $this->sessionId->generate();
        }
    }

    public function end()
    {
        if ($this->status === \PHP_SESSION_NONE) {
            return true;
        }

        $this->status = \PHP_SESSION_NONE;
        $this->id = '';
    }

    /**
     * @return bool
     */
    public function isActive(): bool
    {
        return $this->status === \PHP_SESSION_ACTIVE;
    }

    public function regenerate()
    {
        // Can only regenerate active sessions
        if ($this->status !== \PHP_SESSION_ACTIVE) {
            return false;
        }

        $this->id = $this->sessionId->generate();

        return true;
    }
}


1		<?php declare(strict_types=1);
2
3		namespace WyriHaximus\React\Http\Middleware;
4
5		final class Session
6		{
7		/**
8		* @var string
9		*/
10		private $id = '';
11
12		/**
13		* @var array
14		*/
15		private $contents = [];
16
17		/**
18		* @var SessionIdInterface
19		*/
20		private $sessionId = [];
21
22		/**
23		* @var int
24		*/
25		private $status = \PHP_SESSION_NONE;
26
27		/**
28		* @param string $id
29		* @param array $contents
30		* @param SessionIdInterface $sessionId
31		*/
32	15	public function __construct(string $id, array $contents, SessionIdInterface $sessionId)
33		{
34	15	$this->id = $id;
35	15	$this->contents = $contents;
36	15	$this->sessionId = $sessionId;
37
38	15	if ($this->id !== '') {
39	4	$this->status = \PHP_SESSION_ACTIVE;
40		}
41	15	}
42
43		/**
44		* @return string
45		*/
46	14	public function getId(): string
47		{
48	14	return $this->id;
49		}
50
51		/**
52		* @param array $contents
53		*/
54	4	public function setContents(array $contents)
55		{
56	4	$this->contents = $contents;
57	4	}
58
59		/**
60		* @return array
61		*/
62	14	public function getContents(): array
63		{
64	14	return $this->contents;
65		}
66
67	2	public function begin()
68		{
69	2	if ($this->status === \PHP_SESSION_ACTIVE) {
70		return true;
71		}
72
73	2	$this->status = \PHP_SESSION_ACTIVE;
74
75	2	if ($this->id === '') {
76	2	$this->id = $this->sessionId->generate();
77		}
78	2	}
79
80	2	public function end()
81		{
82	2	if ($this->status === \PHP_SESSION_NONE) {
83		return true;
84		}
85
86	2	$this->status = \PHP_SESSION_NONE;
87	2	$this->id = '';
88	2	}
89
90		/**
91		* @return bool
92		*/
93	5	public function isActive(): bool
94		{
95	5	return $this->status === \PHP_SESSION_ACTIVE;
96		}
97
98	1	public function regenerate()
99		{
100		// Can only regenerate active sessions
101	1	if ($this->status !== \PHP_SESSION_ACTIVE) {
102		return false;
103		}
104
105	1	$this->id = $this->sessionId->generate();
106
107	1	return true;
108		}
109		}
110

WyriHaximus / reactphp-http-middleware-session

GitHub Access Token became invalid

Pull Request — master (#2)

Session::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like