SessionMiddleware::__invoke() - Code Metrics - Inspection of "Fixed all bugs that came up through infection" - WyriHaximus/reactphp-http-middleware-session - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 05cf04...751266 )

by Cees-Jan

created 2019-03-13 07:32 UTC

SessionMiddleware::__invoke() A

↳ Parent: SessionMiddleware

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	19
ccs	11
cts	11
cp	1
rs	9.6333
c	0
b	0
f	0
cc	1
nc	1
nop	2
crap	1

<?php declare(strict_types=1);

namespace WyriHaximus\React\Http\Middleware;

use HansOtt\PSR7Cookies\RequestCookies;
use HansOtt\PSR7Cookies\SetCookie;
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;
use React\Cache\CacheInterface;
use React\Promise\PromiseInterface;
use function React\Promise\resolve;
use Throwable;
use WyriHaximus\React\Http\Middleware\SessionId\RandomBytes;

final class SessionMiddleware
{
    const ATTRIBUTE_NAME = 'wyrihaximus.react.http.middleware.session';

    const DEFAULT_COOKIE_PARAMS = [
        0,
        '',
        '',
        false,
        false,
    ];

    /**
     * @var string
     */
    private $cookieName;

    /**
     * @var CacheInterface
     */
    private $cache;

    /**
     * @var array
     */
    private $cookieParams;

    /**
     * @var SessionIdInterface
     */
    private $sessionId;

    /**
     * @param string                  $cookieName
     * @param CacheInterface          $cache
     * @param array                   $cookieParams
     * @param SessionIdInterface|null $sessionId
     */
    public function __construct(
        string $cookieName,
        CacheInterface $cache,
        array $cookieParams = [],
        SessionIdInterface $sessionId = null
    ) {
        $this->cookieName = $cookieName;
        $this->cache = $cache;
        $this->cookieParams = \array_replace(self::DEFAULT_COOKIE_PARAMS, $cookieParams);

        if ($sessionId === null) {
            $sessionId = new RandomBytes();
        }
        $this->sessionId = $sessionId;
    }

    public function __invoke(ServerRequestInterface $request, callable $next)
    {
        return $this->fetchSessionFromRequest($request)->then(function (Session $session) use ($next, $request) {
            $request = $request->withAttribute(self::ATTRIBUTE_NAME, $session);
$x = 1;
$callable = function() use ($x) {
    $x = 2; // Not visible in outer scope. If you would like this, how
            // about using a different variable name than $x?
};

$callable();
var_dump($x); // integer(1)

            return resolve(
                $next($request)
            )->then(function (ResponseInterface $response) use ($session) {
                return $this->updateCache($session)->then(function () use ($response) {
                    return $response;
                });
            })->then(function ($response) use ($session) {
                $cookie = $this->getCookie($session);
                $response = $cookie->addToResponse($response);

                return $response;
            });
        });
    }

    private function fetchSessionFromRequest(ServerRequestInterface $request): PromiseInterface
    {
        $id = '';
        $cookies = RequestCookies::createFromRequest($request);

        try {
            if (!$cookies->has($this->cookieName)) {
                return resolve(new Session($id, [], $this->sessionId));
            }
            $id = $cookies->get($this->cookieName)->getValue();

            return $this->fetchSessionDataFromCache($id)->then(function (array $sessionData) use ($id) {
                return new Session($id, $sessionData, $this->sessionId);
            });
        } catch (Throwable $et) {
            // Do nothing, only a not found will be thrown so generating our own id now
        }

        return resolve(new Session($id, [], $this->sessionId));
    }

    private function fetchSessionDataFromCache(string $id): PromiseInterface
    {
        if ($id === '') {
            return resolve([]);
        }

        return $this->cache->get($id)->then(function ($result) {
            if ($result === null) {
                return resolve([]);
            }

            return $result;
        });
    }

    private function updateCache(Session $session): PromiseInterface
    {
        foreach ($session->getOldIds() as $oldId) {
            $this->cache->delete($oldId);
        }

        if ($session->isActive()) {
            return resolve($this->cache->set($session->getId(), $session->getContents()));
        }

        return resolve();
    }

    private function getCookie(Session $session): SetCookie
    {
        $cookieParams = $this->cookieParams;

        if ($session->isActive()) {
            // Only set time when expires is set in the future
            if ($cookieParams[0] > 0) {
                $cookieParams[0] += \time();
            }

            return new SetCookie($this->cookieName, $session->getId(), ...$cookieParams);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }
        unset($cookieParams[0]);

        return SetCookie::thatDeletesCookie($this->cookieName, ...$cookieParams);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}


1		<?php declare(strict_types=1);
2
3		namespace WyriHaximus\React\Http\Middleware;
4
5		use HansOtt\PSR7Cookies\RequestCookies;
6		use HansOtt\PSR7Cookies\SetCookie;
7		use Psr\Http\Message\ResponseInterface;
8		use Psr\Http\Message\ServerRequestInterface;
9		use React\Cache\CacheInterface;
10		use React\Promise\PromiseInterface;
11		use function React\Promise\resolve;
12		use Throwable;
13		use WyriHaximus\React\Http\Middleware\SessionId\RandomBytes;
14
15		final class SessionMiddleware
16		{
17		const ATTRIBUTE_NAME = 'wyrihaximus.react.http.middleware.session';
18
19		const DEFAULT_COOKIE_PARAMS = [
20		0,
21		'',
22		'',
23		false,
24		false,
25		];
26
27		/**
28		* @var string
29		*/
30		private $cookieName;
31
32		/**
33		* @var CacheInterface
34		*/
35		private $cache;
36
37		/**
38		* @var array
39		*/
40		private $cookieParams;
41
42		/**
43		* @var SessionIdInterface
44		*/
45		private $sessionId;
46
47		/**
48		* @param string $cookieName
49		* @param CacheInterface $cache
50		* @param array $cookieParams
51		* @param SessionIdInterface\|null $sessionId
52		*/
53	19	public function __construct(
54		string $cookieName,
55		CacheInterface $cache,
56		array $cookieParams = [],
57		SessionIdInterface $sessionId = null
58		) {
59	19	$this->cookieName = $cookieName;
60	19	$this->cache = $cache;
61	19	$this->cookieParams = \array_replace(self::DEFAULT_COOKIE_PARAMS, $cookieParams);
62
63	19	if ($sessionId === null) {
64	19	$sessionId = new RandomBytes();
65		}
66	19	$this->sessionId = $sessionId;
67	19	}
68
69	19	public function __invoke(ServerRequestInterface $request, callable $next)
70		{
71		return $this->fetchSessionFromRequest($request)->then(function (Session $session) use ($next, $request) {
72	18	$request = $request->withAttribute(self::ATTRIBUTE_NAME, $session);
		0 ignored issues – show Bug introduced 2018-01-22 09:17 UTC by Report Bug Copy Issue Report Consider using a different name than the imported variable `$request`, or did you forget to import by reference? It seems like you are assigning to a variable which was imported through a `use` statement which was not imported by reference. For clarity, we suggest to use a different name or import by reference depending on whether you would like to have the change visibile in outer-scope. Change not visible in outer-scope $x = 1; $callable = function() use ($x) { $x = 2; // Not visible in outer scope. If you would like this, how // about using a different variable name than $x? }; $callable(); var_dump($x); // integer(1) Change visible in outer-scope $x = 1; $callable = function() use (&$x) { $x = 2; }; $callable(); var_dump($x); // integer(2) Loading history...
73
74	18	return resolve(
75	18	$next($request)
76		)->then(function (ResponseInterface $response) use ($session) {
77		return $this->updateCache($session)->then(function () use ($response) {
78	18	return $response;
79	18	});
80		})->then(function ($response) use ($session) {
81	18	$cookie = $this->getCookie($session);
82	18	$response = $cookie->addToResponse($response);
83
84	18	return $response;
85	18	});
86	19	});
87		}
88
89	19	private function fetchSessionFromRequest(ServerRequestInterface $request): PromiseInterface
90		{
91	19	$id = '';
92	19	$cookies = RequestCookies::createFromRequest($request);
93
94		try {
95	19	if (!$cookies->has($this->cookieName)) {
96	11	return resolve(new Session($id, [], $this->sessionId));
97		}
98	8	$id = $cookies->get($this->cookieName)->getValue();
99
100		return $this->fetchSessionDataFromCache($id)->then(function (array $sessionData) use ($id) {
101	6	return new Session($id, $sessionData, $this->sessionId);
102	7	});
103	1	} catch (Throwable $et) {
104		// Do nothing, only a not found will be thrown so generating our own id now
105		}
106
107	1	return resolve(new Session($id, [], $this->sessionId));
108		}
109
110	8	private function fetchSessionDataFromCache(string $id): PromiseInterface
111		{
112	8	if ($id === '') {
113		return resolve([]);
114		}
115
116		return $this->cache->get($id)->then(function ($result) {
117	6	if ($result === null) {
118	5	return resolve([]);
119		}
120
121	1	return $result;
122	7	});
123		}
124
125	18	private function updateCache(Session $session): PromiseInterface
126		{
127	18	foreach ($session->getOldIds() as $oldId) {
128	2	$this->cache->delete($oldId);
129		}
130
131	18	if ($session->isActive()) {
132	16	return resolve($this->cache->set($session->getId(), $session->getContents()));
133		}
134
135	2	return resolve();
136		}
137
138	18	private function getCookie(Session $session): SetCookie
139		{
140	18	$cookieParams = $this->cookieParams;
141
142	18	if ($session->isActive()) {
143		// Only set time when expires is set in the future
144	16	if ($cookieParams[0] > 0) {
145	11	$cookieParams[0] += \time();
146		}
147
148	16	return new SetCookie($this->cookieName, $session->getId(), ...$cookieParams);
		0 ignored issues – show Documentation introduced 2018-01-28 18:54 UTC by Report Bug Copy Issue Report `$cookieParams` is of type `array`, but the function expects a `integer`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
149		}
150	2	unset($cookieParams[0]);
151
152	2	return SetCookie::thatDeletesCookie($this->cookieName, ...$cookieParams);
		0 ignored issues – show Documentation introduced 2018-01-28 18:54 UTC by Report Bug Copy Issue Report `$cookieParams` is of type `array`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
153		}
154		}
155

WyriHaximus / reactphp-http-middleware-session

GitHub Access Token became invalid

Push — master ( 05cf04...751266 )

SessionMiddleware::__invoke() A

Complexity

Size

Duplication

Code Coverage

Importance

Change not visible in outer-scope

Change visible in outer-scope

Duplication Side-by-Side

Filter issues like