SessionCacheConfiguration::requestIsCacheable() - Code Metrics - Inspection of "CS fix" - WyriHaximus/reactphp-http-middleware-response-cache-session-cache-configuration - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 377469...2986b1 )

by Cees-Jan

created 2018-04-10 15:16 UTC

SessionCacheConfiguration::requestIsCacheable() A

↳ Parent: SessionCacheConfiguration

Complexity

Conditions	3
Paths	2

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	3

Importance

Changes

Metric	Value
cc	3
eloc	5
nc	2
nop	1
dl	0
loc	10
ccs	5
cts	5
cp	1
crap	3
rs	9.4285
c	0
b	0
f	0

<?php declare(strict_types=1);

namespace WyriHaximus\React\Http\Middleware;

use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;

final class SessionCacheConfiguration implements CacheConfigurationInterface
{
    /**
     * @var CacheConfigurationInterface
     */
    private $cacheConfiguration;

    public function __construct(CacheConfigurationInterface $cacheConfiguration)
    {
        $this->cacheConfiguration = $cacheConfiguration;
    }

    public function requestIsCacheable(ServerRequestInterface $request): bool
    {
        if (
            $request->getAttribute(SessionMiddleware::ATTRIBUTE_NAME) !== null &&
            $request->getAttribute(SessionMiddleware::ATTRIBUTE_NAME)->isActive() === true
        ) {
            return false;
        }

        return $this->cacheConfiguration->requestIsCacheable($request);
    }

    public function responseIsCacheable(ServerRequestInterface $request, ResponseInterface $response): bool
    {
        if (
            $request->getAttribute(SessionMiddleware::ATTRIBUTE_NAME) !== null &&
            $request->getAttribute(SessionMiddleware::ATTRIBUTE_NAME)->isActive() === true
        ) {
            return false;
        }

        return $this->cacheConfiguration->responseIsCacheable($request, $response);
    }

    public function cacheKey(ServerRequestInterface $request): string
    {
        return $this->cacheConfiguration->cacheKey($request);
    }

    public function cacheEncode(ResponseInterface $response): string
    {
        return $this->cacheConfiguration->cacheEncode($response);
    }

    public function cacheDecode(string $response): ResponseInterface
    {
        return $this->cacheConfiguration->cacheDecode($response);
    }
}


1		<?php declare(strict_types=1);
2
3		namespace WyriHaximus\React\Http\Middleware;
4
5		use Psr\Http\Message\ResponseInterface;
6		use Psr\Http\Message\ServerRequestInterface;
7
8		final class SessionCacheConfiguration implements CacheConfigurationInterface
9		{
10		/**
11		* @var CacheConfigurationInterface
12		*/
13		private $cacheConfiguration;
14
15	4	public function __construct(CacheConfigurationInterface $cacheConfiguration)
16		{
17	4	$this->cacheConfiguration = $cacheConfiguration;
18	4	}
19
20	2	public function requestIsCacheable(ServerRequestInterface $request): bool
21		{
22		if (
23	2	$request->getAttribute(SessionMiddleware::ATTRIBUTE_NAME) !== null &&
24	2	$request->getAttribute(SessionMiddleware::ATTRIBUTE_NAME)->isActive() === true
25		) {
26	1	return false;
27		}
28
29	1	return $this->cacheConfiguration->requestIsCacheable($request);
30		}
31
32	2	public function responseIsCacheable(ServerRequestInterface $request, ResponseInterface $response): bool
33		{
34		if (
35	2	$request->getAttribute(SessionMiddleware::ATTRIBUTE_NAME) !== null &&
36	2	$request->getAttribute(SessionMiddleware::ATTRIBUTE_NAME)->isActive() === true
37		) {
38	1	return false;
39		}
40
41	1	return $this->cacheConfiguration->responseIsCacheable($request, $response);
42		}
43
44		public function cacheKey(ServerRequestInterface $request): string
45		{
46		return $this->cacheConfiguration->cacheKey($request);
47		}
48
49		public function cacheEncode(ResponseInterface $response): string
50		{
51		return $this->cacheConfiguration->cacheEncode($response);
52		}
53
54		public function cacheDecode(string $response): ResponseInterface
55		{
56		return $this->cacheConfiguration->cacheDecode($response);
57		}
58		}
59

WyriHaximus / reactphp-http-middleware-response-cache-session-cache-configuration

GitHub Access Token became invalid

Push — master ( 377469...2986b1 )

SessionCacheConfiguration::requestIsCacheable() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like