WyriHaximus\React\Http\Middleware\MeasureMiddleware

Complexity

Total Complexity

7

Size/Duplication

Total Lines	64
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

92.86%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__invoke()	0	22	4
A	collect()	0	15	2
A	cancel()	0	4	1

<?php declare(strict_types=1);

namespace WyriHaximus\React\Http\Middleware;

use Psr\Http\Message\ServerRequestInterface;
use function React\Promise\resolve;

final class MeasureMiddleware
{
    /** @var int */
    private $current = 0;

    /** @var int */
    private $total = 0;

    /** @var null|float */
    private $tookMin = null;

    /** @var float */
    private $tookMax = 0.0;

    /** @var float */
    private $tookAvg = 0.0;

    /** @var float */
    private $tookTotal = 0.0;

    public function __invoke(ServerRequestInterface $request, callable $next)
    {
        $this->current++;
        $start = \microtime(true);

        return resolve($next($request))->always(function () use ($start): void {
            $took = \microtime(true) - $start;
            $this->current--;
            $this->total++;
            $this->tookTotal += $took;

            if ($this->tookMin === null || $took < $this->tookMin) {
                $this->tookMin = $took;
            }

            if ($this->tookMax < $took) {
                $this->tookMax = $took;
            }

            $this->tookAvg = $this->tookTotal / $this->total;
        });
    }

    public function collect(): iterable
    {
        yield 'current' => $this->current;
        yield 'total' => $this->total;
        yield 'took.min' => $this->tookMin === null ? 0.0 : $this->tookMin;
        yield 'took.max' => $this->tookMax;
        yield 'took.average' => $this->tookAvg;
        yield 'took.total' => $this->tookTotal;

        $this->total = 0;
        $this->tookMin = null;
        $this->tookMax = 0.0;
        $this->tookAvg = 0.0;
        $this->tookTotal = 0;

The property $tookTotal was declared of type double, but 0 is of type integer. Maybe add a type cast?

    }

    public function cancel(): void
    {
        // Does not apply to this class
    }
}