Cron::perform() - Code Metrics - Inspection of "Add mutex locking support" - WyriHaximus/reactphp-cron - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d39c6b...1e41a0 )

by Cees-Jan

created 2019-02-22 06:58 UTC

Cron::perform() A

↳ Parent: Cron

Complexity

Conditions	3
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	3.0987

Importance

Changes

Metric	Value
dl	0
loc	16
ccs	7
cts	9
cp	0.7778
rs	9.7333
c	0
b	0
f	0
cc	3
nc	2
nop	1
crap	3.0987

<?php declare(strict_types=1);

namespace WyriHaximus\React;

use React\EventLoop\LoopInterface;
use WyriHaximus\React\Mutex\Memory;
use WyriHaximus\React\Mutex\MutexInterface;

final class Cron
{
    /** @var ActionInterface[] */
    private $actions;

    /** @var MutexInterface */
    private $mutex;

    /**
     * @param SchedulerInterface $scheduler
     * @param MutexInterface     $mutex
     * @param ActionInterface[]  $actions
     */
    private function __construct(SchedulerInterface $scheduler, MutexInterface $mutex, ActionInterface ...$actions)
    {
        $this->actions = $actions;

        $this->mutex = $mutex;

        $scheduler->schedule(function (): void {
            $this->tick();
        });
    }

    public static function create(LoopInterface $loop, ActionInterface ...$actions)
    {
        return new self(new Scheduler($loop), new Memory(), ...$actions);
    }

    private function tick(): void
    {
        foreach ($this->actions as $action) {
            $this->perform($action);
        }
    }

    private function perform(ActionInterface $action): void
    {
        if ($action->isDue() === false) {
            return;
        }

        $this->mutex->acquire($action->getKey())->then(function ($lock) use ($action) {
            if ($lock === false) {
                return;
            }

            return $action->perform()->then(function () use ($action, $lock) {
                return $this->mutex->release($lock);
            });
        })->done();
    }
}


1		<?php declare(strict_types=1);
2
3		namespace WyriHaximus\React;
4
5		use React\EventLoop\LoopInterface;
6		use WyriHaximus\React\Mutex\Memory;
7		use WyriHaximus\React\Mutex\MutexInterface;
8
9		final class Cron
10		{
11		/** @var ActionInterface[] */
12		private $actions;
13
14		/** @var MutexInterface */
15		private $mutex;
16
17		/**
18		* @param SchedulerInterface $scheduler
19		* @param MutexInterface $mutex
20		* @param ActionInterface[] $actions
21		*/
22	2	private function __construct(SchedulerInterface $scheduler, MutexInterface $mutex, ActionInterface ...$actions)
23		{
24	2	$this->actions = $actions;
		0 ignored issues – show Documentation Bug introduced 2019-02-22 07:00 UTC by Report Bug Copy Issue Report It seems like `$actions` of type `array<integer,array<inte...eact\ActionInterface>>>` is incompatible with the declared type `array<integer,object<Wyr...React\ActionInterface>>` of property `$actions`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
25	2	$this->mutex = $mutex;
26
27		$scheduler->schedule(function (): void {
28	2	$this->tick();
29	2	});
30	2	}
31
32	2	public static function create(LoopInterface $loop, ActionInterface ...$actions)
33		{
34	2	return new self(new Scheduler($loop), new Memory(), ...$actions);
35		}
36
37	2	private function tick(): void
38		{
39	2	foreach ($this->actions as $action) {
40	2	$this->perform($action);
41		}
42	2	}
43
44	2	private function perform(ActionInterface $action): void
45		{
46	2	if ($action->isDue() === false) {
47		return;
48		}
49
50		$this->mutex->acquire($action->getKey())->then(function ($lock) use ($action) {
51	2	if ($lock === false) {
52		return;
53		}
54
55		return $action->perform()->then(function () use ($action, $lock) {
56	2	return $this->mutex->release($lock);
57	2	});
58	2	})->done();
59	2	}
60		}
61

WyriHaximus / reactphp-cron

GitHub Access Token became invalid

Push — master ( d39c6b...1e41a0 )

Cron::perform() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like