SecureLine::fromLine() - Code Metrics - Inspection of "Updated factory to use the correct filename" - WyriHaximus/reactphp-child-process-messenger - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6ef5d2...d19825 )

by Cees-Jan

created 2015-12-27 12:31 UTC

SecureLine::fromLine() A

↳ Parent: SecureLine

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	8
ccs	4
cts	4
cp	1
rs	9.4286
cc	2
eloc	4
nc	2
nop	2
crap	2

<?php

namespace WyriHaximus\React\ChildProcess\Messenger\Messages;

class SecureLine implements LineInterface
{
    /**
     * @var Line
     */
    protected $line;

    /**
     * @var string
     */
    protected $key;

    /**
     * @param \JsonSerializable $line
     * @param array $options
     */
    public function __construct(\JsonSerializable $line, array $options)
    {
        $this->line = $line;

        $this->key  = $options['key'];
    }

    /**
     * @return string
     */
    public function __toString()
    {
        $line = json_encode($this->line);
        return json_encode([
            'type' => 'secure',
            'line' => $line,
            'signature' => base64_encode(static::sign($line, $this->key)),
        ]) . LineInterface::EOL;
    }

    protected static function sign($line, $key)
    {
        return hash_hmac('sha256', $line, $key, true);
    }

    protected static function validate($signature, $line, $key)
    {
        return hash_equals($signature, static::sign($line, $key));
    }

    public static function fromLine($line, array $lineOptions)
    {
        if (static::validate(base64_decode($line['signature']), $line['line'], $lineOptions['key'])) {
            return Factory::fromLine($line['line'], $lineOptions);
        }

        throw new \Exception('Signature mismatch!');
    }
}


1		<?php
2
3		namespace WyriHaximus\React\ChildProcess\Messenger\Messages;
4
5		class SecureLine implements LineInterface
6		{
7		/**
8		* @var Line
9		*/
10		protected $line;
11
12		/**
13		* @var string
14		*/
15		protected $key;
16
17		/**
18		* @param \JsonSerializable $line
19		* @param array $options
20		*/
21	2	public function __construct(\JsonSerializable $line, array $options)
22		{
23	2	$this->line = $line;
		0 ignored issues – show Documentation Bug introduced 2015-11-21 19:02 UTC by Report Bug Copy Issue Report It seems like `$line` of type `object<JsonSerializable>` is incompatible with the declared type `object<WyriHaximus\React...essenger\Messages\Line>` of property `$line`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
24	2	$this->key = $options['key'];
25	2	}
26
27		/**
28		* @return string
29		*/
30	2	public function __toString()
31		{
32	2	$line = json_encode($this->line);
33	2	return json_encode([
34	2	'type' => 'secure',
35	2	'line' => $line,
36	2	'signature' => base64_encode(static::sign($line, $this->key)),
37	2	]) . LineInterface::EOL;
38		}
39
40	4	protected static function sign($line, $key)
41		{
42	4	return hash_hmac('sha256', $line, $key, true);
43		}
44
45	4	protected static function validate($signature, $line, $key)
46		{
47	4	return hash_equals($signature, static::sign($line, $key));
48		}
49
50	4	public static function fromLine($line, array $lineOptions)
51		{
52	4	if (static::validate(base64_decode($line['signature']), $line['line'], $lineOptions['key'])) {
53	3	return Factory::fromLine($line['line'], $lineOptions);
54		}
55
56	1	throw new \Exception('Signature mismatch!');
57		}
58		}
59

WyriHaximus / reactphp-child-process-messenger

GitHub Access Token became invalid

Push — master ( 6ef5d2...d19825 )

SecureLine::fromLine() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like