WyriHaximus\Travis\IteratorTrait

Complexity

Total Complexity

10

Size/Duplication

Total Lines	55
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes	1
Bugs	0	Features	1

8 Methods

Rating	Name	Duplication	Size	Complexity
A	getData()	0	9	2
A	key()	0	4	1
A	current()	0	4	1
A	next()	0	4	1
A	prev()	0	4	1
A	rewind()	0	4	1
A	valid()	0	4	1
A	seek()	0	8	2

<?php

namespace WyriHaximus\Travis;

/**
 * @source https://github.com/jeremeamia/php-design-patterns/blob/master/src/Jeremeamia/PhpPatterns/Structural/Collection/IteratorTrait.php
 */
trait IteratorTrait
{
    private $container;

    protected function getData()
    {
        if ($this->container !== null) {
            return $this->container;
        }

        $this->container = $this->getClient()->request($this)->getIterator()->getArrayCopy();

It seems like getClient() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        return $this->container;
    }

    protected $position = 0;

    public function key()
    {
        return $this->position;
    }

    public function current()
    {
        return $this->getData()[$this->position];
    }

    public function next()
    {
        return $this->position++;
    }

    public function prev()
    {
        return $this->position--;
    }

    public function rewind()
    {
        return $this->position = 0;
    }

    public function valid()
    {
        return array_key_exists($this->position, $this->getData());
    }

    public function seek($position)
    {
        $this->position = $position;

        if (!$this->valid()) {
            throw new \OutOfBoundsException("The key [{$position}] does not exist.");
        }
    }
}