These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more
1 | <?php |
||
2 | declare(strict_types=1); |
||
3 | |||
4 | namespace WyriHaximus\Travis\Resource\Sync; |
||
5 | |||
6 | use Rx\Observable; |
||
7 | use Rx\React\Promise; |
||
8 | use WyriHaximus\Travis\Resource\Repository as BaseRepository; |
||
9 | use function Clue\React\Block\await; |
||
10 | use function React\Promise\resolve; |
||
11 | |||
12 | View Code Duplication | class Repository extends BaseRepository |
|
0 ignored issues
–
show
|
|||
13 | { |
||
14 | public function builds(): array |
||
15 | { |
||
16 | return await( |
||
17 | Promise::fromObservable( |
||
18 | $this->getTransport()->getHydrator()->buildAsyncFromSync('Repository', $this)->builds()->toArray() |
||
0 ignored issues
–
show
It seems like you code against a concrete implementation and not the interface
WyriHaximus\Travis\Resource\ResourceInterface as the method builds() does only exist in the following implementations of said interface: WyriHaximus\Travis\Resource\Async\Repository , WyriHaximus\Travis\Resource\Sync\Repository .
Let’s take a look at an example: interface User
{
/** @return string */
public function getPassword();
}
class MyUser implements User
{
public function getPassword()
{
// return something
}
public function getDisplayName()
{
// return some name.
}
}
class AuthSystem
{
public function authenticate(User $user)
{
$this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
// do something.
}
}
In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes
Note: PHP Analyzer uses reverse abstract interpretation to narrow down the types
inside the if block in such a case.
Loading history...
|
|||
19 | ), |
||
20 | $this->getTransport()->getLoop() |
||
21 | ); |
||
22 | } |
||
23 | |||
24 | public function build(int $id): Build |
||
25 | { |
||
26 | return await( |
||
27 | $this->getTransport()->getHydrator()->buildAsyncFromSync('Repository', $this)->build($id), |
||
0 ignored issues
–
show
It seems like you code against a concrete implementation and not the interface
WyriHaximus\Travis\Resource\ResourceInterface as the method build() does only exist in the following implementations of said interface: WyriHaximus\Travis\Resource\Async\Repository , WyriHaximus\Travis\Resource\Sync\Repository .
Let’s take a look at an example: interface User
{
/** @return string */
public function getPassword();
}
class MyUser implements User
{
public function getPassword()
{
// return something
}
public function getDisplayName()
{
// return some name.
}
}
class AuthSystem
{
public function authenticate(User $user)
{
$this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
// do something.
}
}
In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes
Note: PHP Analyzer uses reverse abstract interpretation to narrow down the types
inside the if block in such a case.
Loading history...
|
|||
28 | $this->getTransport()->getLoop() |
||
29 | ); |
||
30 | } |
||
31 | } |
||
32 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.