Job::refresh() - Code Metrics - Inspection of "Merge pull request #27 from WyriHaximus/feature-re..." - WyriHaximus/php-travis-client - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( db0197...4ce89b )

by Cees-Jan

created 2016-11-15 05:36 UTC

Job::refresh() A

↳ Parent: Job

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	6
ccs	0
cts	2
cp	0
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	3
nc	1
nop	0
crap	2

<?php
declare(strict_types=1);

namespace WyriHaximus\Travis\Resource\Async;

use Rx\Observable;
use Rx\ObservableInterface;
use Rx\React\Promise;
use React\Promise\PromiseInterface;
use WyriHaximus\Travis\Resource\Job as BaseJob;
use function React\Promise\resolve;

class Job extends BaseJob
{
    /**
     * @return ObservableInterface
     */
    public function annotations(): ObservableInterface

    {
        return Promise::toObservable(
            $this->getTransport()->request('jobs/' . $this->id() . '/annotations')
        )->flatMap(function ($response) {
            return Observable::fromArray($response['annotations']);
        })->map(function ($annotation) {
            return $this->getTransport()->getHydrator()->hydrate('Annotation', $annotation);
        });
    }

    /**
     * @return PromiseInterface
     */
    public function refresh(): PromiseInterface
    {
        return $this->getTransport()->request('jobs/' . $this->id)->then(function ($json) {
            return resolve($this->getTransport()->getHydrator()->hydrate('Job', $json['job']));
        });
    }
}


1		<?php
2		declare(strict_types=1);
3
4		namespace WyriHaximus\Travis\Resource\Async;
5
6		use Rx\Observable;
7		use Rx\ObservableInterface;
8		use Rx\React\Promise;
9		use React\Promise\PromiseInterface;
10		use WyriHaximus\Travis\Resource\Job as BaseJob;
11		use function React\Promise\resolve;
12
13		class Job extends BaseJob
14		{
15		/**
16		* @return ObservableInterface
17		*/
18	View Code Duplication	public function annotations(): ObservableInterface
		0 ignored issues – show Duplication introduced 2016-07-02 22:00 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
19		{
20		return Promise::toObservable(
21		$this->getTransport()->request('jobs/' . $this->id() . '/annotations')
22		)->flatMap(function ($response) {
23		return Observable::fromArray($response['annotations']);
24		})->map(function ($annotation) {
25		return $this->getTransport()->getHydrator()->hydrate('Annotation', $annotation);
26		});
27		}
28
29		/**
30		* @return PromiseInterface
31		*/
32		public function refresh(): PromiseInterface
33		{
34		return $this->getTransport()->request('jobs/' . $this->id)->then(function ($json) {
35		return resolve($this->getTransport()->getHydrator()->hydrate('Job', $json['job']));
36		});
37		}
38		}
39

WyriHaximus / php-travis-client

GitHub Access Token became invalid

Push — master ( db0197...4ce89b )

Job::refresh() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like