Build::jobs() - Code Metrics - WyriHaximus/php-travis-client - Measure and Improve Code Quality continuously with Scrutinizer

Build::jobs() A
last analyzed 2016-12-04 12:13 UTC

↳ Parent: Build

Complexity

Conditions	1
Paths	1

Size

Total Lines	10
Code Lines	7

Duplication

Lines	10
Ratio	100 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	10
loc	10
rs	9.4285
c	0
b	0
f	0
ccs	0
cts	2
cp	0
cc	1
eloc	7
nc	1
nop	0
crap	2

<?php
declare(strict_types=1);

namespace WyriHaximus\Travis\Resource\Async;

use ApiClients\Foundation\Hydrator\CommandBus\Command\HydrateCommand;
use ApiClients\Foundation\Transport\CommandBus\Command\SimpleRequestCommand;
use Psr\Http\Message\ResponseInterface;
use React\Promise\PromiseInterface;
use Rx\Observable;
use Rx\ObservableInterface;
use Rx\React\Promise;
use WyriHaximus\Travis\Resource\Build as BaseBuild;
use function React\Promise\resolve;

class Build extends BaseBuild
{
    /**
     * @return ObservableInterface
     */
    public function jobs(): ObservableInterface

    {
        return Promise::toObservable(
            $this->handleCommand(new SimpleRequestCommand('builds/' . $this->id()))
        )->flatMap(function ($response) {
            return Observable::fromArray($response->getBody()->getJson()['jobs']);
        })->flatMap(function ($job) {
            return Promise::toObservable($this->handleCommand(new HydrateCommand('Job', $job)));
        });
    }

    /**
     * @param int $id
     * @return PromiseInterface
     */
    public function job(int $id): PromiseInterface

    {
        return $this->handleCommand(
            new SimpleRequestCommand('jobs/' . $id)
        )->then(function (ResponseInterface $response) {
            return $this->handleCommand(
                new HydrateCommand('Job', $response->getBody()->getJson()['job'])
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            );
        });
    }

    public function refresh(): PromiseInterface

    {
        return $this->handleCommand(
            new SimpleRequestCommand('builds/' . $this->id)
        )->then(function (ResponseInterface $response) {
            return resolve($this->handleCommand(
                new SimpleRequestCommand('Build', $response->getBody()->getJson()['build'])
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            ));
        });
    }
}


GitHub Access Token became invalid

Build::jobs() A
last analyzed 2016-12-04 12:13 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

1		<?php
2		declare(strict_types=1);
3
4		namespace WyriHaximus\Travis\Resource\Async;
5
6		use ApiClients\Foundation\Hydrator\CommandBus\Command\HydrateCommand;
7		use ApiClients\Foundation\Transport\CommandBus\Command\SimpleRequestCommand;
8		use Psr\Http\Message\ResponseInterface;
9		use React\Promise\PromiseInterface;
10		use Rx\Observable;
11		use Rx\ObservableInterface;
12		use Rx\React\Promise;
13		use WyriHaximus\Travis\Resource\Build as BaseBuild;
14		use function React\Promise\resolve;
15
16		class Build extends BaseBuild
17		{
18		/**
19		* @return ObservableInterface
20		*/
21	View Code Duplication	public function jobs(): ObservableInterface
		0 ignored issues – show Duplication introduced 2016-05-07 16:01 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
22		{
23		return Promise::toObservable(
24		$this->handleCommand(new SimpleRequestCommand('builds/' . $this->id()))
25		)->flatMap(function ($response) {
26		return Observable::fromArray($response->getBody()->getJson()['jobs']);
27		})->flatMap(function ($job) {
28		return Promise::toObservable($this->handleCommand(new HydrateCommand('Job', $job)));
29		});
30		}
31
32		/**
33		* @param int $id
34		* @return PromiseInterface
35		*/
36	View Code Duplication	public function job(int $id): PromiseInterface
		0 ignored issues – show Duplication introduced 2016-05-08 19:23 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
37		{
38		return $this->handleCommand(
39		new SimpleRequestCommand('jobs/' . $id)
40		)->then(function (ResponseInterface $response) {
41		return $this->handleCommand(
42		new HydrateCommand('Job', $response->getBody()->getJson()['job'])
		0 ignored issues – show Bug introduced 2016-12-04 00:23 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Psr\Http\Message\StreamInterface` as the method `getJson()` does only exist in the following implementations of said interface: `ApiClients\Foundation\Transport\JsonStream`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
43		);
44		});
45		}
46
47	View Code Duplication	public function refresh(): PromiseInterface
		0 ignored issues – show Duplication introduced 2016-12-04 00:23 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
48		{
49		return $this->handleCommand(
50		new SimpleRequestCommand('builds/' . $this->id)
51		)->then(function (ResponseInterface $response) {
52		return resolve($this->handleCommand(
53		new SimpleRequestCommand('Build', $response->getBody()->getJson()['build'])
		0 ignored issues – show Bug introduced 2016-12-04 00:23 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Psr\Http\Message\StreamInterface` as the method `getJson()` does only exist in the following implementations of said interface: `ApiClients\Foundation\Transport\JsonStream`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
54		));
55		});
56		}
57		}
58

WyriHaximus / php-travis-client

GitHub Access Token became invalid

Build::jobs() A last analyzed 2016-12-04 12:13 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

Build::jobs() A
last analyzed 2016-12-04 12:13 UTC