ObservableWhile::get() - Code Metrics - Inspection of "Resolve a promise with `void` when onCompleted is..." - WyriHaximus/php-rxphp-recoilphp-looper - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7f56d3...784cca )

by Cees-Jan

created 2018-08-02 06:07 UTC

ObservableWhile::get() A

↳ Parent: ObservableWhile

Complexity

Conditions	4
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	4

Importance

Changes

Metric	Value
cc	4
nc	3
nop	0
dl	0
loc	14
ccs	7
cts	7
cp	1
crap	4
rs	9.7998
c	0
b	0
f	0

<?php declare(strict_types=1);

namespace WyriHaximus\Rx;

use React\Promise\Deferred;
use React\Promise\PromiseInterface;
use Rx\ObservableInterface;
use function React\Promise\resolve;

final class ObservableWhile
{
    /**
     * @var array
     */
    private $queue = [];

    /**
     * @var Deferred
     */
    private $deferred;

    /**
     * @var bool
     */
    private $done = false;

    /**
     * @param ObservableInterface $observable
     */
    public function __construct(ObservableInterface $observable)
    {
        $observable->subscribe(function ($item) {
            if ($this->deferred instanceof Deferred) {
                $this->deferred->resolve($item);
                $this->deferred = null;

                return;
            }

            $this->queue[] = $item;
        }, null, function () {
            $this->done = true;

            if ($this->deferred instanceof Deferred) {
                $this->deferred->resolve();
                $this->deferred = null;
            }
        });
    }

    public function get(): PromiseInterface
    {
        if (count($this->queue) === 0 && $this->done === true) {
            return resolve();
        }

        if (count($this->queue) === 0) {
            $this->deferred = new Deferred();

            return $this->deferred->promise();
        }

        return resolve(array_shift($this->queue));
    }
}


1		<?php declare(strict_types=1);
2
3		namespace WyriHaximus\Rx;
4
5		use React\Promise\Deferred;
6		use React\Promise\PromiseInterface;
7		use Rx\ObservableInterface;
8		use function React\Promise\resolve;
9
10		final class ObservableWhile
11		{
12		/**
13		* @var array
14		*/
15		private $queue = [];
16
17		/**
18		* @var Deferred
19		*/
20		private $deferred;
21
22		/**
23		* @var bool
24		*/
25		private $done = false;
26
27		/**
28		* @param ObservableInterface $observable
29		*/
30		public function __construct(ObservableInterface $observable)
31		{
32	1	$observable->subscribe(function ($item) {
33	1	if ($this->deferred instanceof Deferred) {
34		$this->deferred->resolve($item);
35		$this->deferred = null;
36
37		return;
38		}
39
40	1	$this->queue[] = $item;
41		}, null, function () {
42	2	$this->done = true;
43
44	2	if ($this->deferred instanceof Deferred) {
45	1	$this->deferred->resolve();
46	1	$this->deferred = null;
47		}
48	2	});
49	2	}
50
51	2	public function get(): PromiseInterface
52		{
53	2	if (count($this->queue) === 0 && $this->done === true) {
54	1	return resolve();
55		}
56
57	2	if (count($this->queue) === 0) {
58	1	$this->deferred = new Deferred();
59
60	1	return $this->deferred->promise();
61		}
62
63	1	return resolve(array_shift($this->queue));
64		}
65		}
66

WyriHaximus / php-rxphp-recoilphp-looper

GitHub Access Token became invalid

Push — master ( 7f56d3...784cca )

ObservableWhile::get() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like