WyriHaximus / cakephp-async-orm

src/WorkerChild.php

<?php declare(strict_types=1);

namespace WyriHaximus\React\Cake\Orm;

use Cake\Cache\Cache;
use Cake\Core\Configure;
use Cake\Datasource\ConnectionManager;
use Cake\Datasource\Exception\PageOutOfBoundsException;
use Cake\Datasource\Paginator;
use Cake\ORM\Query;
use Cake\ORM\TableRegistry;
use React\EventLoop\LoopInterface;
use React\Promise\Deferred;
use function React\Promise\resolve;
use WyriHaximus\React\ChildProcess\Messenger\ChildInterface;
use WyriHaximus\React\ChildProcess\Messenger\Messages\Payload;
use WyriHaximus\React\ChildProcess\Messenger\Messenger;
use function WyriHaximus\React\futurePromise;

final class WorkerChild implements ChildInterface
{
    private $messenger;
    private $loop;

    /**
     * WorkerChild constructor.
     */
    public function __construct(Messenger $messenger, LoopInterface $loop)
    {
        $this->messenger = $messenger;
        $this->loop = $loop;

        $this->messenger->registerRpc('table.call', function (Payload $payload) {
            $deferred = new Deferred();
            $this->loop->futureTick(function () use ($payload, $deferred) {
                $this->handleTableCall($payload, $deferred);
            });

            return $deferred->promise();
        });

        $this->messenger->registerRpc('paginate', function (Payload $payload) {
            return futurePromise($this->loop, $payload)->then(function ($payload) {
                return $this->handlePaginateCall($payload);
            });
        });
    }

    /**
     * @inheritDoc
     */
    public static function create(Messenger $messenger, LoopInterface $loop)
    {
        require dirname(dirname(dirname(dirname(__DIR__)))) . '/config/paths.php';
        require CORE_PATH . 'config' . DS . 'bootstrap.php';
        Configure::config('default', new Configure\Engine\PhpConfig());
        Configure::load('app', 'default', false);
        Cache::setConfig(Configure::consume('Cache'));

It seems like \Cake\Core\Configure::consume('Cache') targeting Cake\Core\Configure::consume() can also be of type null; however, Cake\Core\StaticConfigTrait::setConfig() does only seem to accept string|array, maybe add an additional type check?

        ConnectionManager::setConfig(Configure::consume('Datasources'));

It seems like \Cake\Core\Configure::consume('Datasources') targeting Cake\Core\Configure::consume() can also be of type null; however, Cake\Datasource\ConnectionManager::setConfig() does only seem to accept string|array, maybe add an additional type check?

        return new self($messenger, $loop);
    }

    /**
     * @param Payload  $payload
     * @param Deferred $deferred
     */
    protected function handleTableCall(Payload $payload, Deferred $deferred)
    {
        $result = call_user_func_array([
            TableRegistry::get(

The method Cake\ORM\TableRegistry::get() has been deprecated with message: 3.6.0 Use \Cake\ORM\Locator\TableLocator::get() instead.

                $payload['table']/*,

68% of this comment could be valid code. Did you maybe forget this after debugging?

                [
                    'className' => $payload['className'],
                    'table' => $payload['table'],
                ]*/
            ),
            $payload['function'],
        ], unserialize($payload['arguments']));

        if (!($result instanceof Query)) {
            $deferred->resolve([
                'result' => serialize($result),
            ]);

            return;
        }

        foreach ($result->all() as $row) {
            $deferred->notify([

The method React\Promise\Deferred::notify() has been deprecated with message: 2.6.0 Progress support is deprecated and should not be used anymore.

                'row' => $row,
            ]);
        }

        $deferred->resolve();
    }

    /**
     * @param Payload  $payload
     * @param Deferred $deferred

There is no parameter named $deferred. Was it maybe removed?

     */
    protected function handlePaginateCall(Payload $payload)
    {
        $object = TableRegistry::get(

The method Cake\ORM\TableRegistry::get() has been deprecated with message: 3.6.0 Use \Cake\ORM\Locator\TableLocator::get() instead.

            $payload['table']/*,

68% of this comment could be valid code. Did you maybe forget this after debugging?

                [
                    'className' => $payload['className'],
                    'table' => $payload['table'],
                ]*/
        );
        $paginator = new Paginator();

        try {
            $items = $paginator->paginate($object, $payload['params'], $payload['settings'])->toArray();
            $eos = false;
        } catch (PageOutOfBoundsException $pageOutOfBoundsException) {
            $items = [];
            $eos = true;
        }

        return resolve([
            'items' => $items,
            'eos' => $eos,
            'pagingParams' => $paginator->getPagingParams(),
        ]);
    }
}