AsyncTableRegistry::get() - Code Metrics - Inspection of "AsyncTableRegistry tests" - WyriHaximus/cakephp-async-orm - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 60e9af...3a9521 )

by Cees-Jan

created 2016-03-27 16:52 UTC

AsyncTableRegistry::get() A

↳ Parent: AsyncTableRegistry

Complexity

Conditions	2
Paths	2

Size

Total Lines	13
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	2

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	13
ccs	9
cts	9
cp	1
rs	9.4285
cc	2
eloc	8
nc	2
nop	1
crap	2

<?php

namespace WyriHaximus\React\Cake\Orm;

use Cake\Core\App;
use React\EventLoop\LoopInterface;
use WyriHaximus\React\ChildProcess\Pool\PoolUtilizerInterface;

class AsyncTableRegistry implements PoolUtilizerInterface
{
    /**
     * @var AsyncTable[]
     */
    protected static $tables = [];

    /**
     * @param LoopInterface $loop
     */
    public static function init(LoopInterface $loop)
    {
        Pool::getInstance($loop);
    }

    /**
     * @param $tableName
     *
     * @return AsyncTable
     */
    public static function get($tableName)
    {
        if (isset(static::$tables[$tableName])) {
            return static::$tables[$tableName];
        }

        static::$tables[$tableName] = new AsyncTable(
            Pool::getInstance(),
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
            $tableName,
            App::className($tableName, 'Model/Table', 'Table')
        );
        return static::$tables[$tableName];
    }

    public static function getInstance()
    {
        static $instance = null;
        if (null === $instance) {
            $instance = new static();
        }

        return $instance;
    }

    public static function reset()
    {
        static $instance = null;
    }

    /**
     * @inheritDoc
     */
    public function info()
    {
        return Pool::getInstance()->info();
    }
}


1		<?php
2
3		namespace WyriHaximus\React\Cake\Orm;
4
5		use Cake\Core\App;
6		use React\EventLoop\LoopInterface;
7		use WyriHaximus\React\ChildProcess\Pool\PoolUtilizerInterface;
8
9		class AsyncTableRegistry implements PoolUtilizerInterface
10		{
11		/**
12		* @var AsyncTable[]
13		*/
14		protected static $tables = [];
15
16		/**
17		* @param LoopInterface $loop
18		*/
19	2	public static function init(LoopInterface $loop)
20		{
21	2	Pool::getInstance($loop);
22	2	}
23
24		/**
25		* @param $tableName
26		*
27		* @return AsyncTable
28		*/
29	1	public static function get($tableName)
30		{
31	1	if (isset(static::$tables[$tableName])) {
32	1	return static::$tables[$tableName];
33		}
34
35	1	static::$tables[$tableName] = new AsyncTable(
36	1	Pool::getInstance(),
		0 ignored issues – show Bug introduced 2016-03-02 20:10 UTC by Report Bug Copy Issue Report It seems like `\WyriHaximus\React\Cake\Orm\Pool::getInstance()` can be `null`; however, `__construct()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
37	1	$tableName,
38	1	App::className($tableName, 'Model/Table', 'Table')
39	1	);
40	1	return static::$tables[$tableName];
41		}
42
43	3	public static function getInstance()
44		{
45	3	static $instance = null;
46	3	if (null === $instance) {
47	1	$instance = new static();
48	1	}
49
50	3	return $instance;
51		}
52
53	18	public static function reset()
54		{
55	18	static $instance = null;
56	18	}
57
58		/**
59		* @inheritDoc
60		*/
61	1	public function info()
62		{
63	1	return Pool::getInstance()->info();
64		}
65		}
66

WyriHaximus / cakephp-async-orm

Push — master ( 60e9af...3a9521 )

AsyncTableRegistry::get() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like