WyriHaximus\React\Cake\Orm\AsyncTableRegistry

Complexity

Total Complexity

10

Size/Duplication

Total Lines	78
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	3

Test Coverage

Coverage

70%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	init()	0	4	1
A	reset()	0	4	1
A	info()	0	4	1
B	get()	0	23	4
A	getInstance()	0	9	3

<?php

namespace WyriHaximus\React\Cake\Orm;

use Cake\Core\App;
use React\EventLoop\LoopInterface;
use WyriHaximus\React\ChildProcess\Pool\PoolUtilizerInterface;

class AsyncTableRegistry implements PoolUtilizerInterface
{
    /**
     * @var AsyncTable[]
     */
    protected static $tables = [];

    /**
     * @var AsyncTableRegistry
     */
    protected static $instance = null;

    /**
     * @var boolean
     */
    protected static $reset = false;

    /**
     * @param LoopInterface $loop
     * @param array $config
     */
    public static function init(LoopInterface $loop, array $config = [])
    {
        Pool::getInstance($loop, $config);
    }

    /**
     * @param $tableName
     *
     * @return AsyncTable

The return type AsyncTable is a trait, and thus cannot be used for type-hinting in PHP. Maybe consider adding an interface and use that for type-hinting?

     */
    public static function get($tableName)
    {
        if (is_array($tableName)) {
            $tableName = $tableName['class'];
        }

        if (isset(static::$tables[$tableName])) {
            return static::$tables[$tableName];
        }

        $table = new $tableName();

        if ($table instanceof AsyncTableInterface) {
            $table->setUpAsyncTable(
                Pool::getInstance(),
                $tableName,
                App::className($tableName, 'Model/Table', 'Table')

It seems like \Cake\Core\App::className($tableName, 'Model/Table', 'Table') targeting Cake\Core\App::className() can also be of type false; however, WyriHaximus\React\Cake\Orm\AsyncTableInterface::setUpAsyncTable() does only seem to accept string, did you maybe forget to handle an error condition?

            );
        }

        static::$tables[$tableName] = $table;
        return static::$tables[$tableName];
    }

    public static function getInstance()
    {
        if (null === self::$instance || self::$reset) {
            self::$instance = new static();
            self::$reset = false;
        }

        return self::$instance;
    }

    public static function reset()
    {
        self::$reset = true;
    }

    /**
     * @inheritDoc
     */
    public function info()
    {
        return Pool::getInstance()->info();
    }
}