Issues in TreeScanner.php (master) - Issues in master - WyriHaximus/TwigView - Measure and Improve Code Quality continuously with Scrutinizer

Issues (16)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Lib/TreeScanner.php (3 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
declare(strict_types=1);

namespace WyriHaximus\TwigView\Lib;

/**
 * Class TreeScanner.
 * @package WyriHaximus\TwigView\Lib
 */
final class TreeScanner
{
    /**
     * Return all sections (app & plugins) with an Template directory.
     *
     * @return array
     */
    public static function all(): array
    {
        return static::deepen(RelativeScanner::all());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * Return all templates for a given plugin.
     *
     * @param string $plugin The plugin to find all templates for.
     *
     * @return mixed
     */
    public static function plugin($plugin)
    {
        return static::deepen([
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $plugin => RelativeScanner::plugin($plugin),
        ])[$plugin];
    }

    /**
     * Strip the absolute path of template's paths for all given sections.
     *
     * @param string $sections Sections to iterate over.
     *
     * @return array
     */
    protected static function deepen($sections): array
    {
        foreach ($sections as $section => $paths) {

            $sections[$section] = static::convertToTree($paths);
        }

        return $sections;
    }

    /**
     * Turn a set of paths into a tree.
     *
     * @param array $paths Paths to turn into a tree.
     *
     * @return array
     */
    protected static function convertToTree(array $paths): array
    {
        foreach ($paths as $index => $path) {
            static::convertPathToTree($paths, $index, $path);
        }

        return $paths;
    }

    /**
     * Convert a path into a tree when it contains a directory separator.
     *
     * @param array  $paths The paths to work on.
     * @param mixed  $index Index of $path.
     * @param string $path  Path to breakup and turn into a tree.
     *
     */
    protected static function convertPathToTree(array &$paths, $index, $path)
    {
        if (strpos($path, DIRECTORY_SEPARATOR) !== false) {
            $chunks = explode(DIRECTORY_SEPARATOR, $path);
            $paths = static::branch($paths, $chunks);
            unset($paths[$index]);
        }
    }

    /**
     * Create a branch for the current level and push a twig on it.
     *
     * @param array $paths    Paths to append.
     * @param array $branches Branches to use untill only one left.
     *
     * @return array
     */
    protected static function branch(array $paths, array $branches): array
    {
        $twig = array_shift($branches);
        if (count($branches) == 0) {
            $paths[] = $twig;

            return $paths;
        }

        if (!isset($paths[$twig])) {
            $paths[$twig] = [];
        }

        $paths[$twig] = static::branch($paths[$twig], $branches);

        return $paths;
    }
}


1		<?php
2		declare(strict_types=1);
3
4		namespace WyriHaximus\TwigView\Lib;
5
6		/**
7		* Class TreeScanner.
8		* @package WyriHaximus\TwigView\Lib
9		*/
10		final class TreeScanner
11		{
12		/**
13		* Return all sections (app & plugins) with an Template directory.
14		*
15		* @return array
16		*/
17	2	public static function all(): array
18		{
19	2	return static::deepen(RelativeScanner::all());
		0 ignored issues – show Documentation introduced 2017-09-11 21:58 UTC by Report Bug Copy Issue Report Show Similar Issues like this `\WyriHaximus\TwigView\Lib\RelativeScanner::all()` is of type `array`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
20		}
21
22		/**
23		* Return all templates for a given plugin.
24		*
25		* @param string $plugin The plugin to find all templates for.
26		*
27		* @return mixed
28		*/
29	1	public static function plugin($plugin)
30		{
31	1	return static::deepen([
		0 ignored issues – show Documentation introduced 2017-09-11 21:58 UTC by Report Bug Copy Issue Report Show Similar Issues like this `array($plugin => \WyriHa...anner::plugin($plugin))` is of type `array<string,*>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
32	1	$plugin => RelativeScanner::plugin($plugin),
33	1	])[$plugin];
34		}
35
36		/**
37		* Strip the absolute path of template's paths for all given sections.
38		*
39		* @param string $sections Sections to iterate over.
40		*
41		* @return array
42		*/
43	3	protected static function deepen($sections): array
44		{
45	3	foreach ($sections as $section => $paths) {
		0 ignored issues – show Bug introduced 2015-12-16 16:24 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$sections` of type `string` is not traversable. Loading history...
46	3	$sections[$section] = static::convertToTree($paths);
47		}
48
49	3	return $sections;
50		}
51
52		/**
53		* Turn a set of paths into a tree.
54		*
55		* @param array $paths Paths to turn into a tree.
56		*
57		* @return array
58		*/
59	3	protected static function convertToTree(array $paths): array
60		{
61	3	foreach ($paths as $index => $path) {
62	3	static::convertPathToTree($paths, $index, $path);
63		}
64
65	3	return $paths;
66		}
67
68		/**
69		* Convert a path into a tree when it contains a directory separator.
70		*
71		* @param array $paths The paths to work on.
72		* @param mixed $index Index of $path.
73		* @param string $path Path to breakup and turn into a tree.
74		*
75		*/
76	3	protected static function convertPathToTree(array &$paths, $index, $path)
77		{
78	3	if (strpos($path, DIRECTORY_SEPARATOR) !== false) {
79	3	$chunks = explode(DIRECTORY_SEPARATOR, $path);
80	3	$paths = static::branch($paths, $chunks);
81	3	unset($paths[$index]);
82		}
83	3	}
84
85		/**
86		* Create a branch for the current level and push a twig on it.
87		*
88		* @param array $paths Paths to append.
89		* @param array $branches Branches to use untill only one left.
90		*
91		* @return array
92		*/
93	3	protected static function branch(array $paths, array $branches): array
94		{
95	3	$twig = array_shift($branches);
96	3	if (count($branches) == 0) {
97	3	$paths[] = $twig;
98
99	3	return $paths;
100		}
101
102	3	if (!isset($paths[$twig])) {
103	3	$paths[$twig] = [];
104		}
105
106	3	$paths[$twig] = static::branch($paths[$twig], $branches);
107
108	3	return $paths;
109		}
110		}
111

WyriHaximus / TwigView

Issues (16)

Security Analysis no request data

src/Lib/TreeScanner.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like