RelativeScanner::stripAbsolutePath() - Code Metrics - Inspection of "Better Exceptions handling" - WyriHaximus/TwigView - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#33)

by Yves

created 2016-08-17 12:28 UTC

RelativeScanner::stripAbsolutePath() A

↳ Parent: RelativeScanner

Complexity

Conditions	3
Paths	2

Size

Total Lines	12
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	4.5435

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	12
ccs	4
cts	9
cp	0.4444
rs	9.4285
cc	3
eloc	6
nc	2
nop	2
crap	4.5435

<?php

namespace WyriHaximus\TwigView\Lib;

use Cake\Core\App;

/**
 * Class RelativeScanner
 * @package WyriHaximus\TwigView\Lib
 */
class RelativeScanner
{
    /**
     * Return all sections (app & plugins) with an Template directory.
     *
     * @return array
     */
    public static function all()
    {
        return static::strip(Scanner::all());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * Return all templates for a given plugin.
     *
     * @param string $plugin The plugin to find all templates for.
     *
     * @return mixed
     */
    public static function plugin($plugin)
    {
        return static::strip([
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $plugin => Scanner::plugin($plugin),
        ])[$plugin];
    }

    /**
     * Strip the absolute path of template's paths for all given sections.
     *
     * @param string $sections Sections to iterate over.
     *
     * @return array
     */
    protected static function strip($sections)
    {
        foreach ($sections as $section => $paths) {

            $sections[$section] = static::stripAbsolutePath($paths, $section == 'APP' ? null : $section);
        }
        return $sections;
    }

    /**
     * Strip the absolute path of template's paths.
     *
     * @param array       $paths  Paths to strip.
     * @param string|null $plugin Hold plugin name or null for App.
     *
     * @return array
     */
    protected static function stripAbsolutePath(array $paths, $plugin = null)
    {
        foreach (App::path('Template', $plugin) as $templatesPath) {
            array_walk($paths, function (&$path) use ($templatesPath) {
                if (substr($path, 0, strlen($templatesPath)) == $templatesPath) {
                    $path = substr($path, strlen($templatesPath));
                }
            });
        }

        return $paths;
    }
}


1		<?php
2
3		namespace WyriHaximus\TwigView\Lib;
4
5		use Cake\Core\App;
6
7		/**
8		* Class RelativeScanner
9		* @package WyriHaximus\TwigView\Lib
10		*/
11		class RelativeScanner
12		{
13		/**
14		* Return all sections (app & plugins) with an Template directory.
15		*
16		* @return array
17		*/
18		public static function all()
19		{
20		return static::strip(Scanner::all());
		0 ignored issues – show Documentation introduced 2015-12-16 16:24 UTC by Report Bug Copy Issue Report `\WyriHaximus\TwigView\Lib\Scanner::all()` is of type `array`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
21		}
22
23		/**
24		* Return all templates for a given plugin.
25		*
26		* @param string $plugin The plugin to find all templates for.
27		*
28		* @return mixed
29		*/
30		public static function plugin($plugin)
31		{
32		return static::strip([
		0 ignored issues – show Documentation introduced 2015-12-16 16:24 UTC by Report Bug Copy Issue Report `array($plugin => \WyriHa...anner::plugin($plugin))` is of type `array<string,array>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
33		$plugin => Scanner::plugin($plugin),
34		])[$plugin];
35		}
36
37		/**
38		* Strip the absolute path of template's paths for all given sections.
39		*
40		* @param string $sections Sections to iterate over.
41		*
42		* @return array
43		*/
44	4	protected static function strip($sections)
45		{
46		foreach ($sections as $section => $paths) {
		0 ignored issues – show Bug introduced 2015-12-16 16:24 UTC by Report Bug Copy Issue Report The expression `$sections` of type `string` is not traversable. Loading history...
47		$sections[$section] = static::stripAbsolutePath($paths, $section == 'APP' ? null : $section);
48		}
49	4	return $sections;
50		}
51
52		/**
53		* Strip the absolute path of template's paths.
54		*
55		* @param array $paths Paths to strip.
56		* @param string\|null $plugin Hold plugin name or null for App.
57		*
58		* @return array
59		*/
60	2	protected static function stripAbsolutePath(array $paths, $plugin = null)
61		{
62	2	foreach (App::path('Template', $plugin) as $templatesPath) {
63		array_walk($paths, function (&$path) use ($templatesPath) {
64		if (substr($path, 0, strlen($templatesPath)) == $templatesPath) {
65		$path = substr($path, strlen($templatesPath));
66		}
67		});
68		}
69
70	2	return $paths;
71	2	}
72		}
73

WyriHaximus / TwigView

Pull Request — master (#33)

RelativeScanner::stripAbsolutePath() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like