WsdlToPhp\WsdlHandler\Tag\AbstractTagImport::getLocationAttributeValue()

Complexity

Conditions	6
Paths	8

Size

Total Lines	17
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	6

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function getLocationAttributeValue(): string
    {
        $location = '';

        if ($this->hasAttribute(self::ATTRIBUTE_LOCATION)) {
            $location = $this->getAttributeValue(self::ATTRIBUTE_LOCATION, true);
        } elseif ($this->hasAttribute(self::ATTRIBUTE_SCHEMA_LOCATION)) {
            $location = $this->getAttributeValue(self::ATTRIBUTE_SCHEMA_LOCATION, true);
        } elseif ($this->hasAttribute(self::ATTRIBUTE_SCHEMA_LOCATION_)) {
            $location = $this->getAttributeValue(self::ATTRIBUTE_SCHEMA_LOCATION_, true);
        }

        if (!empty($location) && './' === mb_substr($location, 0, 2)) {

It seems like $location can also be of type boolean; however, parameter $string of mb_substr() does only seem to accept string, maybe add an additional type check?

            $location = mb_substr($location, 2);
        }

        return $location;

The expression return $location could return the type boolean|null which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

    }