Complex classes like AbstractModel often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use AbstractModel, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 15 | abstract class AbstractModel extends AbstractGeneratorAware implements \JsonSerializable |
||
| 16 | { |
||
| 17 | /** |
||
| 18 | * Constant used to define the key to store documentation value in meta |
||
| 19 | * @var string |
||
| 20 | */ |
||
| 21 | const META_DOCUMENTATION = 'documentation'; |
||
| 22 | /** |
||
| 23 | * Original name od the element |
||
| 24 | * @var string |
||
| 25 | */ |
||
| 26 | private $name = ''; |
||
| 27 | /** |
||
| 28 | * Values associated to the operation |
||
| 29 | * @var string[] |
||
| 30 | */ |
||
| 31 | private $meta = array(); |
||
| 32 | /** |
||
| 33 | * Define the inheritance of a struct by the name of the parent struct or type |
||
| 34 | * @var string |
||
| 35 | */ |
||
| 36 | private $inheritance = ''; |
||
| 37 | /** |
||
| 38 | * Store the object which owns the current model |
||
| 39 | * @var AbstractModel |
||
| 40 | */ |
||
| 41 | private $owner = null; |
||
| 42 | /** |
||
| 43 | * Indicates that the current elemen is an abstract element. |
||
| 44 | * It allows to generated an abstract class. |
||
| 45 | * This will happen for element/complexType that are defined with abstract="true" |
||
| 46 | * @var bool |
||
| 47 | */ |
||
| 48 | private $isAbstract = false; |
||
| 49 | /** |
||
| 50 | * Replaced keywords time in order to generate unique new keyword |
||
| 51 | * @var array |
||
| 52 | */ |
||
| 53 | private static $replacedPhpReservedKeywords = array(); |
||
| 54 | /** |
||
| 55 | * Replaced methods time in order to generate unique new method |
||
| 56 | * @var array |
||
| 57 | */ |
||
| 58 | private $replacedReservedMethods = array(); |
||
| 59 | /** |
||
| 60 | * Unique name generated in order to ensure unique naming (for struct constructor and setters/getters even for different case attribute name whith same value) |
||
| 61 | * @var array |
||
| 62 | */ |
||
| 63 | private static $uniqueNames = array(); |
||
| 64 | /** |
||
| 65 | * Main constructor |
||
| 66 | * @uses AbstractModel::setName() |
||
| 67 | * @param Generator $generator |
||
| 68 | * @param string $name the original name |
||
| 69 | */ |
||
| 70 | public function __construct(Generator $generator, $name) |
||
| 75 | /** |
||
| 76 | * @uses AbstractModel::getInheritedModel() |
||
| 77 | * @uses AbstractModel::getPackagedName() |
||
| 78 | * @uses AbstractModel::getExtends() |
||
| 79 | * @uses Struct::isStruct() |
||
| 80 | * @return string |
||
| 81 | */ |
||
| 82 | public function getExtendsClassName() |
||
| 93 | /** |
||
| 94 | * Returns the name of the class the current class inherits from |
||
| 95 | * @return string |
||
| 96 | */ |
||
| 97 | public function getInheritance() |
||
| 101 | /** |
||
| 102 | * Sets the name of the class the current class inherits from |
||
| 103 | * @param string $inheritance |
||
| 104 | * @return AbstractModel |
||
| 105 | */ |
||
| 106 | public function setInheritance($inheritance = '') |
||
| 111 | /** |
||
| 112 | * @uses AbstractGeneratorAware::getGenerator() |
||
| 113 | * @uses Generator::getStruct() |
||
| 114 | * @uses AbstractModel::getInheritance() |
||
| 115 | * @return Struct |
||
| 116 | */ |
||
| 117 | public function getInheritedModel() |
||
| 121 | /** |
||
| 122 | * Returns the meta |
||
| 123 | * @return string[] |
||
| 124 | */ |
||
| 125 | public function getMeta() |
||
| 129 | /** |
||
| 130 | * Sets the meta |
||
| 131 | * @param string[] $meta |
||
| 132 | * @return AbstractModel |
||
| 133 | */ |
||
| 134 | public function setMeta(array $meta = array()) |
||
| 139 | /** |
||
| 140 | * Add meta information to the operation |
||
| 141 | * @uses AbstractModel::getMeta() |
||
| 142 | * @throws \InvalidArgumentException |
||
| 143 | * @param string $metaName |
||
| 144 | * @param mixed $metaValue |
||
| 145 | * @return AbstractModel |
||
| 146 | */ |
||
| 147 | public function addMeta($metaName, $metaValue) |
||
| 167 | /** |
||
| 168 | * Sets the documentation meta value. |
||
| 169 | * Documentation is set as an array so if multiple documentation nodes are set for an unique element, it will gather them. |
||
| 170 | * @uses AbstractModel::META_DOCUMENTATION |
||
| 171 | * @uses AbstractModel::addMeta() |
||
| 172 | * @param string $documentation the documentation from the WSDL |
||
| 173 | * @return AbstractModel |
||
| 174 | */ |
||
| 175 | public function setDocumentation($documentation) |
||
| 181 | /** |
||
| 182 | * Returns a meta value according to its name |
||
| 183 | * @uses AbstractModel::getMeta() |
||
| 184 | * @param string $metaName the meta information name |
||
| 185 | * @param mixed $fallback the fallback value if unset |
||
| 186 | * @return mixed the meta information value |
||
| 187 | */ |
||
| 188 | public function getMetaValue($metaName, $fallback = null) |
||
| 193 | /** |
||
| 194 | * Returns the value of the first meta value assigned to the name |
||
| 195 | * @param string[] $names the meta names to check |
||
| 196 | * @param mixed $fallback the fallback value if anyone is set |
||
| 197 | * @return mixed the meta information value |
||
| 198 | */ |
||
| 199 | public function getMetaValueFirstSet(array $names, $fallback = null) |
||
| 209 | /** |
||
| 210 | * Returns the original name extracted from the WSDL |
||
| 211 | * @return string |
||
| 212 | */ |
||
| 213 | public function getName() |
||
| 217 | /** |
||
| 218 | * Sets the original name extracted from the WSDL |
||
| 219 | * @param string $name |
||
| 220 | * @return AbstractModel |
||
| 221 | */ |
||
| 222 | public function setName($name) |
||
| 227 | /** |
||
| 228 | * Returns a valid clean name for PHP |
||
| 229 | * @uses AbstractModel::getName() |
||
| 230 | * @uses AbstractModel::cleanString() |
||
| 231 | * @param bool $keepMultipleUnderscores optional, allows to keep the multiple consecutive underscores |
||
| 232 | * @return string |
||
| 233 | */ |
||
| 234 | public function getCleanName($keepMultipleUnderscores = true) |
||
| 238 | /** |
||
| 239 | * Returns the owner model object |
||
| 240 | * @return AbstractModel |
||
| 241 | */ |
||
| 242 | public function getOwner() |
||
| 246 | /** |
||
| 247 | * Sets the owner model object |
||
| 248 | * @param AbstractModel $owner object the owner of the current model |
||
| 249 | * @return AbstractModel |
||
| 250 | */ |
||
| 251 | public function setOwner(AbstractModel $owner = null) |
||
| 256 | /** |
||
| 257 | * @return bool |
||
| 258 | */ |
||
| 259 | public function isAbstract() |
||
| 263 | /** |
||
| 264 | * @param bool $isAbstract |
||
| 265 | * @return AbstractModel |
||
| 266 | */ |
||
| 267 | public function setAbstract($isAbstract) |
||
| 272 | /** |
||
| 273 | * Alias to setAbstract |
||
| 274 | * @param bool $isAbstract |
||
| 275 | * @return AbstractModel |
||
| 276 | */ |
||
| 277 | public function setIsAbstract($isAbstract) |
||
| 281 | /** |
||
| 282 | * Returns true if the original name is safe to use as a PHP property, variable name or class name |
||
| 283 | * @uses AbstractModel::getName() |
||
| 284 | * @uses AbstractModel::getCleanName() |
||
| 285 | * @return bool |
||
| 286 | */ |
||
| 287 | public function nameIsClean() |
||
| 291 | /** |
||
| 292 | * Returns the packaged name |
||
| 293 | * @uses AbstractModel::getNamespace() |
||
| 294 | * @uses AbstractModel::getCleanName() |
||
| 295 | * @uses AbstractModel::getContextualPart() |
||
| 296 | * @uses AbstractModel::uniqueName() |
||
| 297 | * @uses AbstractModel::replacePhpReservedKeyword() |
||
| 298 | * @uses AbstractGeneratorAware::getGenerator() |
||
| 299 | * @uses Generator::getOptionPrefix() |
||
| 300 | * @uses Generator::getOptionSuffix() |
||
| 301 | * @uses AbstractModel::uniqueName() to ensure unique naming of struct case sensitively |
||
| 302 | * @return string |
||
| 303 | */ |
||
| 304 | public function getPackagedName($namespaced = false) |
||
| 322 | /** |
||
| 323 | * Allows to define the contextual part of the class name for the package |
||
| 324 | * @return string |
||
| 325 | */ |
||
| 326 | public function getContextualPart() |
||
| 330 | /** |
||
| 331 | * Allows to define from which class the curent model extends |
||
| 332 | * @param bool $short |
||
| 333 | * @return string|null |
||
| 334 | */ |
||
| 335 | public function getExtends($short = false) |
||
| 339 | /** |
||
| 340 | * @uses AbstractGeneratorAware::getGenerator() |
||
| 341 | * @uses Generator::getOptionNamespacePrefix() |
||
| 342 | * @uses Generator::getOptionPrefix() |
||
| 343 | * @uses Generator::getOptionSuffix() |
||
| 344 | * @uses AbstractModel::getSubDirectory() |
||
| 345 | * @return string |
||
| 346 | */ |
||
| 347 | public function getNamespace() |
||
| 365 | /** |
||
| 366 | * Returns directory where to store class and create it if needed |
||
| 367 | * @uses AbstractGeneratorAware::getGenerator() |
||
| 368 | * @uses AbstractModel::getOptionCategory() |
||
| 369 | * @uses AbstractGeneratorAware::getContextualPart() |
||
| 370 | * @uses GeneratorOptions::VALUE_CAT |
||
| 371 | * @return string |
||
| 372 | */ |
||
| 373 | public function getSubDirectory() |
||
| 381 | /** |
||
| 382 | * Returns the sub package name which the model belongs to |
||
| 383 | * Must be overridden by sub classes |
||
| 384 | * @return array |
||
| 385 | */ |
||
| 386 | public function getDocSubPackages() |
||
| 390 | /** |
||
| 391 | * Clean a string to make it valid as PHP variable |
||
| 392 | * @uses GeneratorUtils::cleanString() |
||
| 393 | * @param string $string the string to clean |
||
| 394 | * @param bool $keepMultipleUnderscores optional, allows to keep the multiple consecutive underscores |
||
| 395 | * @return string |
||
| 396 | */ |
||
| 397 | public static function cleanString($string, $keepMultipleUnderscores = true) |
||
| 401 | /** |
||
| 402 | * Returns a usable keyword for a original keyword |
||
| 403 | * @uses PhpReservedKeyword::instance() |
||
| 404 | * @uses PhpReservedKeyword::is() |
||
| 405 | * @param string $keyword the keyword |
||
| 406 | * @param string $context the context |
||
| 407 | * @return string |
||
| 408 | */ |
||
| 409 | public static function replacePhpReservedKeyword($keyword, $context = null) |
||
| 427 | /** |
||
| 428 | * @throws \InvalidArgumentException |
||
| 429 | * @param $filename |
||
| 430 | * @return AbstractReservedWord |
||
| 431 | */ |
||
| 432 | public function getReservedMethodsInstance($filename = null) |
||
| 436 | /** |
||
| 437 | * Returns a usable method for a original method |
||
| 438 | * @uses PhpReservedKeywords::instance() |
||
| 439 | * @uses PhpReservedKeywords::is() |
||
| 440 | * @param string $methodName the method name |
||
| 441 | * @param string $context the context |
||
| 442 | * @return string |
||
| 443 | */ |
||
| 444 | public function replaceReservedMethod($methodName, $context = null) |
||
| 462 | /** |
||
| 463 | * Static method wich returns a unique name case sensitively |
||
| 464 | * Useful to name methods case sensitively distinct, see http://the-echoplex.net/log/php-case-sensitivity |
||
| 465 | * @param string $name the original name |
||
| 466 | * @param string $context the context where the name is needed unique |
||
| 467 | * @return string |
||
| 468 | */ |
||
| 469 | protected static function uniqueName($name, $context) |
||
| 484 | /** |
||
| 485 | * Gives the availability for test purpose and multiple package generation to purge unique names |
||
| 486 | */ |
||
| 487 | public static function purgeUniqueNames() |
||
| 491 | /** |
||
| 492 | * Gives the availability for test purpose and multiple package generation to purge reserved keywords usage |
||
| 493 | */ |
||
| 494 | public static function purgePhpReservedKeywords() |
||
| 498 | /** |
||
| 499 | * Should return the properties of the inherited class |
||
| 500 | * @return array |
||
| 501 | */ |
||
| 502 | abstract protected function toJsonSerialize(); |
||
| 503 | /** |
||
| 504 | * {@inheritDoc} |
||
| 505 | * @see JsonSerializable::jsonSerialize() |
||
| 506 | */ |
||
| 507 | public function jsonSerialize() |
||
| 517 | /** |
||
| 518 | * @param Generator $generator |
||
| 519 | * @param array $args |
||
| 520 | * @return AbstractModel |
||
| 521 | */ |
||
| 522 | public static function instanceFromSerializedJson(Generator $generator, array $args) |
||
| 539 | /** |
||
| 540 | * @param array $args |
||
| 541 | * @throws \InvalidArgumentException |
||
| 542 | */ |
||
| 543 | private static function checkSerializedJson(array $args) |
||
| 555 | } |
||
| 556 |