Complex classes like AbstractModel often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use AbstractModel, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 15 | abstract class AbstractModel extends AbstractGeneratorAware |
||
| 16 | { |
||
| 17 | /** |
||
| 18 | * Constant used to define the key to store documentation value in meta |
||
| 19 | * @var string |
||
| 20 | */ |
||
| 21 | const META_DOCUMENTATION = 'documentation'; |
||
| 22 | /** |
||
| 23 | * Original name od the element |
||
| 24 | * @var string |
||
| 25 | */ |
||
| 26 | private $name = ''; |
||
| 27 | /** |
||
| 28 | * Values associated to the operation |
||
| 29 | * @var string[] |
||
| 30 | */ |
||
| 31 | private $meta = array(); |
||
| 32 | /** |
||
| 33 | * Define the inheritance of a struct by the name of the parent struct or type |
||
| 34 | * @var string |
||
| 35 | */ |
||
| 36 | private $inheritance = ''; |
||
| 37 | /** |
||
| 38 | * Store the object which owns the current model |
||
| 39 | * @var AbstractModel |
||
| 40 | */ |
||
| 41 | private $owner = null; |
||
| 42 | /** |
||
| 43 | * Indicates that the current elemen is an abstract element. |
||
| 44 | * It allows to generated an abstract class. |
||
| 45 | * This will happen for element/complexType that are defined with abstract="true" |
||
| 46 | * @var bool |
||
| 47 | */ |
||
| 48 | private $isAbstract = false; |
||
| 49 | /** |
||
| 50 | * Replaced keywords time in order to generate unique new keyword |
||
| 51 | * @var array |
||
| 52 | */ |
||
| 53 | private static $replacedPhpReservedKeywords = array(); |
||
| 54 | /** |
||
| 55 | * Replaced methods time in order to generate unique new method |
||
| 56 | * @var array |
||
| 57 | */ |
||
| 58 | private $replacedReservedMethods = array(); |
||
| 59 | /** |
||
| 60 | * Unique name generated in order to ensure unique naming (for struct constructor and setters/getters even for different case attribute name whith same value) |
||
| 61 | * @var array |
||
| 62 | */ |
||
| 63 | private static $uniqueNames = array(); |
||
| 64 | 716 | /** |
|
| 65 | * Main constructor |
||
| 66 | 716 | * @uses AbstractModel::setName() |
|
| 67 | 716 | * @param Generator $generator |
|
| 68 | 716 | * @param string $name the original name |
|
| 69 | */ |
||
| 70 | public function __construct(Generator $generator, $name) |
||
| 75 | /** |
||
| 76 | 208 | * @uses AbstractModel::getInheritedMoel() |
|
| 77 | * @uses AbstractModel::getPackagedName() |
||
| 78 | 208 | * @uses AbstractModel::getExtends() |
|
| 79 | 208 | * @uses Struct::getIsStruct() |
|
| 80 | 20 | * @return string |
|
| 81 | 15 | */ |
|
| 82 | 208 | public function getExtendsClassName() |
|
| 93 | 268 | /** |
|
| 94 | * Returns the name of the class the current class inherits from |
||
| 95 | * @return string |
||
| 96 | */ |
||
| 97 | public function getInheritance() |
||
| 101 | 172 | /** |
|
| 102 | 172 | * Sets the name of the class the current class inherits from |
|
| 103 | * @param AbstractModel |
||
| 104 | */ |
||
| 105 | public function setInheritance($inheritance = '') |
||
| 110 | 208 | /** |
|
| 111 | * @uses AbstractGeneratorAware::getGenerator() |
||
| 112 | 208 | * @uses Generator::getStruct() |
|
| 113 | * @uses AbstractModel::getInheritance() |
||
| 114 | * @return Struct |
||
| 115 | */ |
||
| 116 | public function getInheritedMoel() |
||
| 120 | 288 | /** |
|
| 121 | * Returns the meta |
||
| 122 | * @return string[] |
||
| 123 | */ |
||
| 124 | public function getMeta() |
||
| 128 | /** |
||
| 129 | 4 | * Sets the meta |
|
| 130 | 4 | * @param string[] $meta |
|
| 131 | * @return AbstractModel |
||
| 132 | */ |
||
| 133 | public function setMeta(array $meta = array()) |
||
| 138 | /** |
||
| 139 | * Add meta information to the operation |
||
| 140 | 364 | * @uses AbstractModel::getMeta() |
|
| 141 | * @throws \InvalidArgumentException |
||
| 142 | 364 | * @param string $metaName |
|
| 143 | 8 | * @param mixed $metaValue |
|
| 144 | * @return AbstractModel |
||
| 145 | 356 | */ |
|
| 146 | 356 | public function addMeta($metaName, $metaValue) |
|
| 166 | /** |
||
| 167 | * Sets the documentation meta value. |
||
| 168 | 104 | * Documentation is set as an array so if multiple documentation nodes are set for an unique element, it will gather them. |
|
| 169 | * @uses AbstractModel::META_DOCUMENTATION |
||
| 170 | 104 | * @uses AbstractModel::addMeta() |
|
| 171 | * @param string $documentation the documentation from the WSDL |
||
| 172 | * @return AbstractModel |
||
| 173 | */ |
||
| 174 | public function setDocumentation($documentation) |
||
| 178 | /** |
||
| 179 | 232 | * Returns a meta value according to its name |
|
| 180 | * @uses AbstractModel::getMeta() |
||
| 181 | 232 | * @param string $metaName the meta information name |
|
| 182 | 232 | * @param mixed $fallback the fallback value if unset |
|
| 183 | * @return mixed the meta information value |
||
| 184 | */ |
||
| 185 | public function getMetaValue($metaName, $fallback = null) |
||
| 190 | 104 | /** |
|
| 191 | * Returns the value of the first meta value assigned to the name |
||
| 192 | 104 | * @param array $names the meta names to check |
|
| 193 | 104 | * @param mixed $fallback the fallback value if anyone is set |
|
| 194 | 104 | * @return mixed the meta information value |
|
| 195 | 86 | */ |
|
| 196 | public function getMetaValueFirstSet(array $names, $fallback = null) |
||
| 206 | 628 | /** |
|
| 207 | * Returns the original name extracted from the WSDL |
||
| 208 | * @return string |
||
| 209 | */ |
||
| 210 | public function getName() |
||
| 214 | /** |
||
| 215 | 716 | * Sets the original name extracted from the WSDL |
|
| 216 | 716 | * @param string $name |
|
| 217 | * @return AbstractModel |
||
| 218 | */ |
||
| 219 | public function setName($name) |
||
| 224 | /** |
||
| 225 | 512 | * Returns a valid clean name for PHP |
|
| 226 | * @uses AbstractModel::getName() |
||
| 227 | 512 | * @uses AbstractModel::cleanString() |
|
| 228 | * @param bool $keepMultipleUnderscores optional, allows to keep the multiple consecutive underscores |
||
| 229 | * @return string |
||
| 230 | */ |
||
| 231 | public function getCleanName($keepMultipleUnderscores = true) |
||
| 235 | 508 | /** |
|
| 236 | * Returns the owner model object |
||
| 237 | * @return AbstractModel |
||
| 238 | */ |
||
| 239 | public function getOwner() |
||
| 243 | /** |
||
| 244 | 552 | * Sets the owner model object |
|
| 245 | 552 | * @param AbstractModel $owner object the owner of the current model |
|
| 246 | * @return AbstractModel |
||
| 247 | */ |
||
| 248 | public function setOwner(AbstractModel $owner) |
||
| 253 | /** |
||
| 254 | * @return bool |
||
| 255 | */ |
||
| 256 | public function getIsAbstract() |
||
| 260 | 20 | /** |
|
| 261 | 20 | * @param bool $isAbstract |
|
| 262 | * @return AbstractModel |
||
| 263 | */ |
||
| 264 | public function setIsAbstract($isAbstract) |
||
| 269 | 180 | /** |
|
| 270 | * Returns true if the original name is safe to use as a PHP property, variable name or class name |
||
| 271 | 180 | * @uses AbstractModel::getName() |
|
| 272 | * @uses AbstractModel::getCleanName() |
||
| 273 | * @return bool |
||
| 274 | */ |
||
| 275 | public function nameIsClean() |
||
| 279 | /** |
||
| 280 | * Returns the packaged name |
||
| 281 | * @uses AbstractModel::getNamespace() |
||
| 282 | * @uses AbstractModel::getCleanName() |
||
| 283 | * @uses AbstractModel::getContextualPart() |
||
| 284 | * @uses AbstractModel::uniqueName() |
||
| 285 | * @uses AbstractModel::replacePhpReservedKeyword() |
||
| 286 | 500 | * @uses AbstractGeneratorAware::getGenerator() |
|
| 287 | * @uses Generator::getOptionPrefix() |
||
| 288 | 500 | * @uses Generator::getOptionSuffix() |
|
| 289 | 500 | * @uses AbstractModel::uniqueName() to ensure unique naming of struct case sensitively |
|
| 290 | 196 | * @return string |
|
| 291 | 147 | */ |
|
| 292 | 500 | public function getPackagedName($namespaced = false) |
|
| 310 | 64 | /** |
|
| 311 | * Allows to define the contextual part of the class name for the package |
||
| 312 | * @return string |
||
| 313 | */ |
||
| 314 | public function getContextualPart() |
||
| 318 | /** |
||
| 319 | 32 | * Allows to define from which class the curent model extends |
|
| 320 | * @param bool $short |
||
| 321 | * @return string|null |
||
| 322 | */ |
||
| 323 | public function getExtends($short = false) |
||
| 327 | /** |
||
| 328 | * @uses AbstractGeneratorAware::getGenerator() |
||
| 329 | 236 | * @uses Generator::getOptionNamespacePrefix() |
|
| 330 | * @uses Generator::getOptionPrefix() |
||
| 331 | 236 | * @uses Generator::getOptionSuffix() |
|
| 332 | 236 | * @uses AbstractModel::getSubDirectory() |
|
| 333 | 236 | * @return string |
|
| 334 | 228 | */ |
|
| 335 | 184 | public function getNamespace() |
|
| 353 | /** |
||
| 354 | * Returns directory where to store class and create it if needed |
||
| 355 | 260 | * @uses AbstractGeneratorAware::getGenerator() |
|
| 356 | * @uses AbstractModel::getOptionCategory() |
||
| 357 | 260 | * @uses AbstractGeneratorAware::getContextualPart() |
|
| 358 | 260 | * @uses GeneratorOptions::VALUE_CAT |
|
| 359 | 260 | * @return string |
|
| 360 | 195 | */ |
|
| 361 | 260 | public function getSubDirectory() |
|
| 369 | /** |
||
| 370 | 4 | * Returns the sub package name which the model belongs to |
|
| 371 | * Must be overridden by sub classes |
||
| 372 | * @return array |
||
| 373 | */ |
||
| 374 | public function getDocSubPackages() |
||
| 378 | /** |
||
| 379 | 516 | * Clean a string to make it valid as PHP variable |
|
| 380 | * @uses GeneratorUtils::cleanString() |
||
| 381 | 516 | * @param string $string the string to clean |
|
| 382 | * @param bool $keepMultipleUnderscores optional, allows to keep the multiple consecutive underscores |
||
| 383 | * @return string |
||
| 384 | */ |
||
| 385 | public static function cleanString($string, $keepMultipleUnderscores = true) |
||
| 389 | /** |
||
| 390 | * Returns a usable keyword for a original keyword |
||
| 391 | 496 | * @uses PhpReservedKeyword::instance() |
|
| 392 | * @uses PhpReservedKeyword::is() |
||
| 393 | 496 | * @param string $keyword the keyword |
|
| 394 | 496 | * @param string $context the context |
|
| 395 | 112 | * @return string |
|
| 396 | 60 | */ |
|
| 397 | 60 | public static function replacePhpReservedKeyword($keyword, $context = null) |
|
| 415 | /** |
||
| 416 | * @throws \InvalidArgumentException |
||
| 417 | 504 | * @param $filename |
|
| 418 | * @return AbstractReservedWord |
||
| 419 | 504 | */ |
|
| 420 | 504 | public function getReservedMethodsInstance($filename = null) |
|
| 424 | 428 | /** |
|
| 425 | 321 | * Returns a usable method for a original method |
|
| 426 | 32 | * @uses PhpReservedKeywords::instance() |
|
| 427 | * @uses PhpReservedKeywords::is() |
||
| 428 | 432 | * @param string $keyword the keyword |
|
|
|
|||
| 429 | 432 | * @param string $context the context |
|
| 430 | 432 | * @return string |
|
| 431 | */ |
||
| 432 | public function replaceReservedMethod($methodName, $context = null) |
||
| 450 | /** |
||
| 451 | * Static method wich returns a unique name case sensitively |
||
| 452 | * Useful to name methods case sensitively distinct, see http://the-echoplex.net/log/php-case-sensitivity |
||
| 453 | * @param string $name the original name |
||
| 454 | * @param string $context the context where the name is needed unique |
||
| 455 | * @return string |
||
| 456 | */ |
||
| 457 | protected static function uniqueName($name, $context) |
||
| 472 | /** |
||
| 473 | * Gives the availability for test purpose and multiple package generation to purge unique names |
||
| 474 | * @todo see if it can be removed by reviewing how unique names are generated |
||
| 475 | */ |
||
| 476 | public static function purgeUniqueNames() |
||
| 480 | /** |
||
| 481 | * Gives the availability for test purpose and multiple package generation to purge reserved keywords usage |
||
| 482 | * @todo see if it can be removed by reviewing how reserved keywords are generated |
||
| 483 | */ |
||
| 484 | public static function purgePhpReservedKeywords() |
||
| 488 | /** |
||
| 489 | * Gives the availability for test purpose and multiple package generation to purge reserved methods usage |
||
| 490 | * @todo see if it can be removed by reviewing how reserved methods are generated |
||
| 491 | */ |
||
| 492 | public static function purgeReservedMethods() |
||
| 496 | } |
||
| 497 |
This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function.
Consider the following example. The parameter
$italyis not defined by the methodfinale(...).The most likely cause is that the parameter was removed, but the annotation was not.