Complex classes like AbstractModel often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use AbstractModel, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 15 | abstract class AbstractModel extends AbstractGeneratorAware implements \JsonSerializable |
||
| 16 | { |
||
| 17 | /** |
||
| 18 | * Constant used to define the key to store documentation value in meta |
||
| 19 | * @var string |
||
| 20 | */ |
||
| 21 | const META_DOCUMENTATION = 'documentation'; |
||
| 22 | /** |
||
| 23 | * Original name od the element |
||
| 24 | * @var string |
||
| 25 | */ |
||
| 26 | private $name = ''; |
||
| 27 | /** |
||
| 28 | * Values associated to the operation |
||
| 29 | * @var string[] |
||
| 30 | */ |
||
| 31 | private $meta = array(); |
||
| 32 | /** |
||
| 33 | * Define the inheritance of a struct by the name of the parent struct or type |
||
| 34 | * @var string |
||
| 35 | */ |
||
| 36 | private $inheritance = ''; |
||
| 37 | /** |
||
| 38 | * Store the object which owns the current model |
||
| 39 | * @var AbstractModel |
||
| 40 | */ |
||
| 41 | private $owner = null; |
||
| 42 | /** |
||
| 43 | * Indicates that the current elemen is an abstract element. |
||
| 44 | * It allows to generated an abstract class. |
||
| 45 | * This will happen for element/complexType that are defined with abstract="true" |
||
| 46 | * @var bool |
||
| 47 | */ |
||
| 48 | private $isAbstract = false; |
||
| 49 | /** |
||
| 50 | * Replaced keywords time in order to generate unique new keyword |
||
| 51 | * @var array |
||
| 52 | */ |
||
| 53 | private static $replacedPhpReservedKeywords = array(); |
||
| 54 | /** |
||
| 55 | * Replaced methods time in order to generate unique new method |
||
| 56 | * @var array |
||
| 57 | */ |
||
| 58 | private $replacedReservedMethods = array(); |
||
| 59 | /** |
||
| 60 | * Unique name generated in order to ensure unique naming (for struct constructor and setters/getters even for different case attribute name whith same value) |
||
| 61 | * @var array |
||
| 62 | */ |
||
| 63 | private static $uniqueNames = array(); |
||
| 64 | /** |
||
| 65 | * Main constructor |
||
| 66 | * @uses AbstractModel::setName() |
||
| 67 | * @param Generator $generator |
||
| 68 | * @param string $name the original name |
||
| 69 | */ |
||
| 70 | 1480 | public function __construct(Generator $generator, $name) |
|
| 75 | /** |
||
| 76 | * @uses AbstractModel::getInheritedModel() |
||
| 77 | * @uses AbstractModel::getPackagedName() |
||
| 78 | * @uses AbstractModel::getExtends() |
||
| 79 | * @uses Struct::isStruct() |
||
| 80 | * @return string |
||
| 81 | */ |
||
| 82 | 300 | public function getExtendsClassName() |
|
| 93 | /** |
||
| 94 | * Returns the name of the class the current class inherits from |
||
| 95 | * @return string |
||
| 96 | */ |
||
| 97 | 420 | public function getInheritance() |
|
| 101 | /** |
||
| 102 | * Sets the name of the class the current class inherits from |
||
| 103 | * @param string $inheritance |
||
| 104 | * @return AbstractModel |
||
| 105 | */ |
||
| 106 | 425 | public function setInheritance($inheritance = '') |
|
| 111 | /** |
||
| 112 | * @uses AbstractGeneratorAware::getGenerator() |
||
| 113 | * @uses Generator::getStruct() |
||
| 114 | * @uses AbstractModel::getInheritance() |
||
| 115 | * @return Struct |
||
| 116 | */ |
||
| 117 | 300 | public function getInheritedModel() |
|
| 118 | { |
||
| 119 | 300 | return $this->getGenerator()->getStruct($this->getInheritance()); |
|
| 120 | } |
||
| 121 | /** |
||
| 122 | * Returns the meta |
||
| 123 | * @return string[] |
||
| 124 | */ |
||
| 125 | 390 | public function getMeta() |
|
| 129 | /** |
||
| 130 | * Sets the meta |
||
| 131 | * @param string[] $meta |
||
| 132 | * @return AbstractModel |
||
| 133 | */ |
||
| 134 | 300 | public function setMeta(array $meta = array()) |
|
| 139 | /** |
||
| 140 | * Add meta information to the operation |
||
| 141 | * @uses AbstractModel::getMeta() |
||
| 142 | * @throws \InvalidArgumentException |
||
| 143 | * @param string $metaName |
||
| 144 | * @param mixed $metaValue |
||
| 145 | * @return AbstractModel |
||
| 146 | */ |
||
| 147 | 220 | public function addMeta($metaName, $metaValue) |
|
| 167 | /** |
||
| 168 | * Sets the documentation meta value. |
||
| 169 | * Documentation is set as an array so if multiple documentation nodes are set for an unique element, it will gather them. |
||
| 170 | * @uses AbstractModel::META_DOCUMENTATION |
||
| 171 | * @uses AbstractModel::addMeta() |
||
| 172 | * @param string $documentation the documentation from the WSDL |
||
| 173 | * @return AbstractModel |
||
| 174 | */ |
||
| 175 | 60 | public function setDocumentation($documentation) |
|
| 176 | { |
||
| 177 | 60 | return $this->addMeta(self::META_DOCUMENTATION, is_array($documentation) ? $documentation : array( |
|
| 178 | 60 | $documentation, |
|
| 179 | 36 | )); |
|
| 180 | } |
||
| 181 | /** |
||
| 182 | * Returns a meta value according to its name |
||
| 183 | * @uses AbstractModel::getMeta() |
||
| 184 | * @param string $metaName the meta information name |
||
| 185 | * @param mixed $fallback the fallback value if unset |
||
| 186 | * @return mixed the meta information value |
||
| 187 | */ |
||
| 188 | 320 | public function getMetaValue($metaName, $fallback = null) |
|
| 189 | { |
||
| 190 | 320 | $meta = $this->getMeta(); |
|
| 191 | 320 | return array_key_exists($metaName, $meta) ? $meta[$metaName] : $fallback; |
|
| 192 | } |
||
| 193 | /** |
||
| 194 | * Returns the value of the first meta value assigned to the name |
||
| 195 | * @param string[] $names the meta names to check |
||
| 196 | * @param mixed $fallback the fallback value if anyone is set |
||
| 197 | * @return mixed the meta information value |
||
| 198 | */ |
||
| 199 | 155 | public function getMetaValueFirstSet(array $names, $fallback = null) |
|
| 200 | { |
||
| 201 | 155 | $meta = $this->getMeta(); |
|
| 202 | 155 | foreach ($names as $name) { |
|
| 203 | 155 | if (array_key_exists($name, $meta)) { |
|
| 204 | 137 | return $meta[$name]; |
|
| 205 | } |
||
| 206 | 72 | } |
|
| 207 | 120 | return $fallback; |
|
| 208 | } |
||
| 209 | /** |
||
| 210 | * Returns the original name extracted from the WSDL |
||
| 211 | * @return string |
||
| 212 | */ |
||
| 213 | 930 | public function getName() |
|
| 214 | { |
||
| 215 | 930 | return $this->name; |
|
| 216 | } |
||
| 217 | /** |
||
| 218 | * Sets the original name extracted from the WSDL |
||
| 219 | * @param string $name |
||
| 220 | * @return AbstractModel |
||
| 221 | */ |
||
| 222 | 1480 | public function setName($name) |
|
| 223 | { |
||
| 224 | 1480 | $this->name = $name; |
|
| 225 | 1480 | return $this; |
|
| 226 | } |
||
| 227 | /** |
||
| 228 | * Returns a valid clean name for PHP |
||
| 229 | * @uses AbstractModel::getName() |
||
| 230 | * @uses AbstractModel::cleanString() |
||
| 231 | * @param bool $keepMultipleUnderscores optional, allows to keep the multiple consecutive underscores |
||
| 232 | * @return string |
||
| 233 | */ |
||
| 234 | 755 | public function getCleanName($keepMultipleUnderscores = true) |
|
| 235 | { |
||
| 236 | 755 | return self::cleanString($this->getName(), $keepMultipleUnderscores); |
|
| 237 | } |
||
| 238 | /** |
||
| 239 | * Returns the owner model object |
||
| 240 | * @return AbstractModel |
||
| 241 | */ |
||
| 242 | 715 | public function getOwner() |
|
| 243 | { |
||
| 244 | 715 | return $this->owner; |
|
| 245 | } |
||
| 246 | /** |
||
| 247 | * Sets the owner model object |
||
| 248 | * @param AbstractModel $owner object the owner of the current model |
||
| 249 | * @return AbstractModel |
||
| 250 | */ |
||
| 251 | 1230 | public function setOwner(AbstractModel $owner = null) |
|
| 252 | { |
||
| 253 | 1230 | $this->owner = $owner; |
|
| 254 | 1230 | return $this; |
|
| 255 | } |
||
| 256 | /** |
||
| 257 | * @return bool |
||
| 258 | */ |
||
| 259 | 305 | public function isAbstract() |
|
| 260 | { |
||
| 261 | 305 | return $this->isAbstract; |
|
| 262 | } |
||
| 263 | /** |
||
| 264 | * @param bool $isAbstract |
||
| 265 | * @return AbstractModel |
||
| 266 | */ |
||
| 267 | 305 | public function setAbstract($isAbstract) |
|
| 268 | { |
||
| 269 | 305 | $this->isAbstract = $isAbstract; |
|
| 270 | 305 | return $this; |
|
| 271 | } |
||
| 272 | /** |
||
| 273 | * Returns true if the original name is safe to use as a PHP property, variable name or class name |
||
| 274 | * @uses AbstractModel::getName() |
||
| 275 | * @uses AbstractModel::getCleanName() |
||
| 276 | * @return bool |
||
| 277 | */ |
||
| 278 | 255 | public function nameIsClean() |
|
| 279 | { |
||
| 280 | 255 | return ($this->getName() !== '' && $this->getName() === $this->getCleanName()); |
|
| 281 | } |
||
| 282 | /** |
||
| 283 | * Returns the packaged name |
||
| 284 | * @uses AbstractModel::getNamespace() |
||
| 285 | * @uses AbstractModel::getCleanName() |
||
| 286 | * @uses AbstractModel::getContextualPart() |
||
| 287 | * @uses AbstractModel::uniqueName() |
||
| 288 | * @uses AbstractModel::replacePhpReservedKeyword() |
||
| 289 | * @uses AbstractGeneratorAware::getGenerator() |
||
| 290 | * @uses Generator::getOptionPrefix() |
||
| 291 | * @uses Generator::getOptionSuffix() |
||
| 292 | * @uses AbstractModel::uniqueName() to ensure unique naming of struct case sensitively |
||
| 293 | * @return string |
||
| 294 | */ |
||
| 295 | 700 | public function getPackagedName($namespaced = false) |
|
| 296 | { |
||
| 297 | 700 | $nameParts = array(); |
|
| 298 | 700 | if ($namespaced && $this->getNamespace() !== '') { |
|
| 299 | 280 | $nameParts[] = sprintf('\%s\\', $this->getNamespace()); |
|
| 300 | 168 | } |
|
| 301 | 700 | $cleanName = $this->getCleanName(); |
|
| 302 | 700 | if ($this->getGenerator()->getOptionPrefix() !== '') { |
|
| 303 | 435 | $nameParts[] = $this->getGenerator()->getOptionPrefix(); |
|
| 304 | 261 | } else { |
|
| 305 | 310 | $cleanName = self::replacePhpReservedKeyword($cleanName); |
|
| 306 | } |
||
| 307 | 700 | $nameParts[] = ucfirst(self::uniqueName($cleanName, $this->getContextualPart())); |
|
| 308 | 700 | if ($this->getGenerator()->getOptionSuffix() !== '') { |
|
| 309 | 30 | $nameParts[] = $this->getGenerator()->getOptionSuffix(); |
|
| 310 | 18 | } |
|
| 311 | 700 | return implode('', $nameParts); |
|
| 312 | } |
||
| 313 | /** |
||
| 314 | * Allows to define the contextual part of the class name for the package |
||
| 315 | * @return string |
||
| 316 | */ |
||
| 317 | 110 | public function getContextualPart() |
|
| 318 | { |
||
| 319 | 110 | return ''; |
|
| 320 | } |
||
| 321 | /** |
||
| 322 | * Allows to define from which class the curent model extends |
||
| 323 | * @param bool $short |
||
| 324 | * @return string|null |
||
| 325 | */ |
||
| 326 | 55 | public function getExtends($short = false) |
|
| 327 | { |
||
| 328 | 55 | return ''; |
|
| 329 | } |
||
| 330 | /** |
||
| 331 | * @uses AbstractGeneratorAware::getGenerator() |
||
| 332 | * @uses Generator::getOptionNamespacePrefix() |
||
| 333 | * @uses Generator::getOptionPrefix() |
||
| 334 | * @uses Generator::getOptionSuffix() |
||
| 335 | * @uses AbstractModel::getSubDirectory() |
||
| 336 | * @return string |
||
| 337 | */ |
||
| 338 | 350 | public function getNamespace() |
|
| 339 | { |
||
| 340 | 350 | $namespaces = array(); |
|
| 341 | 350 | $namespace = $this->getGenerator()->getOptionNamespacePrefix(); |
|
| 342 | 350 | if (empty($namespace)) { |
|
| 343 | 340 | if ($this->getGenerator()->getOptionPrefix() !== '') { |
|
| 344 | 270 | $namespaces[] = $this->getGenerator()->getOptionPrefix(); |
|
| 345 | 232 | } elseif ($this->getGenerator()->getOptionSuffix() !== '') { |
|
| 346 | 142 | $namespaces[] = $this->getGenerator()->getOptionSuffix(); |
|
| 347 | 6 | } |
|
| 348 | 204 | } else { |
|
| 349 | 10 | $namespaces[] = $namespace; |
|
| 350 | } |
||
| 351 | 350 | if ($this->getSubDirectory() !== '') { |
|
| 352 | 325 | $namespaces[] = $this->getSubDirectory(); |
|
| 353 | 195 | } |
|
| 354 | 350 | return implode('\\', $namespaces); |
|
| 355 | } |
||
| 356 | /** |
||
| 357 | * Returns directory where to store class and create it if needed |
||
| 358 | * @uses AbstractGeneratorAware::getGenerator() |
||
| 359 | * @uses AbstractModel::getOptionCategory() |
||
| 360 | * @uses AbstractGeneratorAware::getContextualPart() |
||
| 361 | * @uses GeneratorOptions::VALUE_CAT |
||
| 362 | * @return string |
||
| 363 | */ |
||
| 364 | 380 | public function getSubDirectory() |
|
| 365 | { |
||
| 366 | 380 | $subDirectory = ''; |
|
| 367 | 380 | if ($this->getGenerator()->getOptionCategory() === GeneratorOptions::VALUE_CAT) { |
|
| 368 | 375 | $subDirectory = $this->getContextualPart(); |
|
| 369 | 225 | } |
|
| 370 | 380 | return $subDirectory; |
|
| 371 | } |
||
| 372 | /** |
||
| 373 | * Returns the sub package name which the model belongs to |
||
| 374 | * Must be overridden by sub classes |
||
| 375 | * @return array |
||
| 376 | */ |
||
| 377 | 5 | public function getDocSubPackages() |
|
| 378 | { |
||
| 379 | 5 | return array(); |
|
| 380 | } |
||
| 381 | /** |
||
| 382 | * Clean a string to make it valid as PHP variable |
||
| 383 | * @uses GeneratorUtils::cleanString() |
||
| 384 | * @param string $string the string to clean |
||
| 385 | * @param bool $keepMultipleUnderscores optional, allows to keep the multiple consecutive underscores |
||
| 386 | * @return string |
||
| 387 | */ |
||
| 388 | 760 | public static function cleanString($string, $keepMultipleUnderscores = true) |
|
| 389 | { |
||
| 390 | 760 | return GeneratorUtils::cleanString($string, $keepMultipleUnderscores); |
|
| 391 | } |
||
| 392 | /** |
||
| 393 | * Returns a usable keyword for a original keyword |
||
| 394 | * @uses PhpReservedKeyword::instance() |
||
| 395 | * @uses PhpReservedKeyword::is() |
||
| 396 | * @param string $keyword the keyword |
||
| 397 | * @param string $context the context |
||
| 398 | * @return string |
||
| 399 | */ |
||
| 400 | 700 | public static function replacePhpReservedKeyword($keyword, $context = null) |
|
| 401 | { |
||
| 402 | 700 | if (PhpReservedKeyword::instance()->is($keyword)) { |
|
| 403 | 160 | if ($context !== null) { |
|
| 404 | 85 | $keywordKey = $keyword . '_' . $context; |
|
| 405 | 85 | if (!array_key_exists($keywordKey, self::$replacedPhpReservedKeywords)) { |
|
| 406 | 50 | self::$replacedPhpReservedKeywords[$keywordKey] = 0; |
|
| 407 | 30 | } else { |
|
| 408 | 35 | self::$replacedPhpReservedKeywords[$keywordKey]++; |
|
| 409 | } |
||
| 410 | 85 | return '_' . $keyword . (self::$replacedPhpReservedKeywords[$keywordKey] ? '_' . self::$replacedPhpReservedKeywords[$keywordKey] : ''); |
|
| 411 | } else { |
||
| 412 | 130 | return '_' . $keyword; |
|
| 413 | } |
||
| 414 | } else { |
||
| 415 | 700 | return $keyword; |
|
| 416 | } |
||
| 417 | } |
||
| 418 | /** |
||
| 419 | * @throws \InvalidArgumentException |
||
| 420 | * @param $filename |
||
| 421 | * @return AbstractReservedWord |
||
| 422 | */ |
||
| 423 | 5 | public function getReservedMethodsInstance($filename = null) |
|
| 424 | { |
||
| 425 | 5 | throw new \InvalidArgumentException(sprintf('The method %s should be defined in the class %s', __FUNCTION__, get_called_class(), __LINE__)); |
|
| 426 | } |
||
| 427 | /** |
||
| 428 | * Returns a usable method for a original method |
||
| 429 | * @uses PhpReservedKeywords::instance() |
||
| 430 | * @uses PhpReservedKeywords::is() |
||
| 431 | * @param string $methodName the method name |
||
| 432 | * @param string $context the context |
||
| 433 | * @return string |
||
| 434 | */ |
||
| 435 | 700 | public function replaceReservedMethod($methodName, $context = null) |
|
| 436 | { |
||
| 437 | 700 | if ($this->getReservedMethodsInstance()->is($methodName)) { |
|
| 438 | 5 | if ($context !== null) { |
|
| 439 | 5 | $methodKey = $methodName . '_' . $context; |
|
| 440 | 5 | if (!array_key_exists($methodKey, $this->replacedReservedMethods)) { |
|
| 441 | 5 | $this->replacedReservedMethods[$methodKey] = 0; |
|
| 442 | 3 | } else { |
|
| 443 | $this->replacedReservedMethods[$methodKey]++; |
||
| 444 | } |
||
| 445 | 5 | return '_' . $methodName . ($this->replacedReservedMethods[$methodKey] ? '_' . $this->replacedReservedMethods[$methodKey] : ''); |
|
| 446 | } else { |
||
| 447 | 5 | return '_' . $methodName; |
|
| 448 | } |
||
| 449 | } else { |
||
| 450 | 695 | return $methodName; |
|
| 451 | } |
||
| 452 | } |
||
| 453 | /** |
||
| 454 | * Static method wich returns a unique name case sensitively |
||
| 455 | * Useful to name methods case sensitively distinct, see http://the-echoplex.net/log/php-case-sensitivity |
||
| 456 | * @param string $name the original name |
||
| 457 | * @param string $context the context where the name is needed unique |
||
| 458 | * @return string |
||
| 459 | */ |
||
| 460 | 705 | protected static function uniqueName($name, $context) |
|
| 461 | { |
||
| 462 | 705 | $insensitiveKey = strtolower($name . '_' . $context); |
|
| 463 | 705 | $sensitiveKey = $name . '_' . $context; |
|
| 464 | 705 | if (array_key_exists($sensitiveKey, self::$uniqueNames)) { |
|
| 465 | 700 | return self::$uniqueNames[$sensitiveKey]; |
|
| 466 | 590 | } elseif (!array_key_exists($insensitiveKey, self::$uniqueNames)) { |
|
| 467 | 585 | self::$uniqueNames[$insensitiveKey] = 0; |
|
| 468 | 351 | } else { |
|
| 469 | 40 | self::$uniqueNames[$insensitiveKey]++; |
|
| 470 | } |
||
| 471 | 590 | $uniqueName = $name . (self::$uniqueNames[$insensitiveKey] ? '_' . self::$uniqueNames[$insensitiveKey] : ''); |
|
| 472 | 590 | self::$uniqueNames[$sensitiveKey] = $uniqueName; |
|
| 473 | 590 | return $uniqueName; |
|
| 474 | } |
||
| 475 | /** |
||
| 476 | * Gives the availability for test purpose and multiple package generation to purge unique names |
||
| 477 | */ |
||
| 478 | 390 | public static function purgeUniqueNames() |
|
| 479 | { |
||
| 480 | 390 | self::$uniqueNames = array(); |
|
| 481 | 390 | } |
|
| 482 | /** |
||
| 483 | * Gives the availability for test purpose and multiple package generation to purge reserved keywords usage |
||
| 484 | */ |
||
| 485 | 360 | public static function purgePhpReservedKeywords() |
|
| 489 | /** |
||
| 490 | * Should return the properties of the inherited class |
||
| 491 | * @return array |
||
| 492 | */ |
||
| 493 | abstract protected function toJsonSerialize(); |
||
| 494 | /** |
||
| 495 | * {@inheritDoc} |
||
| 496 | * @see JsonSerializable::jsonSerialize() |
||
| 497 | */ |
||
| 498 | 15 | public function jsonSerialize() |
|
| 499 | { |
||
| 500 | 15 | return array_merge($this->toJsonSerialize(), array( |
|
| 501 | 15 | 'inheritance' => $this->inheritance, |
|
| 502 | 15 | 'abstract' => $this->isAbstract, |
|
| 503 | 15 | 'meta' => $this->meta, |
|
| 504 | 15 | 'name' => $this->name, |
|
| 505 | 15 | '__CLASS__' => get_called_class(), |
|
| 506 | 9 | )); |
|
| 507 | } |
||
| 508 | /** |
||
| 509 | * @param Generator $generator |
||
| 510 | * @param array $args |
||
| 511 | * @return AbstractModel |
||
| 512 | */ |
||
| 513 | 295 | public static function instanceFromSerializedJson(Generator $generator, array $args) |
|
| 514 | { |
||
| 515 | 295 | self::checkSerializedJson($args); |
|
| 530 | /** |
||
| 531 | * @param array $args |
||
| 532 | * @throws \InvalidArgumentException |
||
| 533 | */ |
||
| 534 | 295 | private static function checkSerializedJson(array $args) |
|
| 546 | } |
||
| 547 |