StructArrayReservedKeywords::__construct() - Code Metrics - Inspection of "issue #45 - simplify method" - WsdlToPhp/PackageGenerator - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — feature/issue-54 ( 0869de...548adc )

by Mikaël

created 2016-04-10 20:09 UTC

StructArrayReservedKeywords::__construct() A

↳ Parent: StructArrayReservedKeywords

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	5
rs	9.4285
cc	1
eloc	3
nc	1
nop	1

<?php

namespace WsdlToPhp\PackageGenerator\ConfigurationReader;

class StructArrayReservedKeywords extends StructReservedKeywords
{
    /**
     * @param string $filename
     */
    protected function __construct($filename)
    {
        parent::__construct($filename);
        $this->parseReservedKeywords(parent::getDefaultConfigurationPath());
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }
    /**
     * @throws \InvalidArgumentException
     * @param string options's file to parse
     * @return StructArrayReservedKeywords
     */
    public static function instance($filename = null)
    {
        return parent::instance(empty($filename) ? self::getDefaultArrayConfigurationPath() : $filename);
    }
    /**
     * @return string
     */
    public static function getDefaultArrayConfigurationPath()
    {
        return dirname(__FILE__) . '/../resources/config/struct_array_reserved_keywords.yml';
    }
}


1			<?php
2
3			namespace WsdlToPhp\PackageGenerator\ConfigurationReader;
4
5			class StructArrayReservedKeywords extends StructReservedKeywords
6			{
7			/**
8			* @param string $filename
9			*/
10			protected function __construct($filename)
11			{
12			parent::__construct($filename);
13			$this->parseReservedKeywords(parent::getDefaultConfigurationPath());
			1 ignored issue – show Comprehensibility Bug introduced 2016-04-10 20:40 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`getDefaultConfigurationPath()` instead of `__construct()`). Are you sure this is correct? If so, you might want to change this to `$this->getDefaultConfigurationPath()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
14			}
15			/**
16			* @throws \InvalidArgumentException
17			* @param string options's file to parse
18			* @return StructArrayReservedKeywords
19			*/
20			public static function instance($filename = null)
21			{
22			return parent::instance(empty($filename) ? self::getDefaultArrayConfigurationPath() : $filename);
23			}
24			/**
25			* @return string
26			*/
27			public static function getDefaultArrayConfigurationPath()
28			{
29			return dirname(__FILE__) . '/../resources/config/struct_array_reserved_keywords.yml';
30			}
31			}
32

WsdlToPhp / PackageGenerator

Push — feature/issue-54 ( 0869de...548adc )

StructArrayReservedKeywords::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like