WordPoints / wordpoints

src/admin/screens/modules-load.php

Braces +4 added lines, -2 removed lines

@@ -11,9 +11,11 @@
 
 if ( isset( $_POST['clear-recent-list'] ) ) {
 	$action = 'clear-recent-list';
-} elseif ( isset( $_REQUEST['action'] ) && -1 !== (int) $_REQUEST['action'] ) { // WPCS: CSRF OK.
+} elseif ( isset( $_REQUEST['action'] ) && -1 !== (int) $_REQUEST['action'] ) {
+// WPCS: CSRF OK.
 	$action = sanitize_key( $_REQUEST['action'] );
-} elseif ( isset( $_REQUEST['action2'] ) && -1 !== (int) $_REQUEST['action2'] ) { // WPCS: CSRF OK.
+} elseif ( isset( $_REQUEST['action2'] ) && -1 !== (int) $_REQUEST['action2'] ) {
+// WPCS: CSRF OK.
 	$action = sanitize_key( $_REQUEST['action2'] );
 } else {
 	$action = '';

Spacing +24 added lines, -24 removed lines

@@ -9,22 +9,22 @@ 
 
 global $status, $wp_version, $parent_file;
 
-if ( isset( $_POST['clear-recent-list'] ) ) {
+if ( isset( $_POST[ 'clear-recent-list' ] ) ) {
 	$action = 'clear-recent-list';
-} elseif ( isset( $_REQUEST['action'] ) && -1 !== (int) $_REQUEST['action'] ) { // WPCS: CSRF OK.
-	$action = sanitize_key( $_REQUEST['action'] );
-} elseif ( isset( $_REQUEST['action2'] ) && -1 !== (int) $_REQUEST['action2'] ) { // WPCS: CSRF OK.
-	$action = sanitize_key( $_REQUEST['action2'] );
+} elseif ( isset( $_REQUEST[ 'action' ] ) && -1 !== (int) $_REQUEST[ 'action' ] ) { // WPCS: CSRF OK.
+	$action = sanitize_key( $_REQUEST[ 'action' ] );
+} elseif ( isset( $_REQUEST[ 'action2' ] ) && -1 !== (int) $_REQUEST[ 'action2' ] ) { // WPCS: CSRF OK.
+	$action = sanitize_key( $_REQUEST[ 'action2' ] );
 } else {
 	$action = '';
 }
 
-$page   = ( isset( $_REQUEST['paged'] ) ) ? max( 1, absint( $_REQUEST['paged'] ) ) : 1; // WPCS: CSRF OK.
-$module = ( isset( $_REQUEST['module'] ) ) ? sanitize_text_field( wp_unslash( $_REQUEST['module'] ) ) : ''; // WPCS: CSRF OK.
-$s      = ( isset( $_REQUEST['s'] ) ) ? sanitize_text_field( wp_unslash( $_REQUEST['s'] ) ) : ''; // WPCS: CSRF OK.
+$page   = ( isset( $_REQUEST[ 'paged' ] ) ) ? max( 1, absint( $_REQUEST[ 'paged' ] ) ) : 1; // WPCS: CSRF OK.
+$module = ( isset( $_REQUEST[ 'module' ] ) ) ? sanitize_text_field( wp_unslash( $_REQUEST[ 'module' ] ) ) : ''; // WPCS: CSRF OK.
+$s      = ( isset( $_REQUEST[ 's' ] ) ) ? sanitize_text_field( wp_unslash( $_REQUEST[ 's' ] ) ) : ''; // WPCS: CSRF OK.
 
 // Clean up request URI from temporary args for screen options/paging URI's to work as expected.
-$_SERVER['REQUEST_URI'] = remove_query_arg( array( 'error', 'deleted', 'activate', 'activate-multi', 'deactivate', 'deactivate-multi', '_error_nonce' ) );
+$_SERVER[ 'REQUEST_URI' ] = remove_query_arg( array( 'error', 'deleted', 'activate', 'activate-multi', 'deactivate', 'deactivate-multi', '_error_nonce' ) );
 
 $redirect_url = self_admin_url( "admin.php?page=wordpoints_extensions&module_status={$status}&paged={$page}&s={$s}" );
 
@@ -91,8 +91,8 @@ 
 
 		check_admin_referer( 'bulk-modules' );
 
-		$modules = isset( $_POST['checked'] )
-			? array_map( 'sanitize_text_field', (array) wp_unslash( $_POST['checked'] ) )
+		$modules = isset( $_POST[ 'checked' ] )
+			? array_map( 'sanitize_text_field', (array) wp_unslash( $_POST[ 'checked' ] ) )
 			: array();
 
 		// Only activate modules which are not already active.
@@ -219,8 +219,8 @@ 
 
 		check_admin_referer( 'bulk-modules' );
 
-		$modules = isset( $_POST['checked'] )
-			? array_map( 'sanitize_text_field', (array) wp_unslash( $_POST['checked'] ) )
+		$modules = isset( $_POST[ 'checked' ] )
+			? array_map( 'sanitize_text_field', (array) wp_unslash( $_POST[ 'checked' ] ) )
 			: array();
 
 		$network_modules = array_filter( $modules, 'is_wordpoints_module_active_for_network' );
@@ -262,8 +262,8 @@ 
 		check_admin_referer( 'bulk-modules' );
 
 		// $_POST = from the module form; $_GET = from the FTP details screen.
-		$modules = isset( $_REQUEST['checked'] )
-			? array_map( 'sanitize_text_field', (array) wp_unslash( $_REQUEST['checked'] ) )
+		$modules = isset( $_REQUEST[ 'checked' ] )
+			? array_map( 'sanitize_text_field', (array) wp_unslash( $_REQUEST[ 'checked' ] ) )
 			: array();
 
 		if ( empty( $modules ) ) {
@@ -291,7 +291,7 @@ 
 
 		$parent_file = 'admin.php';
 
-		if ( ! isset( $_REQUEST['verify-delete'] ) ) {
+		if ( ! isset( $_REQUEST[ 'verify-delete' ] ) ) {
 
 			wp_enqueue_script( 'jquery' );
 			require_once ABSPATH . 'wp-admin/admin-header.php';
@@ -311,15 +311,15 @@ 
 
 					if ( '.' === dirname( $module ) ) {
 
-						$files_to_delete[] = $module_dir . '/' . $module;
+						$files_to_delete[ ] = $module_dir . '/' . $module;
 						$data              = wordpoints_get_module_data( $module_dir . '/' . $module );
 
 						if ( ! empty( $data ) ) {
 
 							$module_info[ $module ] = $data;
-							$module_info[ $module ]['is_uninstallable'] = is_uninstallable_wordpoints_module( $module );
+							$module_info[ $module ][ 'is_uninstallable' ] = is_uninstallable_wordpoints_module( $module );
 
-							if ( ! $module_info[ $module ]['network'] ) {
+							if ( ! $module_info[ $module ][ 'network' ] ) {
 								$have_non_network_modules = true;
 							}
 						}
@@ -339,9 +339,9 @@ 
 						foreach ( $folder_modules as $module_file => $data ) {
 
 							$module_info[ $module_file ] = $data;
-							$module_info[ $module_file ]['is_uninstallable'] = is_uninstallable_wordpoints_module( $module );
+							$module_info[ $module_file ][ 'is_uninstallable' ] = is_uninstallable_wordpoints_module( $module );
 
-							if ( ! $module_info[ $module_file ]['network'] ) {
+							if ( ! $module_info[ $module_file ][ 'network' ] ) {
 								$have_non_network_modules = true;
 							}
 						}
@@ -380,16 +380,16 @@ 
 
 						foreach ( $module_info as $module ) {
 
-							if ( $module['is_uninstallable'] ) {
+							if ( $module[ 'is_uninstallable' ] ) {
 
 								// translators: 1. Extension name; 2. Extension author.
-								echo '<li>', wp_kses( sprintf( __( '<strong>%1$s</strong> by <em>%2$s</em> (will also <strong>delete its data</strong>)', 'wordpoints' ), esc_html( $module['name'] ), esc_html( $module['author_name'] ) ), array( 'strong' => array(), 'em' => array() ) ), '</li>';
+								echo '<li>', wp_kses( sprintf( __( '<strong>%1$s</strong> by <em>%2$s</em> (will also <strong>delete its data</strong>)', 'wordpoints' ), esc_html( $module[ 'name' ] ), esc_html( $module[ 'author_name' ] ) ), array( 'strong' => array(), 'em' => array() ) ), '</li>';
 								$data_to_delete = true;
 
 							} else {
 
 								// translators: 1. Extension name; 2. Extension author.
-								echo '<li>', wp_kses( sprintf( __( '<strong>%1$s</strong> by <em>%2$s</em>', 'wordpoints' ), esc_html( $module['name'] ), esc_html( $module['author_name'] ) ), array( 'strong' => array(), 'em' => array() ) ), '</li>';
+								echo '<li>', wp_kses( sprintf( __( '<strong>%1$s</strong> by <em>%2$s</em>', 'wordpoints' ), esc_html( $module[ 'name' ] ), esc_html( $module[ 'author_name' ] ) ), array( 'strong' => array(), 'em' => array() ) ), '</li>';
 							}
 						}
 

src/admin/screens/configure-components.php

Spacing +24 added lines, -24 removed lines

@@ -17,13 +17,13 @@ 
 // Show messages and errors.
 //
 
-if ( isset( $_GET['wordpoints_component'], $_GET['_wpnonce'] ) && $wordpoints_components->is_registered( sanitize_key( $_GET['wordpoints_component'] ) ) ) { // WPCS: CSRF OK.
+if ( isset( $_GET[ 'wordpoints_component' ], $_GET[ '_wpnonce' ] ) && $wordpoints_components->is_registered( sanitize_key( $_GET[ 'wordpoints_component' ] ) ) ) { // WPCS: CSRF OK.
 
-	$component = sanitize_key( $_GET['wordpoints_component'] );
+	$component = sanitize_key( $_GET[ 'wordpoints_component' ] );
 
-	if ( isset( $_GET['message'] ) && wordpoints_verify_nonce( '_wpnonce', "wordpoints_component_message-{$component}" ) ) {
+	if ( isset( $_GET[ 'message' ] ) && wordpoints_verify_nonce( '_wpnonce', "wordpoints_component_message-{$component}" ) ) {
 
-		switch ( (int) $_GET['message'] ) {
+		switch ( (int) $_GET[ 'message' ] ) {
 
 			case 1:
 				if ( $wordpoints_components->is_active( $component ) ) {
@@ -43,15 +43,15 @@ 
 		if ( isset( $message ) ) {
 
 			wordpoints_show_admin_message(
-				esc_html( sprintf( $message, $components[ $component ]['name'] ) )
+				esc_html( sprintf( $message, $components[ $component ][ 'name' ] ) )
 				, 'success'
 				, array( 'dismissible' => true )
 			);
 		}
 
-	} elseif ( isset( $_GET['error'] ) && wordpoints_verify_nonce( '_wpnonce', "wordpoints_component_error-{$component}" ) ) {
+	} elseif ( isset( $_GET[ 'error' ] ) && wordpoints_verify_nonce( '_wpnonce', "wordpoints_component_error-{$component}" ) ) {
 
-		switch ( (int) $_GET['error'] ) {
+		switch ( (int) $_GET[ 'error' ] ) {
 
 			case 1:
 				if ( ! $wordpoints_components->is_active( $component ) ) {
@@ -71,7 +71,7 @@ 
 		if ( isset( $error ) ) {
 
 			wordpoints_show_admin_error(
-				esc_html( sprintf( $error, $components[ $component ]['name'] ) )
+				esc_html( sprintf( $error, $components[ $component ][ 'name' ] ) )
 				, array( 'dismissible' => true )
 			);
 		}
@@ -109,7 +109,7 @@ 
 
 		<?php
 
-		if ( $wordpoints_components->is_active( $component['slug'] ) ) {
+		if ( $wordpoints_components->is_active( $component[ 'slug' ] ) ) {
 
 			$action = 'deactivate';
 			$button = __( 'Deactivate', 'wordpoints' );
@@ -124,38 +124,38 @@ 
 
 		<tr>
 			<td>
-				<?php if ( '' !== $component['component_uri'] ) : ?>
-					<a href="<?php echo esc_url( $component['component_uri'] ); ?>">
+				<?php if ( '' !== $component[ 'component_uri' ] ) : ?>
+					<a href="<?php echo esc_url( $component[ 'component_uri' ] ); ?>">
 				<?php endif; ?>
-					<?php echo esc_html( $component['name'] ); ?>
-				<?php if ( '' !== $component['component_uri'] ) : ?>
+					<?php echo esc_html( $component[ 'name' ] ); ?>
+				<?php if ( '' !== $component[ 'component_uri' ] ) : ?>
 					</a>
 				<?php endif; ?>
 			</td>
 			<td>
-				<?php echo wp_kses( $component['description'], 'wordpoints_component_description' ); ?>
-				<?php if ( '' !== $component['author'] ) : ?>
+				<?php echo wp_kses( $component[ 'description' ], 'wordpoints_component_description' ); ?>
+				<?php if ( '' !== $component[ 'author' ] ) : ?>
 					&nbsp;|&nbsp;
 					<?php
 					// translators: Author name.
 					echo esc_html( sprintf( __( 'By %s', 'wordpoints' ), '' /* This space intentionally left blank */ ) );
 					?>
-					<?php if ( '' !== $component['author_uri'] ) : ?>
-						<a href="<?php echo esc_url( $component['author_uri'] ); ?>">
+					<?php if ( '' !== $component[ 'author_uri' ] ) : ?>
+						<a href="<?php echo esc_url( $component[ 'author_uri' ] ); ?>">
 					<?php endif; ?>
-						<?php echo esc_html( $component['author'] ); ?>
-					<?php if ( '' !== $component['author_uri'] ) : ?>
+						<?php echo esc_html( $component[ 'author' ] ); ?>
+					<?php if ( '' !== $component[ 'author_uri' ] ) : ?>
 						</a>
 					<?php endif; ?>
 				<?php endif; ?>
 			</td>
-			<td><?php echo esc_html( $component['version'] ); ?></td>
+			<td><?php echo esc_html( $component[ 'version' ] ); ?></td>
 			<td>
-				<form method="post" name="wordpoints_components_form_<?php echo esc_attr( $component['slug'] ); ?>">
+				<form method="post" name="wordpoints_components_form_<?php echo esc_attr( $component[ 'slug' ] ); ?>">
 					<input type="hidden" name="wordpoints_component_action" value="<?php echo esc_attr( $action ); ?>" />
-					<input type="hidden" name="wordpoints_component" value="<?php echo esc_attr( $component['slug'] ); ?>" />
-					<?php wp_nonce_field( "wordpoints_{$action}_component-{$component['slug']}" ); ?>
-					<?php submit_button( $button, "secondary wordpoints-component-{$action}", "wordpoints-component-{$action}_{$component['slug']}", false ); ?>
+					<input type="hidden" name="wordpoints_component" value="<?php echo esc_attr( $component[ 'slug' ] ); ?>" />
+					<?php wp_nonce_field( "wordpoints_{$action}_component-{$component[ 'slug' ]}" ); ?>
+					<?php submit_button( $button, "secondary wordpoints-component-{$action}", "wordpoints-component-{$action}_{$component[ 'slug' ]}", false ); ?>
 				</form>
 			</td>
 		</tr>

Braces +2 added lines, -1 removed lines

@@ -17,7 +17,8 @@
 // Show messages and errors.
 //
 
-if ( isset( $_GET['wordpoints_component'], $_GET['_wpnonce'] ) && $wordpoints_components->is_registered( sanitize_key( $_GET['wordpoints_component'] ) ) ) { // WPCS: CSRF OK.
+if ( isset( $_GET['wordpoints_component'], $_GET['_wpnonce'] ) && $wordpoints_components->is_registered( sanitize_key( $_GET['wordpoints_component'] ) ) ) {
+// WPCS: CSRF OK.
 
 	$component = sanitize_key( $_GET['wordpoints_component'] );
 

src/components/points/includes/deprecated.php

Spacing +4 added lines, -4 removed lines

@@ -184,13 +184,13 @@ 
 
 				$instance = array_merge( $this->defaults, $instance );
 
-				if ( ! $this->is_matching_post_type( $post->post_type, $instance['post_type'] ) ) {
+				if ( ! $this->is_matching_post_type( $post->post_type, $instance[ 'post_type' ] ) ) {
 					continue;
 				}
 
 				$points_type = $this->points_type( $number );
 
-				wordpoints_subtract_points( $comment->user_id, $instance['points'], $points_type, 'comment_disapprove', array( 'status' => $new_status ) );
+				wordpoints_subtract_points( $comment->user_id, $instance[ 'points' ], $points_type, 'comment_disapprove', array( 'status' => $new_status ) );
 
 				update_comment_meta(
 					$comment->comment_ID
@@ -375,14 +375,14 @@ 
 			$instance = array_merge( $this->defaults, $instance );
 
 			if (
-				$this->is_matching_post_type( $post->post_type, $instance['post_type'] )
+				$this->is_matching_post_type( $post->post_type, $instance[ 'post_type' ] )
 				&& 'auto-draft' !== $post->post_status
 				&& __( 'Auto Draft', 'default' ) !== $post->post_title
 			) {
 
 				wordpoints_alter_points(
 					$post->post_author
-					, -$instance['points']
+					, -$instance[ 'points' ]
 					, $this->points_type( $number )
 					, 'post_delete'
 					, array( 'post_title' => $post->post_title, 'post_type' => $post->post_type )

src/components/points/includes/hooks/periodic.php

Spacing +12 added lines, -12 removed lines

@@ -85,15 +85,15 @@ 
 
 			if (
 				! isset( $last_visit[ $points_type ] )
-				|| (int) ( $last_visit[ $points_type ] / $instance['period'] ) < (int) ( $now / $instance['period'] )
+				|| (int) ( $last_visit[ $points_type ] / $instance[ 'period' ] ) < (int) ( $now / $instance[ 'period' ] )
 			) {
 
 				wordpoints_add_points(
 					$user_id
-					, $instance['points']
+					, $instance[ 'points' ]
 					, $points_type
 					, 'periodic'
-					, array( 'period' => $instance['period'] )
+					, array( 'period' => $instance[ 'period' ] )
 				);
 
 				$last_visit[ $points_type ] = $now;
@@ -133,7 +133,7 @@ 
 	 */
 	public function logs( $text, $points, $points_type, $user_id, $log_type, $meta ) {
 
-		switch ( $meta['period'] ) {
+		switch ( $meta[ 'period' ] ) {
 
 			case HOUR_IN_SECONDS:
 				$message = _x( 'Hourly points.', 'points log description', 'wordpoints' );
@@ -169,9 +169,9 @@ 
 	 */
 	protected function generate_description( $instance = array() ) {
 
-		if ( ! empty( $instance['period'] ) ) {
+		if ( ! empty( $instance[ 'period' ] ) ) {
 
-			switch ( $instance['period'] ) {
+			switch ( $instance[ 'period' ] ) {
 
 				case HOUR_IN_SECONDS:
 					return __( 'Visiting the site at least once in an hour.', 'wordpoints' );
@@ -207,8 +207,8 @@ 
 
 		$new_instance = array_merge( $this->defaults, $old_instance, $new_instance );
 
-		wordpoints_posint( $new_instance['points'] );
-		wordpoints_posint( $new_instance['period'] );
+		wordpoints_posint( $new_instance[ 'points' ] );
+		wordpoints_posint( $new_instance[ 'period' ] );
 
 		return $new_instance;
 	}
@@ -227,7 +227,7 @@ 
 		$instance = array_merge( $this->defaults, $instance );
 
 		$dropdown_args = array(
-			'selected' => $instance['period'],
+			'selected' => $instance[ 'period' ],
 			'id'       => $this->get_field_id( 'period' ),
 			'name'     => $this->get_field_name( 'period' ),
 			'class'    => 'widefat wordpoints-append-to-hook-title',
@@ -261,9 +261,9 @@ 
 	protected function get_periods() {
 
 		$periods = array(
-			HOUR_IN_SECONDS     => __( 'hourly',  'wordpoints' ),
-			DAY_IN_SECONDS      => __( 'daily',   'wordpoints' ),
-			WEEK_IN_SECONDS     => __( 'weekly',  'wordpoints' ),
+			HOUR_IN_SECONDS     => __( 'hourly', 'wordpoints' ),
+			DAY_IN_SECONDS      => __( 'daily', 'wordpoints' ),
+			WEEK_IN_SECONDS     => __( 'weekly', 'wordpoints' ),
 			30 * DAY_IN_SECONDS => __( 'monthly', 'wordpoints' ),
 		);
 

src/components/points/includes/hooks/post.php

Spacing +5 added lines, -5 removed lines

@@ -111,22 +111,22 @@
 			$points_type = $this->points_type( $number );
 
 			if (
-				$this->is_matching_post_type( $post->post_type, $instance['post_type'] )
+				$this->is_matching_post_type( $post->post_type, $instance[ 'post_type' ] )
 				&& ! $this->awarded_points_already( $post->ID, $points_type )
 			) {
 
-				if ( isset( $instance['publish'] ) ) {
+				if ( isset( $instance[ 'publish' ] ) ) {
 					_deprecated_argument( __METHOD__, '1.4.0', 'The "publish" hook setting is no longer used to hold the value for the points. Use "points" instead.' );
-					$instance['points'] = $instance['publish'];
+					$instance[ 'points' ] = $instance[ 'publish' ];
 				}
 
-				if ( ! isset( $instance['points'] ) ) {
+				if ( ! isset( $instance[ 'points' ] ) ) {
 					continue;
 				}
 
 				wordpoints_alter_points(
 					$post->post_author
-					, $instance['points']
+					, $instance[ 'points' ]
 					, $points_type
 					, 'post_publish'
 					, array( 'post_id' => $post->ID )

src/components/points/includes/hooks/registration.php

Spacing +2 added lines, -2 removed lines

@@ -59,8 +59,8 @@
 
 		foreach ( $this->get_instances() as $number => $instance ) {
 
-			if ( isset( $instance['points'] ) ) {
-				wordpoints_add_points( $user_id, $instance['points'], $this->points_type( $number ), 'register' );
+			if ( isset( $instance[ 'points' ] ) ) {
+				wordpoints_add_points( $user_id, $instance[ 'points' ], $this->points_type( $number ), 'register' );
 			}
 		}
 	}

src/components/points/includes/hooks/abstracts/comment-approved.php

Spacing +4 added lines, -4 removed lines

@@ -86,14 +86,14 @@ 
 
 			if (
 				'approved' === $last_status
-				|| ! $this->is_matching_post_type( $post->post_type, $instance['post_type'] )
+				|| ! $this->is_matching_post_type( $post->post_type, $instance[ 'post_type' ] )
 			) {
 				continue;
 			}
 
 			wordpoints_add_points(
 				$this->select_user_to_award( $comment, $post )
-				, $instance['points']
+				, $instance[ 'points' ]
 				, $points_type
 				, $this->log_type
 				, array( 'comment_id' => $comment->comment_ID )
@@ -258,8 +258,8 @@ 
 
 		$comment = false;
 
-		if ( isset( $meta['comment_id'] ) ) {
-			$comment = get_comment( $meta['comment_id'] );
+		if ( isset( $meta[ 'comment_id' ] ) ) {
+			$comment = get_comment( $meta[ 'comment_id' ] );
 		}
 
 		if ( ! $comment ) {

src/components/points/admin/includes/ajax.php

Spacing +21 added lines, -21 removed lines

@@ -38,7 +38,7 @@ 
 	}
 
 	// Save hooks order for all points types.
-	if ( ! isset( $_POST['points_types'] ) || ! is_array( $_POST['points_types'] ) ) {
+	if ( ! isset( $_POST[ 'points_types' ] ) || ! is_array( $_POST[ 'points_types' ] ) ) {
 		wp_die( -1, '', array( 'response' => 400 ) );
 	}
 
@@ -46,11 +46,11 @@ 
 
 	foreach ( array_keys( wordpoints_get_points_types() ) as $points_type ) {
 
-		if ( empty( $_POST['points_types'][ $points_type ] ) ) {
+		if ( empty( $_POST[ 'points_types' ][ $points_type ] ) ) {
 			continue;
 		}
 
-		$hooks = sanitize_text_field( wp_unslash( $_POST['points_types'][ $points_type ] ) );
+		$hooks = sanitize_text_field( wp_unslash( $_POST[ 'points_types' ][ $points_type ] ) );
 
 		$points_type_hooks = array();
 
@@ -106,7 +106,7 @@ 
 
 	$error = __( 'An error has occurred. Please reload the page and try again.', 'wordpoints' );
 
-	if ( isset( $_POST['points-slug'] ) ) {
+	if ( isset( $_POST[ 'points-slug' ] ) ) {
 
 		// - We are saving the settings for a points type.
 
@@ -123,19 +123,19 @@ 
 
 		$settings = array();
 
-		if ( isset( $_POST['points-name'] ) ) {
-			$settings['name'] = trim( sanitize_text_field( wp_unslash( $_POST['points-name'] ) ) );
+		if ( isset( $_POST[ 'points-name' ] ) ) {
+			$settings[ 'name' ] = trim( sanitize_text_field( wp_unslash( $_POST[ 'points-name' ] ) ) );
 		}
 
-		if ( isset( $_POST['points-prefix'] ) ) {
-			$settings['prefix'] = ltrim( sanitize_text_field( wp_unslash( $_POST['points-prefix'] ) ) );
+		if ( isset( $_POST[ 'points-prefix' ] ) ) {
+			$settings[ 'prefix' ] = ltrim( sanitize_text_field( wp_unslash( $_POST[ 'points-prefix' ] ) ) );
 		}
 
-		if ( isset( $_POST['points-suffix'] ) ) {
-			$settings['suffix'] = rtrim( sanitize_text_field( wp_unslash( $_POST['points-suffix'] ) ) );
+		if ( isset( $_POST[ 'points-suffix' ] ) ) {
+			$settings[ 'suffix' ] = rtrim( sanitize_text_field( wp_unslash( $_POST[ 'points-suffix' ] ) ) );
 		}
 
-		$points_type = sanitize_key( $_POST['points-slug'] );
+		$points_type = sanitize_key( $_POST[ 'points-slug' ] );
 
 		$old_settings = wordpoints_get_points_type( $points_type );
 
@@ -159,14 +159,14 @@ 
 
 		// - We are creating/updating/deleting an instance of a hook.
 
-		if ( ! isset( $_POST['id_base'], $_POST['hook-id'], $_POST['points_type'], $_POST['hook_number'] ) ) {
+		if ( ! isset( $_POST[ 'id_base' ], $_POST[ 'hook-id' ], $_POST[ 'points_type' ], $_POST[ 'hook_number' ] ) ) {
 			wp_die( -1, '', array( 'response' => 400 ) );
 		}
 
-		$id_base        = sanitize_key( $_POST['id_base'] );
-		$hook_id        = sanitize_key( $_POST['hook-id'] );
-		$points_type_id = sanitize_key( $_POST['points_type'] );
-		$number         = (int) $_POST['hook_number'];
+		$id_base        = sanitize_key( $_POST[ 'id_base' ] );
+		$hook_id        = sanitize_key( $_POST[ 'hook-id' ] );
+		$points_type_id = sanitize_key( $_POST[ 'points_type' ] );
+		$number         = (int) $_POST[ 'hook_number' ];
 
 		/*
 		 * Normally the hook ID will be in 'hook-id' when we are updating a hook.
@@ -177,11 +177,11 @@ 
 		if ( ! $number ) {
 
 			// This holds the ID number if the hook is brand new.
-			if ( ! isset( $_POST['multi_number'] ) || ! wordpoints_posint( $_POST['multi_number'] ) ) {
+			if ( ! isset( $_POST[ 'multi_number' ] ) || ! wordpoints_posint( $_POST[ 'multi_number' ] ) ) {
 				wp_die( '<p>' . esc_html( $error ) . '</p>', '', array( 'response' => 400 ) );
 			}
 
-			$number  = (int) $_POST['multi_number'];
+			$number  = (int) $_POST[ 'multi_number' ];
 			$hook_id = $id_base . '-' . $number;
 		}
 
@@ -198,7 +198,7 @@ 
 		// Get the hooks for this points type.
 		$points_type_hooks = ( isset( $points_types_hooks[ $points_type_id ] ) ) ? $points_types_hooks[ $points_type_id ] : array();
 
-		if ( ! empty( $_POST['delete_hook'] ) ) {
+		if ( ! empty( $_POST[ 'delete_hook' ] ) ) {
 
 			// - We are deleting a hook instance.
 
@@ -229,7 +229,7 @@ 
 			$new_instance = reset( $settings );
 
 			// Save the points types-hooks associations.
-			$points_type_hooks[] = $hook->get_id( $number );
+			$points_type_hooks[ ] = $hook->get_id( $number );
 			$points_types_hooks[ $points_type_id ] = $points_type_hooks;
 			WordPoints_Points_Hooks::save_points_types_hooks( $points_types_hooks );
 
@@ -247,7 +247,7 @@ 
 
 		$hook->update_callback( wp_unslash( $new_instance ), $number );
 
-		if ( empty( $_POST['add_new'] ) ) {
+		if ( empty( $_POST[ 'add_new' ] ) ) {
 			$hook->form_callback( $number );
 		}
 

src/components/points/admin/includes/functions.php

Braces +9 added lines, -4 removed lines

@@ -143,7 +143,8 @@ 
  */
 function wordpoints_points_admin_screen_hooks() {
 
-	if ( isset( $_GET['edithook'] ) || isset( $_POST['savehook'] ) || isset( $_POST['removehook'] ) ) { // WPCS: CSRF OK.
+	if ( isset( $_GET['edithook'] ) || isset( $_POST['savehook'] ) || isset( $_POST['removehook'] ) ) {
+// WPCS: CSRF OK.
 
 		// - We're doing this without AJAX (JS).
 
@@ -206,7 +207,8 @@ 
  */
 function wordpoints_no_js_points_hooks_save() {
 
-	if ( ! isset( $_POST['savehook'] ) && ! isset( $_POST['removehook'] ) ) { // WPCS: CSRF OK.
+	if ( ! isset( $_POST['savehook'] ) && ! isset( $_POST['removehook'] ) ) {
+// WPCS: CSRF OK.
 		return;
 	}
 
@@ -290,9 +292,12 @@ 
 
 	<?php if ( $has_form ) : ?>
 		<hr />
-	<?php else : ?>
+	<?php else {
+	: ?>
 		<br />
-	<?php endif; ?>
+	<?php endif;
+}
+?>
 
 	<div class="hook-instance-description">
 		<label for="<?php $hook->the_field_id( '_description' ); ?>"><?php echo esc_html_x( 'Description (optional):', 'points hook', 'wordpoints' ); ?></label>

Spacing +10 added lines, -10 removed lines

@@ -146,7 +146,7 @@ 
  */
 function wordpoints_points_admin_screen_hooks() {
 
-	if ( isset( $_GET['edithook'] ) || isset( $_POST['savehook'] ) || isset( $_POST['removehook'] ) ) { // WPCS: CSRF OK.
+	if ( isset( $_GET[ 'edithook' ] ) || isset( $_POST[ 'savehook' ] ) || isset( $_POST[ 'removehook' ] ) ) { // WPCS: CSRF OK.
 
 		// - We're doing this without AJAX (JS).
 
@@ -209,7 +209,7 @@ 
  */
 function wordpoints_no_js_points_hooks_save() {
 
-	if ( ! isset( $_POST['savehook'] ) && ! isset( $_POST['removehook'] ) ) { // WPCS: CSRF OK.
+	if ( ! isset( $_POST[ 'savehook' ] ) && ! isset( $_POST[ 'removehook' ] ) ) { // WPCS: CSRF OK.
 		return;
 	}
 
@@ -287,7 +287,7 @@ 
  */
 function wordpoints_points_hook_description_form( $has_form, $instance, $hook ) {
 
-	$description = ( isset( $instance['_description'] ) ) ? $instance['_description'] : '';
+	$description = ( isset( $instance[ '_description' ] ) ) ? $instance[ '_description' ] : '';
 
 	?>
 
@@ -353,7 +353,7 @@ 
 			?>
 
 			<tr>
-				<th scope="row"><?php echo esc_html( $type['name'] ); ?></th>
+				<th scope="row"><?php echo esc_html( $type[ 'name' ] ); ?></th>
 				<td>
 					<input type="hidden" name="<?php echo esc_attr( "wordpoints_points_old-{$slug}" ); ?>" value="<?php echo esc_attr( $points ); ?>" />
 					<input type="number" name="<?php echo esc_attr( "wordpoints_points-{$slug}" ); ?>" value="<?php echo esc_attr( $points ); ?>" autocomplete="off" />
@@ -398,7 +398,7 @@ 
 		<tbody>
 		<?php foreach ( wordpoints_get_points_types() as $slug => $type ) : ?>
 			<tr>
-				<th scope="row" style="text-align: left;"><?php echo esc_html( $type['name'] ); ?></th>
+				<th scope="row" style="text-align: left;"><?php echo esc_html( $type[ 'name' ] ); ?></th>
 				<td style="text-align: right;"><?php wordpoints_display_points( $user->ID, $slug, 'profile_page' ); ?></td>
 			</tr>
 		<?php endforeach; ?>
@@ -428,7 +428,7 @@ 
 	}
 
 	if (
-		! isset( $_POST['wordpoints_points_set_nonce'], $_POST['wordpoints_set_reason'] )
+		! isset( $_POST[ 'wordpoints_points_set_nonce' ], $_POST[ 'wordpoints_set_reason' ] )
 		|| ! wordpoints_verify_nonce( 'wordpoints_points_set_nonce', 'wordpoints_points_set_profile', null, 'post' )
 	) {
 		return;
@@ -453,7 +453,7 @@ 
 				, 'profile_edit'
 				, array(
 					'user_id' => get_current_user_id(),
-					'reason'  => sanitize_text_field( wp_unslash( $_POST['wordpoints_set_reason'] ) ),
+					'reason'  => sanitize_text_field( wp_unslash( $_POST[ 'wordpoints_set_reason' ] ) ),
 				)
 			);
 		}
@@ -509,11 +509,11 @@ 
 function wordpoints_points_admin_settings_save() {
 
 	if (
-		isset( $_POST['default_points_type'] )
+		isset( $_POST[ 'default_points_type' ] )
 		&& wordpoints_verify_nonce( 'wordpoints_default_points_type_nonce', 'wordpoints_default_points_type', null, 'post' )
 	) {
 
-		$points_type = sanitize_key( $_POST['default_points_type'] );
+		$points_type = sanitize_key( $_POST[ 'default_points_type' ] );
 
 		if ( '-1' === $points_type ) {
 
@@ -536,7 +536,7 @@ 
 function wordpoints_points_admin_notices() {
 
 	if (
-		( ! isset( $_GET['page'] ) || 'wordpoints_points_types' !== $_GET['page'] ) // WPCS: CSRF OK.
+		( ! isset( $_GET[ 'page' ] ) || 'wordpoints_points_types' !== $_GET[ 'page' ] ) // WPCS: CSRF OK.
 		&& current_user_can( 'manage_wordpoints_points_types' )
 		&& ! wordpoints_get_points_types()
 	) {