Completed
Push — master ( 9bbfca...6621c7 )
by J.D.
03:38
created
src/components/points/admin/screens/hooks.php 2 patches
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -43,18 +43,18 @@  discard block
 block discarded – undo
43 43
 		return;
44 44
 	}
45 45
 
46
-	if ( isset( $_GET['message'] ) && isset( $messages[ (int) $_GET['message'] ] ) ) { // WPCS: CSRF OK.
46
+	if ( isset( $_GET[ 'message' ] ) && isset( $messages[ (int) $_GET[ 'message' ] ] ) ) { // WPCS: CSRF OK.
47 47
 
48 48
 		wordpoints_show_admin_message(
49
-			esc_html( $messages[ (int) $_GET['message'] ] ) // WPCS: CSRF OK.
49
+			esc_html( $messages[ (int) $_GET[ 'message' ] ] ) // WPCS: CSRF OK.
50 50
 			, 'success'
51 51
 			, array( 'dismissible' => true )
52 52
 		);
53 53
 
54
-	} elseif ( isset( $_GET['error'] ) && isset( $errors[ (int) $_GET['error'] ] ) ) { // WPCS: CSRF OK.
54
+	} elseif ( isset( $_GET[ 'error' ] ) && isset( $errors[ (int) $_GET[ 'error' ] ] ) ) { // WPCS: CSRF OK.
55 55
 
56 56
 		wordpoints_show_admin_error(
57
-			esc_html( $errors[ (int) $_GET['error'] ] ) // WPCS: CSRF OK.
57
+			esc_html( $errors[ (int) $_GET[ 'error' ] ] ) // WPCS: CSRF OK.
58 58
 			, array( 'dismissible' => true )
59 59
 		);
60 60
 	}
@@ -124,8 +124,8 @@  discard block
 block discarded – undo
124 124
 			foreach ( $points_types as $slug => $points_type ) {
125 125
 
126 126
 				$wrap_class = 'hooks-holder-wrap';
127
-				if ( ! empty( $points_type['class'] ) ) {
128
-					$wrap_class .= ' points-type-' . $points_type['class'];
127
+				if ( ! empty( $points_type[ 'class' ] ) ) {
128
+					$wrap_class .= ' points-type-' . $points_type[ 'class' ];
129 129
 				}
130 130
 
131 131
 				if ( $i ) {
@@ -137,7 +137,7 @@  discard block
 block discarded – undo
137 137
 				<div class="<?php echo esc_attr( $wrap_class ); ?>">
138 138
 					<div class="points-type-name">
139 139
 						<div class="points-type-name-arrow"><br /></div>
140
-						<h2><?php echo esc_html( $points_type['name'] ); ?><span class="spinner"></span></h2>
140
+						<h2><?php echo esc_html( $points_type[ 'name' ] ); ?><span class="spinner"></span></h2>
141 141
 					</div>
142 142
 					<div id="<?php echo esc_attr( $slug ); ?>" class="hooks-sortables">
143 143
 
Please login to merge, or discard this patch.
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -43,7 +43,8 @@  discard block
 block discarded – undo
43 43
 		return;
44 44
 	}
45 45
 
46
-	if ( isset( $_GET['message'] ) && isset( $messages[ (int) $_GET['message'] ] ) ) { // WPCS: CSRF OK.
46
+	if ( isset( $_GET['message'] ) && isset( $messages[ (int) $_GET['message'] ] ) ) {
47
+// WPCS: CSRF OK.
47 48
 
48 49
 		wordpoints_show_admin_message(
49 50
 			esc_html( $messages[ (int) $_GET['message'] ] ) // WPCS: CSRF OK.
@@ -51,7 +52,8 @@  discard block
 block discarded – undo
51 52
 			, array( 'dismissible' => true )
52 53
 		);
53 54
 
54
-	} elseif ( isset( $_GET['error'] ) && isset( $errors[ (int) $_GET['error'] ] ) ) { // WPCS: CSRF OK.
55
+	} elseif ( isset( $_GET['error'] ) && isset( $errors[ (int) $_GET['error'] ] ) ) {
56
+// WPCS: CSRF OK.
55 57
 
56 58
 		wordpoints_show_admin_error(
57 59
 			esc_html( $errors[ (int) $_GET['error'] ] ) // WPCS: CSRF OK.
Please login to merge, or discard this patch.
src/components/points/classes/shortcode.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@  discard block
 block discarded – undo
22 22
 	 */
23 23
 	protected function verify_atts() {
24 24
 
25
-		if ( isset( $this->pairs['points_type'] ) ) {
25
+		if ( isset( $this->pairs[ 'points_type' ] ) ) {
26 26
 
27 27
 			$points_type = $this->get_points_type();
28 28
 
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
 				return $points_type;
31 31
 			}
32 32
 
33
-			$this->atts['points_type'] = $points_type;
33
+			$this->atts[ 'points_type' ] = $points_type;
34 34
 		}
35 35
 
36 36
 		return parent::verify_atts();
@@ -50,7 +50,7 @@  discard block
 block discarded – undo
50 50
 	 */
51 51
 	protected function get_points_type() {
52 52
 
53
-		$points_type = $this->atts['points_type'];
53
+		$points_type = $this->atts[ 'points_type' ];
54 54
 
55 55
 		if ( ! wordpoints_is_points_type( $points_type ) ) {
56 56
 
Please login to merge, or discard this patch.
src/components/points/classes/shortcode/logs.php 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
40 40
 	 */
41 41
 	protected function verify_atts() {
42 42
 
43
-		if ( ! wordpoints_is_points_logs_query( $this->atts['query'] ) ) {
43
+		if ( ! wordpoints_is_points_logs_query( $this->atts[ 'query' ] ) ) {
44 44
 			return sprintf(
45 45
 				// translators: 1. Attribute name; 2. Shortcode name; 3. Example of proper usage.
46 46
 				__( 'The &#8220;%1$s&#8221; attribute of the %2$s shortcode must be the slug of a registered points log query. Example: %3$s.', 'wordpoints' )
@@ -50,17 +50,17 @@  discard block
 block discarded – undo
50 50
 			);
51 51
 		}
52 52
 
53
-		if ( false === wordpoints_int( $this->atts['paginate'] ) ) {
54
-			$this->atts['paginate'] = 1;
53
+		if ( false === wordpoints_int( $this->atts[ 'paginate' ] ) ) {
54
+			$this->atts[ 'paginate' ] = 1;
55 55
 		}
56 56
 
57 57
 		// Back-compat. Needs to stay here "forever" for legacy installs.
58
-		if ( isset( $this->atts['datatables'] ) ) {
59
-			$this->atts['paginate'] = wordpoints_int( $this->atts['datatables'] );
58
+		if ( isset( $this->atts[ 'datatables' ] ) ) {
59
+			$this->atts[ 'paginate' ] = wordpoints_int( $this->atts[ 'datatables' ] );
60 60
 		}
61 61
 
62
-		if ( false === wordpoints_int( $this->atts['show_users'] ) ) {
63
-			$this->atts['show_users'] = 1;
62
+		if ( false === wordpoints_int( $this->atts[ 'show_users' ] ) ) {
63
+			$this->atts[ 'show_users' ] = 1;
64 64
 		}
65 65
 
66 66
 		return parent::verify_atts();
@@ -74,12 +74,12 @@  discard block
 block discarded – undo
74 74
 
75 75
 		ob_start();
76 76
 		wordpoints_show_points_logs_query(
77
-			$this->atts['points_type']
78
-			, $this->atts['query']
77
+			$this->atts[ 'points_type' ]
78
+			, $this->atts[ 'query' ]
79 79
 			, array(
80
-				'paginate'   => $this->atts['paginate'],
81
-				'show_users' => $this->atts['show_users'],
82
-				'searchable' => $this->atts['searchable'],
80
+				'paginate'   => $this->atts[ 'paginate' ],
81
+				'show_users' => $this->atts[ 'show_users' ],
82
+				'searchable' => $this->atts[ 'searchable' ],
83 83
 			)
84 84
 		);
85 85
 
Please login to merge, or discard this patch.
src/components/points/classes/shortcode/user/points.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -37,8 +37,8 @@
 block discarded – undo
37 37
 	protected function generate() {
38 38
 
39 39
 		return wordpoints_get_formatted_points(
40
-			$this->atts['user_id']
41
-			, $this->atts['points_type']
40
+			$this->atts[ 'user_id' ]
41
+			, $this->atts[ 'points_type' ]
42 42
 			, 'points-shortcode'
43 43
 		);
44 44
 	}
Please login to merge, or discard this patch.
src/components/points/classes/shortcode/top/users.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
 	 */
37 37
 	protected function verify_atts() {
38 38
 
39
-		if ( ! wordpoints_posint( $this->atts['users'] ) ) {
39
+		if ( ! wordpoints_posint( $this->atts[ 'users' ] ) ) {
40 40
 			return sprintf(
41 41
 				// translators: 1. Attribute name; 2. Shortcode name; 3. Example of proper usage.
42 42
 				__( 'The &#8220;%1$s&#8221; attribute of the %2$s shortcode must be a positive integer. Example: %3$s.', 'wordpoints' )
@@ -57,8 +57,8 @@  discard block
 block discarded – undo
57 57
 
58 58
 		ob_start();
59 59
 		wordpoints_points_show_top_users(
60
-			$this->atts['users']
61
-			, $this->atts['points_type']
60
+			$this->atts[ 'users' ]
61
+			, $this->atts[ 'points_type' ]
62 62
 			, 'shortcode'
63 63
 		);
64 64
 
Please login to merge, or discard this patch.
src/components/points/classes/logs/view.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -145,7 +145,7 @@  discard block
 block discarded – undo
145 145
 	 */
146 146
 	protected function get_logs() {
147 147
 
148
-		if ( $this->args['searchable'] ) {
148
+		if ( $this->args[ 'searchable' ] ) {
149 149
 
150 150
 			$search_term = $this->get_search_term();
151 151
 
@@ -161,7 +161,7 @@  discard block
 block discarded – undo
161 161
 			}
162 162
 		}
163 163
 
164
-		if ( $this->args['paginate'] ) {
164
+		if ( $this->args[ 'paginate' ] ) {
165 165
 
166 166
 			$page = $this->get_page_number();
167 167
 			$per_page = $this->get_per_page();
Please login to merge, or discard this patch.
src/components/points/classes/logs/viewing/restriction/wrapper.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -57,7 +57,7 @@
 block discarded – undo
57 57
 				continue;
58 58
 			}
59 59
 
60
-			$this->restrictions[] = $restriction;
60
+			$this->restrictions[ ] = $restriction;
61 61
 		}
62 62
 	}
63 63
 
Please login to merge, or discard this patch.
src/components/points/classes/logs/viewing/restriction/hooks.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -109,7 +109,7 @@
 block discarded – undo
109 109
 				continue;
110 110
 			}
111 111
 
112
-			$descriptions[] = sprintf( $string, $entity->get_title() );
112
+			$descriptions[ ] = sprintf( $string, $entity->get_title() );
113 113
 		}
114 114
 
115 115
 		return $descriptions;
Please login to merge, or discard this patch.
src/components/points/classes/logs/view/table.php 2 patches
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -222,7 +222,8 @@
 block discarded – undo
222 222
 
223 223
 		$search_term = '';
224 224
 
225
-		if ( isset( $_POST['wordpoints_points_logs_search'] ) ) { // WPCS: CSRF OK
225
+		if ( isset( $_POST['wordpoints_points_logs_search'] ) ) {
226
+// WPCS: CSRF OK
226 227
 			$search_term = trim(
227 228
 				sanitize_text_field(
228 229
 					wp_unslash( $_POST['wordpoints_points_logs_search'] ) // WPCS: CSRF OK
Please login to merge, or discard this patch.
Spacing   +24 added lines, -24 removed lines patch added patch discarded remove patch
@@ -61,7 +61,7 @@  discard block
 block discarded – undo
61 61
 			);
62 62
 
63 63
 			if ( ! empty( $points_type_name ) ) {
64
-				$this->column_headings['points'] = $points_type_name;
64
+				$this->column_headings[ 'points' ] = $points_type_name;
65 65
 			}
66 66
 		}
67 67
 
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
 
70 70
 		foreach ( array( 'searchable', 'paginate' ) as $arg ) {
71 71
 			if ( $this->args[ $arg ] ) {
72
-				$extra_classes[] = $arg;
72
+				$extra_classes[ ] = $arg;
73 73
 			}
74 74
 		}
75 75
 
@@ -92,19 +92,19 @@  discard block
 block discarded – undo
92 92
 		?>
93 93
 
94 94
 		<div class="wordpoints-points-logs-wrapper">
95
-			<?php if ( $this->args['searchable'] ) : ?>
95
+			<?php if ( $this->args[ 'searchable' ] ) : ?>
96 96
 				<?php $this->search_box(); ?>
97 97
 			<?php endif; ?>
98 98
 
99 99
 			<table class="wordpoints-points-logs widefat <?php echo esc_attr( implode( ' ', $extra_classes ) ); ?>">
100 100
 				<thead>
101 101
 					<tr>
102
-						<?php if ( $this->args['show_users'] ) : ?>
103
-							<th scope="col"><?php echo esc_html( $this->column_headings['user'] ); ?></th>
102
+						<?php if ( $this->args[ 'show_users' ] ) : ?>
103
+							<th scope="col"><?php echo esc_html( $this->column_headings[ 'user' ] ); ?></th>
104 104
 						<?php endif; ?>
105
-						<th scope="col"><?php echo esc_html( $this->column_headings['points'] ); ?></th>
106
-						<th scope="col"><?php echo esc_html( $this->column_headings['description'] ); ?></th>
107
-						<th scope="col"><?php echo esc_html( $this->column_headings['time'] ); ?></th>
105
+						<th scope="col"><?php echo esc_html( $this->column_headings[ 'points' ] ); ?></th>
106
+						<th scope="col"><?php echo esc_html( $this->column_headings[ 'description' ] ); ?></th>
107
+						<th scope="col"><?php echo esc_html( $this->column_headings[ 'time' ] ); ?></th>
108 108
 					</tr>
109 109
 				</thead>
110 110
 				<tbody>
@@ -118,7 +118,7 @@  discard block
 block discarded – undo
118 118
 
119 119
 		?>
120 120
 		<tr>
121
-			<td colspan="<?php echo ( $this->args['show_users'] ) ? 4 : 3; ?>">
121
+			<td colspan="<?php echo ( $this->args[ 'show_users' ] ) ? 4 : 3; ?>">
122 122
 				<?php esc_html_e( 'No matching logs found.', 'wordpoints' ); ?>
123 123
 			</td>
124 124
 		</tr>
@@ -135,7 +135,7 @@  discard block
 block discarded – undo
135 135
 		?>
136 136
 
137 137
 		<tr class="wordpoints-log-id-<?php echo (int) $log->id; ?> <?php echo ( $this->i % 2 ) ? 'odd' : 'even'; ?>">
138
-			<?php if ( $this->args['show_users'] ) : ?>
138
+			<?php if ( $this->args[ 'show_users' ] ) : ?>
139 139
 				<td>
140 140
 					<?php echo get_avatar( $user->ID, 32 ); ?>
141 141
 					<span class="wordpoints-points-log-user-name">
@@ -199,17 +199,17 @@  discard block
 block discarded – undo
199 199
 				</tbody>
200 200
 				<tfoot>
201 201
 					<tr>
202
-						<?php if ( $this->args['show_users'] ) : ?>
203
-							<th scope="col"><?php echo esc_html( $this->column_headings['user'] ); ?></th>
202
+						<?php if ( $this->args[ 'show_users' ] ) : ?>
203
+							<th scope="col"><?php echo esc_html( $this->column_headings[ 'user' ] ); ?></th>
204 204
 						<?php endif; ?>
205
-						<th scope="col"><?php echo esc_html( $this->column_headings['points'] ); ?></th>
206
-						<th scope="col"><?php echo esc_html( $this->column_headings['description'] ); ?></th>
207
-						<th scope="col"><?php echo esc_html( $this->column_headings['time'] ); ?></th>
205
+						<th scope="col"><?php echo esc_html( $this->column_headings[ 'points' ] ); ?></th>
206
+						<th scope="col"><?php echo esc_html( $this->column_headings[ 'description' ] ); ?></th>
207
+						<th scope="col"><?php echo esc_html( $this->column_headings[ 'time' ] ); ?></th>
208 208
 					</tr>
209 209
 				</tfoot>
210 210
 			</table>
211 211
 
212
-			<?php if ( $this->args['paginate'] ) : ?>
212
+			<?php if ( $this->args[ 'paginate' ] ) : ?>
213 213
 				<?php $this->pagination(); ?>
214 214
 			<?php endif; ?>
215 215
 		</div>
@@ -224,10 +224,10 @@  discard block
 block discarded – undo
224 224
 
225 225
 		$search_term = '';
226 226
 
227
-		if ( isset( $_POST['wordpoints_points_logs_search'] ) ) { // WPCS: CSRF OK
227
+		if ( isset( $_POST[ 'wordpoints_points_logs_search' ] ) ) { // WPCS: CSRF OK
228 228
 			$search_term = trim(
229 229
 				sanitize_text_field(
230
-					wp_unslash( $_POST['wordpoints_points_logs_search'] ) // WPCS: CSRF OK
230
+					wp_unslash( $_POST[ 'wordpoints_points_logs_search' ] ) // WPCS: CSRF OK
231 231
 				)
232 232
 			);
233 233
 
@@ -245,10 +245,10 @@  discard block
 block discarded – undo
245 245
 		$page = 1;
246 246
 
247 247
 		if (
248
-			isset( $_GET['wordpoints_points_logs_page'] ) // WPCS: CSRF OK.
249
-			&& wordpoints_posint( $_GET['wordpoints_points_logs_page'] ) // WPCS: CSRF OK.
248
+			isset( $_GET[ 'wordpoints_points_logs_page' ] ) // WPCS: CSRF OK.
249
+			&& wordpoints_posint( $_GET[ 'wordpoints_points_logs_page' ] ) // WPCS: CSRF OK.
250 250
 		) {
251
-			$page = (int) $_GET['wordpoints_points_logs_page'];
251
+			$page = (int) $_GET[ 'wordpoints_points_logs_page' ];
252 252
 		}
253 253
 
254 254
 		return $page;
@@ -262,10 +262,10 @@  discard block
 block discarded – undo
262 262
 		$per_page = 25;
263 263
 
264 264
 		if (
265
-			isset( $_GET['wordpoints_points_logs_per_page'] ) // WPCS: CSRF OK.
266
-			&& wordpoints_posint( $_GET['wordpoints_points_logs_per_page'] ) // WPCS: CSRF OK.
265
+			isset( $_GET[ 'wordpoints_points_logs_per_page' ] ) // WPCS: CSRF OK.
266
+			&& wordpoints_posint( $_GET[ 'wordpoints_points_logs_per_page' ] ) // WPCS: CSRF OK.
267 267
 		) {
268
-			$per_page = (int) $_GET['wordpoints_points_logs_per_page'];
268
+			$per_page = (int) $_GET[ 'wordpoints_points_logs_per_page' ];
269 269
 		}
270 270
 
271 271
 		return $per_page;
Please login to merge, or discard this patch.