WordPoints / hooks-api

src/includes/classes/entity/user/roles.php

Spacing +4 added lines, -4 removed lines

@@ -34,15 +34,15 @@ 
 	/**
 	 * @since 1.0.0
 	 */
-	protected function get_related_entity_ids( WordPoints_Entity $entity ) {
-		return $entity->get_the_attr_value( $this->related_ids_field );
+	protected function get_related_entity_ids(WordPoints_Entity $entity) {
+		return $entity->get_the_attr_value($this->related_ids_field);
 	}
 
 	/**
 	 * @since 1.0.0
 	 */
 	public function get_title() {
-		return __( 'Roles', 'wordpoints' );
+		return __('Roles', 'wordpoints');
 	}
 
 	/**
@@ -62,7 +62,7 @@ 
 				'conditions'       => array(
 					array(
 						'field' => 'meta_key',
-						'value' => $GLOBALS['wpdb']->get_blog_prefix() . 'capabilities',
+						'value' => $GLOBALS['wpdb']->get_blog_prefix().'capabilities',
 					),
 				),
 			),

src/includes/classes/hook/reaction.php

Spacing +5 added lines, -5 removed lines

@@ -35,18 +35,18 @@ 
 	/**
 	 * @since 1.0.0
 	 */
-	public function __construct( $id, WordPoints_Hook_Reaction_StoreI $store ) {
+	public function __construct($id, WordPoints_Hook_Reaction_StoreI $store) {
 
-		$this->ID    = wordpoints_int( $id );
+		$this->ID    = wordpoints_int($id);
 		$this->store = $store;
 	}
 
 	/**
 	 * @since 1.0.0
 	 */
-	public function __get( $var ) {
+	public function __get($var) {
 
-		if ( 'ID' === $var ) {
+		if ('ID' === $var) {
 			return $this->ID;
 		}
 
@@ -69,7 +69,7 @@ 
 	 * @since 1.0.0
 	 */
 	public function get_reactor_slug() {
-		return $this->get_meta( 'reactor' ); // TODO remove this method?
+		return $this->get_meta('reactor'); // TODO remove this method?
 	}
 
 	/**

src/includes/classes/hook/reaction/validator.php

Spacing +32 added lines, -32 removed lines

@@ -103,12 +103,12 @@ 
 	 * @param bool                            $fail_fast Whether to fail as soon as
 	 *                                                   the first error is found.
 	 */
-	public function __construct( $settings, $fail_fast = false ) {
+	public function __construct($settings, $fail_fast = false) {
 
 		$this->fail_fast = $fail_fast;
 		$this->hooks = wordpoints_hooks();
 
-		if ( $settings instanceof WordPoints_Hook_ReactionI ) {
+		if ($settings instanceof WordPoints_Hook_ReactionI) {
 
 			$this->reaction     = $settings;
 			$this->settings     = $this->reaction->get_all_meta();
@@ -119,11 +119,11 @@ 
 
 			$this->settings = $settings;
 
-			if ( isset( $this->settings['event'] ) ) {
+			if (isset($this->settings['event'])) {
 				$this->event_slug = $this->settings['event'];
 			}
 
-			if ( isset( $this->settings['reactor'] ) ) {
+			if (isset($this->settings['reactor'])) {
 				$this->reactor_slug = $this->settings['reactor'];
 			}
 		}
@@ -146,16 +146,16 @@ 
 			$fail_fast = $this->fail_fast;
 			$this->fail_fast = true;
 
-			if ( ! isset( $this->event_slug ) ) {
-				$this->add_error( __( 'Event is missing.', 'wordpoints' ), 'event' );
-			} elseif ( ! $this->hooks->events->is_registered( $this->event_slug ) ) {
-				$this->add_error( __( 'Event is invalid.', 'wordpoints' ), 'event' );
+			if ( ! isset($this->event_slug)) {
+				$this->add_error(__('Event is missing.', 'wordpoints'), 'event');
+			} elseif ( ! $this->hooks->events->is_registered($this->event_slug)) {
+				$this->add_error(__('Event is invalid.', 'wordpoints'), 'event');
 			}
 
-			if ( ! isset( $this->reactor_slug ) ) {
-				$this->add_error( __( 'Reactor is missing.', 'wordpoints' ), 'reactor' );
-			} elseif ( ! $this->hooks->reactors->is_registered( $this->reactor_slug ) ) {
-				$this->add_error( __( 'Reactor is invalid.', 'wordpoints' ), 'reactor' );
+			if ( ! isset($this->reactor_slug)) {
+				$this->add_error(__('Reactor is missing.', 'wordpoints'), 'reactor');
+			} elseif ( ! $this->hooks->reactors->is_registered($this->reactor_slug)) {
+				$this->add_error(__('Reactor is invalid.', 'wordpoints'), 'reactor');
 			}
 
 			// From here on out we can collect errors as they come (unless we are
@@ -166,16 +166,16 @@ 
 				$this->event_slug
 			);
 
-			$this->event_args = new WordPoints_Hook_Event_Args( $event_args );
-			$this->event_args->set_validator( $this );
+			$this->event_args = new WordPoints_Hook_Event_Args($event_args);
+			$this->event_args->set_validator($this);
 
-			$reactor = $this->hooks->reactors->get( $this->reactor_slug );
+			$reactor = $this->hooks->reactors->get($this->reactor_slug);
 
-			$this->settings = $reactor->validate_settings( $this->settings, $this, $this->event_args );
+			$this->settings = $reactor->validate_settings($this->settings, $this, $this->event_args);
 
 			/** @var WordPoints_Hook_Extension $extension */
-			foreach ( $this->hooks->extensions->get_all() as $extension ) {
-				$this->settings = $extension->validate_settings( $this->settings, $this, $this->event_args );
+			foreach ($this->hooks->extensions->get_all() as $extension) {
+				$this->settings = $extension->validate_settings($this->settings, $this, $this->event_args);
 			}
 
 			/**
@@ -185,12 +185,12 @@ 
 			 * @param WordPoints_Hook_Reaction_Validator $validator The validator object.
 			 * @param WordPoints_Hook_Event_Args         $args      The event args object.
 			 */
-			$this->settings = apply_filters( 'wordpoints_hook_reaction_validate', $this->settings, $this, $this->event_args );
+			$this->settings = apply_filters('wordpoints_hook_reaction_validate', $this->settings, $this, $this->event_args);
 
-		} catch ( WordPoints_Hook_Validator_Exception $e ) {
+		} catch (WordPoints_Hook_Validator_Exception $e) {
 
 			// Do nothing.
-			unset( $e );
+			unset($e);
 		}
 
 		return $this->settings;
@@ -218,17 +218,17 @@ 
 	 * @throws WordPoints_Hook_Validator_Exception If the validator is configured to
 	 *                                             fail as soon as an error is found.
 	 */
-	public function add_error( $message, $field = null ) {
+	public function add_error($message, $field = null) {
 
 		$field_stack = $this->field_stack;
 
-		if ( null !== $field ) {
+		if (null !== $field) {
 			$field_stack[] = $field;
 		}
 
-		$this->errors[] = array( 'message' => $message, 'field' => $field_stack );
+		$this->errors[] = array('message' => $message, 'field' => $field_stack);
 
-		if ( $this->fail_fast ) {
+		if ($this->fail_fast) {
 			throw new WordPoints_Hook_Validator_Exception;
 		}
 	}
@@ -241,7 +241,7 @@ 
 	 * @return bool Whether the validator found any errors.
 	 */
 	public function had_errors() {
-		return ! empty( $this->errors );
+		return ! empty($this->errors);
 	}
 
 	/**
@@ -262,7 +262,7 @@ 
 	 *
 	 * @param string $field The field.
 	 */
-	public function push_field( $field ) {
+	public function push_field($field) {
 		$this->field_stack[] = $field;
 	}
 
@@ -272,7 +272,7 @@ 
 	 * @since 1.0.0
 	 */
 	public function pop_field() {
-		array_pop( $this->field_stack );
+		array_pop($this->field_stack);
 	}
 
 	/**
@@ -317,7 +317,7 @@ 
 	 */
 	public function get_id() {
 
-		if ( ! $this->reaction ) {
+		if ( ! $this->reaction) {
 			return false;
 		}
 
@@ -355,13 +355,13 @@ 
 	 *
 	 * @return mixed The meta value.
 	 */
-	public function get_meta( $key ) {
+	public function get_meta($key) {
 
-		if ( ! isset( $this->settings[ $key ] ) ) {
+		if ( ! isset($this->settings[$key])) {
 			return null;
 		}
 
-		return $this->settings[ $key ];
+		return $this->settings[$key];
 	}
 
 	/**

src/includes/classes/hook/reaction/storei.php

Spacing +7 added lines, -7 removed lines

@@ -24,7 +24,7 @@ 
 	 *
 	 * @param string $slug The slug of this store.
 	 */
-	public function __construct( $slug );
+	public function __construct($slug);
 
 	/**
 	 * Get the slug of this reaction store.
@@ -59,7 +59,7 @@ 
 	 *
 	 * @return bool Whether the reaction exists.
 	 */
-	public function reaction_exists( $id );
+	public function reaction_exists($id);
 
 	/**
 	 * Get an reaction object.
@@ -70,7 +70,7 @@ 
 	 *
 	 * @return WordPoints_Hook_ReactionI|false The reaction, or false if nonexistent.
 	 */
-	public function get_reaction( $id );
+	public function get_reaction($id);
 
 	/**
 	 * Create an reaction.
@@ -83,7 +83,7 @@ 
 	 *         The reaction object if created successfully. False or a validator
 	 *         instance if not.
 	 */
-	public function create_reaction( array $settings );
+	public function create_reaction(array $settings);
 
 	/**
 	 * Update an reaction.
@@ -97,7 +97,7 @@ 
 	 *         The reaction object if updated successfully. False or a validator
 	 *         instance if not.
 	 */
-	public function update_reaction( $id, array $settings );
+	public function update_reaction($id, array $settings);
 
 	/**
 	 * Delete an reaction.
@@ -108,7 +108,7 @@ 
 	 *
 	 * @return bool Whether the reaction was deleted successfully.
 	 */
-	public function delete_reaction( $id );
+	public function delete_reaction($id);
 
 	/**
 	 * Get all hook reactions for the reactor.
@@ -131,7 +131,7 @@ 
 	 *
 	 * @return WordPoints_Hook_ReactionI[]
 	 */
-	public function get_reactions_to_event( $event_slug );
+	public function get_reactions_to_event($event_slug);
 }
 
 // EOF

src/includes/classes/entity/comment/post.php

Spacing +2 added lines, -2 removed lines

@@ -37,8 +37,8 @@
 	/**
 	 * @since 1.0.0
 	 */
-	protected function get_related_entity_ids( WordPoints_Entity $entity ) {
-		return $entity->get_the_attr_value( $this->related_ids_field );
+	protected function get_related_entity_ids(WordPoints_Entity $entity) {
+		return $entity->get_the_attr_value($this->related_ids_field);
 	}
 	
 	/**

src/includes/classes/hook/events.php

Spacing +21 added lines, -21 removed lines

@@ -37,13 +37,13 @@ 
 	/**
 	 * @since 1.0.0
 	 */
-	public function __construct( $slug ) {
+	public function __construct($slug) {
 
 		$hooks = wordpoints_hooks();
 
 		$this->router = $hooks->router;
 
-		parent::__construct( $slug );
+		parent::__construct($slug);
 	}
 
 	/**
@@ -51,7 +51,7 @@ 
 	 */
 	public function init() {
 
-		$this->sub_apps->register( 'args', 'WordPoints_Class_Registry_Children' );
+		$this->sub_apps->register('args', 'WordPoints_Class_Registry_Children');
 
 		parent::init();
 	}
@@ -75,25 +75,25 @@ 
 	 *
 	 * @return bool Whether the event was registered.
 	 */
-	public function register( $slug, $class, array $args = array() ) {
+	public function register($slug, $class, array $args = array()) {
 
-		parent::register( $slug, $class, $args );
+		parent::register($slug, $class, $args);
 
-		if ( isset( $args['actions'] ) ) {
-			foreach ( $args['actions'] as $type => $actions ) {
-				foreach ( (array) $actions as $action_slug ) {
-					$this->router->add_event_to_action( $slug, $action_slug, $type );
+		if (isset($args['actions'])) {
+			foreach ($args['actions'] as $type => $actions) {
+				foreach ((array) $actions as $action_slug) {
+					$this->router->add_event_to_action($slug, $action_slug, $type);
 				}
 			}
 		}
 
-		if ( isset( $args['args'] ) ) {
-			foreach ( $args['args'] as $arg_slug => $class ) {
-				$this->args->register( $slug, $arg_slug, $class );
+		if (isset($args['args'])) {
+			foreach ($args['args'] as $arg_slug => $class) {
+				$this->args->register($slug, $arg_slug, $class);
 			}
 		}
 
-		$this->event_data[ $slug ] = $args;
+		$this->event_data[$slug] = $args;
 
 		return true;
 	}
@@ -101,23 +101,23 @@ 
 	/**
 	 * @since 1.0.0
 	 */
-	public function deregister( $slug ) {
+	public function deregister($slug) {
 
-		if ( ! $this->is_registered( $slug ) ) {
+		if ( ! $this->is_registered($slug)) {
 			return;
 		}
 
-		parent::deregister( $slug );
+		parent::deregister($slug);
 
-		foreach ( (array) $this->event_data[ $slug ]['actions'] as $type => $actions ) {
-			foreach ( (array) $actions as $action_slug ) {
-				$this->router->remove_event_from_action( $slug, $action_slug, $type );
+		foreach ((array) $this->event_data[$slug]['actions'] as $type => $actions) {
+			foreach ((array) $actions as $action_slug) {
+				$this->router->remove_event_from_action($slug, $action_slug, $type);
 			}
 		}
 
-		$this->args->deregister_children( $slug );
+		$this->args->deregister_children($slug);
 
-		unset( $this->event_data[ $slug ] );
+		unset($this->event_data[$slug]);
 	}
 }
 

src/includes/classes/hook/extension/periods.php

Spacing +77 added lines, -77 removed lines

@@ -36,11 +36,11 @@ 
 	public function get_ui_script_data() {
 
 		$periods = array(
-			MINUTE_IN_SECONDS   => __( 'Minute', 'wordpoints' ),
-			HOUR_IN_SECONDS     => __( 'Hour',   'wordpoints' ),
-			DAY_IN_SECONDS      => __( 'Day',    'wordpoints' ),
-			WEEK_IN_SECONDS     => __( 'Week',   'wordpoints' ),
-			30 * DAY_IN_SECONDS => __( 'Month',  'wordpoints' ),
+			MINUTE_IN_SECONDS   => __('Minute', 'wordpoints'),
+			HOUR_IN_SECONDS     => __('Hour', 'wordpoints'),
+			DAY_IN_SECONDS      => __('Day', 'wordpoints'),
+			WEEK_IN_SECONDS     => __('Week', 'wordpoints'),
+			30 * DAY_IN_SECONDS => __('Month', 'wordpoints'),
 		);
 
 		/**
@@ -50,12 +50,12 @@ 
 		 *
 		 * @param string[] $periods The period titles, indexed by length in seconds.
 		 */
-		$periods = apply_filters( 'wordpoints_hooks_ui_data_periods', $periods );
+		$periods = apply_filters('wordpoints_hooks_ui_data_periods', $periods);
 
 		return array(
 			'periods' => $periods,
 			'l10n' => array(
-				'label' => __( 'Trigger reaction no more than once per:', 'wordpoints' ),
+				'label' => __('Trigger reaction no more than once per:', 'wordpoints'),
 			),
 		);
 	}
@@ -69,25 +69,25 @@ 
 	 *
 	 * @return array The validated periods.
 	 */
-	protected function validate_action_type_settings( $periods ) {
+	protected function validate_action_type_settings($periods) {
 
-		if ( ! is_array( $periods ) ) {
+		if ( ! is_array($periods)) {
 
 			$this->validator->add_error(
-				__( 'Periods do not match expected format.', 'wordpoints' )
+				__('Periods do not match expected format.', 'wordpoints')
 			);
 
 			return array();
 		}
 
-		foreach ( $periods as $index => $period ) {
+		foreach ($periods as $index => $period) {
 
-			$this->validator->push_field( $index );
+			$this->validator->push_field($index);
 
-			$period = $this->validate_period( $period );
+			$period = $this->validate_period($period);
 
-			if ( $period ) {
-				$periods[ $index ] = $period;
+			if ($period) {
+				$periods[$index] = $period;
 			}
 
 			$this->validator->pop_field();
@@ -105,30 +105,30 @@ 
 	 *
 	 * @return array|false The validated period, or false if invalid.
 	 */
-	protected function validate_period( $period ) {
+	protected function validate_period($period) {
 
-		if ( ! is_array( $period ) ) {
+		if ( ! is_array($period)) {
 			$this->validator->add_error(
-				__( 'Period does not match expected format.', 'wordpoints' )
+				__('Period does not match expected format.', 'wordpoints')
 			);
 
 			return false;
 		}
 
-		if ( isset( $period['args'] ) ) {
-			$this->validate_period_args( $period['args'] );
+		if (isset($period['args'])) {
+			$this->validate_period_args($period['args']);
 		}
 
-		if ( ! isset( $period['length'] ) ) {
+		if ( ! isset($period['length'])) {
 
 			$this->validator->add_error(
-				__( 'Period length setting is missing.', 'wordpoints' )
+				__('Period length setting is missing.', 'wordpoints')
 			);
 
-		} elseif ( false === wordpoints_posint( $period['length'] ) ) {
+		} elseif (false === wordpoints_posint($period['length'])) {
 
 			$this->validator->add_error(
-				__( 'Period length must be a positive integer.', 'wordpoints' )
+				__('Period length must be a positive integer.', 'wordpoints')
 				, 'length'
 			);
 
@@ -145,34 +145,34 @@ 
 	 *
 	 * @param mixed $args The args the period is related to.
 	 */
-	protected function validate_period_args( $args ) {
+	protected function validate_period_args($args) {
 
-		if ( ! is_array( $args ) ) {
+		if ( ! is_array($args)) {
 
 			$this->validator->add_error(
-				__( 'Period does not match expected format.', 'wordpoints' )
+				__('Period does not match expected format.', 'wordpoints')
 				, 'args'
 			);
 
 			return;
 		}
 
-		$this->validator->push_field( 'args' );
+		$this->validator->push_field('args');
 
-		foreach ( $args as $index => $hierarchy ) {
+		foreach ($args as $index => $hierarchy) {
 
-			$this->validator->push_field( $index );
+			$this->validator->push_field($index);
 
-			if ( ! is_array( $hierarchy ) ) {
+			if ( ! is_array($hierarchy)) {
 
 				$this->validator->add_error(
-					__( 'Period does not match expected format.', 'wordpoints' )
+					__('Period does not match expected format.', 'wordpoints')
 				);
 
-			} elseif ( ! $this->event_args->get_from_hierarchy( $hierarchy ) ) {
+			} elseif ( ! $this->event_args->get_from_hierarchy($hierarchy)) {
 
 				$this->validator->add_error(
-					__( 'Invalid period.', 'wordpoints' ) // TODO better error message
+					__('Invalid period.', 'wordpoints') // TODO better error message
 				);
 			}
 
@@ -185,19 +185,19 @@ 
 	/**
 	 * @since 1.0.0
 	 */
-	public function should_hit( WordPoints_Hook_Fire $fire ) {
+	public function should_hit(WordPoints_Hook_Fire $fire) {
 
-		$periods = $this->get_settings_from_fire( $fire );
+		$periods = $this->get_settings_from_fire($fire);
 
-		if ( empty( $periods ) ) {
+		if (empty($periods)) {
 			return true;
 		}
 
 		$this->event_args = $fire->event_args;
 		$this->action_type = $fire->action_type;
 
-		foreach ( $periods as $period ) {
-			if ( ! $this->has_period_ended( $period, $fire->reaction ) ) {
+		foreach ($periods as $period) {
+			if ( ! $this->has_period_ended($period, $fire->reaction)) {
 				return false;
 			}
 		}
@@ -221,24 +221,24 @@ 
 	) {
 
 		$period = $this->get_period_by_reaction(
-			$this->get_period_signature( $settings, $reaction )
+			$this->get_period_signature($settings, $reaction)
 			, $reaction
 		);
 
 		// If the period isn't found, we know that we can still fire.
-		if ( ! $period ) {
+		if ( ! $period) {
 			return true;
 		}
 
-		$now = current_time( 'timestamp' );
-		$hit_time = strtotime( $period->date, $now );
+		$now = current_time('timestamp');
+		$hit_time = strtotime($period->date, $now);
 
-		if ( ! empty( $settings['relative'] ) ) {
-			return ( $hit_time < $now - $settings['length'] );
+		if ( ! empty($settings['relative'])) {
+			return ($hit_time < $now - $settings['length']);
 		} else {
 			return (
-				(int) ( $hit_time / $settings['length'] )
-				< (int) ( $now / $settings['length'] )
+				(int) ($hit_time / $settings['length'])
+				< (int) ($now / $settings['length'])
 			);
 		}
 	}
@@ -252,24 +252,24 @@ 
 	 *
 	 * @return array The arg values.
 	 */
-	protected function get_arg_values( array $period_args ) {
+	protected function get_arg_values(array $period_args) {
 
 		$values = array();
 
-		foreach ( $period_args as $arg_hierarchy ) {
+		foreach ($period_args as $arg_hierarchy) {
 
 			$arg = $this->event_args->get_from_hierarchy(
 				$arg_hierarchy
 			);
 
-			if ( ! $arg instanceof WordPoints_EntityishI ) {
+			if ( ! $arg instanceof WordPoints_EntityishI) {
 				continue;
 			}
 
-			$values[ implode( '.', $arg_hierarchy ) ] = $arg->get_the_value();
+			$values[implode('.', $arg_hierarchy)] = $arg->get_the_value();
 		}
 
-		ksort( $values );
+		ksort($values);
 
 		return $values;
 	}
@@ -283,11 +283,11 @@ 
 	 *
 	 * @return object|false The period data, or false if not found.
 	 */
-	protected function get_period( $period_id ) {
+	protected function get_period($period_id) {
 
-		$period = wp_cache_get( $period_id, 'wordpoints_hook_periods' );
+		$period = wp_cache_get($period_id, 'wordpoints_hook_periods');
 
-		if ( ! $period ) {
+		if ( ! $period) {
 
 			global $wpdb;
 
@@ -304,11 +304,11 @@ 
 				)
 			);
 
-			if ( ! $period ) {
+			if ( ! $period) {
 				return false;
 			}
 
-			wp_cache_set( $period->id, $period, 'wordpoints_hook_periods' );
+			wp_cache_set($period->id, $period, 'wordpoints_hook_periods');
 		}
 
 		return $period;
@@ -332,14 +332,14 @@ 
 
 		$reaction_guid = $reaction->get_guid();
 
-		$cache_key = wp_json_encode( $reaction_guid ) . "-{$signature}-{$this->action_type}";
+		$cache_key = wp_json_encode($reaction_guid)."-{$signature}-{$this->action_type}";
 
 		// Before we run the query, we try to lookup the ID in the cache.
-		$period_id = wp_cache_get( $cache_key, 'wordpoints_hook_period_ids_by_reaction' );
+		$period_id = wp_cache_get($cache_key, 'wordpoints_hook_period_ids_by_reaction');
 
 		// If we found it, we can retrieve the period by ID instead.
-		if ( $period_id ) {
-			return $this->get_period( $period_id );
+		if ($period_id) {
+			return $this->get_period($period_id);
 		}
 
 		global $wpdb;
@@ -362,18 +362,18 @@ 
 				"
 				, $signature
 				, $reaction_guid['store']
-				, wp_json_encode( $reaction_guid['context_id'] )
+				, wp_json_encode($reaction_guid['context_id'])
 				, $reaction_guid['id']
 				, $this->action_type
 			)
 		);
 
-		if ( ! $period ) {
+		if ( ! $period) {
 			return false;
 		}
 
-		wp_cache_set( $cache_key, $period->id, 'wordpoints_hook_period_ids_by_reaction' );
-		wp_cache_set( $period->id, $period, 'wordpoints_hook_periods' );
+		wp_cache_set($cache_key, $period->id, 'wordpoints_hook_period_ids_by_reaction');
+		wp_cache_set($period->id, $period, 'wordpoints_hook_periods');
 
 		return $period;
 	}
@@ -381,21 +381,21 @@ 
 	/**
 	 * @since 1.0.0
 	 */
-	public function after_hit( WordPoints_Hook_Fire $fire ) {
+	public function after_hit(WordPoints_Hook_Fire $fire) {
 
-		$periods = $this->get_settings_from_fire( $fire );
+		$periods = $this->get_settings_from_fire($fire);
 
-		if ( empty( $periods ) ) {
+		if (empty($periods)) {
 			return;
 		}
 
 		$this->event_args = $fire->event_args;
 		$this->action_type = $fire->action_type;
 
-		foreach ( $periods as $settings ) {
+		foreach ($periods as $settings) {
 
 			$this->add_period(
-				$this->get_period_signature( $settings, $fire->reaction )
+				$this->get_period_signature($settings, $fire->reaction)
 				, $fire
 			);
 		}
@@ -420,14 +420,14 @@ 
 		WordPoints_Hook_ReactionI $reaction
 	) {
 
-		if ( isset( $settings['args'] ) ) {
+		if (isset($settings['args'])) {
 			$period_args = $settings['args'];
 		} else {
-			$period_args = array( $reaction->get_meta( 'target' ) );
+			$period_args = array($reaction->get_meta('target'));
 		}
 
 		return wordpoints_hash(
-			wp_json_encode( $this->get_arg_values( $period_args ) )
+			wp_json_encode($this->get_arg_values($period_args))
 		);
 	}
 
@@ -441,7 +441,7 @@ 
 	 *
 	 * @return false|object The period data, or false if not found.
 	 */
-	protected function add_period( $signature, WordPoints_Hook_Fire $fire ) {
+	protected function add_period($signature, WordPoints_Hook_Fire $fire) {
 
 		global $wpdb;
 
@@ -451,17 +451,17 @@ 
 				'hit_id' => $fire->hit_id,
 				'signature' => $signature,
 			)
-			, array( '%d', '%s' )
+			, array('%d', '%s')
 		);
 
-		if ( ! $inserted ) {
+		if ( ! $inserted) {
 			return false;
 		}
 
 		$period_id = $wpdb->insert_id;
 
 		wp_cache_set(
-			wp_json_encode( $fire->reaction->get_guid() ) . "-{$signature}-{$this->action_type}"
+			wp_json_encode($fire->reaction->get_guid())."-{$signature}-{$this->action_type}"
 			, $period_id
 			, 'wordpoints_hook_period_ids_by_reaction'
 		);

src/includes/classes/hook/reactor.php

Spacing +9 added lines, -9 removed lines

@@ -143,21 +143,21 @@ 
 	) {
 
 		if (
-			empty( $settings['target'] )
-			|| ! is_array( $settings['target'] )
+			empty($settings['target'])
+			|| ! is_array($settings['target'])
 		) {
 
-			$validator->add_error( __( 'Invalid target.', 'wordpoints' ), 'target' );
+			$validator->add_error(__('Invalid target.', 'wordpoints'), 'target');
 
 		} else {
 
-			$target = $event_args->get_from_hierarchy( $settings['target'] );
+			$target = $event_args->get_from_hierarchy($settings['target']);
 
 			if (
 				! $target instanceof WordPoints_Entity
-				|| ! in_array( $target->get_slug(), (array) $this->arg_types )
+				|| ! in_array($target->get_slug(), (array) $this->arg_types)
 			) {
-				$validator->add_error( __( 'Invalid target.', 'wordpoints' ), 'target' );
+				$validator->add_error(__('Invalid target.', 'wordpoints'), 'target');
 			}
 		}
 
@@ -167,8 +167,8 @@ 
 	/**
 	 * @since 1.0.0
 	 */
-	public function update_settings( WordPoints_Hook_ReactionI $reaction, array $settings ) {
-		$reaction->update_meta( 'target', $settings['target'] );
+	public function update_settings(WordPoints_Hook_ReactionI $reaction, array $settings) {
+		$reaction->update_meta('target', $settings['target']);
 	}
 
 	/**
@@ -178,7 +178,7 @@ 
 	 *
 	 * @param WordPoints_Hook_Fire $fire The hook fire object.
 	 */
-	abstract public function hit( WordPoints_Hook_Fire $fire );
+	abstract public function hit(WordPoints_Hook_Fire $fire);
 }
 
 // EOF

src/includes/classes/entity/change.php

Doc Comments +15 added lines

@@ -58,8 +58,20 @@ 
 
 // this is basically a reactor
 interface WordPoints_Entity_Change_ListenerI {
+
+	/**
+	 * @return void
+	 */
 	public function created( WordPoints_Entity $entity );
+
+	/**
+	 * @return void
+	 */
 	public function updated( WordPoints_Entity $before, WordPoints_Entity $after );
+
+	/**
+	 * @return void
+	 */
 	public function deleted( WordPoints_Entity $entity );
 }
 
@@ -129,6 +141,9 @@ 
 		return true;
 	}
 
+	/**
+	 * @param string $type
+	 */
 	protected function fire_event( $type, WordPoints_Entity $entity ) {
 
 		$args = new WordPoints_Hook_Event_Args( array() );

Spacing +62 added lines, -62 removed lines

@@ -10,19 +10,19 @@ 
 // this is basicaly a router.
 class WordPoints_Entity_chang_trigger implements WordPoints_Entity_Change_ListenerI {
 
-	public function created( WordPoints_Entity $entity ) {
+	public function created(WordPoints_Entity $entity) {
 		// can multiple entities be created at once? not using insert() but via query()
 		// maybe? and how shoudl we handle that, all at once or one by one?
 
 		/** @var WordPoints_Entity_Change_ListenerI[] $listeners */
-		$listeners = wordpoints_apps()->sub_apps->get( 'entity_change_listeners' );
-		foreach ( $listeners as $listener ) {
-			$listener->created( $entity );
+		$listeners = wordpoints_apps()->sub_apps->get('entity_change_listeners');
+		foreach ($listeners as $listener) {
+			$listener->created($entity);
 		}
 	}
 
 
-	public function updated( WordPoints_Entity $before, WordPoints_Entity $after ) {
+	public function updated(WordPoints_Entity $before, WordPoints_Entity $after) {
 
 		// what if multiple entities are updated at once? do we run each one separatately?
 		// mayb ethat should be left up to the listenter.
@@ -30,7 +30,7 @@ 
 	}
 
 
-	public function deleted( WordPoints_Entity $entity ) {
+	public function deleted(WordPoints_Entity $entity) {
 
 		// what if we need information about this entitie's relationships, etc., that
 		// isn't included inthe entity object?
@@ -58,41 +58,41 @@ 
 
 // this is basically a reactor
 interface WordPoints_Entity_Change_ListenerI {
-	public function created( WordPoints_Entity $entity );
-	public function updated( WordPoints_Entity $before, WordPoints_Entity $after );
-	public function deleted( WordPoints_Entity $entity );
+	public function created(WordPoints_Entity $entity);
+	public function updated(WordPoints_Entity $before, WordPoints_Entity $after);
+	public function deleted(WordPoints_Entity $entity);
 }
 
 class WordPoints_Entity_Change_Listener_Hooks implements WordPoints_Entity_Change_ListenerI {
 
-	public function created( WordPoints_Entity $entity ) {
+	public function created(WordPoints_Entity $entity) {
 
 		// maybe we would have multuiple events with requirements for a single entity?
 		// like comment author and post commentn author targets for the same hook.
 		// but I guess taht is just one event.
 		// what about user register vs user create on MS?
-		if ( $this->matches_requirements( $entity ) ) {
-			$this->fire_event( 'add', $entity );
+		if ($this->matches_requirements($entity)) {
+			$this->fire_event('add', $entity);
 		}
 	}
 
-	public function updated( WordPoints_Entity $before, WordPoints_Entity $after ) {
+	public function updated(WordPoints_Entity $before, WordPoints_Entity $after) {
 
-		if ( $this->matches_requirements( $after ) ) {
-			if ( ! $this->matches_requirements( $before ) ) {
-				$this->fire_event( 'add', $after );
+		if ($this->matches_requirements($after)) {
+			if ( ! $this->matches_requirements($before)) {
+				$this->fire_event('add', $after);
 			}
 		} else {
-			if ( $this->matches_requirements( $before ) ) {
-				$this->fire_event( 'remove', $after );
+			if ($this->matches_requirements($before)) {
+				$this->fire_event('remove', $after);
 			}
 		}
 	}
 
-	public function deleted( WordPoints_Entity $entity ) {
+	public function deleted(WordPoints_Entity $entity) {
 
-		if ( $this->matches_requirements( $entity ) ) {
-			$this->fire_event( 'remove', $entity );
+		if ($this->matches_requirements($entity)) {
+			$this->fire_event('remove', $entity);
 		}
 	}
 
@@ -108,20 +108,20 @@ 
 	// called into play when the entity itself is deleted is moot, because the
 	// reltionships, etc., aren't even taken into account when toggle-off is called,
 	// in the points reactor. other reators might, i guess.
-	protected function matches_requirements( WordPoints_Entity $entity ) {
+	protected function matches_requirements(WordPoints_Entity $entity) {
 
 		/** @var WordPoints_Class_Registry $defaults */
-		$defaults = wordpoints_apps()->sub_apps->get( 'entity_possession_defaults' );
+		$defaults = wordpoints_apps()->sub_apps->get('entity_possession_defaults');
 
-		$defaults = $defaults->get( $entity->get_slug() );
+		$defaults = $defaults->get($entity->get_slug());
 
-		if ( ! $defaults ) {
+		if ( ! $defaults) {
 			return false;
 		}
 
 		// use conditions here?
-		foreach ( $defaults as $child => $value ) {
-			if ( $entity->get_child( $child ) !== $value ) {
+		foreach ($defaults as $child => $value) {
+			if ($entity->get_child($child) !== $value) {
 				return false;
 			}
 		}
@@ -129,13 +129,13 @@ 
 		return true;
 	}
 
-	protected function fire_event( $type, WordPoints_Entity $entity ) {
+	protected function fire_event($type, WordPoints_Entity $entity) {
 
-		$args = new WordPoints_Hook_Event_Args( array() );
-		$args->add_entity( $entity );
+		$args = new WordPoints_Hook_Event_Args(array());
+		$args->add_entity($entity);
 
 		wordpoints_hooks()->fire(
-			$type . '_entity_' . $entity->get_slug(),
+			$type.'_entity_'.$entity->get_slug(),
 			$args,
 			'toggle_on'
 		);
@@ -144,31 +144,31 @@ 
 
 class WordPoints_Entity_Change_Listener_Points implements WordPoints_Entity_Change_ListenerI {
 
-	public function created( WordPoints_Entity $entity ) {
+	public function created(WordPoints_Entity $entity) {
 
 		$this->process_entityish(
 			$entity
-			, $this->get_settings_for_entity( $entity )
+			, $this->get_settings_for_entity($entity)
 		);
 	}
 
-	protected function process_entityish( WordPoints_EntityishI $entity, $settings ) {
+	protected function process_entityish(WordPoints_EntityishI $entity, $settings) {
 
 		// possibly make this more like extension handling
-		if ( ! $this->meets_conditions( $entity, $settings['conditions'] ) ) {
+		if ( ! $this->meets_conditions($entity, $settings['conditions'])) {
 			return;
 		}
 
 		// possibly make this more like reactor handling.
-		$this->award_points( $settings );
+		$this->award_points($settings);
 
 		// only proces the attributes taht have changed.
 		// acutally, in this case, the entity was just created.
-		if ( $entity instanceof WordPoints_Entity_ParentI ) {
+		if ($entity instanceof WordPoints_Entity_ParentI) {
 
 			// this check runs on attributes only.
-			foreach ( $settings['children'] as $child_slug => $child_settings ) {
-				$this->process_entityish( $entity->get_child( $child_slug ), $child_settings );
+			foreach ($settings['children'] as $child_slug => $child_settings) {
+				$this->process_entityish($entity->get_child($child_slug), $child_settings);
 			}
 
 			// we also need to check for any children, like relationships, that have
@@ -176,7 +176,7 @@ 
 			// for this we need a list of relationships.
 			// if we do two-way relationships, we may need to have infinite-loop
 			// halding here, depending.
-			foreach ( $this->get_related_entities( $entity ) as $child_entity ) {
+			foreach ($this->get_related_entities($entity) as $child_entity) {
 				// If a comment was just created, for example, and we have conditions
 				// on the post entity, that affect the comment author, this allows
 				// us to handle those by pulling up the settings for the post entity
@@ -195,7 +195,7 @@ 
 				// as we've proposed...
 				$this->process_entityish(
 					$child_entity
-					, $this->get_entity_settings( $child_entity )
+					, $this->get_entity_settings($child_entity)
 				);
 			}
 		}
@@ -209,15 +209,15 @@ 
 	// doesn't really make sense.
 	// I think relationships can be created and deleted, but not really updated.
 	// so maybe what we need is a separate api?
-	public function updated( WordPoints_Entity $before, WordPoints_Entity $after ) {
+	public function updated(WordPoints_Entity $before, WordPoints_Entity $after) {
 
-		$settings = $this->get_settings_for_entity( $before );
+		$settings = $this->get_settings_for_entity($before);
 
 		/** @var WordPoints_Class_Registry_ChildrenI $children */
 		$children = wordpoints_entities()->children;
-		foreach ( $children->get_children_slugs( $before->get_slug() ) as $child_slug ) {
+		foreach ($children->get_children_slugs($before->get_slug()) as $child_slug) {
 			
-			if ( ! isset( $settings['children'][ $child_slug ] ) ) {
+			if ( ! isset($settings['children'][$child_slug])) {
 				continue;
 			}
 			
@@ -232,23 +232,23 @@ 
 			// but then we'll not be checking even the relationships taht are defined
 			// on the atts. so we have to decide whether those should be handled by
 			// a separate api or not.
-			if ( $before->get_the_attr_value( $child_slug ) === $after->get_the_attr_value( $child_slug ) ) {
+			if ($before->get_the_attr_value($child_slug) === $after->get_the_attr_value($child_slug)) {
 				continue;
 			}
 
 			$this->process_modified_entityish(
-				$before->get_child( $child_slug )
-				, $after->get_child( $child_slug )
-				, $settings['children'][ $child_slug ]
+				$before->get_child($child_slug)
+				, $after->get_child($child_slug)
+				, $settings['children'][$child_slug]
 			);
 		}
 	}
 
-	protected function process_modified_entityish( WordPoints_EntityishI $before, WordPoints_EntityishI $after, $settings ) {
+	protected function process_modified_entityish(WordPoints_EntityishI $before, WordPoints_EntityishI $after, $settings) {
 
-		if ( ! $this->meets_conditions( $before, $settings['conditions'] ) ) {
-			if ( $this->meets_conditions( $after, $settings['conditions'] ) ) {
-				$this->award_points( $settings );
+		if ( ! $this->meets_conditions($before, $settings['conditions'])) {
+			if ($this->meets_conditions($after, $settings['conditions'])) {
+				$this->award_points($settings);
 
 				// also need to process other eneities that are affected by this
 				// change, which may have conditions on this, i.e., that could be
@@ -265,38 +265,38 @@ 
 				// then we do indeed need to run through the children/parents.
 			}
 		} else {
-			if ( ! $this->meets_conditions( $after, $settings['conditions'] ) ) {
-				$this->remove_points( $settings );
+			if ( ! $this->meets_conditions($after, $settings['conditions'])) {
+				$this->remove_points($settings);
 			}
 		}
 	}
 
-	public function deleted( WordPoints_Entity $entity ) {
+	public function deleted(WordPoints_Entity $entity) {
 		// basically the opposite of created().
-		$this->process_entityish_reverse( $entity );
+		$this->process_entityish_reverse($entity);
 	}
 
-	protected function meets_conditions( WordPoints_EntityishI $entityish, $conditions ) {
+	protected function meets_conditions(WordPoints_EntityishI $entityish, $conditions) {
 		// use conditions api
 
 		return false;
 	}
 
-	private function award_points( $settings ) {
+	private function award_points($settings) {
 
-		$hierarchy = new WordPoints_Entity_Hierarchy( $this->eitnty );
+		$hierarchy = new WordPoints_Entity_Hierarchy($this->eitnty);
 		// todo we'll need to introudce entity array targets, possibly.
 		// how will we know how to reverse the target reltinoship chains in the UI
 		// before saving? i guess we'll need to either have a dedicated index fo taht
 		// or else juust look it up by looping through the relationships (though we'd
 		// have to remove the entity array {} part from any one-to-many relationships
 		// and maybe we'd have to add it to others?)
-		$targets = $hierarchy->get_from_hierarchy( $settings['target'] );
+		$targets = $hierarchy->get_from_hierarchy($settings['target']);
 
 		// maybe just one target, maybe several, depending.
 	}
 
-	private function get_related_entities( WordPoints_Entity $entity ) {
+	private function get_related_entities(WordPoints_Entity $entity) {
 
 		// what we need is parental conditions. Conditions that go up the chain,
 		// and look back at parent entities. This way we can handle the info about