WordPoints_Hook_Hit_Logger::log_hit() - Code Metrics - Inspection of "wp-l10n-validator" - WordPoints/hooks-api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 33372a...46be78 )

by J.D.

created 2016-01-28 20:10 UTC

WordPoints_Hook_Hit_Logger::log_hit() B

↳ Parent: WordPoints_Hook_Hit_Logger

Complexity

Conditions	3
Paths	3

Size

Total Lines	39
Code Lines	25

Duplication

Lines	0
Ratio	0 %

Metric	Value
dl	0
loc	39
rs	8.8571
nc	3
cc	3
eloc	25
nop	0

<?php

/**
 * Hook hit logger class.
 *
 * @package wordpoints-hooks-api
 * @since   1.0.0
 */

/**
 * Logs hook hits.
 *
 * @since 1.0.0
 */
class WordPoints_Hook_Hit_Logger {

	/**
	 * The fire for which a hit might occur.
	 *
	 * @since 1.0.0
	 *
	 * @var WordPoints_Hook_Fire
	 */
	protected $fire;

	/**
	 * @param WordPoints_Hook_Fire $fire The fire that might be logged as a hit.
	 */
	public function __construct( WordPoints_Hook_Fire $fire ) {

		$this->fire = $fire;
	}

	/**
	 * Logs a hit for this fire.
	 *
	 * @since 1.0.0
	 *
	 * @return int|false The hit ID, or false if logging the hit failed.
	 */
	public function log_hit() {

		global $wpdb;

		$signature = wordpoints_hooks_get_event_signature( $this->fire->event_args );

		$inserted = $wpdb->insert(
			$wpdb->wordpoints_hook_hits
			, array(
				'fire_type' => $this->fire->firer->get_slug(),
				'signature' => $signature,
				'event' => $this->fire->reaction->get_event_slug(),
				'reactor' => $this->fire->reaction->get_reactor_slug(),
				'reaction_type' => $this->fire->reaction->get_storage_group_slug(),
				'reaction_id' => $this->fire->reaction->ID,
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
				'date' => current_time( 'mysql' ),
			)
		);

		if ( ! $inserted ) {
			return false;
		}

		$hit_id = $wpdb->insert_id;

		$supersedes = $this->fire->get_superseded_hit();

		if ( $supersedes ) {
			$wpdb->update(
				$wpdb->wordpoints_hook_hits
				, array( 'superseded_by' => $hit_id )
				, array( 'id' => $supersedes->id )
				, array( '%d' )
				, array( '%d' )
			);
		}

		return $hit_id;
	}
}

// EOF


1			<?php
2
3			/**
4			* Hook hit logger class.
5			*
6			* @package wordpoints-hooks-api
7			* @since 1.0.0
8			*/
9
10			/**
11			* Logs hook hits.
12			*
13			* @since 1.0.0
14			*/
15			class WordPoints_Hook_Hit_Logger {
16
17			/**
18			* The fire for which a hit might occur.
19			*
20			* @since 1.0.0
21			*
22			* @var WordPoints_Hook_Fire
23			*/
24			protected $fire;
25
26			/**
27			* @param WordPoints_Hook_Fire $fire The fire that might be logged as a hit.
28			*/
29			public function __construct( WordPoints_Hook_Fire $fire ) {
30
31			$this->fire = $fire;
32			}
33
34			/**
35			* Logs a hit for this fire.
36			*
37			* @since 1.0.0
38			*
39			* @return int\|false The hit ID, or false if logging the hit failed.
40			*/
41			public function log_hit() {
42
43			global $wpdb;
44
45			$signature = wordpoints_hooks_get_event_signature( $this->fire->event_args );
46
47			$inserted = $wpdb->insert(
48			$wpdb->wordpoints_hook_hits
49			, array(
50			'fire_type' => $this->fire->firer->get_slug(),
51			'signature' => $signature,
52			'event' => $this->fire->reaction->get_event_slug(),
53			'reactor' => $this->fire->reaction->get_reactor_slug(),
54			'reaction_type' => $this->fire->reaction->get_storage_group_slug(),
55			'reaction_id' => $this->fire->reaction->ID,
			0 ignored issues – show Bug introduced 2016-01-28 20:13 UTC by Report Bug Copy Issue Report Accessing `ID` on the interface `WordPoints_Hook_ReactionI` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
56			'date' => current_time( 'mysql' ),
57			)
58			);
59
60			if ( ! $inserted ) {
61			return false;
62			}
63
64			$hit_id = $wpdb->insert_id;
65
66			$supersedes = $this->fire->get_superseded_hit();
67
68			if ( $supersedes ) {
69			$wpdb->update(
70			$wpdb->wordpoints_hook_hits
71			, array( 'superseded_by' => $hit_id )
72			, array( 'id' => $supersedes->id )
73			, array( '%d' )
74			, array( '%d' )
75			);
76			}
77
78			return $hit_id;
79			}
80			}
81
82			// EOF
83

WordPoints / hooks-api

Push — master ( 33372a...46be78 )

WordPoints_Hook_Hit_Logger::log_hit() B

Complexity

Size

Duplication

Available Fixes

Duplication Side-by-Side

Filter issues like