WordPoints / hooks-api

src/includes/classes/entity/stored/array.php

Spacing +1 added lines, -1 removed lines

@@ -31,7 +31,7 @@
 	public function get_storage_info() {
 		return array(
 			'type' => 'array',
-			'info' => array( 'type' => 'method' ),
+			'info' => array('type' => 'method'),
 		);
 	}
 }

src/includes/classes/entity/relationship/stored/field.php

Spacing +2 added lines, -2 removed lines

@@ -37,8 +37,8 @@
 	/**
 	 * @since 1.0.0
 	 */
-	protected function get_related_entity_ids( WordPoints_Entity $entity ) {
-		return $entity->get_the_attr_value( $this->related_ids_field );
+	protected function get_related_entity_ids(WordPoints_Entity $entity) {
+		return $entity->get_the_attr_value($this->related_ids_field);
 	}
 	
 	/**

src/includes/classes/entity/attr.php

Spacing +3 added lines, -3 removed lines

@@ -39,7 +39,7 @@ 
 	 *
 	 * @return mixed The attribute value.
 	 */
-	abstract protected function get_attr_value_from_entity( WordPoints_Entity $entity );
+	abstract protected function get_attr_value_from_entity(WordPoints_Entity $entity);
 
 	/**
 	 * Get the data type of this attribute's values.
@@ -66,9 +66,9 @@ 
 	 *
 	 * @return bool Whether the value was set correctly.
 	 */
-	public function set_the_value_from_entity( WordPoints_Entity $entity ) {
+	public function set_the_value_from_entity(WordPoints_Entity $entity) {
 
-		$this->the_value = $this->get_attr_value_from_entity( $entity );
+		$this->the_value = $this->get_attr_value_from_entity($entity);
 
 		return true;
 	}

src/includes/classes/entity/user/roles.php

Spacing +4 added lines, -4 removed lines

@@ -34,15 +34,15 @@ 
 	/**
 	 * @since 1.0.0
 	 */
-	protected function get_related_entity_ids( WordPoints_Entity $entity ) {
-		return $entity->get_the_attr_value( $this->related_ids_field );
+	protected function get_related_entity_ids(WordPoints_Entity $entity) {
+		return $entity->get_the_attr_value($this->related_ids_field);
 	}
 
 	/**
 	 * @since 1.0.0
 	 */
 	public function get_title() {
-		return __( 'Roles', 'wordpoints' );
+		return __('Roles', 'wordpoints');
 	}
 
 	/**
@@ -62,7 +62,7 @@ 
 				'conditions'       => array(
 					array(
 						'field' => 'meta_key',
-						'value' => $GLOBALS['wpdb']->get_blog_prefix() . 'capabilities',
+						'value' => $GLOBALS['wpdb']->get_blog_prefix().'capabilities',
 					),
 				),
 			),

src/includes/classes/hook/reaction/validator.php

Spacing +32 added lines, -32 removed lines

@@ -103,12 +103,12 @@ 
 	 * @param bool                            $fail_fast Whether to fail as soon as
 	 *                                                   the first error is found.
 	 */
-	public function __construct( $settings, $fail_fast = false ) {
+	public function __construct($settings, $fail_fast = false) {
 
 		$this->fail_fast = $fail_fast;
 		$this->hooks = wordpoints_hooks();
 
-		if ( $settings instanceof WordPoints_Hook_ReactionI ) {
+		if ($settings instanceof WordPoints_Hook_ReactionI) {
 
 			$this->reaction     = $settings;
 			$this->settings     = $this->reaction->get_all_meta();
@@ -119,11 +119,11 @@ 
 
 			$this->settings = $settings;
 
-			if ( isset( $this->settings['event'] ) ) {
+			if (isset($this->settings['event'])) {
 				$this->event_slug = $this->settings['event'];
 			}
 
-			if ( isset( $this->settings['reactor'] ) ) {
+			if (isset($this->settings['reactor'])) {
 				$this->reactor_slug = $this->settings['reactor'];
 			}
 		}
@@ -146,16 +146,16 @@ 
 			$fail_fast = $this->fail_fast;
 			$this->fail_fast = true;
 
-			if ( ! isset( $this->event_slug ) ) {
-				$this->add_error( __( 'Event is missing.', 'wordpoints' ), 'event' );
-			} elseif ( ! $this->hooks->events->is_registered( $this->event_slug ) ) {
-				$this->add_error( __( 'Event is invalid.', 'wordpoints' ), 'event' );
+			if ( ! isset($this->event_slug)) {
+				$this->add_error(__('Event is missing.', 'wordpoints'), 'event');
+			} elseif ( ! $this->hooks->events->is_registered($this->event_slug)) {
+				$this->add_error(__('Event is invalid.', 'wordpoints'), 'event');
 			}
 
-			if ( ! isset( $this->reactor_slug ) ) {
-				$this->add_error( __( 'Reactor is missing.', 'wordpoints' ), 'reactor' );
-			} elseif ( ! $this->hooks->reactors->is_registered( $this->reactor_slug ) ) {
-				$this->add_error( __( 'Reactor is invalid.', 'wordpoints' ), 'reactor' );
+			if ( ! isset($this->reactor_slug)) {
+				$this->add_error(__('Reactor is missing.', 'wordpoints'), 'reactor');
+			} elseif ( ! $this->hooks->reactors->is_registered($this->reactor_slug)) {
+				$this->add_error(__('Reactor is invalid.', 'wordpoints'), 'reactor');
 			}
 
 			// From here on out we can collect errors as they come (unless we are
@@ -166,16 +166,16 @@ 
 				$this->event_slug
 			);
 
-			$this->event_args = new WordPoints_Hook_Event_Args( $event_args );
-			$this->event_args->set_validator( $this );
+			$this->event_args = new WordPoints_Hook_Event_Args($event_args);
+			$this->event_args->set_validator($this);
 
-			$reactor = $this->hooks->reactors->get( $this->reactor_slug );
+			$reactor = $this->hooks->reactors->get($this->reactor_slug);
 
-			$this->settings = $reactor->validate_settings( $this->settings, $this, $this->event_args );
+			$this->settings = $reactor->validate_settings($this->settings, $this, $this->event_args);
 
 			/** @var WordPoints_Hook_Extension $extension */
-			foreach ( $this->hooks->extensions->get_all() as $extension ) {
-				$this->settings = $extension->validate_settings( $this->settings, $this, $this->event_args );
+			foreach ($this->hooks->extensions->get_all() as $extension) {
+				$this->settings = $extension->validate_settings($this->settings, $this, $this->event_args);
 			}
 
 			/**
@@ -185,12 +185,12 @@ 
 			 * @param WordPoints_Hook_Reaction_Validator $validator The validator object.
 			 * @param WordPoints_Hook_Event_Args         $args      The event args object.
 			 */
-			$this->settings = apply_filters( 'wordpoints_hook_reaction_validate', $this->settings, $this, $this->event_args );
+			$this->settings = apply_filters('wordpoints_hook_reaction_validate', $this->settings, $this, $this->event_args);
 
-		} catch ( WordPoints_Hook_Validator_Exception $e ) {
+		} catch (WordPoints_Hook_Validator_Exception $e) {
 
 			// Do nothing.
-			unset( $e );
+			unset($e);
 		}
 
 		return $this->settings;
@@ -218,17 +218,17 @@ 
 	 * @throws WordPoints_Hook_Validator_Exception If the validator is configured to
 	 *                                             fail as soon as an error is found.
 	 */
-	public function add_error( $message, $field = null ) {
+	public function add_error($message, $field = null) {
 
 		$field_stack = $this->field_stack;
 
-		if ( null !== $field ) {
+		if (null !== $field) {
 			$field_stack[] = $field;
 		}
 
-		$this->errors[] = array( 'message' => $message, 'field' => $field_stack );
+		$this->errors[] = array('message' => $message, 'field' => $field_stack);
 
-		if ( $this->fail_fast ) {
+		if ($this->fail_fast) {
 			throw new WordPoints_Hook_Validator_Exception;
 		}
 	}
@@ -241,7 +241,7 @@ 
 	 * @return bool Whether the validator found any errors.
 	 */
 	public function had_errors() {
-		return ! empty( $this->errors );
+		return ! empty($this->errors);
 	}
 
 	/**
@@ -262,7 +262,7 @@ 
 	 *
 	 * @param string $field The field.
 	 */
-	public function push_field( $field ) {
+	public function push_field($field) {
 		$this->field_stack[] = $field;
 	}
 
@@ -272,7 +272,7 @@ 
 	 * @since 1.0.0
 	 */
 	public function pop_field() {
-		array_pop( $this->field_stack );
+		array_pop($this->field_stack);
 	}
 
 	/**
@@ -317,7 +317,7 @@ 
 	 */
 	public function get_id() {
 
-		if ( ! $this->reaction ) {
+		if ( ! $this->reaction) {
 			return false;
 		}
 
@@ -355,13 +355,13 @@ 
 	 *
 	 * @return mixed The meta value.
 	 */
-	public function get_meta( $key ) {
+	public function get_meta($key) {
 
-		if ( ! isset( $this->settings[ $key ] ) ) {
+		if ( ! isset($this->settings[$key])) {
 			return null;
 		}
 
-		return $this->settings[ $key ];
+		return $this->settings[$key];
 	}
 
 	/**

src/includes/classes/entity/comment/post.php

Spacing +2 added lines, -2 removed lines

@@ -37,8 +37,8 @@
 	/**
 	 * @since 1.0.0
 	 */
-	protected function get_related_entity_ids( WordPoints_Entity $entity ) {
-		return $entity->get_the_attr_value( $this->related_ids_field );
+	protected function get_related_entity_ids(WordPoints_Entity $entity) {
+		return $entity->get_the_attr_value($this->related_ids_field);
 	}
 	
 	/**

src/includes/classes/hook/events.php

Spacing +21 added lines, -21 removed lines

@@ -37,13 +37,13 @@ 
 	/**
 	 * @since 1.0.0
 	 */
-	public function __construct( $slug ) {
+	public function __construct($slug) {
 
 		$hooks = wordpoints_hooks();
 
 		$this->router = $hooks->router;
 
-		parent::__construct( $slug );
+		parent::__construct($slug);
 	}
 
 	/**
@@ -51,7 +51,7 @@ 
 	 */
 	public function init() {
 
-		$this->sub_apps->register( 'args', 'WordPoints_Class_Registry_Children' );
+		$this->sub_apps->register('args', 'WordPoints_Class_Registry_Children');
 
 		parent::init();
 	}
@@ -75,25 +75,25 @@ 
 	 *
 	 * @return bool Whether the event was registered.
 	 */
-	public function register( $slug, $class, array $args = array() ) {
+	public function register($slug, $class, array $args = array()) {
 
-		parent::register( $slug, $class, $args );
+		parent::register($slug, $class, $args);
 
-		if ( isset( $args['actions'] ) ) {
-			foreach ( $args['actions'] as $type => $actions ) {
-				foreach ( (array) $actions as $action_slug ) {
-					$this->router->add_event_to_action( $slug, $action_slug, $type );
+		if (isset($args['actions'])) {
+			foreach ($args['actions'] as $type => $actions) {
+				foreach ((array) $actions as $action_slug) {
+					$this->router->add_event_to_action($slug, $action_slug, $type);
 				}
 			}
 		}
 
-		if ( isset( $args['args'] ) ) {
-			foreach ( $args['args'] as $arg_slug => $class ) {
-				$this->args->register( $slug, $arg_slug, $class );
+		if (isset($args['args'])) {
+			foreach ($args['args'] as $arg_slug => $class) {
+				$this->args->register($slug, $arg_slug, $class);
 			}
 		}
 
-		$this->event_data[ $slug ] = $args;
+		$this->event_data[$slug] = $args;
 
 		return true;
 	}
@@ -101,23 +101,23 @@ 
 	/**
 	 * @since 1.0.0
 	 */
-	public function deregister( $slug ) {
+	public function deregister($slug) {
 
-		if ( ! $this->is_registered( $slug ) ) {
+		if ( ! $this->is_registered($slug)) {
 			return;
 		}
 
-		parent::deregister( $slug );
+		parent::deregister($slug);
 
-		foreach ( (array) $this->event_data[ $slug ]['actions'] as $type => $actions ) {
-			foreach ( (array) $actions as $action_slug ) {
-				$this->router->remove_event_from_action( $slug, $action_slug, $type );
+		foreach ((array) $this->event_data[$slug]['actions'] as $type => $actions) {
+			foreach ((array) $actions as $action_slug) {
+				$this->router->remove_event_from_action($slug, $action_slug, $type);
 			}
 		}
 
-		$this->args->deregister_children( $slug );
+		$this->args->deregister_children($slug);
 
-		unset( $this->event_data[ $slug ] );
+		unset($this->event_data[$slug]);
 	}
 }
 

src/includes/classes/entity/change.php

Doc Comments +15 added lines

@@ -58,8 +58,20 @@ 
 
 // this is basically a reactor
 interface WordPoints_Entity_Change_ListenerI {
+
+	/**
+	 * @return void
+	 */
 	public function created( WordPoints_Entity $entity );
+
+	/**
+	 * @return void
+	 */
 	public function updated( WordPoints_Entity $before, WordPoints_Entity $after );
+
+	/**
+	 * @return void
+	 */
 	public function deleted( WordPoints_Entity $entity );
 }
 
@@ -129,6 +141,9 @@ 
 		return true;
 	}
 
+	/**
+	 * @param string $type
+	 */
 	protected function fire_event( $type, WordPoints_Entity $entity ) {
 
 		$args = new WordPoints_Hook_Event_Args( array() );

Spacing +62 added lines, -62 removed lines

@@ -10,19 +10,19 @@ 
 // this is basicaly a router.
 class WordPoints_Entity_chang_trigger implements WordPoints_Entity_Change_ListenerI {
 
-	public function created( WordPoints_Entity $entity ) {
+	public function created(WordPoints_Entity $entity) {
 		// can multiple entities be created at once? not using insert() but via query()
 		// maybe? and how shoudl we handle that, all at once or one by one?
 
 		/** @var WordPoints_Entity_Change_ListenerI[] $listeners */
-		$listeners = wordpoints_apps()->sub_apps->get( 'entity_change_listeners' );
-		foreach ( $listeners as $listener ) {
-			$listener->created( $entity );
+		$listeners = wordpoints_apps()->sub_apps->get('entity_change_listeners');
+		foreach ($listeners as $listener) {
+			$listener->created($entity);
 		}
 	}
 
 
-	public function updated( WordPoints_Entity $before, WordPoints_Entity $after ) {
+	public function updated(WordPoints_Entity $before, WordPoints_Entity $after) {
 
 		// what if multiple entities are updated at once? do we run each one separatately?
 		// mayb ethat should be left up to the listenter.
@@ -30,7 +30,7 @@ 
 	}
 
 
-	public function deleted( WordPoints_Entity $entity ) {
+	public function deleted(WordPoints_Entity $entity) {
 
 		// what if we need information about this entitie's relationships, etc., that
 		// isn't included inthe entity object?
@@ -58,41 +58,41 @@ 
 
 // this is basically a reactor
 interface WordPoints_Entity_Change_ListenerI {
-	public function created( WordPoints_Entity $entity );
-	public function updated( WordPoints_Entity $before, WordPoints_Entity $after );
-	public function deleted( WordPoints_Entity $entity );
+	public function created(WordPoints_Entity $entity);
+	public function updated(WordPoints_Entity $before, WordPoints_Entity $after);
+	public function deleted(WordPoints_Entity $entity);
 }
 
 class WordPoints_Entity_Change_Listener_Hooks implements WordPoints_Entity_Change_ListenerI {
 
-	public function created( WordPoints_Entity $entity ) {
+	public function created(WordPoints_Entity $entity) {
 
 		// maybe we would have multuiple events with requirements for a single entity?
 		// like comment author and post commentn author targets for the same hook.
 		// but I guess taht is just one event.
 		// what about user register vs user create on MS?
-		if ( $this->matches_requirements( $entity ) ) {
-			$this->fire_event( 'add', $entity );
+		if ($this->matches_requirements($entity)) {
+			$this->fire_event('add', $entity);
 		}
 	}
 
-	public function updated( WordPoints_Entity $before, WordPoints_Entity $after ) {
+	public function updated(WordPoints_Entity $before, WordPoints_Entity $after) {
 
-		if ( $this->matches_requirements( $after ) ) {
-			if ( ! $this->matches_requirements( $before ) ) {
-				$this->fire_event( 'add', $after );
+		if ($this->matches_requirements($after)) {
+			if ( ! $this->matches_requirements($before)) {
+				$this->fire_event('add', $after);
 			}
 		} else {
-			if ( $this->matches_requirements( $before ) ) {
-				$this->fire_event( 'remove', $after );
+			if ($this->matches_requirements($before)) {
+				$this->fire_event('remove', $after);
 			}
 		}
 	}
 
-	public function deleted( WordPoints_Entity $entity ) {
+	public function deleted(WordPoints_Entity $entity) {
 
-		if ( $this->matches_requirements( $entity ) ) {
-			$this->fire_event( 'remove', $entity );
+		if ($this->matches_requirements($entity)) {
+			$this->fire_event('remove', $entity);
 		}
 	}
 
@@ -108,20 +108,20 @@ 
 	// called into play when the entity itself is deleted is moot, because the
 	// reltionships, etc., aren't even taken into account when toggle-off is called,
 	// in the points reactor. other reators might, i guess.
-	protected function matches_requirements( WordPoints_Entity $entity ) {
+	protected function matches_requirements(WordPoints_Entity $entity) {
 
 		/** @var WordPoints_Class_Registry $defaults */
-		$defaults = wordpoints_apps()->sub_apps->get( 'entity_possession_defaults' );
+		$defaults = wordpoints_apps()->sub_apps->get('entity_possession_defaults');
 
-		$defaults = $defaults->get( $entity->get_slug() );
+		$defaults = $defaults->get($entity->get_slug());
 
-		if ( ! $defaults ) {
+		if ( ! $defaults) {
 			return false;
 		}
 
 		// use conditions here?
-		foreach ( $defaults as $child => $value ) {
-			if ( $entity->get_child( $child ) !== $value ) {
+		foreach ($defaults as $child => $value) {
+			if ($entity->get_child($child) !== $value) {
 				return false;
 			}
 		}
@@ -129,13 +129,13 @@ 
 		return true;
 	}
 
-	protected function fire_event( $type, WordPoints_Entity $entity ) {
+	protected function fire_event($type, WordPoints_Entity $entity) {
 
-		$args = new WordPoints_Hook_Event_Args( array() );
-		$args->add_entity( $entity );
+		$args = new WordPoints_Hook_Event_Args(array());
+		$args->add_entity($entity);
 
 		wordpoints_hooks()->fire(
-			$type . '_entity_' . $entity->get_slug(),
+			$type.'_entity_'.$entity->get_slug(),
 			$args,
 			'toggle_on'
 		);
@@ -144,31 +144,31 @@ 
 
 class WordPoints_Entity_Change_Listener_Points implements WordPoints_Entity_Change_ListenerI {
 
-	public function created( WordPoints_Entity $entity ) {
+	public function created(WordPoints_Entity $entity) {
 
 		$this->process_entityish(
 			$entity
-			, $this->get_settings_for_entity( $entity )
+			, $this->get_settings_for_entity($entity)
 		);
 	}
 
-	protected function process_entityish( WordPoints_EntityishI $entity, $settings ) {
+	protected function process_entityish(WordPoints_EntityishI $entity, $settings) {
 
 		// possibly make this more like extension handling
-		if ( ! $this->meets_conditions( $entity, $settings['conditions'] ) ) {
+		if ( ! $this->meets_conditions($entity, $settings['conditions'])) {
 			return;
 		}
 
 		// possibly make this more like reactor handling.
-		$this->award_points( $settings );
+		$this->award_points($settings);
 
 		// only proces the attributes taht have changed.
 		// acutally, in this case, the entity was just created.
-		if ( $entity instanceof WordPoints_Entity_ParentI ) {
+		if ($entity instanceof WordPoints_Entity_ParentI) {
 
 			// this check runs on attributes only.
-			foreach ( $settings['children'] as $child_slug => $child_settings ) {
-				$this->process_entityish( $entity->get_child( $child_slug ), $child_settings );
+			foreach ($settings['children'] as $child_slug => $child_settings) {
+				$this->process_entityish($entity->get_child($child_slug), $child_settings);
 			}
 
 			// we also need to check for any children, like relationships, that have
@@ -176,7 +176,7 @@ 
 			// for this we need a list of relationships.
 			// if we do two-way relationships, we may need to have infinite-loop
 			// halding here, depending.
-			foreach ( $this->get_related_entities( $entity ) as $child_entity ) {
+			foreach ($this->get_related_entities($entity) as $child_entity) {
 				// If a comment was just created, for example, and we have conditions
 				// on the post entity, that affect the comment author, this allows
 				// us to handle those by pulling up the settings for the post entity
@@ -195,7 +195,7 @@ 
 				// as we've proposed...
 				$this->process_entityish(
 					$child_entity
-					, $this->get_entity_settings( $child_entity )
+					, $this->get_entity_settings($child_entity)
 				);
 			}
 		}
@@ -209,15 +209,15 @@ 
 	// doesn't really make sense.
 	// I think relationships can be created and deleted, but not really updated.
 	// so maybe what we need is a separate api?
-	public function updated( WordPoints_Entity $before, WordPoints_Entity $after ) {
+	public function updated(WordPoints_Entity $before, WordPoints_Entity $after) {
 
-		$settings = $this->get_settings_for_entity( $before );
+		$settings = $this->get_settings_for_entity($before);
 
 		/** @var WordPoints_Class_Registry_ChildrenI $children */
 		$children = wordpoints_entities()->children;
-		foreach ( $children->get_children_slugs( $before->get_slug() ) as $child_slug ) {
+		foreach ($children->get_children_slugs($before->get_slug()) as $child_slug) {
 			
-			if ( ! isset( $settings['children'][ $child_slug ] ) ) {
+			if ( ! isset($settings['children'][$child_slug])) {
 				continue;
 			}
 			
@@ -232,23 +232,23 @@ 
 			// but then we'll not be checking even the relationships taht are defined
 			// on the atts. so we have to decide whether those should be handled by
 			// a separate api or not.
-			if ( $before->get_the_attr_value( $child_slug ) === $after->get_the_attr_value( $child_slug ) ) {
+			if ($before->get_the_attr_value($child_slug) === $after->get_the_attr_value($child_slug)) {
 				continue;
 			}
 
 			$this->process_modified_entityish(
-				$before->get_child( $child_slug )
-				, $after->get_child( $child_slug )
-				, $settings['children'][ $child_slug ]
+				$before->get_child($child_slug)
+				, $after->get_child($child_slug)
+				, $settings['children'][$child_slug]
 			);
 		}
 	}
 
-	protected function process_modified_entityish( WordPoints_EntityishI $before, WordPoints_EntityishI $after, $settings ) {
+	protected function process_modified_entityish(WordPoints_EntityishI $before, WordPoints_EntityishI $after, $settings) {
 
-		if ( ! $this->meets_conditions( $before, $settings['conditions'] ) ) {
-			if ( $this->meets_conditions( $after, $settings['conditions'] ) ) {
-				$this->award_points( $settings );
+		if ( ! $this->meets_conditions($before, $settings['conditions'])) {
+			if ($this->meets_conditions($after, $settings['conditions'])) {
+				$this->award_points($settings);
 
 				// also need to process other eneities that are affected by this
 				// change, which may have conditions on this, i.e., that could be
@@ -265,38 +265,38 @@ 
 				// then we do indeed need to run through the children/parents.
 			}
 		} else {
-			if ( ! $this->meets_conditions( $after, $settings['conditions'] ) ) {
-				$this->remove_points( $settings );
+			if ( ! $this->meets_conditions($after, $settings['conditions'])) {
+				$this->remove_points($settings);
 			}
 		}
 	}
 
-	public function deleted( WordPoints_Entity $entity ) {
+	public function deleted(WordPoints_Entity $entity) {
 		// basically the opposite of created().
-		$this->process_entityish_reverse( $entity );
+		$this->process_entityish_reverse($entity);
 	}
 
-	protected function meets_conditions( WordPoints_EntityishI $entityish, $conditions ) {
+	protected function meets_conditions(WordPoints_EntityishI $entityish, $conditions) {
 		// use conditions api
 
 		return false;
 	}
 
-	private function award_points( $settings ) {
+	private function award_points($settings) {
 
-		$hierarchy = new WordPoints_Entity_Hierarchy( $this->eitnty );
+		$hierarchy = new WordPoints_Entity_Hierarchy($this->eitnty);
 		// todo we'll need to introudce entity array targets, possibly.
 		// how will we know how to reverse the target reltinoship chains in the UI
 		// before saving? i guess we'll need to either have a dedicated index fo taht
 		// or else juust look it up by looping through the relationships (though we'd
 		// have to remove the entity array {} part from any one-to-many relationships
 		// and maybe we'd have to add it to others?)
-		$targets = $hierarchy->get_from_hierarchy( $settings['target'] );
+		$targets = $hierarchy->get_from_hierarchy($settings['target']);
 
 		// maybe just one target, maybe several, depending.
 	}
 
-	private function get_related_entities( WordPoints_Entity $entity ) {
+	private function get_related_entities(WordPoints_Entity $entity) {
 
 		// what we need is parental conditions. Conditions that go up the chain,
 		// and look back at parent entities. This way we can handle the info about

src/includes/classes/wpdb/wrapper.php

Doc Comments +20 added lines

@@ -73,12 +73,28 @@ 
 
 
 interface WordPoints_WPDB_Query_Data {
+
+	/**
+	 * @return string
+	 */
 	public function get_table_name();
+
+	/**
+	 * @return void
+	 */
 	public function get_where_clause();
 }
 
 interface WordPoints_MySQL_Query_Parser_SimpleI {
+
+	/**
+	 * @return void
+	 */
 	public function get_table_name();
+
+	/**
+	 * @return string
+	 */
 	public function get_where_clause();
 }
 
@@ -164,6 +180,10 @@ 
 }
 
 interface WordPoints_WPDB_Query_WrapperI {
+
+	/**
+	 * @return void
+	 */
 	public function __construct( $slug, $args, $wpdb );
 	public function execute();
 

Spacing +51 added lines, -51 removed lines

@@ -11,60 +11,60 @@ 
 
 	protected $wpdb;
 
-	public function __construct( $wpdb ) {
+	public function __construct($wpdb) {
 		$this->wpdb = $wpdb;
 	}
 
-	public function __get( $name ) {
+	public function __get($name) {
 		return $this->wpdb->$name;
 	}
 
-	public function __set( $name, $value ) {
+	public function __set($name, $value) {
 		$this->wpdb->$name = $value;
 	}
 
-	public function __isset( $name ) {
-		return isset( $this->wpdb->$name );
+	public function __isset($name) {
+		return isset($this->wpdb->$name);
 	}
 
-	public function __unset( $name ) {
-		unset( $this->wpdb->$name );
+	public function __unset($name) {
+		unset($this->wpdb->$name);
 	}
 
-	public function __call( $name, $arguments ) {
+	public function __call($name, $arguments) {
 
-		$wrappers = wordpoints_apps()->sub_apps->get( 'wpdb_wrappers' );
-		$slugs = $wrappers->get_child_slugs( $name );
+		$wrappers = wordpoints_apps()->sub_apps->get('wpdb_wrappers');
+		$slugs = $wrappers->get_child_slugs($name);
 		$should_listen = $query = false;
 
 
-		switch ( $name ) {
+		switch ($name) {
 
 			case 'insert':
 //			case 'replace':
-				$query = new WordPoints_WPDB_Query_Data_Array( $this->args[0] );
+				$query = new WordPoints_WPDB_Query_Data_Array($this->args[0]);
 			break;
 
 			case 'update':
-				$query =  new WordPoints_WPDB_Query_Data_Array( $this->args[0], $this->args[2] );
+				$query = new WordPoints_WPDB_Query_Data_Array($this->args[0], $this->args[2]);
 			break;
 
 			case 'delete':
-				$query =  new WordPoints_WPDB_Query_Data_Array( $this->args[0], $this->args[1] );
+				$query = new WordPoints_WPDB_Query_Data_Array($this->args[0], $this->args[1]);
 			break;
 
 			case 'query':
-				$query =  new WordPoints_WPDB_Query_Data_SQL( $this->args[0] );
+				$query = new WordPoints_WPDB_Query_Data_SQL($this->args[0]);
 			break;
 		}
 
-		if ( $query ) {
+		if ($query) {
 			/** @var WordPoints_WPDB_Query_WrapperI $wrapper */
-			$wrapper = $wrappers->get( $name, $query );
+			$wrapper = $wrappers->get($name, $query);
 
 			$result = $wrapper->execute();
 		} else {
-			$result = call_user_func_array( array( $this->wpdb, $name ), $arguments );
+			$result = call_user_func_array(array($this->wpdb, $name), $arguments);
 		}
 
 		return $result;
@@ -84,7 +84,7 @@ 
 
 class WordPoints_MySQL_Query_Parser_Simple_Insert implements WordPoints_MySQL_Query_Parser_SimpleI {
 
-	public function __construct( $sql ) {
+	public function __construct($sql) {
 		$this->sql = $sql;
 	}
 
@@ -99,7 +99,7 @@ 
 		// columns will not be needed. then the other code can decide what to do.
 		// although I guess sense we have the tablel name we could reun the query
 		// ourselves if we need/want to.
-		if ( stripos( $this->sql, 'ON DUPLICATE KEY UPDATE' ) ) {
+		if (stripos($this->sql, 'ON DUPLICATE KEY UPDATE')) {
 
 		}
 
@@ -119,7 +119,7 @@ 
 	 */
 	protected $parser;
 
-	public function __construct( $sql ) {
+	public function __construct($sql) {
 		$this->sql = $sql;
 		$this->parser = $this->get_parser();
 	}
@@ -130,7 +130,7 @@ 
 		// of query it is.
 		// maybe the parser will actually be passed in, and the query type deterimed
 		// by teh method wrapper.
-		$parser = new WordPoints_MySQL_Query_Parser_Simple_Insert( $this->sql );
+		$parser = new WordPoints_MySQL_Query_Parser_Simple_Insert($this->sql);
 		// maybe we don't even need to parse.
 		return $parser;
 	}
@@ -149,7 +149,7 @@ 
 	protected $table_name;
 	protected $where_data;
 
-	public function __construct( $table_name, $where_data = array() ) {
+	public function __construct($table_name, $where_data = array()) {
 		$this->table_name = $table_name;
 		$this->where_data = $where_data;
 	}
@@ -164,7 +164,7 @@ 
 }
 
 interface WordPoints_WPDB_Query_WrapperI {
-	public function __construct( $slug, $args, $wpdb );
+	public function __construct($slug, $args, $wpdb);
 	public function execute();
 
 }
@@ -185,7 +185,7 @@ 
 	protected $result;
 	protected $backed_up_wpdb_vars;
 
-	public function __construct( $slug, $args, $wpdb ) {
+	public function __construct($slug, $args, $wpdb) {
 		$this->slug = $slug;
 		$this->args = $args;
 		$this->wpdb = $wpdb;
@@ -194,20 +194,20 @@ 
 
 	protected function get_query_data() {
 
-		switch ( $this->slug ) {
+		switch ($this->slug) {
 
 			case 'insert':
 				//			case 'replace':
-				return new WordPoints_WPDB_Query_Data_Array( $this->args[0] );
+				return new WordPoints_WPDB_Query_Data_Array($this->args[0]);
 
 			case 'update':
-				return new WordPoints_WPDB_Query_Data_Array( $this->args[0], $this->args[2] );
+				return new WordPoints_WPDB_Query_Data_Array($this->args[0], $this->args[2]);
 
 			case 'delete':
-				return new WordPoints_WPDB_Query_Data_Array( $this->args[0], $this->args[1] );
+				return new WordPoints_WPDB_Query_Data_Array($this->args[0], $this->args[1]);
 
 			case 'query':
-				return new WordPoints_WPDB_Query_Data_SQL( $this->args[0] );
+				return new WordPoints_WPDB_Query_Data_SQL($this->args[0]);
 		}
 
 		return false;
@@ -217,13 +217,13 @@ 
 
 		$should_listen = $this->should_listen();
 
-		if ( $should_listen ) {
+		if ($should_listen) {
 			$this->before_query();
 		}
 
-		$this->result = call_user_func_array( array( $this->wpdb, $this->slug ), $this->args );
+		$this->result = call_user_func_array(array($this->wpdb, $this->slug), $this->args);
 
-		if ( $should_listen && $this->was_successful_query() ) {
+		if ($should_listen && $this->was_successful_query()) {
 			$this->backup_wpdb_vars();
 			$this->after_query();
 			$this->restore_wpdb_vars();
@@ -252,8 +252,8 @@ 
 
 		// we could check for the availableility of eahc valu here in case of dropins
 		// or they become not available in the future.
-		foreach ( $to_backup as $property ) {
-			$this->backed_up_wpdb_vars[ $property ] = $this->wpdb->$property;
+		foreach ($to_backup as $property) {
+			$this->backed_up_wpdb_vars[$property] = $this->wpdb->$property;
 		}
 	}
 
@@ -263,7 +263,7 @@ 
 		// with the backed up result.
 		$this->wpdb->flush();
 
-		foreach ( $this->backed_up_wpdb_vars as $property => $value ) {
+		foreach ($this->backed_up_wpdb_vars as $property => $value) {
 			$this->wpdb->$property = $value;
 		}
 	}
@@ -301,18 +301,18 @@ 
 	 */
 	protected function is_entity_table() {
 
-		$this->entity = 'new entity object' . $this->data->get_table_name();
+		$this->entity = 'new entity object'.$this->data->get_table_name();
 
 		return true;
 	}
 
 	public function should_listen() {
 
-		if ( ! $this->data ) {
+		if ( ! $this->data) {
 			return false;
 		}
 
-		if ( $this->is_entity_table() ) {
+		if ($this->is_entity_table()) {
 			return false;
 		}
 
@@ -320,7 +320,7 @@ 
 	}
 
 	protected function was_successful_query() {
-		return (bool) wordpoints_posint( $not_by_ref = $this->wpdb->num_rows );
+		return (bool) wordpoints_posint($not_by_ref = $this->wpdb->num_rows);
 	}
 }
 
@@ -330,7 +330,7 @@ 
 	protected $args;
 	protected $wpdb;
 
-	public function __construct( $slug, $args, $wpdb ) {
+	public function __construct($slug, $args, $wpdb) {
 		$this->slug = $slug;
 		$this->args = $args;
 		$this->wpdb = $wpdb;
@@ -341,10 +341,10 @@ 
 		// check if this is a query that we want to listen to.
 		// if so, call execute on a particular child.
 		// otherwise, just call execute.
-		if ( $this->get_query_type() ) {
+		if ($this->get_query_type()) {
 
 		} else {
-			$result = call_user_func_array( array( $this->wpdb, $this->slug ), $this->args );
+			$result = call_user_func_array(array($this->wpdb, $this->slug), $this->args);
 		}
 
 		return $result;
@@ -369,15 +369,15 @@ 
 
 		$ids = $this->get_entity_ids();
 
-		$this->entities = new WordPoints_Entity_Array( $this->entity->get_slug() );
-		$this->entities->set_the_value( $ids );
+		$this->entities = new WordPoints_Entity_Array($this->entity->get_slug());
+		$this->entities->set_the_value($ids);
 	}
 
 	protected function get_entity_ids() {
 		$where = $this->data->get_where_clause();
-		$id_field = wordpoints_escape_mysql_identifier( $this->entity->get_id_field() );
-		$table_name = wordpoints_escape_mysql_identifier( $this->data->get_table_name() );
-		return $this->wpdb->get_col( "SELECT {$id_field} FROM {$table_name} {$where}" );
+		$id_field = wordpoints_escape_mysql_identifier($this->entity->get_id_field());
+		$table_name = wordpoints_escape_mysql_identifier($this->data->get_table_name());
+		return $this->wpdb->get_col("SELECT {$id_field} FROM {$table_name} {$where}");
 	}
 
 	protected function after_query() {
@@ -396,13 +396,13 @@ 
 		$where_clause = $this->data->get_where_clause();
 
 		// get a before snapshot, if any matching are found.
-		if ( $where_clause ) {
+		if ($where_clause) {
 
 		}
 	}
 
 	protected function after_query() {
-		$this->entity->set_the_value( $this->wpdb->insert_id );
+		$this->entity->set_the_value($this->wpdb->insert_id);
 		// I guess we invoke the api to run the action now?
 		$this->trigger_entity_create_actions();
 	}
@@ -413,7 +413,7 @@ 
 
 	protected function after_query() {
 		// I guess we invoke the api to run the action now?
-		$this->trigger_entity_delete_actions( $this->entities );
+		$this->trigger_entity_delete_actions($this->entities);
 	}
 }