Issues in class-give-db-sequential-ordering.php (master) - Issues in master - WordImpress/Give - Measure and Improve Code Quality continuously with Scrutinizer

Issues (4296)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

includes/class-give-db-sequential-ordering.php (9 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Sequential Donation DB
 *
 * @package     Give
 * @subpackage  Classes/Give_DB_Sequential_Ordering
 * @copyright   Copyright (c) 2018, WordImpress
 * @license     https://opensource.org/licenses/gpl-license GNU Public License
 * @since       2.1.0
 */

// Exit if accessed directly.
if ( ! defined( 'ABSPATH' ) ) {
	exit;
}

/**
 * Give_DB_Sequential_Ordering Class
 *
 * This class is for interacting with the sequential donation database table.
 *
 * @since 2.1.0
 */
class Give_DB_Sequential_Ordering extends Give_DB {

	/**
	 * Give_DB_Sequential_Ordering constructor.
	 *
	 * Set up the Give DB Donor class.
	 *
	 * @since  2.1.0
	 * @access public
	 */
	public function __construct() {

		/* @var WPDB $wpdb */
		global $wpdb;

		$this->table_name  = $wpdb->prefix . 'give_sequential_ordering';
		$this->primary_key = 'id';
		$this->version     = '1.0';

		// Install table.
		$this->register_table();

		parent::__construct();
	}

	/**
	 * Get columns and formats
	 *
	 * @since  2.1.0
	 * @access public
	 *
	 * @return array  Columns and formats.
	 */
	public function get_columns() {
		return array(
			'id'         => '%d',
			'payment_id' => '%s',
		);
	}

	/**
	 * Get default column values
	 *
	 * @since  2.1.0
	 * @access public
	 *
	 * @return array  Default column values.
	 */
	public function get_column_defaults() {
		return array(
			'id'         => 0,
			'payment_id' => '',
		);
	}


	/**
	 * Create the table
	 *
	 * @since  2.1.0
	 * @access public
	 *
	 * @return void
	 */
	public function create_table() {
		global $wpdb;
		$charset_collate = $wpdb->get_charset_collate();

		// Calculate auto increment number.
		$payment_ID = $wpdb->get_var(

			$wpdb->prepare(
				"
				SELECT ID
				FROM $wpdb->posts
				WHERE post_type=%s
				ORDER By ID desc
				LIMIT 1
				",
				'give_payment'
			)
		);

		$sql = "CREATE TABLE {$this->table_name} (
        id bigint(20) NOT NULL AUTO_INCREMENT,
        payment_id bigint(20) NOT NULL,
        PRIMARY KEY  (id)
        ) {$charset_collate};";

		require_once( ABSPATH . 'wp-admin/includes/upgrade.php' );
		dbDelta( $sql );

		if ( ! empty( $payment_ID ) ) {
			$auto_increment = $payment_ID + 1;
			$wpdb->query( "ALTER TABLE {$this->table_name} AUTO_INCREMENT={$auto_increment};" );

			give_update_option( 'sequential-ordering_number', $auto_increment );
		} else {
			give_update_option( 'sequential-ordering_number', 1 );
		}

		update_option( $this->table_name . '_db_version', $this->version, false );
	}


	/**
	 * Get id auto increment next value.
	 *
	 * @since 2.1.0
	 * @return null|string
	 */
	public function get_id_auto_increment_val() {
		global $wpdb;

		return $wpdb->get_var(

			$wpdb->prepare(
				"
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
				SELECT AUTO_INCREMENT
				FROM  INFORMATION_SCHEMA.TABLES
				WHERE TABLE_SCHEMA=%s
				AND TABLE_NAME=%s
				",
				DB_NAME,
				$this->table_name
			)
		);
	}
}


1		<?php
2		/**
3		* Sequential Donation DB
4		*
5		* @package Give
6		* @subpackage Classes/Give_DB_Sequential_Ordering
7		* @copyright Copyright (c) 2018, WordImpress
8		* @license https://opensource.org/licenses/gpl-license GNU Public License
9		* @since 2.1.0
10		*/
11
12		// Exit if accessed directly.
13		if ( ! defined( 'ABSPATH' ) ) {
14		exit;
15		}
16
17		/**
18		* Give_DB_Sequential_Ordering Class
19		*
20		* This class is for interacting with the sequential donation database table.
21		*
22		* @since 2.1.0
23		*/
24		class Give_DB_Sequential_Ordering extends Give_DB {
25
26		/**
27		* Give_DB_Sequential_Ordering constructor.
28		*
29		* Set up the Give DB Donor class.
30		*
31		* @since 2.1.0
32		* @access public
33		*/
34	View Code Duplication	public function __construct() {
		0 ignored issues – show Duplication introduced 2018-02-17 00:46 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
35		/* @var WPDB $wpdb */
36		global $wpdb;
37
38		$this->table_name = $wpdb->prefix . 'give_sequential_ordering';
39		$this->primary_key = 'id';
40		$this->version = '1.0';
41
42		// Install table.
43		$this->register_table();
44
45		parent::__construct();
46		}
47
48		/**
49		* Get columns and formats
50		*
51		* @since 2.1.0
52		* @access public
53		*
54		* @return array Columns and formats.
55		*/
56		public function get_columns() {
57		return array(
58		'id' => '%d',
59		'payment_id' => '%s',
60		);
61		}
62
63		/**
64		* Get default column values
65		*
66		* @since 2.1.0
67		* @access public
68		*
69		* @return array Default column values.
70		*/
71		public function get_column_defaults() {
72		return array(
73		'id' => 0,
74		'payment_id' => '',
75		);
76		}
77
78
79		/**
80		* Create the table
81		*
82		* @since 2.1.0
83		* @access public
84		*
85		* @return void
86		*/
87		public function create_table() {
88		global $wpdb;
89		$charset_collate = $wpdb->get_charset_collate();
90
91		// Calculate auto increment number.
92		$payment_ID = $wpdb->get_var(
		0 ignored issues – show introduced 2018-05-02 19:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this Usage of a direct database call is discouraged. Loading history... introduced 2018-05-02 19:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this Usage of a direct database call without caching is prohibited. Use wp_cache_get / wp_cache_set. Loading history...
93		$wpdb->prepare(
94		"
95		SELECT ID
96		FROM $wpdb->posts
97		WHERE post_type=%s
98		ORDER By ID desc
99		LIMIT 1
100		",
101		'give_payment'
102		)
103		);
104
105		$sql = "CREATE TABLE {$this->table_name} (
106		id bigint(20) NOT NULL AUTO_INCREMENT,
107		payment_id bigint(20) NOT NULL,
108		PRIMARY KEY (id)
109		) {$charset_collate};";
110
111		require_once( ABSPATH . 'wp-admin/includes/upgrade.php' );
112		dbDelta( $sql );
113
114		if ( ! empty( $payment_ID ) ) {
115		$auto_increment = $payment_ID + 1;
116		$wpdb->query( "ALTER TABLE {$this->table_name} AUTO_INCREMENT={$auto_increment};" );
		0 ignored issues – show introduced 2018-05-02 19:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this Usage of a direct database call is discouraged. Loading history... introduced 2018-05-02 19:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this Usage of a direct database call without caching is prohibited. Use wp_cache_get / wp_cache_set. Loading history... introduced 2018-05-02 19:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this Attempting a database schema change is highly discouraged. Loading history...
117		give_update_option( 'sequential-ordering_number', $auto_increment );
118		} else {
119		give_update_option( 'sequential-ordering_number', 1 );
120		}
121
122		update_option( $this->table_name . '_db_version', $this->version, false );
123		}
124
125
126		/**
127		* Get id auto increment next value.
128		*
129		* @since 2.1.0
130		* @return null\|string
131		*/
132		public function get_id_auto_increment_val() {
133		global $wpdb;
134
135		return $wpdb->get_var(
		0 ignored issues – show introduced 2018-05-02 19:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this Usage of a direct database call is discouraged. Loading history... introduced 2018-05-02 19:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this Usage of a direct database call without caching is prohibited. Use wp_cache_get / wp_cache_set. Loading history...
136		$wpdb->prepare(
137		"
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-05-02 19:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this The string literal `\n SELECT...ME=%s\n` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
138		SELECT AUTO_INCREMENT
139		FROM INFORMATION_SCHEMA.TABLES
140		WHERE TABLE_SCHEMA=%s
141		AND TABLE_NAME=%s
142		",
143		DB_NAME,
144		$this->table_name
145		)
146		);
147		}
148		}
149

WordImpress / Give

Issues (4296)

Security Analysis not enabled

includes/class-give-db-sequential-ordering.php (9 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like